chromium/src
0
Fork 0
Code Activity

[fuchsia] Disable flaky video playback tests.

Browse Source 
Tests which play back video can flake when run in parallel due to a
problematic DCHECK in VideoCadenceEstimator (see bug).

Bug: 1090159,1090489
Change-Id: Ie4e93ba562108503a98992011632355e4ddfc7ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226923
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774336}
This commit is contained in:
Kevin Marshall
2020-06-02 21:11:29 +00:00
committed by Commit Bot
parent 49d6c215c5
commit ff4ddb4ee0
1 changed files with 8 additions and 3 deletions

11
fuchsia/engine/web_engine_integration_test.cc

@ -524,6 +524,7 @@ TEST_F(WebEngineIntegrationTest, PlayAudio) {
EXPECT_FALSE(fake_audio_consumer_service_->instance(0)->is_muted());
}
// TODO(crbug.com/1090159): Reenable when cadence estimator DCHECK is fixed.
TEST_F(WebEngineIntegrationTest, DISABLED_PlayVideo) {
StartWebEngine();
CreateContextAndFrame(ContextParamsWithAudioAndTestData());
@ -587,7 +588,8 @@ TEST_F(WebEngineIntegrationTest, MicrophoneAccess_WithoutPermission) {
navigation_listener_->RunUntilTitleEquals("ended");
}
TEST_F(WebEngineIntegrationTest, SetBlockMediaLoading_Blocked) {
// TODO(crbug.com/1090159): Reenable when cadence estimator DCHECK is fixed.
TEST_F(WebEngineIntegrationTest, DISABLED_SetBlockMediaLoading_Blocked) {
StartWebEngine();
CreateContextAndFrame(ContextParamsWithAudioAndTestData());
@ -605,7 +607,8 @@ TEST_F(WebEngineIntegrationTest, SetBlockMediaLoading_Blocked) {
// Initially, set media blocking to be true. When media is unblocked, check that
// it begins playing, since autoplay=true.
TEST_F(WebEngineIntegrationTest, SetBlockMediaLoading_AfterUnblock) {
// TODO(crbug.com/1090159): Reenable when cadence estimator DCHECK is fixed.
TEST_F(WebEngineIntegrationTest, DISABLED_SetBlockMediaLoading_AfterUnblock) {
StartWebEngine();
CreateContextAndFrame(ContextParamsWithAudioAndTestData());
@ -625,7 +628,9 @@ TEST_F(WebEngineIntegrationTest, SetBlockMediaLoading_AfterUnblock) {
// Check that when autoplay=false and media loading was blocked after the
// element has started loading that media will play when play() is called.
TEST_F(WebEngineIntegrationTest, SetBlockMediaLoading_SetBlockedAfterLoading) {
// TODO(crbug.com/1090159): Reenable when cadence estimator DCHECK is fixed.
TEST_F(WebEngineIntegrationTest,
DISABLED_SetBlockMediaLoading_SetBlockedAfterLoading) {
StartWebEngine();
CreateContextAndFrame(ContextParamsWithAudioAndTestData());