0

[Code health] Enable gn check for //extensions/browser/api:*

This CL enables gn check for //extensions/browser/api:*. This is done
by merging //extensions/browser/api/storage:* and
//extensions/browser/api/clipboard:* into //extensions/browser/api:*.

Bug: 1158984
Change-Id: I149dae156dc8ee7727561ff93ca7a2839491cb05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2847999
Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#885791}
This commit is contained in:
Ghazale Hosseinabadi
2021-05-22 17:59:12 +00:00
committed by Chromium LUCI CQ
parent 7d7c0314e7
commit ff82c4c9e9
5 changed files with 35 additions and 72 deletions
.gn
extensions
BUILD.gn
browser
api
BUILD.gn
clipboard
storage

1
.gn

@ -70,7 +70,6 @@ no_check_targets = [
"//chrome/test:unit_tests__library",
"//chrome/test:usage_time_limit_unittests",
"//chrome/test:xr_browser_tests_common",
"//extensions/browser/api:*", # 7 errors
"//extensions/browser:*", # 20 errors
"//extensions:*", # 75 errors
"//headless:*", # 167 errors

@ -156,7 +156,7 @@ static_library("test_support") {
"//content/test:test_support",
"//extensions/browser",
"//extensions/browser:test_support",
"//extensions/browser/api/storage",
"//extensions/browser/api",
"//extensions/common",
"//extensions/common:core_api_provider",
"//extensions/common/api",

@ -32,13 +32,33 @@ source_set("api") {
"guest_view/web_view/web_view_internal_api.cc",
"guest_view/web_view/web_view_internal_api.h",
# TODO(crbug.com/1206265): anything under hid/, system_display/ and usb/ should be moved out of this target.
# TODO(crbug.com/1206265): anything under hid/, storage/, system_display/
# and usb/ should be moved out of this target.
"hid/hid_api.cc",
"hid/hid_api.h",
"hid/hid_connection_resource.cc",
"hid/hid_connection_resource.h",
"hid/hid_device_manager.cc",
"hid/hid_device_manager.h",
"storage/backend_task_runner.cc",
"storage/backend_task_runner.h",
"storage/local_value_store_cache.cc",
"storage/local_value_store_cache.h",
"storage/session_storage_manager.cc",
"storage/session_storage_manager.h",
"storage/settings_observer.h",
"storage/settings_storage_quota_enforcer.cc",
"storage/settings_storage_quota_enforcer.h",
"storage/storage_api.cc",
"storage/storage_api.h",
"storage/storage_area_namespace.cc",
"storage/storage_area_namespace.h",
"storage/storage_frontend.cc",
"storage/storage_frontend.h",
"storage/value_store_cache.cc",
"storage/value_store_cache.h",
"storage/weak_unlimited_settings_storage.cc",
"storage/weak_unlimited_settings_storage.h",
"system_display/display_info_provider.cc",
"system_display/display_info_provider.h",
"system_display/system_display_api.cc",
@ -64,6 +84,7 @@ source_set("api") {
"//content/public/common",
"//extensions/browser:browser_sources",
"//extensions/common",
"//extensions/common/api",
"//ipc",
"//services/device/public/cpp/usb:usb",
]
@ -96,6 +117,17 @@ source_set("api") {
"//device/bluetooth",
]
if (is_chromeos) {
sources += [
"clipboard/clipboard_api.cc",
"clipboard/clipboard_api.h",
]
deps += [
"//components/prefs:prefs",
"//ui/base/clipboard",
]
}
if (is_chromeos_ash) {
sources += [
"lock_screen_data/data_item.cc",
@ -134,6 +166,7 @@ source_set("api") {
group("api_implementations") {
public_deps = [
"//extensions/browser:browser_sources",
"//extensions/browser/api",
"//extensions/browser/api/alarms",
"//extensions/browser/api/app_current_window_internal",
"//extensions/browser/api/app_runtime",
@ -162,7 +195,6 @@ group("api_implementations") {
"//extensions/browser/api/sockets_tcp",
"//extensions/browser/api/sockets_tcp_server",
"//extensions/browser/api/sockets_udp",
"//extensions/browser/api/storage",
"//extensions/browser/api/system_cpu",
"//extensions/browser/api/system_info",
"//extensions/browser/api/system_memory",
@ -172,10 +204,6 @@ group("api_implementations") {
"//extensions/browser/api/virtual_keyboard_private",
]
if (is_chromeos_ash || is_chromeos_lacros) {
public_deps += [ "//extensions/browser/api/clipboard" ]
}
if (is_chromeos_ash) {
public_deps += [
"//extensions/browser/api/cec_private",

@ -1,24 +0,0 @@
# Copyright 2016 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import("//extensions/buildflags/buildflags.gni")
assert(enable_extensions,
"Cannot depend on extensions because enable_extensions=false.")
source_set("clipboard") {
sources = [
"clipboard_api.cc",
"clipboard_api.h",
]
deps = [
"//extensions/browser/api",
"//extensions/common",
"//extensions/common/api",
"//ui/base/clipboard",
]
public_deps = [ "//extensions/browser:browser_sources" ]
}

@ -1,40 +0,0 @@
# Copyright 2016 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import("//extensions/buildflags/buildflags.gni")
assert(enable_extensions,
"Cannot depend on extensions because enable_extensions=false.")
source_set("storage") {
sources = [
"backend_task_runner.cc",
"backend_task_runner.h",
"local_value_store_cache.cc",
"local_value_store_cache.h",
"session_storage_manager.cc",
"session_storage_manager.h",
"settings_observer.h",
"settings_storage_quota_enforcer.cc",
"settings_storage_quota_enforcer.h",
"storage_api.cc",
"storage_api.h",
"storage_area_namespace.cc",
"storage_area_namespace.h",
"storage_frontend.cc",
"storage_frontend.h",
"value_store_cache.cc",
"value_store_cache.h",
"weak_unlimited_settings_storage.cc",
"weak_unlimited_settings_storage.h",
]
deps = [
"//extensions/browser/api",
"//extensions/common",
"//extensions/common/api",
]
public_deps = [ "//extensions/browser:browser_sources" ]
}