The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: I8a9934c8837b7e99594af4d63d4343128b70f7fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493246
Auto-Submit: Alison Gale <agale@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293200}
This will make it possible to do jobjectArray->vector<string>
conversions without having a separate API for strings vs objects.
Also:
* Changes to allow "env", "jcaller", and "ret" as parameter names
* Some changes in preparation for using "jobject" (rather than
subclasses) in proxy types.
* Fixes ConvertArray::ToJniType of plain jobject. (b/335353381)
Bug: 331819030, 330378731, 335353381
Change-Id: I5c891a678819814920d67a72d3bf5747eebd0045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5457894
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1289536}
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: I89f0a4d7ddeb7c9585f3a0e5421aef8ce5a6f0f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5455854
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1287738}
PrefValueStore::GetValueFromStoreWithType and proper PrefService
registration should already make these paths impossible to hit but
absl hardening checks in crbug.com/41497491 hint otherwise...
R=battre@chromium.org
Bug: 41497491
Change-Id: I512465cd3d4a8322ef89a78053dcbf6e0cd21c71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5416453
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Dominic Battre <battre@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1282709}
Adding a metric to track which preference are updated.
An udpate to a preference is triggering an update of the file on disk.
The update is done though the ImportantFileWrite which is suspected to
be too heavy on disk flush and it is affecting Chrome performance.
Bug: 40667025
Change-Id: Ic8a1d58e2e781eb919980a1c4eba873acdce44e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5391881
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Luc Nguyen <lucnguyen@google.com>
Cr-Commit-Position: refs/heads/main@{#1282506}
This is batch 1 of a Chromium-wide cleanup preparing for a libc++ change that changes various iterators to not be raw pointers.
components/omnibox/browser/autocomplete_result_unittest.cc was refactored to use base::span in AssertResultMatches().
AX-Relnotes: n/a.
Bug: 328308661
Change-Id: I77e74d10ae0a616b9086d712476d712cd31ccb3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5350511
Owners-Override: Nico Weber <thakis@chromium.org>
Commit-Queue: Arthur Eubanks <aeubanks@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1269423}
Soon, jni_zero's generated files will no longer have a dep onto base's
jni_android.h, which will break a number of files which rely on that
include to provide the base:: aliases to jni_zero functions. For the
most part, I have just changed the base::android:: refs to jni_zero::,
and in a few files with different references I've just added a direct
include of jni_android.h (or whatever header file was needed).
Bug: 1377351
Change-Id: I1a635d950be3e60f2afa400e52fe33fa9e433002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5240489
Auto-Submit: Sam Maier <smaier@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Owners-Override: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1252790}
In https://crrev.com/c/5154759, some uses of PrefChangeRegister were
moved to unique_ptr to ensure they could be reset prior to the
PrefService they referenced being destroyed. This caused a performance
regression on some benchmarks.
This reverts the majority of that change and instead adds an explicit
Reset method to PrefChangeRegister that clears the reference to the
PrefService. Using this avoids the heap allocation while still
addressing the dangling reference.
Fixed: 1515042
Bug: 1512677
Change-Id: I22ed2fd8d66e013c07382ddfdee6f2ecc37e96d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5217796
Commit-Queue: Mark Rowe <markrowe@chromium.org>
Reviewed-by: Dominic Battre <battre@chromium.org>
Auto-Submit: Mark Rowe <markrowe@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1251498}
PrefNotifierImpl::AddPrefObserver() used new + base::WrapUnique. Use
std::make_unique instead. Also replace a use of
std::unordered_map::operator[] with emplace() for smaller code.
Change-Id: I00d5f8bebd29fedcc7e78524a3466695650d9723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4954236
Auto-Submit: Adam Rice <ricea@chromium.org>
Commit-Queue: Dominic Battre <battre@chromium.org>
Reviewed-by: Dominic Battre <battre@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1212655}
Standalone browser settings are associated with the Ash primary profile
and may contain extension-set preferences from the main Lacros profile.
These settings should not be synced with Incognito.
The CL also fixes two other issues:
- The PrefServiceSyncableChromeOsTest fixture switched the recommended
store with the standalone browser store;
- While the standalone browser settings were readable from Incognito,
attempting to set a value in the standalone browser store from Incognito
caused a memory access violation.
Bug: b/292239313
Change-Id: I5066be8f15ce83e7353a10eea85c7a8aa2c2e906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4918977
Commit-Queue: Andreea Costinas <acostinas@google.com>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1208847}
Add a unit test that goes through offline demo mode. This test adds
functionality for prefs and settings, e.g. checking if oobe is completed
in the correct steps.
Bug: b:280794386
Change-Id: I3b142ea2c739a945f34ca5755c1b33fce88637d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4853517
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Dominic Battre <battre@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Miriam Polzer <mpolzer@google.com>
Cr-Commit-Position: refs/heads/main@{#1198292}
These direct deps were found via the new jdeps tool which will
eventually replace ClassPathValidator (the current way of detecting
missing direct deps).
Bug: 1099522
Change-Id: I4a537d97b59aac8574d2c011cd73b93fd8dc0290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4712911
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Owners-Override: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1174933}
GN edits made via script. It refactors all files where:
* There is a 1:1 mapping between android_library() and generate_jni()
* Variables were not used to store source files
@VisibleForTesting changes made manually
Validate-Test-Flakiness: skip
Bug: 1410871
Change-Id: I3a1c4262b020648d1eed8edc0c55fd98eab46e17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4580907
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1153635}
Unit tests for the go/rusty-qr-code-generator project are in the
`components_unittests` and therefore this CL adds coverage of this test
suite to the Rust bots.
Because of the https://www.hyrumslaw.com the CL has to modify some unit
tests that depend on the following semi-private aspects of the JSON
parser (which subtly differ on Rust bots):
* Exact shape of JSON error messages
* Threading model (broken by Rust implementation's usage of
`base::ThreadPool` in place of a mojo call):
* Tests no longer can use
`base::test::SingleThreadTaskEnvironment`
* Usage of `base::RunLoop::RunIdle` needs to be refactored away
(note that the comment for this method already says that it
should *not* be used - that `QuitClosure` + `Run` should be
preferred).
Bug: 1431991
Change-Id: I88da4f03b341a728b50ab209ed9eda8b4251ae31
Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
Cq-Include-Trybots: chromium/try:win-rust-x64-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571966
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1151521}
We are currently merging a CL that checks for dangling ptrs at exit, and
those pointers were detected to be dangling at exit
(crrev.com/c/4345458).
This new dangling ptrs check will help diagnose PartitionAlloc
quarantine memory bloat.
Bug: 1291138
Change-Id: Ic2f4be013e1e944c8211effa9ee745755661948f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4501235
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Owners-Override: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Paul Semel <paulsemel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1139622}
