luci-bisection@appspot.gserviceaccount.com
610a2eaeac
Revert "Reland "[lens-rearch][30/n] Remove update context from overlay controller.""
...
This reverts commit cac2493a61bad3b74ba3925c4dca9a266a798cae.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/6269741137133568
Sample build with failed test: https://ci.chromium.org/b/8714130360255361761
Affected test(s):
[ninja://chrome/test:browser_tests/LensOverlayControllerInnerHtmlWithInnerTextAndApc.PageContentTypeHistograms](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:browser_tests%2FLensOverlayControllerInnerHtmlWithInnerTextAndApc.PageContentTypeHistograms?q=VHash%3A6d0a43807ac672d9 )
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F6269741137133568&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6575884&type=BUG
Original change's description:
> Reland "[lens-rearch][30/n] Remove update context from overlay controller."
>
> Differences from reverted version: These changes by viewing the diff
> from PS1 to the latest PS. The differences are the disabling of the
> failing tests on branded builds with an added TODO that they should be
> re-enabled and fixed when fully resolving crbug.com/417812533
>
> This is a reland of commit f213852e1756254a740b6de1b4435ad88f9175e4
>
> Original change's description:
> > [lens-rearch][30/n] Remove update context from overlay controller.
> >
> > This removes the update page contextualization code from the overlay
> > controller in favor of updating the page context via the
> > contextualization controller. This also removes the overlay controller
> > not showing the overlay when initializing. This should be a no-op.
> >
> > Bug: 418825720
> > Change-Id: I3f559650c7d67f2cb9b62e9639b8907e9035a886
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6565474
> > Commit-Queue: Juan Mojica <juanmojica@google.com>
> > Commit-Queue: Duncan Mercer <mercerd@google.com>
> > Reviewed-by: Duncan Mercer <mercerd@google.com>
> > Auto-Submit: Juan Mojica <juanmojica@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1463558}
>
> Bug: 418825720
> Change-Id: Ief6b9e2c41ff5a34145c2d796699933842ffa189
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6575884
> Auto-Submit: Juan Mojica <juanmojica@google.com>
> Reviewed-by: Duncan Mercer <mercerd@google.com>
> Commit-Queue: Duncan Mercer <mercerd@google.com>
> Cr-Commit-Position: refs/heads/main@{#1464392}
>
Bug: 418825720
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Iafd8a49eb833ed7574c990d2095e5f39a120d58c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581378
Owners-Override: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Lingqi Chi <lingqi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464598}
2025-05-23 00:10:37 -07:00
Ramon Cano Aparicio
37bab131cd
Make chrome ios smoke tests aware of Seed File.
...
Before this CL, the test only checks Local State, now it checks the seed
file, to make sure that the seed is stored in a file.
To achieve that, it changes the way that the seed is injected into the
test, so when it inject a seed, it writes to both Local State and the
VariationsSeedV1 file.
Also it waits if a write is in progress, to make sure the check happens
after the seed is written.
Bug: 413580167
Change-Id: Iac24ccfda2859afaf86643905d18c1042eea65ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6546896
Reviewed-by: Ernest Nguyen Hung <ernn@google.com>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Commit-Queue: Ramon Cano Aparicio <rcanoaparicio@google.com>
Cr-Commit-Position: refs/heads/main@{#1464597}
2025-05-23 00:01:35 -07:00
chromium-autoroll
fc507ebe1c
Roll Chrome Android ARM64 PGO Profile
...
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1747971391-16c8aa5943b01583b8469767fd7a840df29a6ae7-2f3a3cd0dc47b7357c36aace440965589bfbf709.profdata to chrome-android64-main-1747975865-828629cbf1b8764814c590488be9acb26b4df939-630eac6033ededa684ffb8f5d32c83eb15caa8d9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com ,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I7d6c95798ffe85b40e54ed2e01f3f6142c2139ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581448
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464596}
2025-05-22 23:59:40 -07:00
chromium-autoroll
ed0bb5218e
Roll Depot Tools from 2b2ac20ac019 to e0ece52cfb4f (1 revision)
...
2b2ac20ac0..e0ece52cfbrecipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC chops-source-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
Change-Id: I02ddb298a5d52ccd4578d1e659fc71979cd53e10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581629
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464595}
2025-05-22 23:57:06 -07:00
chromium-autoroll
14adab46f0
Roll Chrome Mac Arm PGO Profile
...
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1747972769-0d1e31ff68a49d5159c64084f750cb0dfa965af9-f792e638e042a31818195792b08de9c159a9b937.profdata to chrome-mac-arm-main-1747979604-68956431eb96ccb29beb4e3c1868d86077d95b33-e3700ab53c077eecee3b69528dad4038b174b11c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com ,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I162405680beb5db63d4809aa7dc74cfcdb46fe64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6582068
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464594}
2025-05-22 23:56:10 -07:00
Colin Blundell
66ec83edf2
[Viz] Remove alpha_type override in TransferableResourceTracker
...
The SharedImages that are backing the TransferableResources created here
are all created with the default kPremul value for their
alpha type [1][2].
[1] https://source.chromium.org/chromium/chromium/src/+/main:components/viz/service/surfaces/surface_saved_frame.cc;l=157-161;drc=c76e4f83a8c5786b463c3e55c070a21ac751b96b
[2] https://source.chromium.org/chromium/chromium/src/+/main:components/viz/service/surfaces/surface_saved_frame.cc;l=203-227;drc=c76e4f83a8c5786b463c3e55c070a21ac751b96b;bpv=1;bpt=1
Bug: 410591523
Change-Id: I9141d8c6058e4f080b2e189058dc08835f85c702
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578110
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464593}
2025-05-22 23:55:33 -07:00
Colin Blundell
c9d17ee287
[Blink] Make CRPSI::resources_ hold only unused_resources
...
CanvasResourceProviderSharedImage::resources_ currently holds the
currently-used resource when single-buffered. This is confusing, as in
manay places the code treats it as having only unused resources (e.g.,
`ClearUnusedResources()` clears it, which for single-buffered mode
relies on the fact that we *also* hold a ref to the resource in
`resource_`).
This CL changes CanvasResourceProviderSharedImage to hold the resource
only in `resource_` for single-buffered mode, meaning that `resources_`
holds only unused resources (and will always be empty in single-buffered
mode). We do this by changing NewOrRecycledResource() to directly return
the resource that it creates when in single-buffered mode.
The return value of NewOrRecycledResource() is put directly into
`resource_` at all callsites other than [1]. [1] is used with the
software compositor, in which case the CRP cannot be
single-buffered [2][3].
The CL also makes the corresponding adjustments needed for this change
(which are minimal).
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc;l=495;drc=c76e4f83a8c5786b463c3e55c070a21ac751b96b;bpv=1;bpt=1?q=NewOrRecycled&ss=chromium
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc;l=307-310?q=canvas_resource_provider.cc&ss=chromium
[3] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc;l=1341-1357?q=canvas_resource_provider.cc&ss=chromium
Bug: 352263194
Change-Id: I2d2959e4b068e2051af4b693101f82cc69d2d797
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6575347
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464592}
2025-05-22 23:55:01 -07:00
Colin Blundell
a7d9c88a00
[Blink] Rename CanvasResourceDispatcher test fields/methods for clarity
...
Follows the rename in the production class [1].
[1] https://chromium-review.googlesource.com/c/chromium/src/+/6573936
Bug: 352263194
Change-Id: Ib00a2e9cf8a0387815c1f13c52cc25766368fd99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578029
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464591}
2025-05-22 23:54:25 -07:00
Adem Derinel
08af4e7b06
Simplify PasswordDropdownShown.* histograms in password/histograms.xml
...
Change-Id: Id2cad6bf1b4cc4d1e001e1d8131c1d1d267e0c12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578506
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Adem Derinel <derinel@google.com>
Cr-Commit-Position: refs/heads/main@{#1464590}
2025-05-22 23:53:52 -07:00
Qihui Zhao
e593ffb677
Update virtual card save bubble with badge view
...
Mock:
https://screenshot.googleplex.com/7Pn5jrGaNdnYSBJ
Screenshot:
https://screenshot.googleplex.com/3saVSXwYg3u9a7h
https://screenshot.googleplex.com/4BTLRoaD4u9ckWQ
Bug: b:405973373
Change-Id: I4395b2c835496dc90d0b046cbdab4e09f3bd2820
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6565541
Reviewed-by: Jan Keitel <jkeitel@google.com>
Commit-Queue: Qihui Zhao <qihuizhao@google.com>
Reviewed-by: Olivia Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/main@{#1464589}
2025-05-22 23:53:07 -07:00
Joanmarie Diggs
1514ff5c6a
Fix a11y flake of UnownedInnerWebContentsBrowserTest.AttachUnownedInnerWebContents
...
A DCHECK in BrowserAccessibilityManager::IsRootFrameManager is sometimes
failing because RenderFrameHostImpl::AccessibilityIsRootFrame returns
true for an iframe in the process of being destroyed, but the Browser
Accessibility Manager still has a parent tree id for that iframe.
Prior to deleting RenderFrameHostImpl's Browser Accessibility Manager
in the destructor, detach it from the parent manager.
Bug: 418991761
Change-Id: I0aa7b5bbbbc2820a8cafd40edccdfd632adae02f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6575346
Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464588}
2025-05-22 23:50:55 -07:00
jhtin
5e71c708c1
jp systempk: Move focus after dictionary delete to caret or add.
...
Moves it to the caret of the dictionary that is now in the previously
deleted dictionary's index, or to the add button in the dictionary page
if there is no dictionary in that index.
go/screencast/cast/NDgyNTg0MDgzMDM4MjA4MHw5NTFlMjdhNi02ZQ
Fixed: b:418055514
Change-Id: Id86b5d1a1c54a5fbeb4d1490c094b8a9dee61c88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6582162
Commit-Queue: Jon Htin <jhtin@google.com>
Reviewed-by: John Palmer <jopalmer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464587}
2025-05-22 23:47:34 -07:00
Jan Keitel
361a6c1f79
Modernize equality operators in //ui
...
This CL is pure clean-up and contains no functionality changes.
Depending on the files covered in the CL (since the CL was generated
using git cl split), it does a subset of the following:
the following:
- Remove unneeded operator!= declarations/definitions since C++20 can
automatically derive those from operator==.
- Default operator== where this is equivalent to the current behavior.
- Default operator<=> where this is equivalent to the current
behavior.
This CL was uploaded by git cl split.
R=kylixrd@chromium.org
Bug: 40256175
Change-Id: I9d1c9cb13159aabb003358031fb9d8f88de533a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6532331
Auto-Submit: Jan Keitel <jkeitel@google.com>
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Commit-Queue: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1464586}
2025-05-22 23:47:19 -07:00
Koji Ishii
aa06bd1073
[text-autospace] Change EastAsianSpacingType::kOther to 0
...
In the review of crrev.com/c/6342273, we intentionally set
`kNarrow` to be 0 because `kNarrow` is the largest set in the
data file[1]. It turned out that this decision was wrong, and
that this patch changes `kOther` to be 0.
1. The data file[1] defines that the default is `kOther`.
Meaning any values that are not set must be `kOther`, but
`CharacterPropertyValues` sets the default value to 0.
`InlineTextAutoSpaceTest/HtmlTest.Apply/11` tests U+739AD
is `kOther`, but the current code returns `kNarrow`.
2. The review assumed `kNarrow` is the largest set by counting
the value in the data file[1]. It missed that the file has:
# @missing: 0000..10FFFF; O
meaning the omitted code points are O. This change reduced
`kSerializedCharacterDataSize` from 21,264 to 15,680 bytes.
[1] https://unicode.org/reports/tr59/#data
Bug: 40275399
Change-Id: I0141e2b658ffc1d418b48a2a084a51d672e5cd8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6579828
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464585}
2025-05-22 23:41:35 -07:00
Johannes Henkel
54fe177800
[soft navs] back.tentative.html waits for effect of history.back().
...
The test is written so that the paints may arrive before the
URL update, because history.back()'s effect is asynchronous.
https://developer.mozilla.org/en-US/docs/Web/API/History/back
This makes it so that we wait for the effect of history.back()
before we modify the DOM, in the test. In this way,
when we change soft navigation detection to require the URL
change to arrive first [1], this test should continue to pass.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/6542137
Change-Id: If492d5e6adc75bbecc7f5c5c2dcc332f33fc3dad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581465
Reviewed-by: Michal Mocny <mmocny@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464584}
2025-05-22 23:40:17 -07:00
Colin Blundell
b4ecf4b06e
[//cc] Port PictureLayerImpl test away from creating low res tiles
...
Ports ChangeRasterTranslationNukeActiveLayerTiles in anticipation of
removing low-res tiling altogether.
Bug: 418234930
Change-Id: Ic7ecfd9d7661a26054b8ac4e854d07bb26b4fe5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578724
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464583}
2025-05-22 23:39:45 -07:00
Tsuyoshi Horo
4a222b6d9b
PluginInterceptor: Clear decoding types for plugin loading payloads
...
When a PDF is fetched from the server,
PluginResponseInterceptorURLLoaderThrottle intercepts the response. It
then rewrites the response body to load the PDF plugin.
The issue arises because the original URLResponseHead is copied and sent
to the renderer process along with this newly created plugin-loading
payload. If the original server response for the PDF had
`client_side_content_decoding_types` set (e.g., for a compressed PDF),
these types are preserved in the copied head. Consequently, the renderer
process mistakenly attempts to apply content decoding (as specified by
`client_side_content_decoding_types`) to the plugin-loading payload
itself. This corruption of the specialized payload prevents the PDF
plugin from loading correctly.
This CL addresses the problem by modifying
PluginResponseInterceptorURLLoaderThrottle. It now explicitly clears
the `client_side_content_decoding_types` from the URLResponseHead
before the modified response (containing the PDF plugin-loading payload)
is forwarded to the renderer process.
By ensuring `client_side_content_decoding_types` is empty for this
particular payload, this change prevents the renderer from erroneously
attempting to decode the plugin-loading payload. This allows the PDF
plugin to be loaded correctly, enabling proper rendering of PDFs even
when the original PDF resource was served with content encoding.
The test file 'test.pdf.gz' is created from the existing 'test.pdf'
by executing `gzip -k test.pdf`.
Fixed: 417398061
Bug: 391950057
Change-Id: I9f02929af38d9f35f31ea7ad9b440e5347fd2531
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6582002
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464582}
2025-05-22 23:33:58 -07:00
ChromeOS bot
a623329556
Automated Commit: LKGM 16291.0.0-1069055 for chromeos.
...
CrOS Changes (16289.0.0-1068983 -> 16291.0.0-1069055):
- External: http://go/cros-changes/76752..76824?ext=true
- Internal: http://go/cros-changes/110389..110461
Uploaded by https://ci.chromium.org/b/8714186012487876993
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-brya-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-jacuzzi-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-reven-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-volteer-chrome
CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-octopus-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-jacuzzi-rel
CrOS-LKGM: 16291.0.0-1069055
Merge-Approval-Bypass: Automated LKGM update
Cr-Original-Build-Id: 8714186012487876993
CrOS-External-Manifest-Position: 76824
CrOS-Internal-Manifest-Position: 110461
Change-Id: Iede19e6cf9eb411501f645b9698cd60b40f8831d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6580666
Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464581}
2025-05-22 23:31:53 -07:00
Johannes Henkel
4dc7802b02
[soft navs] Wait for history.back's effect in one more test.
...
Update interaction-with-paint-before-back.tentative.html so that
we don't paint before the effect of history.back takes effect.
We do this by waiting for the URL to change before mutating
the DOM. In this way, we'll continue to detect a soft navigation once
https://chromium-review.googlesource.com/c/chromium/src/+/6542137
lands.
Change-Id: Ifad8a7761d10c52a90f25d9e31e3449041ac80f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581578
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Michal Mocny <mmocny@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464580}
2025-05-22 23:20:49 -07:00
chromium-internal-autoroll
634905fb55
Roll clank/internal/apps from 032cd9aa2d98 to 0d8dce9ef69a (1 revision)
...
032cd9aa2d..0d8dce9ef6https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: Ieed09ea2ba49550d4a51d6e2e9dc28676887566b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581003
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464579}
2025-05-22 23:15:44 -07:00
chromium-autoroll
918e83316c
Roll Chrome Win64 PGO Profile
...
Roll Chrome Win64 PGO profile from chrome-win64-main-1747936607-5a6137eb5450ca5d3616b870007034a682bdd0d1-69fb47b82a6b54185ef4d8fb55a4d5986f147002.profdata to chrome-win64-main-1747958116-acc4ba18642be4e4671339d652a03ec6d1c4ca62-27634fa381c6426758aa5ee8e41e07eb20de6241.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com ,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ic08041927e9360dcd64d51568baea01c9f7997e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581295
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464578}
2025-05-22 23:11:06 -07:00
chromium-autoroll
c10a7c267a
Roll Skia from 18b85aced9b7 to ec992ded21de (2 revisions)
...
https://skia.googlesource.com/skia.git/+log/18b85aced9b7..ec992ded21de
2025-05-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 098e033ef69b to a4af0bcda127 (6 revisions)
2025-05-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC kjlubick@google.com ,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:mac14.arm64-blink-rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: kjlubick@google.com
Change-Id: Ia5ea657aedc1f7186420de52ee0cbd07f30b63a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581865
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464577}
2025-05-22 23:05:21 -07:00
chromium-internal-autoroll
43d9b1690e
Roll optimization-guide from aa7ee4b538e9 to e6fa5c8b549f
...
aa7ee4b538..e6fa5c8b54https://skia-autoroll.corp.goog/r/optimization-guide-chromium
Please CC chrome-intelligence-core@google.com ,sophiechang@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:419662542
Change-Id: Ie15ef21cde7dc5bd69e002fb2d779fb93f6586d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6582086
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464576}
2025-05-22 23:01:18 -07:00
Dominik Klemba
8e5e3f8549
Migrate ExtensionInstallPromptShowParamsTest into InProcessBrowserTest
...
Use of BrowserWithTestWindowTest is being deprecated and existing
tests requiring a Browser environment are being migrated to
being browser tests.
This CL updates the ExtensionInstallPromptShowParamsTest fixture to an
InProcessBrowserTest and removes the BrowserWithTestWindowTest
dependency.
Bug: 417766643
Change-Id: I47c22b2eece5f7e00fa1327d92c541ad236ecf40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578526
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Piotr Wrótniak <piotrwrotniak@google.com>
Reviewed-by: Tom Lukaszewicz <tluk@chromium.org>
Commit-Queue: Dominik Klemba <tacet@google.com>
Cr-Commit-Position: refs/heads/main@{#1464575}
2025-05-22 23:00:14 -07:00
chromium-autoroll
e3700ab53c
Roll Chrome Win32 PGO Profile
...
Roll Chrome Win32 PGO profile from chrome-win32-main-1747936607-0f2275ac7ccea9479fe0d01329add34967ac4d9d-69fb47b82a6b54185ef4d8fb55a4d5986f147002.profdata to chrome-win32-main-1747947544-7282a9865055c7d266763599033fc394662403ab-7f97f1d4fb86635ee5251487e3498f3f0299e152.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com ,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I7495b763763df4dcd3c10bb0be558d3fe6b01487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581581
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464574}
2025-05-22 22:53:24 -07:00
chromium-autoroll
352694c2a1
Roll Dawn from 366360f5c679 to 65e89ee3bd4c (7 revisions)
...
https://dawn.googlesource.com/dawn.git/+log/366360f5c679..65e89ee3bd4c
2025-05-23 jiawei.shao@intel.com [dawn/native] Replace `DAWN_LIKELY` with C++20 `[[likely]]`
2025-05-23 dsinclair@chromium.org [ir] Emit `continue` statements when converting to a Program.
2025-05-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from adffd31eb02f to d72e2b1a15d2 (1 revision)
2025-05-22 dsinclair@chromium.org [spirv-reader][ir] Add image read support.
2025-05-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 39d1c1ac45e3 to f0289a17bad0 (7 revisions)
2025-05-22 petermcneeley@google.com [tint] Arm enable transform handle for direct variable access
2025-05-22 dsinclair@chromium.org Fix IRToProgramRoundTripTest for invalid WGSL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com ,dneto@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64
Bug: chromium:343500108,chromium:387000529,chromium:406795494,chromium:407374442
Tbr: dneto@google.com
Change-Id: I3c5f569352a4391086740090074ff673de9bf538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6582024
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464573}
2025-05-22 22:52:35 -07:00
chromium-autoroll
ace84a03a7
Roll DevTools Frontend from 730a37a2d9af to 2ee87ba288c9 (2 revisions)
...
730a37a2d9..2ee87ba288changhaohan@chromium.org Add commandFor target linking in the DOM tree
2025-05-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS (trusted)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com ,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Ia775f6e9c2c607958437d885036610e58dd842ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6582083
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464572}
2025-05-22 22:45:32 -07:00
Brad Triebwasser
2b833ce5e0
Align Prompt input IDL with spec.
...
Updates name of IDL unions, and plumbs through the ability to attach a
list of message contents for a single prompt message.
Fuchsia binary size: This CL delta is only 123 lines of code. Increases
are likely due to idl changes and corresponding generated code.
Change-Id: I05724d1adcf76a404090d0e16eb08e56512620ae
Bug: 407801078
Fuchsia-Binary-Size: Size increase is unavoidable; See description.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6537171
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Mike Wasserman <msw@chromium.org>
Commit-Queue: Brad Triebwasser <btriebw@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464571}
2025-05-22 22:40:07 -07:00
chromium-autoroll
9605dbbe72
Roll Perfetto Trace Processor Win from 8435ff3dc184 to fa368a66f714
...
8435ff3dc1..fa368a66f7https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC chrometto-team@google.com ,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: Ibfed47c379a308c84509df5088c4d1ef565c217c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6582043
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464570}
2025-05-22 22:35:49 -07:00
chromium-autoroll
ca3c9758f9
Roll vulkan-deps from d8d0687affb2 to a4af0bcda127 (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/d8d0687affb2..a4af0bcda127
Also rolling transitive DEPS:
a44043332c..2cfeb90c13https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC angle-team@google.com ,cnorthrop@google.com,dneto@google.com,radial-bots+chrome-roll@google.com,radial-bots@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel
Bug: None
Tbr: cnorthrop@google.com ,dneto@google.com,radial-bots+chrome-roll@google.com
Change-Id: Icc97691f1509531e386cd232b9cce6b3da2c3b3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581036
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464569}
2025-05-22 22:34:56 -07:00
Kalvin Lee
80a9b9546a
spanify: Treat exclusions as frontiers
...
A non-functional test is provided with this change, to be investigated
in issue 419598098.
Fixed: 417339795
Change-Id: I19301a8f897aed59a6a44ad01a26cbf24dd88af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6538488
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464568}
2025-05-22 22:33:55 -07:00
Johannes Henkel
a53675a266
[soft navs] Tweaks to WPT task-attribution.html
...
This is in preparation for
https://chromium-review.googlesource.com/c/chromium/src/+/6542137
- setTimeoutForUrlUpdate was never wired up and no more useful.
- withSchedulerYield: swap order of url and ui update.
Change-Id: I85e8e13574e95de2aa22cf8216aa15996be4aa41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6580641
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Michal Mocny <mmocny@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464567}
2025-05-22 22:28:07 -07:00
chromium-autoroll
4deaee7946
Roll Chrome Android ARM64 PGO Profile
...
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1747966373-62caa01085345bcc2a42bf80391a950368ec11de-bc7e232775260ac418a57e55db6297d3a30b6655.profdata to chrome-android64-main-1747971391-16c8aa5943b01583b8469767fd7a840df29a6ae7-2f3a3cd0dc47b7357c36aace440965589bfbf709.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com ,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I7ea5a52a6ef1fbc21faec4a301a45f2dae9bfd36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581863
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464566}
2025-05-22 22:27:36 -07:00
Mike West
4693684f8f
[SRI Message Signatures] Support the @target-uri derived component.
...
This CL adds support for the `@target-uri` derived component, as defined
in https://www.rfc-editor.org/rfc/rfc9421.html#name-target-uri .
Bug: 383409584
Change-Id: Ic37d62540aaef9abc2679163cf1fa3a8d3ba6054
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578249
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464565}
2025-05-22 22:26:58 -07:00
Lei Zhang
22dd0af342
Remove chromeos_buildflags.h from //base headers
...
Stop using //base as a crutch for other parts of the code base that is
using this include transitively. Fix the GN build dependency rules as
well. For a couple of files, remove unused chromeos_buildflags.h
includes to avoid the build rule changes.
Bug: 354842935
Change-Id: I3096a284f1ef1cb4c39f3dfac73b15e76a361422
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6577222
Owners-Override: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464564}
2025-05-22 22:26:13 -07:00
Ramin Halavati
db6d35a43d
Add memory usage metric for OCR and Main Content Extraction services.
...
Memory usage of OCR and Main Content Extraction services are monitored
and the max usage per process instance is recorded.
Older metrics on memory state before OCR service are removed since the
new metrics better indicate the usage and can be used in future to stop
service initialization when enough memory is not available.
OBSOLETE_HISTOGRAMS=Accessibility.OCR.Service.MemoryBefore.{status}.Available is replaced by Accessibility.{ServiceName}.Service.MaxMemoryLoad
OBSOLETE_HISTOGRAMS=Accessibility.OCR.Service.MemoryBefore.{status}.Pressure is replaced by Accessibility.{ServiceName}.Service.MaxMemoryLoad
OBSOLETE_HISTOGRAMS=Accessibility.OCR.Service.MemoryBefore.{status}.Total is replaced by Accessibility.{ServiceName}.Service.MaxMemoryLoad
AX-Relotes: n/a
Bug: 369722831
Change-Id: I23bfe03ef6f3db5d4739c38d04398ee272ce8534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6552375
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Reviewed-by: Kyungjun Lee <kyungjunlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1464563}
2025-05-22 22:08:33 -07:00
chromium-autoroll
0d0b8701cf
Roll DevTools Frontend from 35bc8a8909d5 to 730a37a2d9af (1 revision)
...
35bc8a8909..730a37a2d9devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Chrome (for Testing) PIN
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com ,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Ib97a2f3b1e5971f4f03010fa17add54870b5b4da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581302
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464562}
2025-05-22 21:53:47 -07:00
Shuhei Takahashi
7b26a49e42
extensions: Generate Java enum for ExtensionAction::ShowAction
...
Bug: 385985177
Change-Id: I4498763fa26f0951f8ccc43f9141ab8dbc9c2e89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581677
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Shuhei Takahashi <nya@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464561}
2025-05-22 21:53:38 -07:00
chromium-autoroll
630eac6033
Roll ChromeOS Arm AFDO profile from 138-7151.22-1747621183-benchmark-138.0.7190.0-r1 to 138-7151.22-1747621183-benchmark-138.0.7194.0-r1
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-arm-chromium
Please CC c-compiler-chrome@google.com ,mobiletc-prebuild@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: mobiletc-prebuild@google.com
Change-Id: I721e37aea89c91c74217a1754d96b3ff7d8d8566
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6582027
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464560}
2025-05-22 21:51:05 -07:00
Hiroki Nakagawa
120d4d4ad2
Prefetch: Add prefetch tests for auth and cert errors
...
These test behavior is expected and no behavior fix is needed. See
https://crrev.com/c/6565430 and
https://crrev.com/c/6555942/comment/f763d814_2a482f31/ for details.
Bug: 413168040
Change-Id: Ia1d73c99f1bd5312881f88eb94c1f114f73e10c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6555942
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464559}
2025-05-22 21:46:44 -07:00
chromium-autoroll
f43c67d7d4
Roll Chrome Mac Arm PGO Profile
...
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1747965552-dd1c8859a51e8dab7abca3f7ee9837c704aa973a-18d89d402b4f65ea6eb4783158a56cba37393a6e.profdata to chrome-mac-arm-main-1747972769-0d1e31ff68a49d5159c64084f750cb0dfa965af9-f792e638e042a31818195792b08de9c159a9b937.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com ,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: If883e58342932ae37fe69a6329df08b999064f45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581966
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464558}
2025-05-22 21:46:35 -07:00
Yoshisato Yanagisawa
9620748f6b
Revert "[User Education] Do not show IPH during fullscreen"
...
This reverts commit ec404c06b61ff0b931b3b5f103173a226072a311.
Reason for revert:
Assuming the reason of continuous test failures in:
https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2Fchrome%2Ftest%3Ainteractive_ui_tests%2FHelpBubbleFactoryViewsUiTest.ToggleFocusForAccessibility?q=VHASH%3Abb6b160579f4c5fb
https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2Fchrome%2Ftest%3Ainteractive_ui_tests%2FHelpBubbleFactoryViewsUiTest.ToggleFocusForAccessibilityStartsFocused?q=VHASH%3Abb6b160579f4c5fb
https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2Fchrome%2Ftest%3Ainteractive_ui_tests%2FHelpBubbleFactoryViewsUiTest.ToggleFocusViaAccelerator?q=VHASH%3Abb6b160579f4c5fb
i.e.
HelpBubbleFactoryViewsUiTest.ToggleFocusForAccessibility
HelpBubbleFactoryViewsUiTest.ToggleFocusForAccessibilityStartsFocused
HelpBubbleFactoryViewsUiTest.ToggleFocusViaAccelerator
Bug: 411475424
Original change's description:
> [User Education] Do not show IPH during fullscreen
>
> Updates UE2.0 and 2.5, adds tests.
>
> See bug for motivation.
>
> Bug: 411475424
> Change-Id: I78bea54c1a17609335d37e313c74ab7ff01389a9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6580416
> Reviewed-by: Darryl James <dljames@chromium.org>
> Commit-Queue: Dana Fried <dfried@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1464302}
Bug: 411475424
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Icb5da7db96fe6cb127ed30fe18159386f6c40d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581407
Owners-Override: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Mingyu Lei <leimy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464557}
2025-05-22 21:45:03 -07:00
Koji Ishii
c5c8506d5f
[text-autospace] Change the code for testing
...
`InlineTextAutoSpace::Apply()` had an optional vector for
testing code to inspect its computation.
This patch changes it to a callback. This reduces test-only
code from the production, and makes it easier to change the
core logic without changing tests.
This patch has no behavior changes.
Bug: 40275399
Change-Id: I5371e936fce4e954c245d839315c49efb897fbef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6577875
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464556}
2025-05-22 21:38:54 -07:00
Yoichi Osato
ff7255ab68
Roll src/net/third_party/quiche/src/ 7802d58f2..3b42119c3 (6 commits)
...
https://quiche.googlesource.com/quiche.git/+log/7802d58f2294..3b42119c3e4b
$ git log 7802d58f2..3b42119c3 --date=short --no-merges --format='%ad %ae %s'
2025-05-21 martinduke Remove deprecated min_ack_delay transport parameter.
2025-05-20 davidben Use `bssl::UniquePtr` to own the `SSL_CREDENTIAL` in `SetCertChain`
2025-05-20 birenroy Removes the old quiche_mem_slice_lib BUILD target and forwarding header file.
2025-05-20 martinduke Divert all QUIC key derivation to use heapless functions.
2025-05-20 quiche-dev Early returns from BalsaFrame::HasInvalidHeaderChars().
2025-05-20 quiche-dev std::array::fill is not constexpr in C++ 17; use aggregate initialization instead.
Created with:
roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src
Change-Id: Ie9e764eb522af37fe258540e5d15600239176437
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6575502
Auto-Submit: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464555}
2025-05-22 21:34:18 -07:00
chromium-internal-autoroll
b7564e8e44
Roll clank/internal/apps from 642dcf56c559 to 032cd9aa2d98 (1 revision)
...
642dcf56c5..032cd9aa2dhttps://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: I557dc0d1fba272be7ebdf5e788e635ce1f781b51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581404
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464554}
2025-05-22 21:25:35 -07:00
chromium-autoroll
69fe3cfec2
Roll V8 from 5f0be56704de to 13977d393a48 (2 revisions)
...
5f0be56704..13977d393av8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 13.8.239
2025-05-23 zhijin.zeng@spacemit.com [risc-v] Remove useless zero-extend instruction for lwu in rv64
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-autoroll
Please CC liviurau@google.com ,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel
Change-Id: Ic2a20d951d1acede278389638f5600d727537c3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581785
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464553}
2025-05-22 21:17:03 -07:00
Kenichi Ishibashi
98463d098e
HttpStreamPool: Update some tests
...
This is a preparation for making AttemptManager enter "draining"
state after all jobs are notified. Some tests assumed that:
- Could access AttemptManager via Group after notification.
- Only one FakeServiceEndpointRequest was needed.
When we make AttemptManager enter "draining" these don't always hold.
Update some of these tests to remove such assumptions. Changes are:
- Use the associated AttemptManager of a StreamRequester, which can
be used unless the AttemptManager is destroyed.
- Use the default resolution for ServiceEndpointRequest.
No behavior changes.
Bug: 414173943
Change-Id: I550ae7455e65aa25ba8132f2b604390a7bf5efe8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581796
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464552}
2025-05-22 21:12:07 -07:00
chromium-autoroll
ad1f8ec51a
Roll Chrome Android ARM64 PGO Profile
...
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1747960124-e8fd86ebb8f5d09830f177638c3f0b82ee43d6ed-e5352fdb7821f60bb4b89f8bed340d9bcbbba6b1.profdata to chrome-android64-main-1747966373-62caa01085345bcc2a42bf80391a950368ec11de-bc7e232775260ac418a57e55db6297d3a30b6655.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com ,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I7739238e88c171abeb8330ae35bacd001196965f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581964
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464551}
2025-05-22 21:11:57 -07:00
chromium-internal-autoroll
02d3729082
Roll clank/internal/apps from c2910b6472c3 to 642dcf56c559 (1 revision)
...
c2910b6472..642dcf56c5https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: I59d990b2e93c95c2560202f3b1d06c18d0b1ea9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581403
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1464550}
2025-05-22 21:07:08 -07:00
Eshwar Stalin
2a35bf59eb
Adding a flag for the tab search toolbar feature
...
Change-Id: Iedc4e758ecd541be498f5b1087c8205c9c77c03e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6574832
Reviewed-by: Alison Gale <agale@chromium.org>
Commit-Queue: Eshwar Stalin <estalin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464549}
2025-05-22 21:01:31 -07:00
