b41301a2a3
Reland "cros-geo-apikey: Update ChromeOS surfaces to use new API keys"
...
This reverts commit 31a89b88e6https://chromium-review.googlesource.com/c/chromium/src/+/6401294
Original change's description:
> Revert "cros-geo-apikey: Update ChromeOS surfaces to use new API keys"
>
> This reverts commit f1341b6f55https://chromium-review.googlesource.com/c/chromium/src/+/6361503
> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org >
> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org >
> > Commit-Queue: Zauri Meshveliani <zauri@chromium.org >
> > Cr-Commit-Position: refs/heads/main@{#1438300}
>
> Bug: 394051078, 406579271
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Ie920746087812a1fd118b66031e7bd42cf8c210f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6399493
> Auto-Submit: Joel Hockey <joelhockey@chromium.org >
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> Owners-Override: Joel Hockey <joelhockey@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1438546}
Bug: 394051078, 406579271
Change-Id: I53f5a383a367c1a21b32ce899dbb9e635049a11a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6401295
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Owners-Override: Joel Hockey <joelhockey@chromium.org >
Commit-Queue: Joel Hockey <joelhockey@chromium.org >
Reviewed-by: Joel Hockey <joelhockey@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1438987}
2025-03-27 13:53:57 -07:00
31a89b88e6
Revert "cros-geo-apikey: Update ChromeOS surfaces to use new API keys"
...
This reverts commit f1341b6f55https://chromium-review.googlesource.com/c/chromium/src/+/6361503
> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org >
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org >
> Commit-Queue: Zauri Meshveliani <zauri@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1438300}
Bug: 394051078, 406579271
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ie920746087812a1fd118b66031e7bd42cf8c210f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6399493
Auto-Submit: Joel Hockey <joelhockey@chromium.org >
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Owners-Override: Joel Hockey <joelhockey@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1438546}
2025-03-26 19:45:09 -07:00
f1341b6f55
cros-geo-apikey: Update ChromeOS surfaces to use new API keys
...
Introduce new methods for ChromeOS to access the ChromeOS-specific GCP
API keys. Update the `SimpleGeolocationRequest` and
`ChromeContentBrowserClient` to use these new keys instead.
Bug: 394051078
Change-Id: I36b6995b3bfb7edd81ac63d785c0a8946101137b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6361503
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org >
Reviewed-by: Mihai Sardarescu <msarda@chromium.org >
Commit-Queue: Zauri Meshveliani <zauri@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1438300}
2025-03-26 11:52:22 -07:00
0c0448b8fe
google_apis: Remove Lacros leftovers
...
Lacros is gone.
- Replace IS_CHROMEOS_ASH uses with IS_CHROMEOS.
- Remove IS_CHROMEOS_LACROS uses.
- Remove includes of build/chromeos_buildflags.h or replace the with
build/build_config.h.
- Remove imports of chromeos/ui_mode.gni.
Bug: b:354842935
Change-Id: I1c49e9eef253057fc68286fdd1d55d1cf116a486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6228659
Reviewed-by: Monica Basta <msalama@chromium.org >
Commit-Queue: Georg Neis <neis@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1415926}
2025-02-04 17:01:08 -08:00
4416597d3b
[google_apis] Remove BUILDFLAG(OS_IOS) from google_api_keys.
...
This CL replaces the usage of BUILDFLAG(IS_IOS) with
BUILDFLAG(SUPPORT_EXTERNAL_GOOGLE_API_KEY) as
SUPPORT_EXTERNAL_GOOGLE_API_KEY is already true on OS_IOS
Bug: NONE
Change-Id: I21aa7a12035e343ffe43e0a63b364f1bd7048a56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5947450
Reviewed-by: Alex Ilin <alexilin@chromium.org >
Commit-Queue: Mihai Sardarescu <msarda@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1373862}
2024-10-25 13:23:37 +00:00
6075bf2174
[google_apis] Crash if the API key was already configured
...
This CL crashes the application if the API key is overridden after its
first usage.
Bug: 40164066
Change-Id: I71044d1d5a7e6f2f808b85fa23013b23ee411469
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5890974
Reviewed-by: David Dorwin <ddorwin@chromium.org >
Reviewed-by: Alex Ilin <alexilin@chromium.org >
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org >
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Commit-Queue: Mihai Sardarescu <msarda@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1373212}
2024-10-24 09:33:51 +00:00
dec8a3beba
Reland "Add Boca API key."
...
This reverts commit b2aa0c30ffhttps://chromium-review.googlesource.com/c/chromium/src/+/5917342
Original change's description:
> Revert "Add Boca API key."
>
> This reverts commit 43bf3dc6dbhttps://chromium-review.googlesource.com/c/chromium/src/+/5908987
> > Reviewed-by: Avynn Donaghe <avynn@google.com >
> > Commit-Queue: Dorian Brandon <dorianbrandon@google.com >
> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
> > Cr-Commit-Position: refs/heads/main@{#1364855}
>
> Bug: b/359931233
> Change-Id: Ifc49a7176f484f511edf11601b9afedca2f34e23
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5912855
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> Auto-Submit: Steinar H Gunderson <sesse@chromium.org >
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> Owners-Override: Steinar H Gunderson <sesse@chromium.org >
> Commit-Queue: Steinar H Gunderson <sesse@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1364904}
Bug: b/359931233
Change-Id: Ib665729e9de678cd921bf8642043d00efb458ef9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5917407
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
Commit-Queue: Dorian Brandon <dorianbrandon@google.com >
Cr-Commit-Position: refs/heads/main@{#1366428}
2024-10-09 20:39:54 +00:00
b2aa0c30ff
Revert "Add Boca API key."
...
This reverts commit 43bf3dc6dbhttps://chromium-review.googlesource.com/c/chromium/src/+/5908987
> Reviewed-by: Avynn Donaghe <avynn@google.com >
> Commit-Queue: Dorian Brandon <dorianbrandon@google.com >
> Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1364855}
Bug: b/359931233
Change-Id: Ifc49a7176f484f511edf11601b9afedca2f34e23
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5912855
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Auto-Submit: Steinar H Gunderson <sesse@chromium.org >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Owners-Override: Steinar H Gunderson <sesse@chromium.org >
Commit-Queue: Steinar H Gunderson <sesse@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1364904}
2024-10-07 13:42:14 +00:00
43bf3dc6db
Add Boca API key.
...
The Boca API key will be used for Live Translate on ChromeOS.
Bug: b/359931233
Change-Id: Ie9b18ec6d0eb781c245301125b177ed4161386c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5908987
Reviewed-by: Avynn Donaghe <avynn@google.com >
Commit-Queue: Dorian Brandon <dorianbrandon@google.com >
Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1364855}
2024-10-07 10:24:54 +00:00
c8f909854f
[google-apis] Stop re-including google_api_keys-inc.cc in tests
...
Instead of including google_api_keys-inc.cc multiple times in the tests,
we can now construct ApiKeyCache instance in a test and re-assign the
global pointer to it.
Bug: 367764868
Change-Id: I7a229aed2357de4e61a318fd7da9a0b63020697c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5878080
Commit-Queue: Alex Ilin <alexilin@chromium.org >
Reviewed-by: Mihai Sardarescu <msarda@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1358788}
2024-09-23 14:09:40 +00:00
629b3b3e83
[google_apis] Use const-string references
...
This CL uses const-string references for API keys accessors. This is
safe as the keys are stored in global variables and are never released.
Note: As a side effect this no longer loads the API keys on non-browser
processes as GaiaUrls::oauth2_chrome_client_id_ is no longer loaded
in the GaiaUrls() constructor.
Bug: 364842312
Change-Id: I527f4f25b00a174592bb6e36257ff06d39322b58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5837280
Reviewed-by: Alex Ilin <alexilin@chromium.org >
Commit-Queue: Mihai Sardarescu <msarda@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1353250}
2024-09-10 11:32:46 +00:00
dc3ef35dfb
[google_apis] Crash if the API key was already configured
...
This CL crashes the application if the API key is overriden after its
first usage.
Bug: 40164066
Change-Id: I28e978c90589f9df49f0cda903734c9f3cba5064
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5837037
Reviewed-by: Alex Ilin <alexilin@chromium.org >
Commit-Queue: Mihai Sardarescu <msarda@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1351396}
2024-09-05 14:13:13 +00:00
b5c06f2580
Remove deprecated GetNonStableAPIKey() API
...
This reverts commit 5a97d03352https://chromium-review.googlesource.com/c/chromium/src/+/5749404
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org >
> Commit-Queue: James Lee <ljjlee@google.com >
> Cr-Commit-Position: refs/heads/main@{#1334882}
Bug: 40216037, 355652328
Change-Id: If8f2a96faabfcdf377cb1b25a83365af241ca424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5756821
Commit-Queue: James Lee <ljjlee@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: James Lee <ljjlee@google.com >
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1336626}
2024-08-02 15:22:22 +00:00
5a97d03352
Partial revert of crrev/c/5741205
...
There were still some code references outside the main Chromium repo, so re-adding the soon-to-be-deprecated API while those are migrated.
Bug: 40216037, 355652328
Change-Id: I2d30e61a5b0dfc7bb1e8031b3a1e50ee6cf975bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5749404
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org >
Commit-Queue: James Lee <ljjlee@google.com >
Cr-Commit-Position: refs/heads/main@{#1334882}
2024-07-30 16:22:04 +00:00
4c20facac8
Migrate remaining usages of google_apis::GetNonStableAPIKey()
...
This CL is purely cleanup; there are no functional changes (in
particular the same all callers continue to use the same API key as
previously).
AX-Relnotes: n/a.
Bug: 40216037,355652328
Change-Id: Ic3d13df0e6b33a5e4ac76a61294f70dee1aaaf7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5741205
Reviewed-by: Alex Ilin <alexilin@chromium.org >
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org >
Reviewed-by: Nate Fischer <ntfschr@chromium.org >
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Commit-Queue: James Lee <ljjlee@google.com >
Cr-Commit-Position: refs/heads/main@{#1334802}
2024-07-30 14:03:44 +00:00
feb1c36478
Consistent interface to add the Google API key to a request
...
As part of crrev/c/5734315 I notice there is a lot of inconsistency
and duplication in how we set API keys on requests:
* Some places set a URL parameter, some set the HTTP header (both are
valid per https://cloud.google.com/apis/docs/system-parameters )
* The header name is hard-coded in many places
* Call sites don't all handle the different stable/non-stable channel
keys
This CL adds an API to improve on the issues above.
Bug: 355544759
Change-Id: Iea4616bcbdcb10ba7d9e2dcd8ffefddd2df813be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5730337
Auto-Submit: James Lee <ljjlee@google.com >
Reviewed-by: Alex Ilin <alexilin@chromium.org >
Reviewed-by: Nohemi Fernandez <fernandex@chromium.org >
Commit-Queue: James Lee <ljjlee@google.com >
Cr-Commit-Position: refs/heads/main@{#1334202}
2024-07-29 13:07:28 +00:00
47d1537de7
Migrate TODOs referencing old crbug IDs to the new issue tracker IDs
...
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/ <old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/ <old id>)
- TODO(https://issues.chromium.org/u/1/issues/ <old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: Ieeb461e2d489e86fd50b87a2a0721a2be34520c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467317
Owners-Override: Alison Gale <agale@chromium.org >
Commit-Queue: Darryl James <dljames@chromium.org >
Commit-Queue: Alison Gale <agale@chromium.org >
Reviewed-by: Darryl James <dljames@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1290198}
2024-04-19 21:31:46 +00:00
4ed896bb64
Reland "Reland "HaTS: Add HaTS Api Key""
...
This is a reland of commit 8475f68315https://chrome-internal-review.googlesource.com/c/chrome/google_apis/internal/+/6151544 , it has to be rolled manually. This roll has been done in https://crrev.com/c/4859186 .
Original change's description:
> Reland "HaTS: Add HaTS Api Key"
>
> This is a reland of commit 53451bb279https://chromium-review.googlesource.com/c/chromium/src/+/4683948
> > Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org >
> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
> > Cr-Commit-Position: refs/heads/main@{#1187261}
>
> Bug: 1121586, b/291043820, 1475428
> Change-Id: I66e5d709c342dff35068a69f4dc0cba369aee5e3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4808127
> Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1188271}
Bug: 1121586, b/291043820, 1475428
Change-Id: Ib160384da9ced5a3cd096dc61c9e30ead92f7fcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4859292
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org >
Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1196020}
2023-09-13 15:35:58 +00:00
08be09ec4a
Revert "Reland "HaTS: Add HaTS Api Key""
...
This reverts commit 8475f6831553451bb279https://chromium-review.googlesource.com/c/chromium/src/+/4683948
> > Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org >
> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
> > Cr-Commit-Position: refs/heads/main@{#1187261}
>
> Bug: 1121586, b/291043820, 1475428
> Change-Id: I66e5d709c342dff35068a69f4dc0cba369aee5e3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4808127
> Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1188271}
Bug: 1121586, b/291043820, 1475428
Change-Id: Ied2bd6b2a4930e86500d0bd8e4c53f4a214a28fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4813466
Auto-Submit: Artsiom Mitrokhin <amitrokhin@chromium.org >
Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
Reviewed-by: Ana Salazar Maldonado <anasalazar@google.com >
Commit-Queue: Ana Salazar Maldonado <anasalazar@google.com >
Owners-Override: Ana Salazar Maldonado <anasalazar@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1188371}
2023-08-25 16:10:50 +00:00
8475f68315
Reland "HaTS: Add HaTS Api Key"
...
This is a reland of commit 53451bb279https://chromium-review.googlesource.com/c/chromium/src/+/4683948
> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org >
> Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1187261}
Bug: 1121586, b/291043820, 1475428
Change-Id: I66e5d709c342dff35068a69f4dc0cba369aee5e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4808127
Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1188271}
2023-08-25 10:50:32 +00:00
97a2d885e9
Revert "HaTS: Add HaTS Api Key"
...
This reverts commit 53451bb279https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/35327/blamelist
Original change's description:
> HaTS: Add HaTS Api Key
>
> Bug: 1121586, b/291043820
> Change-Id: I6fc2db36b61d1ec4fefedf69c380aec196707032
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4683948
> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org >
> Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1187261}
Bug: 1121586, b/291043820
Change-Id: I35bb2a3d0199057073b2c5bdfc0b56c7b70ca25a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4808780
Reviewed-by: Darryl James <dljames@chromium.org >
Auto-Submit: Ana Salazar Maldonado <anasalazar@google.com >
Reviewed-by: Ana Salazar Maldonado <anasalazar@google.com >
Reviewed-by: Joshua Hood <jdh@chromium.org >
Owners-Override: Darryl James <dljames@chromium.org >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Ana Salazar Maldonado <anasalazar@google.com >
Owners-Override: Ana Salazar Maldonado <anasalazar@google.com >
Cr-Commit-Position: refs/heads/main@{#1187467}
2023-08-23 20:32:16 +00:00
53451bb279
HaTS: Add HaTS Api Key
...
Bug: 1121586, b/291043820
Change-Id: I6fc2db36b61d1ec4fefedf69c380aec196707032
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4683948
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org >
Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1187261}
2023-08-23 14:16:46 +00:00
a08ea663bb
Make //google_apis a component
...
Multiple components depend on build target //google_apis which is
against recommended practices in [1] and specifically runs into issues
when new singleton-like state, include base::Feature instances, are
added to //google_apis.
Following recommended practices, this patch makes //google_apis a
component itself, as all targets it depends on are already components.
[1] https://chromium.googlesource.com/chromium/src/+/main/docs/component_build.md#dependencies-between-targets
Change-Id: I9c14050314b208791d7d5773ab76a7913c422bd9
Fixed: 1417961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4272614
Reviewed-by: Jamie Walch <jamiewalch@chromium.org >
Reviewed-by: Alex Ilin <alexilin@chromium.org >
Commit-Queue: Mikel Astiz <mastiz@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1107876}
2023-02-21 19:30:11 +00:00
97f1a03603
[google_apis] Only define Ash-specific keys in Ash builds
...
The SODA key is moved to accommodate a single conditional block for Ash.
Bug: 1377536
Change-Id: Ic639b2a90d9797e99ce616dace66b09cd01306d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3991851
Commit-Queue: David Dorwin <ddorwin@chromium.org >
Reviewed-by: Mihai Sardarescu <msarda@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1066714}
2022-11-02 21:44:03 +00:00
581738bbaf
[google_apis] Only define platform-specific keys on those platforms
...
GOOGLE_API_KEY_ANDROID_NON_STABLE is specific to Android.
GOOGLE_API_KEY_SHARING is used by Nearby.
Per https://crrev.com/c/2441025 , the feature but is now
"a Chrome OS-only feature." https://crrev.com/c/2564980 later updated
the condition for files that use this feature to use `is_chromeos_ash`
instead of `is_chromeos`.
Bug: 1031156, 1377536
Change-Id: I77ad476d373cd6dfb98a5ed5f71f8ff79270199a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3984260
Auto-Submit: David Dorwin <ddorwin@chromium.org >
Commit-Queue: Mihai Sardarescu <msarda@chromium.org >
Reviewed-by: Mihai Sardarescu <msarda@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1064783}
2022-10-28 10:40:50 +00:00
b4aa65faee
[google_apis] Remove SPDY proxy key support
...
The code that used it was removed early this year. See the bug.
Bug: 1285486, 1377536
Change-Id: Iba6747024b891f1fe0659f353a32c1090af35f48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3984602
Reviewed-by: Tarun Bansal <tbansal@chromium.org >
Reviewed-by: Mihai Sardarescu <msarda@chromium.org >
Auto-Submit: David Dorwin <ddorwin@chromium.org >
Commit-Queue: Mihai Sardarescu <msarda@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1064782}
2022-10-28 10:40:41 +00:00
8ce0344d27
Update copyright headers in google_apis/ and google_update/
...
The methodology used to generate this CL is documented in
https://crbug.com/1098010#c34 .
No-Try: true
Bug: 1098010
Change-Id: I1fb879b19400429688d232eb0b8c7f96c1c3318c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3894203
Auto-Submit: Avi Drissman <avi@chromium.org >
Owners-Override: Avi Drissman <avi@chromium.org >
Commit-Queue: Mark Mentovai <mark@chromium.org >
Reviewed-by: Mark Mentovai <mark@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1046547}
2022-09-13 20:40:56 +00:00
c5f373c3a2
[google_apis] Add BUILDFLAG for whether to define SetAPIKey()
...
Replace iOS and Fuchsia conditions with a new
SUPPORT_EXTERNAL_GOOGLE_API_KEY BUILDFLAG so the logic is only defined
in one location and can be referenced outside //google_apis.
No build logic is changed.
`#if BUILDFLAG(IS_IOS) || BUILDFLAG(IS_FUCHSIA)` is replaced with
`#if BUILDFLAG(SUPPORT_EXTERNAL_GOOGLE_API_KEY)`, which is defined as
`is_ios || is_fuchsia`.
Bug: 1294915
Change-Id: I9a57727d7df86bd22f04c32946af4b49b1b69f29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3756795
Auto-Submit: David Dorwin <ddorwin@chromium.org >
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org >
Commit-Queue: David Dorwin <ddorwin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1045946}
2022-09-12 19:11:48 +00:00
fc90637961
Revert "[google_apis] Allow overriding use_official_google_api_keys"
...
This reverts commit 0ae6b65b32https://crbug.com/1171510 , which caused
> the previous attempt, https://crrev.com/c/2657805 , to be reverted.
>
> Bug: 1294915, 1183709
> Change-Id: I68d8babe6461a91117396488b2a27772c9952f80
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3756721
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org >
> Commit-Queue: David Dorwin <ddorwin@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1041234}
Bug: 1294915, 1183709
Change-Id: I192d4b59097f5db2218447a7983d216b910850a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3864681
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org >
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1042202}
2022-09-01 18:15:36 +00:00
0ae6b65b32
[google_apis] Allow overriding use_official_google_api_keys
...
Previously, is_chrome_branded would override a false value. Fix that and
update the C++ logic to be compatible. Retains the existing behavior
for iOS only due to iOS issue https://crbug.com/1171510 , which caused
the previous attempt, https://crrev.com/c/2657805 , to be reverted.
Bug: 1294915, 1183709
Change-Id: I68d8babe6461a91117396488b2a27772c9952f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3756721
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org >
Commit-Queue: David Dorwin <ddorwin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1041234}
2022-08-30 23:06:24 +00:00
2c1a1e5476
Remove Google API keys for Cloud Print.
...
They are no longer in use.
Bug: 1162164
Change-Id: I303d376d234bb28de67a239180886df3051549d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3384955
Reviewed-by: Monica Basta <msalama@chromium.org >
Reviewed-by: Sam Maier <smaier@chromium.org >
Commit-Queue: Lei Zhang <thestig@chromium.org >
Cr-Commit-Position: refs/heads/main@{#962030}
2022-01-21 19:41:43 +00:00
83bdf14101
misc: Use BUILDFLAG for OS checking
...
Use BUILDFLAG(IS_XXX) instead of defined(OS_XXX).
Generated by `os_buildflag_migration.py` (https://crrev.com/c/3311983 ).
R=thakis@chromium.org
Bug: 1234043https://chromium-review.googlesource.com/c/chromium/src/+/3406582
Reviewed-by: Nico Weber <thakis@chromium.org >
Owners-Override: Nico Weber <thakis@chromium.org >
Commit-Queue: Xiaohan Wang <xhwang@chromium.org >
Cr-Commit-Position: refs/heads/main@{#962020}
2022-01-21 19:23:11 +00:00
658abca48e
Plumb API key for Fresnel service authorization.
...
API key will be used for authenticating device with Fresnel Oneplatform
API. This provides one layer of protection against unauthenticated
requests.
Googlers: go/cros-device-actives-client - See Authorization section
Bug: 1204630
Change-Id: I9dc9ea0391edd1057bc666c2c66c95a196ad0dd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3069422
Commit-Queue: Hirthanan Subenderan <hirthanan@google.com >
Reviewed-by: David Roger <droger@chromium.org >
Cr-Commit-Position: refs/heads/main@{#947610}
2021-12-02 19:22:17 +00:00
43ccd76635
Plumb through API key for ReadAloud service.
...
API key will be used by integration with remote ReadAloud service to provide enhanced text-to-speech synthesis to Select-to-speak.
go/wavenet-chromeos-dd
Bug: 1215291
Change-Id: Ib6263369a15329d9f129273698e009fc0d6c1b69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2930784
Reviewed-by: David Roger <droger@chromium.org >
Commit-Queue: Joel Riley <joelriley@google.com >
Cr-Commit-Position: refs/heads/master@{#889428}
2021-06-04 20:25:57 +00:00
41d26edbc2
[fuchsia] Add support for Google API Key provided via command line
...
Add support for Google API Key when provided through the config file
read by WebEngine.
key present.
Test: Manually tested. Safe Sites functionality works without another
Bug: 1160130
Change-Id: I8b0fef7aa4892e130e0b6d423dc63e733e05aca6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613649
Commit-Queue: Sharon Yang <yangsharon@chromium.org >
Reviewed-by: Wez <wez@chromium.org >
Reviewed-by: Mihai Sardarescu <msarda@chromium.org >
Reviewed-by: David Dorwin <ddorwin@chromium.org >
Cr-Commit-Position: refs/heads/master@{#843741}
2021-01-14 21:23:52 +00:00
95c1668bdf
Remove DevTools survey API key
...
This was going to be used for HaTS surveys in the DevTools frontend
but we ended up going with a different implementation where we share
code with the browser implementation, so we don't need our own API
key anymore. This was never used as it was just added in
preparation.
R=msarda@chromium.org
Bug: 1112738
Change-Id: Ibb92f40bdb1bad23b90320c5021c642961040e96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560499
Auto-Submit: Peter Marshall <petermarshall@chromium.org >
Reviewed-by: Mihai Sardarescu <msarda@chromium.org >
Commit-Queue: Mihai Sardarescu <msarda@chromium.org >
Cr-Commit-Position: refs/heads/master@{#832287}
2020-12-01 11:10:18 +00:00
4cd7ee2dd9
Plumb through the API key for devtools surveys
...
Devtools is adding functionality to do in-product surveys via a
non-public API. This CL adds the ability for the chrome-internal
repository to set an API key that gets piped through to devtools.
The API key is added to google_api_keys in the same way that other API
keys are handled, meaning it can be locally overridden, although there
is not much point to actually doing this because the API itself is not
public.
This CL adds a new method 'getSurveyAPIKey' to the InspectorFrontendHost
API which the devtools frontend uses to communicate with chrome.
The corresponding frontend CL is http://crrev.com/c/2361683/
Doc: https://docs.google.com/document/d/1wMRb1hI2zJ1mzOSJjjF46C2hToGksQf2AxurorxaiTg/edit#heading=h.jc7x7daf69yo
Bug: 1112738
Change-Id: Ic3d9d436556f06b8ff8fb3593e4ed40d68ed3507
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362182
Reviewed-by: Simon Zünd <szuend@chromium.org >
Reviewed-by: Andrey Kosyakov <caseq@chromium.org >
Reviewed-by: Mihai Sardarescu <msarda@chromium.org >
Reviewed-by: Tom Sepez <tsepez@chromium.org >
Commit-Queue: Peter Marshall <petermarshall@chromium.org >
Cr-Commit-Position: refs/heads/master@{#807027}
2020-09-15 14:48:22 +00:00
dcab71341e
Reland "Add SODA API Key"
...
This is a reland of b01fb51632https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/3179564 )
Original change's description:
> Add SODA API Key
>
> This CL adds an API key for the Speech On-Device API (SODA). Usage of
> the API key is outlined here: go/securing-soda-on-chrome.
>
> Bug: 1107615https://chromium-review.googlesource.com/c/chromium/src/+/2309133
> Reviewed-by: David Roger <droger@chromium.org >
> Commit-Queue: Evan Liu <evliu@google.com >
> Cr-Commit-Position: refs/heads/master@{#790550}
Bug: 1107615https://chromium-review.googlesource.com/c/chromium/src/+/2315237
Reviewed-by: David Roger <droger@chromium.org >
Commit-Queue: David Roger <droger@chromium.org >
Cr-Commit-Position: refs/heads/master@{#791181}
2020-07-23 09:17:21 +00:00
be2fb3d70d
Revert "Add SODA API Key"
...
This reverts commit b01fb516321107615https://chromium-review.googlesource.com/c/chromium/src/+/2309133
> Reviewed-by: David Roger <droger@chromium.org >
> Commit-Queue: Evan Liu <evliu@google.com >
> Cr-Commit-Position: refs/heads/master@{#790550}
TBR=droger@chromium.org ,evliu@google.com
Change-Id: I64f9e46714ca6675e74702dc1d1a446d873ed741
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1107615https://chromium-review.googlesource.com/c/chromium/src/+/2311077
Reviewed-by: Ben Pastene <bpastene@chromium.org >
Commit-Queue: Ben Pastene <bpastene@chromium.org >
Cr-Commit-Position: refs/heads/master@{#790686}
2020-07-22 02:16:31 +00:00
b01fb51632
Add SODA API Key
...
This CL adds an API key for the Speech On-Device API (SODA). Usage of
the API key is outlined here: go/securing-soda-on-chrome.
Bug: 1107615https://chromium-review.googlesource.com/c/chromium/src/+/2309133
Reviewed-by: David Roger <droger@chromium.org >
Commit-Queue: Evan Liu <evliu@google.com >
Cr-Commit-Position: refs/heads/master@{#790550}
2020-07-21 21:12:09 +00:00
9ac2a9c49b
[gaia] Read OAuth2 client secret and ID from gaia config
...
This CL adds an option of overriding OAauth2 client secret and ID via
gaia config that was introduced in https://crrev.com/c/2166197 .
Gaia config makes switching between different Gaia environments easier.
Changing OAuth2 client secret and ID should be a part of this.
OAuth2 client parameters are set in google_api_keys.cc. In order to
access the gaia config from that file, gaia config has been moved into
a separate singleton class GaiaConfig. This class is used by both
google_api_keys.cc and gaia_urls.cc.
Skipping presubmit because google_api_keys_unittest.cc includes
non-header files. This triggers a presubmit error.
NOPRESUBMIT=true
Bug: 1072731
Change-Id: Iaf7e1342d1d4c31f627ff62fe3422059d9593642
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245486
Reviewed-by: Mihai Sardarescu <msarda@chromium.org >
Commit-Queue: Alex Ilin <alexilin@chromium.org >
Cr-Commit-Position: refs/heads/master@{#785368}
2020-07-06 14:28:55 +00:00
6d02188059
Reland "Ice Server API integration"
...
This is a reland of b23ba4d3fbhttps://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/2450652 )
TBR=msramek@chromium.org
Original change's description:
> Ice Server API integration
>
> Integrates network traversal API to fetch stun and turn servers for
> webrtc p2p connection. Handles API failure by returning a list of
> public Google stun servers as a fallback.
>
> Bug: 1031156
> Change-Id: I60b5d6ccdb749ce9375bcb3333dc2cbdab62aa18
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994295
> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org >
> Reviewed-by: Martin Šrámek <msramek@chromium.org >
> Reviewed-by: David Roger <droger@chromium.org >
> Reviewed-by: Richard Knoll <knollr@chromium.org >
> Reviewed-by: Alex Gough <ajgo@chromium.org >
> Cr-Commit-Position: refs/heads/master@{#733941}
Bug: 1031156
Change-Id: Ib1f409842a3277b5e1f47d6511ede46361aa5fc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013130
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org >
Reviewed-by: Richard Knoll <knollr@chromium.org >
Reviewed-by: David Roger <droger@chromium.org >
Cr-Commit-Position: refs/heads/master@{#734399}
2020-01-23 10:32:48 +00:00
896c950a7f
Revert "Ice Server API integration"
...
This reverts commit b23ba4d3fbhttps://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/2057
Original change's description:
> Ice Server API integration
>
> Integrates network traversal API to fetch stun and turn servers for
> webrtc p2p connection. Handles API failure by returning a list of
> public Google stun servers as a fallback.
>
> Bug: 1031156
> Change-Id: I60b5d6ccdb749ce9375bcb3333dc2cbdab62aa18
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994295
> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org >
> Reviewed-by: Martin Šrámek <msramek@chromium.org >
> Reviewed-by: David Roger <droger@chromium.org >
> Reviewed-by: Richard Knoll <knollr@chromium.org >
> Reviewed-by: Alex Gough <ajgo@chromium.org >
> Cr-Commit-Position: refs/heads/master@{#733941}
TBR=droger@chromium.org ,msramek@chromium.org ,knollr@chromium.org ,himanshujaju@chromium.org ,ajgo@chromium.org
Change-Id: I62270288afa5716c4dfb5fa6c35df2cfe0a82d79
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1031156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013288
Reviewed-by: Olga Sharonova <olka@chromium.org >
Commit-Queue: Olga Sharonova <olka@chromium.org >
Cr-Commit-Position: refs/heads/master@{#733995}
2020-01-22 14:40:22 +00:00
b23ba4d3fb
Ice Server API integration
...
Integrates network traversal API to fetch stun and turn servers for
webrtc p2p connection. Handles API failure by returning a list of
public Google stun servers as a fallback.
Bug: 1031156
Change-Id: I60b5d6ccdb749ce9375bcb3333dc2cbdab62aa18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994295
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org >
Reviewed-by: Martin Šrámek <msramek@chromium.org >
Reviewed-by: David Roger <droger@chromium.org >
Reviewed-by: Richard Knoll <knollr@chromium.org >
Reviewed-by: Alex Gough <ajgo@chromium.org >
Cr-Commit-Position: refs/heads/master@{#733941}
2020-01-22 11:30:15 +00:00
701d209318
Update to use the new remoting API keys
...
Previously Chrome Remote Desktop uses GOOGLE_API_KEY_REMOTING_FTL and
GOOGLE_API_KEY_REMOTING_FTL_MOBILE. This internal CL defines a
GOOGLE_API_KEY_REMOTING macro for each of the platform:
https://chrome-internal-review.googlesource.com/c/chrome/google_apis/internal/+/1283134
This CL updates google_apis and existing code to use the new
GOOGLE_API_KEY_REMOTING. I'll remove
GOOGLE_API_KEY_REMOTING_FTL(_MOBILE)? once this CL is checked in.
Bug: 961541
Change-Id: I03073acb23950fe0d361081b1bbf2c2fdfe750f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605159
Reviewed-by: Roger Tawa <rogerta@chromium.org >
Reviewed-by: Joe Downing <joedow@chromium.org >
Commit-Queue: Yuwei Huang <yuweih@chromium.org >
Cr-Commit-Position: refs/heads/master@{#658779}
2019-05-10 22:19:02 +00:00
e287631ac6
[remoting] Integrate with RemotingFtlMobileAPIKey
...
This CL implements GetRemotingFtlMobileAPIKey on google_apis and hooks
it up with FtlGrpcContext.
Bug: 954594
Change-Id: I8fb55de710f5ba5b0ee83127eada4c2b806ad8e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583001
Reviewed-by: Joe Downing <joedow@chromium.org >
Reviewed-by: Roger Tawa <rogerta@chromium.org >
Commit-Queue: Yuwei Huang <yuweih@chromium.org >
Cr-Commit-Position: refs/heads/master@{#655360}
2019-04-30 21:21:58 +00:00
bc473b45c3
Reland "Generate and use the real key to sign UMA/UKM uploads."
...
This is a reland of 867eeca264https://chromium-review.googlesource.com/c/1461089
> Commit-Queue: Jesse Doherty <jwd@chromium.org >
> Reviewed-by: Roger Tawa <rogerta@chromium.org >
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org >
> Cr-Commit-Position: refs/heads/master@{#630939}
Bug: 906202
Change-Id: Ib9e4ff6e3c289db965b863093b7a2a38f8eb20b2
Reviewed-on: https://chromium-review.googlesource.com/c/1468141
Commit-Queue: Jesse Doherty <jwd@chromium.org >
Reviewed-by: Robert Kaplow <rkaplow@chromium.org >
Reviewed-by: Roger Tawa <rogerta@chromium.org >
Cr-Commit-Position: refs/heads/master@{#632224}
2019-02-14 16:05:34 +00:00
48b145e704
Reland "Add remoting FTL API key"
...
This is a reland of c0cf050da7https://chrome-internal-review.googlesource.com/c/chrome/google_apis/internal/+/831973
>
> Bug: 927962
> Change-Id: Iecfa48aebe1078a4a0c747f42711000d9155fc3f
> Reviewed-on: https://chromium-review.googlesource.com/c/1450409
> Reviewed-by: Joe Downing <joedow@chromium.org >
> Reviewed-by: Roger Tawa <rogerta@chromium.org >
> Auto-Submit: Yuwei Huang <yuweih@chromium.org >
> Commit-Queue: Roger Tawa <rogerta@chromium.org >
> Cr-Commit-Position: refs/heads/master@{#630352}
Bug: 927962
Change-Id: I04c995d4348ef42de8a72c8c4abd5cff60cda1cd
Reviewed-on: https://chromium-review.googlesource.com/c/1461551
Reviewed-by: Roger Tawa <rogerta@chromium.org >
Commit-Queue: Yuwei Huang <yuweih@chromium.org >
Cr-Commit-Position: refs/heads/master@{#631828}
2019-02-13 19:07:26 +00:00
fb3e31c8d1
Revert "Generate and use the real key to sign UMA/UKM uploads."
...
This reverts commit 867eeca264https://crbug.com/930891
Original change's description:
> Generate and use the real key to sign UMA/UKM uploads.
>
> BUG=906202
>
> Change-Id: I10d2de8a1f30c0a56cc95f69aa6c252f171dca73
> Reviewed-on: https://chromium-review.googlesource.com/c/1461089
> Commit-Queue: Jesse Doherty <jwd@chromium.org >
> Reviewed-by: Roger Tawa <rogerta@chromium.org >
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org >
> Cr-Commit-Position: refs/heads/master@{#630939}
TBR=rogerta@chromium.org ,jwd@chromium.org ,rkaplow@chromium.org
Change-Id: If85da5416f52f414942ca8d75e5f5b4611a86842
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 906202
Reviewed-on: https://chromium-review.googlesource.com/c/1465066
Reviewed-by: Brian Sheedy <bsheedy@chromium.org >
Commit-Queue: Brian Sheedy <bsheedy@chromium.org >
Cr-Commit-Position: refs/heads/master@{#630956}
2019-02-11 22:20:44 +00:00
867eeca264
Generate and use the real key to sign UMA/UKM uploads.
...
BUG=906202
Change-Id: I10d2de8a1f30c0a56cc95f69aa6c252f171dca73
Reviewed-on: https://chromium-review.googlesource.com/c/1461089
Commit-Queue: Jesse Doherty <jwd@chromium.org >
Reviewed-by: Roger Tawa <rogerta@chromium.org >
Reviewed-by: Robert Kaplow <rkaplow@chromium.org >
Cr-Commit-Position: refs/heads/master@{#630939}
2019-02-11 21:34:44 +00:00
