Now that minify_js exists to minify JS files in build_webui which
are not bundled, it makes sense to do this by default when
optimize_webui=true. This also modifies the minify_js.py script
to include the --module flag in Terser, to accommodate ChromeOS.
This change reduces resources.pak by
- 108kb on Linux (8.42mb -> 8.3mb)
- 128kb on CrOS (20.9mb -> 20.77mb)
Bug: 1431253
Change-Id: I4d5b12c3a1966bab255fb874d8dd83036b7adbd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4436531
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Cole Horvitz <colehorvitz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1132226}
crrev.com/c/4405148 added a new optional parameter to the
--force-renderer-accessibility flag that forces an AXMode bundle to be
used during execution, with a default of kAXModeComplete. It is possible
that some tests would want to add or remove flags during execution to
change the mode from kAXModeComplete, so we should allow the mode to
change if no optional parameter is passed to this flag and only
force the mode if the optional parameter has been populated.
Cq-Include-Trybots: luci.chromium.try:linux-chromeos-rel,linux-blink-web-tests-force-accessibility-rel
AX-Relnotes: N/A
Bug: 1434358
Change-Id: I5f95c0cecb1a8688407d1822852ef50a4a9ed430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4440258
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Amanda Lin Dietz <aldietz@google.com>
Cr-Commit-Position: refs/heads/main@{#1132154}
This CL adds an optional parameter to the
--force-rendererer-accessibility command line switch to set the AXMode
to one of the following predefined bundles:
1) Basic
2) Form Controls
3) Complete
If the optional parameter is missing or invalid, then the AXMode
bundle will default to Complete, which runs the full accessibility
engine in Chrome.
This switch will remain backwards compatible as the parameter is
optional. This switch may be updated in the future with additional
predefined bundles.
This switch should aid in testing the AXMode feature.
AX-Relnotes: N/A
Bug: 1411856
Change-Id: I44d71292b4d5d171df3cf93d7486c8d06590a212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4405148
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Amanda Lin Dietz <aldietz@google.com>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1131379}
Previously, build_webui only minified and bundled JS code through
optimize_webui. However, files which were not bundled did not get
minified. This adds the minify_js rule to build_webui so code which
is not bundled is also minified when optimize=true.
This also updates the WebUI build pipeline doc image.
This change reduces resources.pak from 9.0mb to 8.9mb. More files
will be minified in follow-up CLs to further reduce the size of
resources.pak.
Bug: 1431253
Change-Id: Ia7bafc9e69199a1899864c729bde4ff57bae19aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4412620
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Cole Horvitz <colehorvitz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1130594}
This CL creates a build rule and Python script which minifies JS code.
Previously, we only had optimize_webui which bundles and minifies code,
but this rule allows for the minifying of code which does not get
bundled.
Bug: 1431253
Change-Id: I1cffd93ebd377830193e5d03c1f686cfcf5f5fb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4411870
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Cole Horvitz <colehorvitz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1130570}
This mechanism will be used to share files between CrOS and Browser
Settings, in an effort to properly decouple these UIs code.
In this CL moving only a single file to the sharing mechanism as an
example. Remaining shared files will be moved in follow-ups.
Bug: 1431477
Change-Id: Icfbaf7fe23aa474b9ccca66c14f2e5fa693358f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4408104
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1130155}
In many cases, <objc/objc.h> is included in a header file to allow the
use of Objective-C types despite that header needing to be able to be
included in a pure C++ file.
That's not good, and we're looking to ban <objc/objc.h> includes, so
rewrite those files to use the pimpl pattern instead.
Bug: 1429730
Change-Id: Iaa076cdd5bf60882855b8b5806ae13d99ccc0cc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4416244
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1129571}
This CL refactors the two modes introduced in the ComputeAXMode feature,
Basic and Complete, and the mode introduced in the
AccessibilityFormControls feature, FormControls, under one feature flag.
Tests have been updated and added as well.
AX-Relnotes: N/A
Bug: 1411856
Change-Id: Ie3e0e06514c796ab1d64e28c3e87bc2a5c155c8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4401113
Reviewed-by: Evan Liu <evliu@google.com>
Commit-Queue: Amanda Lin Dietz <aldietz@google.com>
Cr-Commit-Position: refs/heads/main@{#1129495}
This is a reland of commit 126fae8049
Locally tested failing robolectric tests, they now pass.
Original change's description:
> Removing concept of MainDex/non-MainDex native
>
> With automatic registration being the default now, there is no need to
> differentiate MainDex/non-MainDex as automatic registration is lazy
> anyways.
>
> Low-Coverage-Reason: Just a deletion of code
> Bug: 1371542
> Change-Id: I85cc1f72e71eb4b2ed36a06bd8b0a25a484ce3fe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4385433
> Owners-Override: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Sam Maier <smaier@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1124766}
Bug: 1371542
Change-Id: Ic54ae392db54e0da6b6dc0cf48867a1b96dc87c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4389822
Auto-Submit: Sam Maier <smaier@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1126519}
The `HTML Preview` extension pointed to in vscode.md has been
deprecated and is no longer maintained, this CL updates the
`HTML Preview` extension to another available extension.
Bug: None
Change-Id: Id7c5c2cb1535f300f0e1b7ad7ab1945627db2fe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4392224
Auto-Submit: Ho Cheung <uioptt24@gmail.com>
Reviewed-by: Ming-Ying Chung <mych@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1126374}
Various places in our documentation currently reference the lack of
site isolation in <webview> tags. Update all such places now that
site isolation for <webview> is available.
Bug: 1267977
Change-Id: I50094307c63fc621b96e5833274035f2a9694739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4385895
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1126059}
With automatic registration being the default now, there is no need to
differentiate MainDex/non-MainDex as automatic registration is lazy
anyways.
Low-Coverage-Reason: Just a deletion of code
Bug: 1371542
Change-Id: I85cc1f72e71eb4b2ed36a06bd8b0a25a484ce3fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4385433
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1124766}
The warning about clobbering all-pass statuses (crrev.com/c/4334979) is
not useful when the affected builder/test passes expectedly (so it
generates no `actual_text` to download). In this change, `rebaseline-cl`
instead automatically generates a dummy baseline that `run_web_tests.py`
and `optimize-baselines` recognize as all-pass. This preserves subtest
-level coverage for failing platforms.
These dummy baselines should rarely be necessary, so this change's
impact on checkout size should be negligible. The dummy baselines are
self-documenting and link to the relevant web test documentation, which
this change updates.
Bug: 1324638
Test: To test the `run_web_tests.py` side:
Test: For `external/wpt/badging/badge-success.https.html`, create an
Test: abbreviated all-pass baseline for linux (host platform) and a
Test: failing baseline for win.
Test: `./run_web_tests.py -t Default external/wpt/badging` succeeds
Change-Id: I4a94fb4fda5c566ab0b5838c8ac913c6ee6cccce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4385729
Reviewed-by: Weizhong Xia <weizhong@google.com>
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1124532}
Changes:
- this setup has been tested now in macOS.
- the word to describe the OS has been updated: "Mac" -> "macOS"
- some shortcuts specific to macOS throughout the text have been updated
- minor markdown formatting.
Bug: None
Change-Id: I2e6448ec01bfcb9157d325010d98df20531deed4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4380224
Auto-Submit: Tiago Vignatti <tvignatti@igalia.com>
Commit-Queue: Tiago Vignatti <tvignatti@igalia.com>
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1124154}
There is some out of date information around raster modes, namely there
is no more OOP vs GPU raster distinction. Update documentation to be
more accurate.
Bug: none
Change-Id: I56fdadd435dd7c391a58bb3bb7f56231c93a7dd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4354893
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1122502}
