0
Commit Graph

1909 Commits

Author SHA1 Message Date
Austin Sullivan
00d34c8c94 Revert "Add memory alignment parameter to gpu::Buffer"
This reverts commit 2b034ff051.

Reason for revert: broke MSAN bots. See https://crbug.com/1434472

Original change's description:
> Add memory alignment parameter to gpu::Buffer
>
> Bug: 1426766
> Change-Id: I0902bf42975ca0a1bb967208fa51e42f4a74392e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4377798
> Commit-Queue: Sergey Pashaev <bioh@yandex-team.ru>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1131990}

Bug: 1426766
Change-Id: I80d49b1f5712cd50e63f041feac79e9415349aad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4443370
Reviewed-by: Meredith Lane <meredithl@chromium.org>
Auto-Submit: Austin Sullivan <asully@chromium.org>
Owners-Override: Austin Sullivan <asully@chromium.org>
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1132321}
2023-04-19 04:40:11 +00:00
Sergey Pashaev
2b034ff051 Add memory alignment parameter to gpu::Buffer
Bug: 1426766
Change-Id: I0902bf42975ca0a1bb967208fa51e42f4a74392e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4377798
Commit-Queue: Sergey Pashaev <bioh@yandex-team.ru>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1131990}
2023-04-18 16:53:37 +00:00
Tom Sepez
55354070d4 Convert PendingSyncMessage::deserializer to std::unique_ptr<>
Follow-on from https://crrev.com/c/4397638, clarifies ownership
of the deserializer.

Change-Id: I2af0a2c42bbc3fe3091254a3d3a72d81756350f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4400765
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1127251}
2023-04-06 16:58:46 +00:00
Avi Drissman
821ca309ed Update header includes for /base/functional in /p*
bind.h, callback.h, callback_forward.h, and callback_helpers.h
moved into /base/functional/. Update the include paths to
directly include them in their new location.

Bug: 1364441
Change-Id: I36784c7cc322001d0b0ec2590c3847f4298033ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4157596
Owners-Override: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1091526}
2023-01-11 22:42:15 +00:00
Sean Maher
e672a665ff task posting v3: remove includes of runner handles and IWYU task runners
Turns out there's a lot of includes, so these will have to be removed
before deleting the implementation of the task runner handles.

To allow the deletion of the task runner handle headers, add
the sequenced/thread task runner handles where they are used in
the codebase with scripts.

This was done with an automated change, with a few touchups afterwards.
The code for the mass-refactor changes are here:
python:
https://paste.googleplex.com/5534570878337024
shell:
https://paste.googleplex.com/6466750748033024

In terms of touchups:
- add sequenced/thread task runner handles to
  the third_party/blink/public/DEPS, because multiple files were using
  it transitively anyways.
- rewrite certain parts of the codebase which used
  ThreadTaskRunnerHandles instead of CurrentDefaultHandles.
- fix a compile issue with forward-declaration in
  extensions/browser/extension_file_task_runner.h.

AX-Relnotes: n/a.
Bug: 1026641
Change-Id: I737ef32aee4e77c21eaa3a2bdc403a28322cf1b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4133323
Owners-Override: Gabriel Charette <gab@chromium.org>
Commit-Queue: Sean Maher <spvw@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1090532}
2023-01-09 21:42:28 +00:00
Vasiliy Telezhnikov
ca6b035ed7 Plumb PPAPISharedImagesSwapChainAllowed policy to nacl
This CL changes flow how all relevant parts decide to use new feature:
Before this CL every part would be querying
kDisablePPAPISharedImagesSwapChain command line flag and
PPAPISharedImagesSwapChain feature flag independently.

It's very complicated and error prone to apply this with enterprise
policy which is available only in browser process and needs to be
communicated via command line flags.

To simplify this now we query flag/feature only in the renderer
process. The value is communicated to nacl process during
initialization of Graphics3D via gpu::Capabilities. GPU process is now
ready to handle both flows.

Bug: 1342033
Change-Id: I5f0fd2ef5f63d4429c9ca273c8777d63ee462597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4108070
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1084280}
2022-12-16 13:42:04 +00:00
Vasiliy Telezhnikov
2e6fab1284 Use shared images for NaCl SwapChain
This CL implements SetDefaultFramebufferSharedImage IPC on the command
buffer that allows callers to set SharedImage and associated params
like need of depth/stencil buffer and samples count to the default
framebuffer (fbo 0).

NaCL host side maintains pool of SharedImages that it uses with new
IPC to draw to the framebuffer.

Both sides are guarded by feature flag (kPPAPISharedImagesSwapChain) and
command line flag  (kDisablePPAPISharedImagesSwapChain) that can veto
the feature flag. Extra command line is needed for enterprise policy.

Bug: 1342033
Change-Id: Iccf800d1bbe8dcd1f168272651ae32c27833c2ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4006326
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1078120}
2022-12-01 17:08:04 +00:00
Sean Maher
a539a158cb Task posting v3: refactor base::PostTaskAndReplyWithResult
Change all instances of base::PostTaskAndReplyWithResult(task_runner
to task_runner->PostTaskAndReplyWithResult(.

This also removes includes of base/task/task_runner_util.h, but only
in the files with 'base::PostTaskAndReplyWithResult' which don't refer
to PostTaskAndReplyWithResult in other places.

Code was refactored with the following scripts:
python script:
https://paste.googleplex.com/5117849478627328
shell script:
https://paste.googleplex.com/4961540519231488

Bug: 1026641
Change-Id: Ifb34b3b9078440dda5902b0d694cb8d3f315dfe7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3892903
Commit-Queue: Sean Maher <spvw@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Owners-Override: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1076288}
2022-11-28 18:13:41 +00:00
Sean Maher
5b9af51fdd task posting v3: moving away from ThreadTaskRunnerHandle
To continue the migration away from TaskRunnerHandles, the codebase
was refactored using the following scripts:
shell script:
https://paste.googleplex.com/4673967729147904
python:
https://paste.googleplex.com/5824001174667264

This will do a few sed-like modifications, changing calls to methods of
ThreadTaskRunnerHandle to calls to methods of
SingleThreadTaskRunner::CurrentDefaultHandle, and swapping includes.

Bug: 1026641
AX-Relnotes: n/a.
Change-Id: Ia33b6dfebb15937481c619f5c838720ce7bb2676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4031817
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Owners-Override: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1074085}
2022-11-21 15:32:47 +00:00
Lei Zhang
a3ba1210f7 Swap ref_counted.h for scoped_refptr.h when appropriate in //ppapi.
At some point, scoped_refptr got split off into its own header. Use it
in //ppapi headers when appropriate.

Bug: 1381627
Change-Id: Ie5b6b3cb2800e73b7bb801bc1e8218aa6848cb40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4011499
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1071907}
2022-11-15 23:41:31 +00:00
Lei Zhang
cc67230216 Remove unnecessary base/memory/ref_counted.h includes from headers.
Header files that do not contain "RefCounted" and do not contain
scoped_refptr do not need to include base/memory/ref_counted.h. Remove
it and do IWYU to fix the build.

Bug: 242216
Change-Id: Ie70e43b0c926b8ef610419c99f43eea991ac8d81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4005763
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Owners-Override: Kyle Charbonneau <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1067592}
2022-11-04 18:28:16 +00:00
Avi Drissman
db497b3200 Update copyright headers in pdf/, ppapi/, printing/
The methodology used to generate this CL is documented in
https://crbug.com/1098010#c95.

No-Try: true
Bug: 1098010
Change-Id: I6ae92e5d7ccbf73b176588124b2f8b4067f805b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900575
Reviewed-by: Mark Mentovai <mark@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1047628}
2022-09-15 19:47:28 +00:00
Christian Flach
a79ba474e1 Use SequenceChecker macros: /ppapi/proxy
Using the macros instead of directly using `SequenceChecker` results in
smaller binaries and decreased memory usage. Most code already uses the
macros. This CL is part of a series of CLs that fixes remaining usages.

This CL was uploaded by git cl split.

R=dschuff@chromium.org

Bug: none
Change-Id: I2b77c5d704b39d087529c3e3b002188c1915baf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3883904
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Auto-Submit: Christian Flach <cmfcmf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1045215}
2022-09-09 17:57:32 +00:00
Fabian Sommer
295fb5d0b8 NaCl on ARM64: Remove dependencies on //skia
NaCl cannot depend on //skia when building for ARM64, as in that build
some libraries are not present in the 32-bit version that NaCl needs.

Therefore, build some (parts of) files only in builds that are not for
nacl_helper.

Introduce a new buildflag IS_MINIMAL_TOOLCHAIN. This is to limit
dependencies in .h/.cc files if we build nacl_helper for ARM64.
Use nogncheck for such conditional includes as gn does not run the
preprocessor.

Test: Build nacl_helper for Linux ARM64
Bug: 1339021
Change-Id: Id95147bc134e34fbae91af3d540ed30a4e96b512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829145
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Fabian Sommer <fabiansommer@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
Reviewed-by: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1037644}
2022-08-22 10:25:04 +00:00
Lei Zhang
2b75f48f84 Fix typos for the word "propagated".
Fix this typo across the code base to quell Tricium SpellChecker
warnings.

Change-Id: I8d1faee3117d121a0b16e857843fb1cbe8252858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810768
Owners-Override: Erik Staab <estaab@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1032172}
2022-08-05 23:44:08 +00:00
K. Moon
f17e216ac7 Switch //ppapi to use enable_ppapi
Switches //ppapi to the PPAPI-specific enable_ppapi arg, rather than the
more general enable_plugins arg.

Bug: 1306610
Change-Id: Id3b1723d41f9c381f9a567325d7ad830d60c4599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3750107
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Auto-Submit: K. Moon <kmoon@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1025398}
2022-07-18 20:59:42 +00:00
Peter Kasting
28b51cf40e Reland: Prevent unsafe narrowing: base/
This relands
https://chromium-review.googlesource.com/c/chromium/src/+/3717404 .

Bug: 1292951
Change-Id: I79a1d884d297903886cf3d8819f8962ba250ccb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3727447
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Owners-Override: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1018684}
2022-06-28 15:02:43 +00:00
Jeroen Dhollander
d13a4eaa16 Revert "Prevent unsafe narrowing: base/"
This reverts commit 5d4fcae17b.

Reason for revert: Breaks MSAN build. See crbug/1339749

Original change's description:
> Prevent unsafe narrowing: base/
>
> Bug: 1292951
> Change-Id: I17b223cfd5bd63752a20b36ffb446d4dc63a2733
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3717404
> Reviewed-by: danakj <danakj@chromium.org>
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Auto-Submit: Peter Kasting <pkasting@chromium.org>
> Owners-Override: danakj <danakj@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1017830}

Bug: 1292951
Bug: 1339749
Change-Id: I210221bb692ae43bc9d2aaa31ff8117bea8405d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3726010
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/main@{#1018171}
2022-06-27 11:03:47 +00:00
Peter Kasting
5d4fcae17b Prevent unsafe narrowing: base/
Bug: 1292951
Change-Id: I17b223cfd5bd63752a20b36ffb446d4dc63a2733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3717404
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Owners-Override: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1017830}
2022-06-24 21:14:38 +00:00
Kenneth Russell
042ad65fa4 Guard against too-large arrays passed to uniform*v.
Catch situations where computing the byte size of the incoming array
would overflow.

Beyond this, detect failures to allocate space in CommandBufferHelper.
In this situation, persistently lose the context client-side. Remove
DCHECKs preventing these guards from being reached.

Add new feature to disable ArrayBuffer size restrictions for testing.
Use it in the new test; it is required for it to pass.

Bug: 1316368
Bug: 1201109
Change-Id: Ic345aed296e2d9a3f44e33c4c207e12b64c4f312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3688833
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Gregg Tavares <gman@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/main@{#1014267}
2022-06-15 02:45:05 +00:00
kylechar
009417ac0a Remove GLRenderer related GL extensions
Delete CHROMIUM GL extensions that were added for swap, presentation and
overlay control from GLRenderer. These extensions are no longer needed
now that GLRenderer has been deleted.

Bug: 1247756
Change-Id: I9df77e118cd4798713dc2684566f0f5eba06006b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3669573
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1009927}
2022-06-02 03:28:25 +00:00
kylechar
56c239dea5 Delete CHROMIUM_image extension
CreateImageCHROMIUM() is no longer used. Delete the extension and all
GLES2Interface functions related to it. Also delete plumbing through
various layers of GPU and IPC code related to it.

Remove references to the extension from other extensions as well.

Bug: 1216120
Change-Id: Ia55ad5d2f85f27c9d337ac928daf5fc614dc9b75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3582497
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#999958}
2022-05-05 17:35:49 +00:00
David Dorwin
fb712813be [ppapi] Assert plugins are enabled in PPAPI GN files.
Only //ppapi/buildflags should ever be reached when !enable_plugins.

This required moving some deps to `if (enable_plugins)` blocks.

Bug: 1306610, 1311822
Test: gn check out/fuchsia && gn check out/linux
Change-Id: I51fe19c4d1582fa4e572424e33eff1edcf14b2b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561898
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Auto-Submit: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Cr-Commit-Position: refs/heads/main@{#995895}
2022-04-26 01:36:51 +00:00
Mark Seaborn
0040a61bca NaCl on ARM64: Fix crash caused by the IRT being built with the wrong flags
In some cases, the IRT was getting built with is_nacl_irt set to
false.  In those cases, the compiler flags set by
build/config/nacl/BUILD.gn (by :compiler_codegen and :irt_optimize)
were not being applied.

This fixes two cases where the IRT architecture is different from the
chrome executable's architecture:

1) ARM32 NaCl in ARM64 Chromium (on Linux or Chrome OS).  The problem
causes "-fasynchronous-unwind-tables" to be omitted, which creates an
IRT that leads to a crash when running the test
PPAPINaClNewlibTest.PostMessage.  The output I got from the test was:

...
[1,4142801984:00:05:39.834116] NaClSysThreadCreate: Bad function pointer
[1,4142801984:00:05:39.834221] NaClSysThreadCreate: Bad function pointer
[1,4142801984:00:05:39.834255] NaClSysThreadCreate: Bad function pointer
[1,4142801984:00:05:39.834285] NaClSysThreadCreate: Bad function pointer
** Signal 11 from untrusted code: pc=1d3474
[1903:1903:0405/000539.939548:ERROR:nacl_process_host.cc(265)] NaCl process exited with status 62720 (0xf500)

I am not sure why that happens, but it looks like an ARM-specific
problem, maybe a miscompile.

2) x86-64 NaCl in Windows x86-32 Chromium.  There don't seem to be any
correctness problems in this case, but having is_nacl_irt==false
causes the IRT to be built with "-O2" instead of "-Os", which makes it
larger than necessary.  The lack of "-fasynchronous-unwind-tables"
shouldn't make a difference because "-fasynchronous-unwind-tables" is
the default on x86-64.

Fix by using current_cpu instead of target_cpu.

Remove an unnecessary assignment to is_nacl_cpu.

Add an assertion as a consistency check to catch the problem of
is_nacl_irt being false.

Bug: 1299021
Test: I ran the test above on ARM64 Ubuntu on a Raspberry Pi
Change-Id: I4f4966bd8fa5359527ab8b91152048e584ed0340
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3575687
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#990482}
2022-04-08 17:42:50 +00:00
Gabriel Charette
494bf1e595 [base] Undo erroneous IWYU of time.h in presence of base::Thread
@QA: This CL is a no-op.

Caused by incorrectly covering base::Thread when using regex
"base::(Time|Thread)(Ticks|Delta)?\b"

This script removed base/time/time.h if:
 1) "base::Thread" is present
 2) There is no (Time|ThreadTicks|Days|Hours|Minutes|Seconds|
                 Milliseconds|Microseconds|Nanoseconds|Hertz)
    string in the file (no base:: prefix required to skip removal)

Bug: 1026641
Change-Id: I9df5e8beccc74054bf9bfff12320a1d4e0295b62
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3563202
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#988045}
2022-04-01 18:58:52 +00:00
Gabriel Charette
d87f10f467 [base] IWYU for base::Time
This CL is a no-op.

Only fixing instances where base::Time (and Ticks/Delta) is used in
a statement (i.e. not as a parameter to avoid adding includes in mere
overrides). Skipping pointer and reference qualified instances.

i.e. matches this regex:
'(\n *[^/\n][^/\n][^/\n]*base::(Time|Thread)(Ticks|Delta)?\b[^*&][^)]*;)'

and skipping files that have any existing fwd-decl for any of the
variants.

This is a prereq to remove unused base/task/post_task.h includes in
https://chromium-review.googlesource.com/c/chromium/src/+/3555247

Bug: 1026641
Change-Id: I87b43a8dc92bdceb67f4bd59b327b54813aa72a6
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557354
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#987283}
2022-03-31 00:44:22 +00:00
David Sanders
527f0ce9f3 Add missing includes of thread_task_runner_handle.h
Bug: 1300573
Change-Id: I033c19a9daadfd9ea448bb53214621b3fff8513e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545009
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#984417}
2022-03-23 17:42:30 +00:00
David Sanders
de5fee5481 Add missing includes of //base/observer_list.h
Bug: 1290552
Change-Id: Iaee69fb002eaea3378c5082de8d847178766c412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3544209
Reviewed-by: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Commit-Queue: David Sanders <dsanders11@ucsbalum.com>
Cr-Commit-Position: refs/heads/main@{#984157}
2022-03-23 02:47:44 +00:00
David Sanders
dc8250f34f Add missing includes of //base/notreached.h (1/N)
Bug: 1300573
Change-Id: Ie949e207558e06bfae8ae18ec9cb078c315aa0de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3528273
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Commit-Queue: David Sanders <dsanders11@ucsbalum.com>
Cr-Commit-Position: refs/heads/main@{#981987}
2022-03-17 01:52:14 +00:00
Lei Zhang
e6a85213b6 Remove some leftover Flash/PDF PPAPI bits.
Remove some random bits that should have been deleted earlier.

Bug: 1064652,1302684
Change-Id: I1db2bc9beb3ab8b2056f91f3114dbfed9c9b7ffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3498736
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#979440}
2022-03-09 21:41:54 +00:00
Lei Zhang
7bb56c6ff3 Remove PPAPI Flash font interfaces.
These APIs were actually shared between the Flash and PDF plugins. With
both of them gone, there are no users left.

Bug: 1064652
Change-Id: I9fbf1cf4d7297e99affd5137fb079d7ddd9d0549
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3500228
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#979432}
2022-03-09 21:33:49 +00:00
Lei Zhang
0b69bab8ad Remove PPAPI PDF interfaces.
These private interfaces no longer have any users, now that the PDF
Viewer stopped using PPAPI. Prior CLs deleted most of the related code,
leaving only a minimal implementation. Delete that along with stragglers
that still reference the PDF headers.

Bug: 1302684
Change-Id: I9c2b5e81d8a919f32b069c68ae053d58a02e2710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3502892
Reviewed-by: K. Moon <kmoon@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#979393}
2022-03-09 20:20:40 +00:00
Lei Zhang
88b95f8c9c Remove NetworkServiceRestartBrowserTest.Plugin.
This test, along with the CORB test PPAPI plugin, were used to ensure
the PPAPI PDF plugin behaved correctly. Delete them now that the PPAPI
PDF plugin is gone.

Bug: 1302684
Change-Id: Ib9624774a7a4028b6f7c48dc85c2ea585971dd82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3506231
Reviewed-by: K. Moon <kmoon@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#979388}
2022-03-09 20:12:19 +00:00
Lei Zhang
91a602d8c3 Remove most browser-side plugin-side PPAPI PDF interfaces.
These private interfaces no longer have any users, now that the PDF
Viewer stopped using PPAPI. Delete the APIs, messages, and tests.

Keep a minimal interface to be removed in a follow-up.

Bug: 1302684
Change-Id: Ib6c72c1b9e5ece524189009fe38f454a0a3c5cab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3505370
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#979360}
2022-03-09 19:24:39 +00:00
Lei Zhang
c9d38cc601 Remove most plugin-side PPAPI PDF interfaces.
These private interfaces no longer have any users, now that the PDF
Viewer stopped using PPAPI. Delete the APIs, messages, and handlers.

Keep a minimal interface to be removed in a follow-up.

Bug: 1302684
Change-Id: Ia613d80d6480e3228dd0f3a816a6f4298fc2c829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3505845
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Lei Zhang <thestig@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#979229}
2022-03-09 14:38:03 +00:00
Lei Zhang
367a283ecc Remove a11y code specific to the PPAPI PDF Viewer.
Since the PPAPI PDF Viewer is gone, it is safe to delete its private
accessibility APIs and related code.

Bug: 1302684
Change-Id: I57931ac7c35ae58891c6a960101d12e35bc531b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3505357
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#978945}
2022-03-08 23:18:22 +00:00
Lei Zhang
6adf4dcd9c Remove PPBFlash_DrawGlyphs_Params.
Leftover Flash bits not used anywhere.

Bug: 1064652
Change-Id: Id43542dcf7683b781fd366c14026ada996dac223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3501241
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#977781}
2022-03-04 19:57:01 +00:00
Daniel Cheng
1c760cfbd3 Migrate remaining non-base uses of base::size() to std::size().
Bug: 1299695
Change-Id: Ib6a4e4ae1eb7cde74521404ff19b769e0dc4d81d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3503059
Reviewed-by: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#977574}
2022-03-04 09:50:59 +00:00
Lei Zhang
443f3001f3 Remove PPAPI Find interfaces.
These private interfaces no longer have any users, now that the PDF
Viewer stopped using PPAPI.

Bug: 1302684
Change-Id: Ifde4b19b5ae73b53c089ba5f2afe113a1ece1d27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3500908
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#977166}
2022-03-03 17:49:23 +00:00
Ivan Murashov
f29a09bf2f Remove unused method from X509CertificatePrivate in PPAPI
After CL https://crrev.com/c/2808690 the method
X509CertificatePrivate::SendToBrowser() no more needed.
Hence unused code is removed.

Bug: 904556
Change-Id: Ib8de30655a162fee6c9cafa1e959dc98d75b1edd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3356199
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Ivan Murashov <ivan.murashov@lge.com>
Cr-Commit-Position: refs/heads/main@{#964175}
2022-01-27 19:06:22 +00:00
Anton Bikineev
d04a155fbf LSC: Apply clang-tidy's modernize-use-bool-literals
The check finds implicit conversions of integer literals to bools:
 bool b1 = 1;
 bool b2 = static_cast<bool>(1);
and transforms them to:
 bool b1 = true;
 bool b2 = true;

Bug: 1290142
Change-Id: I5417f84587e8e06f6ee58efe9269899199310d78
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3407324
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Auto-Submit: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/main@{#963140}
2022-01-25 19:53:44 +00:00
Lei Zhang
5226db7051 Clean up includes in ipc/ipc_message_utils.h.
Remove includes that are not directly needed, and then do IWYU to fix
the build.

Change-Id: Ia0f3f7abdc444faf62cd7f59197a3d12b858387c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3378531
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Auto-Submit: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#962837}
2022-01-25 03:38:55 +00:00
Lei Zhang
36271899fd Remove Flash Fullscreen PPAPI code.
Flash is dead, so this is also dead code.

Bug: 1064652
Change-Id: Icef23a616b831118f3d57ee5ef346f418dd5a13e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3405425
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#962737}
2022-01-24 23:29:47 +00:00
Avi Drissman
dfacb0298e Use [[maybe_unused]] in the old PPAPI IPC macros
Bug: 1286390
Change-Id: Ifa10f00b9ffd9161da65258c784df8bde12b3558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3393065
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#960663}
2022-01-18 22:56:51 +00:00
Xiaohan Wang
0fd6e56a0a ppapi: Use BUILDFLAG for OS checking
Use BUILDFLAG(IS_XXX) instead of defined(OS_XXX).

Generated by `os_buildflag_migration.py` (https://crrev.com/c/3311983).

R=thakis@chromium.org

Bug: 1234043
Test: No functionality change
Change-Id: I0086c9f839def03021be846dd96dcfbf6d74f11a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3373982
Reviewed-by: Nico Weber <thakis@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#958793}
2022-01-13 20:26:11 +00:00
David Sanders
4734e4a1a9 Fix typo in comment in ppapi/proxy/plugin_var_tracker.cc
Change-Id: I1b09b9690637cfe88d950efba9b44624bff77ed9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315238
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#948411}
2021-12-06 00:12:14 +00:00
Nico Weber
7c271e9099 Remove some nonsfi code
We disabled nonsfi in https://chromium-review.googlesource.com/c/chromium/src/+/3298455
so this should have no behavior change.

Bug: 1273132
Change-Id: Icf254b146cd43d53fc17f8bc76d2ffa941da76f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299611
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Sam Clegg <sbc@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Cr-Commit-Position: refs/heads/main@{#946319}
2021-11-30 04:21:09 +00:00
Peter Boström
5666ff4f50 Remove most remaining unused "base/macros.h"
Removes `#include "base/macros.h"` from remaining .cc, .h and .mm files
that do not contain `ignore_result(` and do not trigger pre-commit or
pre-upload errors.

Bug: 1010217
No-Try: true
Change-Id: I4cc5207b3deafa7901764d2e633bbb1ad43cfb73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3276692
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#941054}
2021-11-12 03:40:24 +00:00
Peter Boström
896f13791f Remove all DISALLOW_COPY_AND_ASSIGNs
This replaces all remaining DISALLOW_COPY_AND_ASSIGN() instances with
their expanded counterparts.

The macro definitions and IWYU are left as a separate change. The former
to prevent unintended large reverts and the latter is easier once all
DISALLOW_ macros are gone.

Bug: 1010217
Change-Id: I0e2fd43f4060628c09420709010aab2c84b87148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3259964
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#938612}
2021-11-05 01:12:30 +00:00
Peter Boström
511258be82 Reland "Remove DISALLOW_IMPLICIT_CONSTRUCTORS()"
This reverts commit 15aa98232c.

Reason for revert: Reland without macro removal.

Original change's description:
> Revert "Remove DISALLOW_IMPLICIT_CONSTRUCTORS()"
>
> This reverts commit 5625bdd791.
>
> Reason for revert: breaks compile on https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome and https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome
>
> Original change's description:
> > Remove DISALLOW_IMPLICIT_CONSTRUCTORS()
> >
> > This removes the macro definition and presubmit checks and all existing
> > instances are inlined.
> >
> > IWYU is left as a separate step until all DISALLOW_* macros are removed.
> >
> > Bug: 1010217
> > Change-Id: Ibc4d90d6a1f244a01e65cd3c5a9c50e5419ea5a1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3257088
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Owners-Override: Lei Zhang <thestig@chromium.org>
> > Commit-Queue: Peter Boström <pbos@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#937250}
>
> Bug: 1010217
> Change-Id: I6341be7521fde453b671d6b339eef796a49847ac
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256685
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Owners-Override: Henrik Boström <hbos@google.com>
> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#937292}

Bug: 1010217
Change-Id: Ia50761207d4921319b7e8513497ed62761e6df6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256952
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937662}
2021-11-03 01:18:46 +00:00