This also removes plugin data and settings persistence, which isn't
needed if the Flash plugin doesn't exist (it used to persist its own
data on command from the browser.)
Adds a TODO to figure out how we will remove plugin data now that
Flash is deprecated.
Bug: chromium:1064652,chromium:1135773,chromium:1135779
Change-Id: I2eb1e30856071190cba29cea98cdd86a37722f95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450057
Commit-Queue: Bill Budge <bbudge@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Anthony LaForge <laforge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816370}
With flash removal happening in M88, remove RenderWidgetFullscreenPepper
which was used to implement the Flash Fullscreen setting. Note this
is different that the PPAPI Fullscreen which uses the normal blink
fullscreen request via the WebContainer::RequestFullscreen call.
BUG=1134674
Change-Id: I166596f6f5a677cc1028aed02f74297e0c458696
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446593
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813822}
This removes jumbo.gni, the imports of jumbo.gni, and
any remaining stray references to it in the build files and docs.
Bug: 994387
Change-Id: Ic39b7c609e1bd922e05c7e1104f1e5532c188f5a
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337392
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#796080}
Now that the jumbo build is no longer supported (and hasn't been
for quite a while), there is no need to use the jumbo target types
like jumbo_source_set, jumbo_component, and jumbo_static_library.
This CL converts all such targets back to their non-jumbo equivalents.
The change was made via a simple search and replace.
Bug: 994387
Change-Id: I19b431c148d3b43fa19a72f00b28d84ff5a14e8b
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337280
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#795492}
The WebGPU API provides facilities to create mapped GPUBuffers
backed by shared memory. This makes it very easy for JavaScript to
make large transfer buffer allocations which fail allocation and
instantly lose the context.
This CL adds an option to CommandBuffer::CreateTransferBuffer and
MappedMemoryManager::Alloc to not lose the context on OOM but
instead fail gracefully.
Bug: dawn:450
Change-Id: I7311dd2ab685a150574056fbe9df5fa1724e4b7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310831
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791071}
If the file just needs the CHECK/CHECK_OP/NOTREACHED
macros, use the appropriate header for that instead.
Or if logging.h is not needed at all, remove it.
This is both a nice cleanup (logging.h is a big header,
and including it unnecessarily has compile-time costs),
and part of the final step towards making logging.h no
longer include check.h and the others.
Bug: 1031540
Change-Id: I36a2cdc31d2b641f3ba3d13cefcdaa9d942ed9ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254126
Commit-Queue: Bill Budge <bbudge@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780456}
Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).
This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.
Bug: 1031540
Change-Id: Icaa271ea7e32c0494a7b3f578696e397e7cd0a48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249675
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779331}
This change adds struct PP_PrivateAccessibilityButtonFieldInfo to
PP_PrivateAccessibilityFormFieldInfo to transfer accessibility related
PDF button data (radio button, checkbox and push button) from the plugin
process to the mimehandler process. Made the same changes to the C++
versions of these structs and added the appropriate conversion code.
Bug: 1030242
Change-Id: I33eaab3c6471e017799c54ad8d9c98c43e1baeca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217716
Commit-Queue: Mansi Awasthi <maawas@microsoft.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ankit Kumar 🌪️ <ankk@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#775964}
This change adds struct PP_PrivateAccessibilityChoiceFieldInfo to
PP_PrivateAccessibilityFormFieldInfo to transfer accessibility related
PDF choice field data from the plugin process to the mimehandler
process. Made the same changes to the C++ versions of these structs and
added the appropriate conversion code.
Bug: 1030242
Change-Id: I7aa6fd612de051d9e6b22e84e60c964d24685242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214734
Commit-Queue: Mansi Awasthi <maawas@microsoft.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ankit Kumar 🌪️ <ankk@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#774049}
This change adds struct PP_PrivateAccessibilityFormFieldInfo to
PP_PrivateAccessibilityPageObjects to transfer accessibility related PDF
form field data from the plugin process to the mimehandler process. Made
the same changes to the C++ versions of these structs and added the
appropriate conversion code.
This CL refactors existing PP_PrivateAccessibilityPageObjects to send
text field data as part of PP_PrivateAccessibilityFormFieldInfo struct.
Going forward, other form fields will also be added in
PP_PrivateAccessibilityFormFieldInfo.
This change is needed to avoid bloating of
PP_PrivateAccessibilityPageObjects structure with multiple objects.
Bug: 1030242
Change-Id: Ie55ee36645ff9df9bc57dfaa18fb4cc3f245d60b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215155
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ankit Kumar 🌪️ <ankk@microsoft.com>
Commit-Queue: Mansi Awasthi <maawas@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#772610}
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved
to the much smaller headers check.h, check_op.h, and notreached.h,
respectively.
This CL updates .cc files to use those headers instead when
possible, with the purpose of saving compile time.
(Split out from https://crrev.com/c/2164525 which also has
notes on how the change was generated.)
Bug: 1031540
Change-Id: I59620a4eb8a4c2096bcc75f546d03cd7f9455aa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165109
Commit-Queue: Bill Budge <bbudge@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762906}
Fix code that was implicitly depending on logging.h or its
dependencies.
For example, code that uses DISALLOW_COPY_AND_ASSIGN should
include base/macros.h, but it currently happens to work if
it pulls in logging.h directly or through some dependency.
This is part of refactoring the codebase to use
check.h/check_op.h for the CHECK and CHECK_op macro
instead of logging.h.
Bug: 1031540
Change-Id: I3e650161f9647c8a3ac1d8ad03059fecc6cc8f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157125
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760532}
This change applies the BindOnceRewriter in //ppapi.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.
Steps:
1. run_tool.py --tool base_bind_rewriters \
--tool-arg='--rewriter=bind_to_bind_once'
2. git cl format
This CL was uploaded by git cl split.
R=bbudge@chromium.org
Bug: 714018
Change-Id: If865855e4a21b08c359bc48f08ce3db258e41ffa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132411
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760440}
This change applies changes generated by running the PassedToMoveRewriter
rewriter across a Linux build of the codebase. It changes no functionality,
and only removes base::Passed invocations that can either be completely
omitted, or rewritten in terms of std::move.
TBR=dcheng
Bug: 714018
Change-Id: Ie8af65a571271c2eb77f8f88c2678e8e8abbbb9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120479
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753559}
This also converts some of the receivers to use
base::SyncSocket::ScopedHandle, which is what is the type that is
extracted from the mojo::PlatformHandle.
Bug: 710376
Change-Id: Ie8f3c05851fcd2514ed140886d61746129f43b66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055844
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742417}
This reverts commit c2f0727826.
Reason for revert: This change is causing regression. Bounding box
calculation of a given element requires the |kScrollX| and |kScrollY|
positions. In case of PDF there is a scroll element which lives outside
the PDF node. The scroll element also reports scroll positions. During
calculation of bounding boxes in AXTree::RelativeToTreeBoundsInternal
|kScrollX| and |kScrollY| are applied twice.
Original change's description:
> Add viewport scroll information to PDFAccessibilityTree
>
> This CL adds following information to PDFAccessibilityTree
> - ax::mojom::IntAttribute::kScrollXMin
> - ax::mojom::IntAttribute::kScrollXMax
> - ax::mojom::IntAttribute::kScrollX
> - ax::mojom::IntAttribute::kScrollYMin
> - ax::mojom::IntAttribute::kScrollYMax
> - ax::mojom::IntAttribute::kScrollY
>
> It enables partial implementation of IScrollProvider, following methods
> will work with this change
> - IScrollProvider::get_HorizontallyScrollable
> - IScrollProvider::get_VerticallyScrollable
> - IScrollProvider::get_HorizontalScrollPercent
> - IScrollProvider::get_VerticalScrollPercent
>
> This information is required by Screen readers to announce the current
> scroll position and extent of scroll to the user.
>
> Tests: The best way to test this change will be through browser tests.
> However, it requires the second part of the change, detailed in the
> associated bug, to be completed.
>
> Bug: 1034521
> Change-Id: I629b2773c75f2b6b222d339cd0ae01799d695295
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985821
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Virender Singh <virens@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#728843}
TBR=dcheng@chromium.org,thestig@chromium.org,mohitb@microsoft.com,virens@microsoft.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1034521
Change-Id: I15675f9ba604be96e9c50c9bea1dbe84ef8c9a0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041714
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739108}
This change adds struct PP_PrivateAccessibilityTextFieldInfo to
PP_PrivateAccessibilityPageObjects to transfer accessibility related PDF
text field data from the plugin process to the mimehandler process. Made
the same changes to the C++ versions of these structs and added the
appropriate conversion code.
Bug: 1030242
Change-Id: I50c9e82a9416445394b9cd1747606fc6d3706ef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032463
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Mansi Awasthi <maawas@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#738857}
This change updates ppapi::RunWhileLocked and ppapi::CallWhileUnlocked
to use base::OnceClosure and base::OnceCallback instead of base::Closure
and base::Callback.
Bug: 714018
Change-Id: I7e827ecffe2baca3a681cf3e27982263c89f9f34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011927
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734397}
`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.
Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.
This CL was uploaded by git cl split.
R=bbudge@chromium.org
Bug: 1041419
Change-Id: Ib80f67bc1f9a6a30349eb1289285585590abaffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997826
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730701}
This CL adds following information to PDFAccessibilityTree
- ax::mojom::IntAttribute::kScrollXMin
- ax::mojom::IntAttribute::kScrollXMax
- ax::mojom::IntAttribute::kScrollX
- ax::mojom::IntAttribute::kScrollYMin
- ax::mojom::IntAttribute::kScrollYMax
- ax::mojom::IntAttribute::kScrollY
It enables partial implementation of IScrollProvider, following methods
will work with this change
- IScrollProvider::get_HorizontallyScrollable
- IScrollProvider::get_VerticallyScrollable
- IScrollProvider::get_HorizontalScrollPercent
- IScrollProvider::get_VerticalScrollPercent
This information is required by Screen readers to announce the current
scroll position and extent of scroll to the user.
Tests: The best way to test this change will be through browser tests.
However, it requires the second part of the change, detailed in the
associated bug, to be completed.
Bug: 1034521
Change-Id: I629b2773c75f2b6b222d339cd0ae01799d695295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985821
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Virender Singh <virens@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#728843}
This reverts commit a351b484e7.
Reason for revert: MemorySanitizer: use-of-uninitialized-value.
New struct members added to PP_PrivateAccessibilityViewportInfo seem to remain uninitialized in PdfAccessibilityTreeTest.TestZoomAndScaleChanges.
Original change's description:
> Add viewport scroll information to PDFAccessibilityTree
>
> This CL adds following information to PDFAccessibilityTree
> - ax::mojom::IntAttribute::kScrollXMin
> - ax::mojom::IntAttribute::kScrollXMax
> - ax::mojom::IntAttribute::kScrollX
> - ax::mojom::IntAttribute::kScrollYMin
> - ax::mojom::IntAttribute::kScrollYMax
> - ax::mojom::IntAttribute::kScrollY
>
> It enables partial implementation of IScrollProvider, following methods
> will work with this change
> - IScrollProvider::get_HorizontallyScrollable
> - IScrollProvider::get_VerticallyScrollable
> - IScrollProvider::get_HorizontalScrollPercent
> - IScrollProvider::get_VerticalScrollPercent
>
> This information is required by Screen readers to announce the current
> scroll position and extent of scroll to the user.
>
> Tests: The best way to test this change will be through browser tests.
> However, it requires the second part of the change, detailed in the
> associated bug, to be completed.
>
> Bug: 1034521
> Change-Id: I11067b2af4d5bd73e62d89c8ce86fb00b5f3f7ec
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969412
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
> Commit-Queue: Virender Singh <virens@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#727858}
TBR=dcheng@chromium.org,thestig@chromium.org,manojb@microsoft.com,mohitb@microsoft.com,virens@microsoft.com,ankk@microsoft.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1034521
Change-Id: If82ca15040193884cd03891419d7065da425fcf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985011
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727956}
This CL adds following information to PDFAccessibilityTree
- ax::mojom::IntAttribute::kScrollXMin
- ax::mojom::IntAttribute::kScrollXMax
- ax::mojom::IntAttribute::kScrollX
- ax::mojom::IntAttribute::kScrollYMin
- ax::mojom::IntAttribute::kScrollYMax
- ax::mojom::IntAttribute::kScrollY
It enables partial implementation of IScrollProvider, following methods
will work with this change
- IScrollProvider::get_HorizontallyScrollable
- IScrollProvider::get_VerticallyScrollable
- IScrollProvider::get_HorizontalScrollPercent
- IScrollProvider::get_VerticalScrollPercent
This information is required by Screen readers to announce the current
scroll position and extent of scroll to the user.
Tests: The best way to test this change will be through browser tests.
However, it requires the second part of the change, detailed in the
associated bug, to be completed.
Bug: 1034521
Change-Id: I11067b2af4d5bd73e62d89c8ce86fb00b5f3f7ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969412
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Virender Singh <virens@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#727858}
Added a new action PP_PDF_SET_SELECTION to PP_PdfAccessibilityAction and
selection specific data in PP_PdfAccessibilityActionData. Implemented
PdfAXActionTarget::SetSelection method to send selection data to plugin.
PDFiumEngine handles PP_PDF_SET_SELECTION action and set the selection
in plugin. Added the tests to validate if write action data is sent from
Mimehandler to Plugin for selection and also if the action is correctly
executed in Plugin.
Bug: 1023283
Change-Id: I9112698757d7516d38f29e88174f10da71673b1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934127
Commit-Queue: Mansi Awasthi <maawas@microsoft.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#727044}
The vast majority of this CL is about changing code that used
base::TaskRunner and invoked RunsTasksInCurrentSequence() on it.
For the most part this CL is a logical no-op and a semantical
improvement as almost all APIs who loosely took a TaskRunner in fact
required a SequencedTaskRunner (e.g. were accessing unsynchronized
state) but it "worked" because their callers already happened to provide
task runners that were Sequenced/SingleThreadTaskRunners.
Some impls even used single-threaded APIs such as MessageLoopCurrent or
declaring methods invoked from that TaskRunner as "must run on the UI
thread". Those were changed to use SingleThreadTaskRunner (again, all
callers already were providing one but the API was too loose).
In a few cases where a parallel TaskRunner was actually intended, some
DCHECK(task_runner->RunsTasksInCurrentSequence()) were simply removed as
they were mere impl details, already obvious by the context. There was a
single case where it made sense to assert "doesn't run on a core thread"
in wallpaper_resizer.cc; that was migrated to
base::AssertLongCPUWorkAllowed().
Implementations of base::TaskRunner were either promoted to
Sequenced/SingleThreadTaskRunner when that's what it was actually used
as or the RunsTasksInCurrentSequence() override was removed.
The few actual logic changes:
- ash/.../wallpaper_resizer.cc : base::AssertLongCPUWorkAllowed()
- base/android/.../task_runner_android.h : TODO to make the same change
on the Java side, for now things seem happy when always returning
false from parallel TaskRunnerImpl.
Removed dead code:
- base::debug::ActivityTracker::SetBackgroundTaskRunner()
- AfterStartupTaskUtils::Runner
- net/url_request/test_url_request_interceptor.(h|cc)
Includes were mostly kept as-is (fwd-decls as fwd-decls and
includes-as-includes) except where it was outright wrong or necessary to
make callers happy (remember that foo.h is required in order to have
scoped_refptr<Foo> be fully defined -- and hence required by IWYU if you
have such a member and arguably if taking/returning one by value as part
of your core API).
Pointer semantics are also intentionally unchanged unless 100% incorrect
and easy to update in place (e.g. in some cases raw pointers are used to
return refcounted objects; that should probably be fixed, but not in this
CL).
Bug: 1026641
Change-Id: I1b33744d3a30a05fdb091d3f976270cd59917873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957211
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725203}
This change adds the following
- Adds name PP_PDF_SCROLL_TO_GLOBAL_POINT in PP_PdfAccessibilityAction
action enum.
- Handle PP_PDF_SCROLL_TO_GLOBAL_POINT action in PDFiumEngine.
The action is used by certain screen readers to
scroll content in viewport during continuous read operation.
Bug: 811233
Change-Id: I725a5295f42049af139856ce9815799cf67c0088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954800
Commit-Queue: Virender Singh <virens@microsoft.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#724911}
Earlier we only had link in PDF a11y on which action could be performed.
Now more annotations are to be added in PDF a11y which are actionable.
e.g. highlights.
This CL renames the variables and functions from link to annotation in
action handling pipeline as the same variables and functions will be
used for all actionable annotations.
Additionally an enum PP_PdfAccessibilityAnnotationType is introduced to
disambiguate between the different annotations on which action is to be
performed.
Bug: 1008775
Change-Id: I1b6d75976c49dba5778cb3e7871df318f023779b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958495
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724262}
This change fixes the incorrect scale that we apply to root transform
in PdfAccessibilityTree. At present, we remove the dpi factor from root
transform. This results in only zoom factor being applied when
calculating bounds. For Windows, device scaling is also handled by
application. This is not the case with Mac. As a result, conditional
scale calculation, based on OS, should be done.
Fix uses content::IsUseZoomForDSFEnabled() to find out the correct
scale that needs to be applied.
Bug: 1007169
Change-Id: I4cda488b8acf3823178b4ff68503b081e12aeaa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820697
Commit-Queue: Virender Singh <virens@microsoft.com>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720834}
This change adds new *AccessibilityAnnotInfo structs to transfer
accessibility related PDF annotation data from the plugin process up to
the mimehandler process via the pepper API. This annotation information
is bundled along with links and images into the
*AccessibilityPageObjects group of structs introduced as a part of
http://crrev.com/c/1831957. It will be populated from within pdfium_page
in a subsequent change.
Bug: 1008775
Change-Id: I89eabc8f56c135eac95c2c887d33854fbccbbcb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837558
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Commit-Queue: Kalpak Tapas <katapas@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#716555}
This CL removes code that shares base::SharedMemoryHandle with remote.
This code is no longer used because base::SharedMemoryHandle is
deprecated and replaced with base::*SharedMemoryRegion.
Bug: 795291
Change-Id: I5974bd77b6e40bee662dc2fb4092b7a61f725afb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916827
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715867}
This is a reland of cc4f1e5fe4
This change was reverted due to "Windows Deterministic" bot failing. Apparently,
these bots seems to have a problem with any changes to ppapi/. Currently, the
only way we know is to try again.
This is the exact same CL as the one that was reverted.
Original change's description:
> Pdf a11y: Populate AXNode with new text style info
>
> This change fills the font-family, font-size, font-weight, italic, bold
> and color attributes of the AXNode with exposed values from the PDFium
> APIs.
>
> I've also added a PDF accessibility tree dump test using the filter
> properties to dump those attributes in the expected file. The test file
> is "text-style.pdf".
>
> Somehow, I added in a previous change text-format-expected-blink.txt.
> This file should have never been committed. I removed it in this CL.
>
> Bug: 985604
> Change-Id: I70a4729269aea69e184e61710d7977425b431704
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755412
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Bill Budge <bbudge@chromium.org>
> Reviewed-by: Ian Prest <iapres@microsoft.com>
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711942}
TBR=raymes@chromium.org,bbudge@chromium.org,iapres@microsoft.com,tsepez@chromium.org
Bug: 985604
Change-Id: I4030926c8aff39c05e45b8cdc3a3262d94158c8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898162
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712455}
This change fills the font-family, font-size, font-weight, italic, bold
and color attributes of the AXNode with exposed values from the PDFium
APIs.
I've also added a PDF accessibility tree dump test using the filter
properties to dump those attributes in the expected file. The test file
is "text-style.pdf".
Somehow, I added in a previous change text-format-expected-blink.txt.
This file should have never been committed. I removed it in this CL.
Bug: 985604
Change-Id: I70a4729269aea69e184e61710d7977425b431704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755412
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711942}
This is a precursor to adding a new scoped_refptr(std::nullptr_t)
constructor. The implicit conversion from NULL to scoped_refptr<T>
causes a compilation error with the new constructor. Replace NULL with
nullptr in any files where this is a problem.
This CL was uploaded by git cl split.
R=raymes@chromium.org
Bug: 1018887
Change-Id: I2b2693e82a1aaf15022a680dda56122b7b09a6ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885013
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710423}
In changes pdfium:60110, pdfium:60410 and pdfium:59670, we exposed new
APIs for text style: fill/stroke color, rendering mode and weight.
This change forwards these new available text properties(+ font-family,
which was already exposed) to the
ppapi::PrivateAccessibilityTextRunInfo struct. We use an object of
this type in PdfAccessibilityTree to create the AXNode.
The next step is to populate this information on AXNode.
Bug: 985604
Change-Id: Ia2e41c5427cfb972c071c2a3608631a4f23e6ff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752165
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#710404}
The V8 natives blob (natives_blob.bin) is unused and will shortly be
removed in V8. This CL removes all related infrastructure in chromium.
Specifically, this means that natives_blob.bin is no longer
1. generated during the build process,
2. installed on the target system,
3. loaded by chrome at runtime, and
4. passed to V8.
Tbr: oksamyt@chromium.org
Bug: v8:7624
Change-Id: I535d4308a8aa539c354a212174d47ade411bc89d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847217
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708094}
