Note to reviewers: don't review third_party/grpc/sources/, review
the rest and verify that update.sh is a no-op locally.
Rolling gRPC to a more recent revision in https://crrev.com/c/6276328
will require Chromium to apply some patches. This CL forks gRPC to
add the basis for that. For now we still use the same pinned gRPC
revision, so there should be no behavior change.
The fork strategy is the same used for abseil and mediapipe, i.e. the
files are checked into the src/ repository. To roll, update.sh
downloads the new revision and applies the patches in the patches/
directory (there are none in this CL yet). The script avoids checking
unnecessary files into the repo such as tests and non-C++ files.
generate_gn.sh does depend on non-C++ files, so it's updated to depend
on a fresh clone of the repo (at the same revision).
The removed submodule used to live in third_party/grpc/src. Sadly, this
CL cannot apply cleanly if the fork uses the same path, so it lives
in third_party/grpc/source instead. Includes and BUILD.gn are updated
accordingly.
NO_IFTTT=False positives inside the forked repo.
Bug: 40285204
Change-Id: I3bc2ac38cacdbb8b3527984a47f331dabe6f0aa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6269394
Reviewed-by: Nico Weber <thakis@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Vigen Issahhanjan <vigeni@google.com>
Cr-Commit-Position: refs/heads/main@{#1425352}
This is a reland of commit 61333e40ef
Fixes two more places where the logic was incorrect when DCHECKs were disabled.
Original change's description:
> Reland "Reland "Modify B&A key fetcher code to retain the full key ID""
>
> This is a reland of commit 9f44fe6906
>
> Original change's description:
> > Reland "Modify B&A key fetcher code to retain the full key ID"
> >
> > This is a reland of commit 5624b16cc2
> >
> > Original change's description:
> > > Modify B&A key fetcher code to retain the full key ID
> > >
> > > Changes the B&A key fetcher code so that it stores the full key
> > > identifier instead of the first two bytes parsed as a hexadecimal
> > > number. This will be needed to support features like Private Model
> > > Training that include the full key ID as part of the message.
> > >
> > > This CL also does some refactoring in order to support per-adtech
> > > keys/origin scoped keys as described in
> > > https://github.com/WICG/turtledove/issues/1334.
> > >
> > > NO_IFTTT=Just moving the enums.
> > >
> > > Bug: 390160246
> > > Change-Id: I62ded0175dbbc559363685ada995c91ef2d9d2dc
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6265963
> > > Reviewed-by: Orr Bernstein <orrb@google.com>
> > > Commit-Queue: Russ Hamilton <behamilton@google.com>
> > > Auto-Submit: Russ Hamilton <behamilton@google.com>
> > > Cr-Commit-Position: refs/heads/main@{#1423990}
> >
> > Bug: 390160246
> > Change-Id: I968311418baf9b487654f294f065f893a5b217ac
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299239
> > Commit-Queue: Russ Hamilton <behamilton@google.com>
> > Reviewed-by: Orr Bernstein <orrb@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1424577}
>
> Bug: 390160246
> Change-Id: I9f885c1fd667e094dd2cdf17eb21237fda1057e3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6297865
> Reviewed-by: Orr Bernstein <orrb@google.com>
> Commit-Queue: Russ Hamilton <behamilton@google.com>
> Cr-Commit-Position: refs/heads/main@{#1424802}
Bug: 390160246,399215594
Change-Id: If054e460a0d6991aa5f56bd3d28048fc234b5329
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6305962
Reviewed-by: Orr Bernstein <orrb@google.com>
Commit-Queue: Russ Hamilton <behamilton@google.com>
Cr-Commit-Position: refs/heads/main@{#1425308}
When a session is cloned, OnStop isn't called and thus
process descriptor doesn't have process type if it was set
after the tracing session started.
This brings back logic similar to https://chromium-review.googlesource.com/c/chromium/src/+/6163823
with a few difference:
- process type is updated (whereas only the process name was previously set)
- The descriptor is written by TrackNameRecorder
- process labels are kept and emitted in TrackNameRecorder
Change-Id: I65907390d8da74a34359cd2ff5d054a2d20d1be5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6298800
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1425303}
I couldn't find a reference to these methods and we seem to
compile fine without them so removing.
It seems like this was no longer necessary once we removed the
legacy GIN java bridge.
Bug: 40815663
Change-Id: Idb7528fb1bec09ccee5b44fa375280eaee650647
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6304462
Auto-Submit: Rupert Wiser <bewise@chromium.org>
Commit-Queue: Richard (Torne) Coles <torne@chromium.org>
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1425287}
Some platforms seem to have small noise (< 3 total in all channels).
The intent of the test is still valid in that it verifies first frame
capture to be correct.
Change-Id: Iffdc832ca96a3ab3eadb91aa867367d5af384cf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299814
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Zijie He <zijiehe@google.com>
Cr-Commit-Position: refs/heads/main@{#1425279}
And key the cache on these IDs. These will be used to add events for
cache-managed network requests to devtools for the frame.
The ID is added unconditionally as part of the FetchKey, which
makes it so different frames can't share KVv2 cache entries, but I hope
to relax that constraint in the future (Could remove it from the key
on fetch complete, or only populate it when multiple frames request
related resources, or both, etc).
Bug: 379843989
Change-Id: I3e18b49341b928057cbfd855fc3dabb5dd0cb706
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6300675
Commit-Queue: mmenke <mmenke@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1425192}
This CL addresses a crash in payment_handler_permission_context.cc,
which was reported by lib fuzzer. The crash occurs when the browser
receives a PEPC request for an unsupported type (likely due to auto
generated mojo inputs). To prevent this, the CL adds checks to ensure
that the browser only handles PEPC requests of supported types.
Bug: 398356454
Change-Id: I8d9de086486066876b5d8d07674ec94dd791b51e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6298138
Commit-Queue: Yifan Luo <lyf@chromium.org>
Reviewed-by: Thomas Nguyen <tungnh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1425158}
Both the PartitioningBlobURLIssue DevTools Issue and
kCrossPartitionSameOriginBlobURLFetch UseCounter should only be
triggered when cross-partition, same origin BlobURLs are fetched.
Previously, both were getting triggered in cross origin fetching as
well.
Bug: 372883697
Change-Id: I90221dde05205d260abfc20acf8903f123ee4c59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6282545
Auto-Submit: Janice Liu <janiceliu@chromium.org>
Commit-Queue: Janice Liu <janiceliu@chromium.org>
Reviewed-by: Sun Yueru <yrsun@chromium.org>
Reviewed-by: Andrew Williams <awillia@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1425152}
This makes SharedArrayBuffers available to all client regardless of the Cross origin isolation of the site (unless the feature is manually disabled). This will allow interop clients on Google Meet Hardware that currently rely on the SharedArrayBuffers origin trial to continue using SharedArrayBuffers after that trial expires.
This change acts as an override specifically for Google Meet Hardware (PLATFORM_CFM is specific to Google Meet Hardware). This works around the problem that the SharedArrayBuffers origin trial has expired in the past and may expire in the future.
go/x-on-meet-coop covers this in more detail.
(cherry picked from commit 1d216a4169)
Bug: 303207594
Change-Id: I2524f11939c60b77e00485e3961dacc0ea95970d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5390890
Reviewed-by: Kyle Williams <kdgwill@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Owners-Override: Richard Yeh <rcy@google.com>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Felix Plymouth <fplymouth@google.com>
Cr-Original-Commit-Position: refs/branch-heads/6099_225@{#23}
Cr-Original-Branched-From: 6d3cc0dac5057925e096b1329680124b19f35842-refs/branch-heads/6099@{#1762}
Cr-Original-Branched-From: e6ee4500f7d6549a9ac1354f8d056da49ef406be-refs/heads/main@{#1217362}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6287530
Auto-Submit: Richard Yeh <rcy@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Richard Yeh <rcy@google.com>
Cr-Commit-Position: refs/heads/main@{#1425149}
This CL removes a check that prevents the mCurrentRootId from updating
during the creation of AccessibilityNodeInfo objects.
With the current behavior, in some cases Android-side code is not
receiving a signal that the page was navigated, and so the root ID is
not being updated. When the root ID is stale, then we provide a stale
AccessibilityNodeInfo tree to downstream clients/AT. With this change
we always fetch a fresh root ID during node creation to eliminate the
possibility of a stale tree, at the cost of one extra JNI trip (which
is minimal/trivial). This will keep the mCurrentRootId up-to-date with
the native browser-side AXTree. This can be considered a stopgap
solution to a P1 bug, and caching can be revisited in the future, but
a cache of this value may not be needed in general.
AX-Relnotes: N/A
Bug: 396447488
Change-Id: I134d2313c68c04973aefdaee82bd181ba1a47293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6302633
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/main@{#1425146}
`RenderFrameHost::GetPageUkmSourceId()` returns the UKM source ID for
the prerendering activation even after page activation, which is not
associated with any URL.
This cl uses `AttributionHost::GetPageUkmSourceId()` which keeps track
of the UKM source ID of the most recently navigated primary page to
ensure that metrics are properly associated with the primary page URL.
Change-Id: Id710b8829aef7133743ca6dde88d08bbb33b3f4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6305599
Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org>
Commit-Queue: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1425128}
Replace Media.ScreenCaptureKit.SCContentSharingPicker with
Media.ScreenCaptureKit.SCContentSharingPicker2 to only log the first
call to each PickerObserver.
The intention of this histogram is to log a record each time
SCContentSharingPicker is shown and which callback is called on
PickerObserver as a response to that. However, the callbacks may be
called multiple times, so only the first of these calls should be
recorded.
OBSOLETE_HISTOGRAM[Media.ScreenCaptureKit.SCContentSharingPicker]=Replaced by Media.ScreenCaptureKit.SCContentSharingPicker2
Bug: 393153135
Change-Id: I6d31a346a11591c04092b07aeafc79ed8b627d72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6298229
Reviewed-by: Johannes Kron <kron@chromium.org>
Commit-Queue: Tove Petersson <tovep@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1425059}
With SPLIT_TOUCH deprecated in Android the pointer downs come on Browser
process, even when transferTouchGesture had been called on the first
touch down of the sequence. The subsequent pointer downs after the
transfer come in as an ACTION_DOWN on Browser and there's no blessed way
to tell this apart from an ACTION_DOWN which happened as a result of
the first touch down in the Chrome window.
The behavior changes in this CL:
- Ignore the state transfers coming on browser corresponding to pointer
downs being transferred. Earlier we were CHECK failing if we had
lingering state transfer in the queue.
- InputTransferHandler listens to TouchEnd notifications to tell if
there's an active touch sequence on Viz.
- Add `browser_would_have_handled` flag to touch transfer state, so that
Viz can return back any sequence that was transferred to Viz due to a
late arriving TouchEnd notification.
Bug: 395596230
Change-Id: Ie640ff5fa41420228a5fe0d4108ee76d414c0985
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6276541
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kartar Singh <kartarsingh@google.com>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1425046}
Introduce AXPlatformNode::Pointer, a type of std::unique_ptr<> for
owners of platform nodes. The node's `Destroy()` method is called to
initiate destruction. Migrate all owners of platform nodes to using this
new smart pointer rather than raw_ptr<> and manual calls to instances'
`Destroy()` method.
Also fixes memory leaks in various AccessibilityBridgeFuchsiaTest tests,
which were missing calls to `Destroy()`.
AX-Relnotes: n/a.
Bug: none
Change-Id: I3b7ab5e14726c098350a41126ee0bc26ce1aeef7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6298029
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1425038}
This is part of the process of making user_agent_utils.{cc,h} stop
depending on //content.
The flag has been moved to the main "embedder_support" target, which
does not depend on any other target and has other command-line
switches.
Bug: 389970327
Change-Id: Ib646ada998e8ea2eb23be2b9420d8049aa8f0bac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6242721
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Raphael Kubo da Costa <kubo@igalia.com>
Reviewed-by: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1425012}
This CL checks if the sampling param passed in the `availability()` is
valid using the `ResolveSamplingParamsOption()` method. The sampling
params will be checked from the renderer and the mojom interface is
modified so only the `expected_input_languages` will be passed to the
browser.
Change-Id: I17fb73624a13f2863cd4869bba3071ff1251f8cc
Bug: 390459309
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6277982
Commit-Queue: Mingyu Lei <leimy@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424931}
This change removes some usages of StorageType from
QuotaManagerProxy. All other StorageTypes except
StorageType::kTemporary have been deprecated. Therefore
no longer need to pass this value around. Further cleanup
to remove usages from
QuotaManagerProxy/QuotaManager/QuotaDatabase will follow.
Bug: 40211051
Change-Id: I0aa5413fc6ced600d25ad446ec0281fbd1181074
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6279419
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Ming-Ying Chung <mych@chromium.org>
Reviewed-by: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424923}
This reverts commit 61333e40ef.
Reason for revert: Breaks multiple content_browsertests and content_unittests (see b/399215594) for the failure list.
Original change's description:
> Reland "Reland "Modify B&A key fetcher code to retain the full key ID""
>
> This is a reland of commit 9f44fe6906
>
> Original change's description:
> > Reland "Modify B&A key fetcher code to retain the full key ID"
> >
> > This is a reland of commit 5624b16cc2
> >
> > Original change's description:
> > > Modify B&A key fetcher code to retain the full key ID
> > >
> > > Changes the B&A key fetcher code so that it stores the full key
> > > identifier instead of the first two bytes parsed as a hexadecimal
> > > number. This will be needed to support features like Private Model
> > > Training that include the full key ID as part of the message.
> > >
> > > This CL also does some refactoring in order to support per-adtech
> > > keys/origin scoped keys as described in
> > > https://github.com/WICG/turtledove/issues/1334.
> > >
> > > NO_IFTTT=Just moving the enums.
> > >
> > > Bug: 390160246
> > > Change-Id: I62ded0175dbbc559363685ada995c91ef2d9d2dc
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6265963
> > > Reviewed-by: Orr Bernstein <orrb@google.com>
> > > Commit-Queue: Russ Hamilton <behamilton@google.com>
> > > Auto-Submit: Russ Hamilton <behamilton@google.com>
> > > Cr-Commit-Position: refs/heads/main@{#1423990}
> >
> > Bug: 390160246
> > Change-Id: I968311418baf9b487654f294f065f893a5b217ac
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299239
> > Commit-Queue: Russ Hamilton <behamilton@google.com>
> > Reviewed-by: Orr Bernstein <orrb@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1424577}
>
> Bug: 390160246
> Change-Id: I9f885c1fd667e094dd2cdf17eb21237fda1057e3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6297865
> Reviewed-by: Orr Bernstein <orrb@google.com>
> Commit-Queue: Russ Hamilton <behamilton@google.com>
> Cr-Commit-Position: refs/heads/main@{#1424802}
Bug: 390160246
Change-Id: Ib3d6644251826caa3e2fca75f5fd50435c1c20d4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6303281
Auto-Submit: Chan Li <chanli@chromium.org>
Owners-Override: Chan Li <chanli@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1424882}
Bypasses optimization guide to use on-device model service directly.
This short-term implementation expedites a time-sensitive dev trial.
Enables ai.languageModel.prompt({type: 'image', content: image}):
i = document.getElementsByTagName('img');
s = await window.ai.languageModel.create();
r = await s.prompt(['describe this image',
{type: 'image', content: i[0]}]);
Pass prompt[Streaming]() input via on_device_model::mojom::Input.
Invokes on_device_model::mojom::Session::Execute directly, with flag.
Adds a basic unit test. TODO: Add basic WPTs.
A more correct approach is in development; see crrev.com/c/6231611.
Builds on crrev.com/c/6086800 and prior+parallel prototyping efforts.
Credit to cduvall@chromium.org for big fixes in crrev.com/c/6253876.
Caution: This VERY ROUGH WIP prototype has quirks and known issues!
- Only a subset of JS ImageBitmapSource input types are supported
- Lacks history integration, token counting, overflow handling, etc.
- Does not support concurrent requests, multiple images, some errors.
Test locally on a device compatible with existing Prompt-API usage:
1) Run a Chrome-branded build, with flags and a test user-data-dir
$ chrome --no-sandbox --user-data-dir=/tmp/foo --enable-features=OptimizationGuideOnDeviceModel:on_device_model_image_input/true --enable-blink-features=AIPromptAPIMultimodalInput
2) Trigger model download and init via `ai.languageModel.create()`
3) Verify chrome://component "Optimization Guide..." is up-to-date
4) Quit & replace Chrome's model with a compatible test model:
$ mv tmp/foo/OptGuideOnDeviceModel/2024.9.25.2033/weights.bin tmp/foo/OptGuideOnDeviceModel/2024.9.25.2033/weights.bin.OLD
$ cp ~/Downloads/vision_model.tflite tmp/foo/OptGuideOnDeviceModel/2024.9.25.2033/weights.bin
5) Restart Chrome; try multimodal prompt() inputs per Explainer:
https://github.com/webmachinelearning/prompt-api
Bug: 385173789, 385173368
Change-Id: Ibc75d6777df6c31eed608bcfd9134458da4ce136
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6246232
Mega-CQ: Mike Wasserman <msw@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Mike Wasserman <msw@chromium.org>
Reviewed-by: Brad Triebwasser <btriebw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424824}
This is a reland of commit 9f44fe6906
Original change's description:
> Reland "Modify B&A key fetcher code to retain the full key ID"
>
> This is a reland of commit 5624b16cc2
>
> Original change's description:
> > Modify B&A key fetcher code to retain the full key ID
> >
> > Changes the B&A key fetcher code so that it stores the full key
> > identifier instead of the first two bytes parsed as a hexadecimal
> > number. This will be needed to support features like Private Model
> > Training that include the full key ID as part of the message.
> >
> > This CL also does some refactoring in order to support per-adtech
> > keys/origin scoped keys as described in
> > https://github.com/WICG/turtledove/issues/1334.
> >
> > NO_IFTTT=Just moving the enums.
> >
> > Bug: 390160246
> > Change-Id: I62ded0175dbbc559363685ada995c91ef2d9d2dc
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6265963
> > Reviewed-by: Orr Bernstein <orrb@google.com>
> > Commit-Queue: Russ Hamilton <behamilton@google.com>
> > Auto-Submit: Russ Hamilton <behamilton@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1423990}
>
> Bug: 390160246
> Change-Id: I968311418baf9b487654f294f065f893a5b217ac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299239
> Commit-Queue: Russ Hamilton <behamilton@google.com>
> Reviewed-by: Orr Bernstein <orrb@google.com>
> Cr-Commit-Position: refs/heads/main@{#1424577}
Bug: 390160246
Change-Id: I9f885c1fd667e094dd2cdf17eb21237fda1057e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6297865
Reviewed-by: Orr Bernstein <orrb@google.com>
Commit-Queue: Russ Hamilton <behamilton@google.com>
Cr-Commit-Position: refs/heads/main@{#1424802}
This failure occurs when a buyer's interest group information
serializes to the exact same size in bytes as the ceiling of
the average space remaining for each remaining buyer.
Fixed: 394896168
Change-Id: I67065d443c3ec9e72ac12661619c0f5adddae46d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299356
Auto-Submit: Russ Hamilton <behamilton@google.com>
Commit-Queue: Russ Hamilton <behamilton@google.com>
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424700}
Frames generally are not accessible by display compositor besides
sending it as overlay. Previous code was hardcoding color space during
overlay processing.
This would create mismatch between what's in VideoFrame, SharedImage and
in the overlay. To avoid this (and reduce dependency on is_stream_video)
we should just set correct color space when we create things.
Bug: 396584155
Change-Id: I6104a0fd9e37a3b74e2ded9a55b93269fe338b8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6268043
Reviewed-by: Michael Tang <tangm@microsoft.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424683}
1. Implement IsKnownScreenReaderAppActive() for Mac/Win.
This cannot be based on AXMode::kScreenReader because that
an inaccurate heuristic. We need something that can be updated
based on whether an actual screen reader app is currently running.
2. Add VoiceOver histogram + crash key (these already exist for Windows
screen readers).
IsKnownScreenReaderAppActive() is needed to vet the upcoming
refreshed auto-disable heuristic -- it will report whenever we are about
to auto disable a11y (when we think a11y is no longer used), but a
screen reader is still active, which indicates a flaw in the heuristic
logic.
Auto-disable refresh:
https://docs.google.com/document/d/1DlJn8PPE4towT0W4VknBqB04-SzFAz6yZ0graPc_xS8
To do in follow-ups, implement IsKnownScreenReaderAppActive() for:
* Talkback on Android
* ChromeVox on ChromeOS
* Orca on Linux
Note that these cannot be based on
Bug: none
Change-Id: I3c16dfbe8a5dd1f41b0f854c3a744dc4783b5cc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299355
Reviewed-by: Jayson Adams <shrike@chromium.org>
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424679}
- when RenderDocument is on, do not fall through in Page.reload handler;
- instead, pass script_to_evaluate_on_load to InspectorPageAgent in new
render frame at construction time via AttachDevToolsSession() method;
- handle breakpoint unpause and script termination by an out-of-band
method of DevToolsSession.
- get rid of using InspectorAgentState for storing the script to
evaluate on load, as the RenderDocument code path does not require
this anymore;
- the latter also takes care of a security sensitive race between
reload and navigation to a different URL, so
PageReloadScriptInjection is going away too.
This resolves a race between the page reload initiated by PageHandler::reload() on the browser side and and a round-trip to renderer resulting from fall-through of PageHandler::reload() intended to set script to evaluate on load in the agent state cookie, which occurs with RenderDocument enabled.
Bug: 357977710
Change-Id: Ice796b829b56b514d38b787aea826d04d69f3c76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6261689
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Lucas Radaelli <lucasradaelli@google.com>
Cr-Commit-Position: refs/heads/main@{#1424660}
Suppress MediaFoundationD3D11VideoCapture trace test on windows to
unblock bots until the culprit is found that causes this test failure.
Bug: 398784712
Change-Id: If8838eebb430cd84079721c0e2f347b1ebd3d661
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6297825
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Saifuddin Hitawala <hitawala@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424630}
This is a reland of commit 5624b16cc2
Original change's description:
> Modify B&A key fetcher code to retain the full key ID
>
> Changes the B&A key fetcher code so that it stores the full key
> identifier instead of the first two bytes parsed as a hexadecimal
> number. This will be needed to support features like Private Model
> Training that include the full key ID as part of the message.
>
> This CL also does some refactoring in order to support per-adtech
> keys/origin scoped keys as described in
> https://github.com/WICG/turtledove/issues/1334.
>
> NO_IFTTT=Just moving the enums.
>
> Bug: 390160246
> Change-Id: I62ded0175dbbc559363685ada995c91ef2d9d2dc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6265963
> Reviewed-by: Orr Bernstein <orrb@google.com>
> Commit-Queue: Russ Hamilton <behamilton@google.com>
> Auto-Submit: Russ Hamilton <behamilton@google.com>
> Cr-Commit-Position: refs/heads/main@{#1423990}
Bug: 390160246
Change-Id: I968311418baf9b487654f294f065f893a5b217ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299239
Commit-Queue: Russ Hamilton <behamilton@google.com>
Reviewed-by: Orr Bernstein <orrb@google.com>
Cr-Commit-Position: refs/heads/main@{#1424577}
This patch enables the ViewTransitionCaptureAndView feature as well
as one of the tests that tests this behavior.
Note that there is also over 300 VT WPTs, which also exercise the
capture phase.
This patch 5 out of 5 to implement the feature.
R=pdr@chromium.org
Bug: 358119267
Change-Id: Ief305a053eb180a81b53590437556a98264a1ce3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6258744
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424551}
This change just plumbs the AutoPipReason from the auto picture in
picture tab helper to the WatchTimeRecorder. The reason will be used in
subsequent CLs to allow attributing watch time to the "AutoPip for media
playback" reason.
Bug: 394860526, 368058093
Change-Id: Ibaca8fc6446c6cf557b950b70bbf3e68a125c976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6266667
Commit-Queue: Benjamin Keen <bkeen@google.com>
Reviewed-by: Ted (Chromium) Meyer <tmathmeyer@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Fr <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1424538}
