01a6cb22a3
Android tests such as base_unittests use dir /storage/emulated/0/chromium_test_root with PathService. The user that runs the tests has access to /storage/emulated/0, but not the parent /storage/emulated. Even when the full dir exists, calling CreateDirectory() fails due to the way that it runs stat / mkdir on all subpaths starting at the root. When running with is_debug=true, this leads to crashes when a path provider fails to Override() and calls Register() where the base provider has already registered for the given key. This changes to run stat beginning with the full path and each subdir until a missing dir is found, and then run mkdir on all missing subpaths which solves the issue when the current posix user does not have permission to stat a supath, and will also provide a performance improvement. Bug: 398066589 Change-Id: Ia135a3523dca0d1bfb7f2d6dcd49b322d8405dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6290044 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1425397}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.