0
Commit Graph

28 Commits

Author SHA1 Message Date
Takuto Ikuta
40def48455 PRESUBMIT.py: remove USE_PYTHON3 = True
presubmit now uses python3 only.

This is generated by
$ rg -l '^USE_PYTHON3 = True' | \
  xargs sed -z -i "s/\n*USE_PYTHON3 = True\n*/\n\n/"
with some more modifications.

This also removes run_on_python2, run_on_python3, and skip_shebang_check
args.

Bug: 1207012
Change-Id: I8c842d0a9ac485a27399d704a17b755f58a64db8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573952
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1152319}
2023-06-02 02:23:49 +00:00
Avi Drissman
05dfbc82b0 Update copyright headers in gpu/ (and generated ppapi/ files)
The methodology used to generate this CL is documented in
https://crbug.com/1098010#c34.

No-Try: true
Bug: 1098010
Change-Id: I30614b78d270d4fc3e347b925efa26033eacd472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3891044
Auto-Submit: Avi Drissman <avi@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1046576}
2022-09-13 21:25:34 +00:00
Brian Sheedy
d406c1a88f Fix //gpu pylint warnings
Fixes all pylint warnings in //gpu and re-enables the pylint check in
PRESUBMIT.py.

Bug: 1329829
Change-Id: Ia9d4907de62d292affcedd572c28246b090f337b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3687982
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1011215}
2022-06-07 00:03:16 +00:00
Brian Sheedy
e31df48296 Migrate GPU workaround generator to Python 3
Migrates //gpu/config/build_workaround_header.py to Python 3 and does
some drive-by improvements such as switching from optparse to
argparse and adding type hinting.

Also disables pylint on //gpu for now since v1.5 complains about Python
3 syntax being incorrect and v2.7 complains about Python 2 syntax
being incorrect. This will be re-enabled once all code under the
directory is on a uniform Python version.

Bug: 1329829
Change-Id: Iec44024d435cc87cb45a045225669597fee85dcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3686779
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1010439}
2022-06-03 04:22:17 +00:00
Fabrice de Gans
7a4c68a5a3 [code-health] Migrate //gpu/PRESUBMIT.py to python3
Bug: 1212033
Change-Id: I2fd7af0db6a355730d7130e62511095a45fb72b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2976463
Auto-Submit: Fabrice de Gans <fdegans@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#895249}
2021-06-23 18:40:03 +00:00
Kai Ninomiya
a388f4a157 Fix and un-suppress pylint warnings in gpu/
Bug: 498797
Change-Id: I78f40e1c78bd339b99b466d72dbe051e56f7dfaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243440
Auto-Submit: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778383}
2020-06-15 18:31:51 +00:00
Edward Lemur
35bdc0f535 PRESUBMIT.py: Remove uses of EnsureCQIncludeTrybotsAreAdded.
The functionality was moved to cq.cfg in
https://chromium-review.googlesource.com/c/chromium/src/+/1265735

Bug: 881860
Change-Id: I839784ec7babfa095272ab06c4c21c1e57475216
Reviewed-on: https://chromium-review.googlesource.com/c/1266055
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600875}
2018-10-18 19:59:55 +00:00
Corentin Wallez
b78c44abad PRESUBMITs.py, use LUCI for the optional GPU tests on Windows
Also fixup some documentation links for GPU optional bots.
Also change a PRESUBMIT.py's master name for win_angle_rel_ng.

TBR=kbr@chromium.org
TBR=sky@chromium.org

BUG=chromium:815092

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Ifda505e121f67f922f19da466a37b7f6266cea05
Reviewed-on: https://chromium-review.googlesource.com/1008182
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550188}
2018-04-12 14:29:47 +00:00
Yuly Novikov
129c328059 PRESUBMITs.py, use LUCI for the optional GPU tests on Android
Also in roll scripts

TBR=kbr@chromium.org
TBR=sky@chromium.org

BUG=731979

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic160cb4fab54d32647da0df364891aa670cdaa65
Reviewed-on: https://chromium-review.googlesource.com/972634
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544640}
2018-03-21 05:07:29 +00:00
Corentin Wallez
5ba0089533 PRESUBMITs.py, use LUCI for the optional GPU tests on Mac
Also fixup missed references to the linux GPU optional bot in some roll
scripts.

TBR=kbr@chromium.org
TBR=sky@chromium.org

BUG=chromium:815092

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1b9e63af5258d6c85a7c125b182dbfd79de4243e
Reviewed-on: https://chromium-review.googlesource.com/971406
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544476}
2018-03-20 19:16:06 +00:00
Corentin Wallez
af719e2f31 PRESUBMITs.py, use LUCI for the optional GPU tests on Linux
TBR=kbr@chromium.org
TBR=sky@chromium.org

BUG=chromium:815092

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib8f30c702e603c987e0c89203d8d7cd301f6ba77
Reviewed-on: https://chromium-review.googlesource.com/962933
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543229}
2018-03-14 22:48:35 +00:00
Jonathan Backer
16cd536f31 Fix autoformat and pylint presubmit
Three changes

1) Use depot_tools/clang-format --- it's different from clang-format on
your workstation. This makes "python
gpu/command_buffer/build_gles2_cmd_buffer.py" idempotent.

2) Run pylint as a presubmit step to keep the autogen python scripts
clean.

3) Fix up pylint errors other than redefined-builtin

BUG=789238

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I69da2da0e5b5b1c65085a00806e3733b98b19a2e
Reviewed-on: https://chromium-review.googlesource.com/867470
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529777}
2018-01-17 17:00:10 +00:00
Sunny Sachanandani
4b2894f126 gpu: Automatically add optional gpu tests to ui/gl changes.
ui/gl changes are likely to affect gpu tests so we should run these
trybots.

R=kbr
BUG=712303

Change-Id: Id8b89b4647b1b1926184ff55a8746adddc3b345b

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Change-Id: Id8b89b4647b1b1926184ff55a8746adddc3b345b
Reviewed-on: https://chromium-review.googlesource.com/479802
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#465347}
2017-04-18 20:22:59 +00:00
ynovikov
fc4582fac8 Add android_optional_gpu_tests_rel to variuos presubmit scripts
Add to CQ_INCLUDE_TRYBOTS where win, mac and linux already are added.

BUG=626498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2724863006
Cr-Commit-Position: refs/heads/master@{#454688}
2017-03-03 22:18:05 +00:00
kbr
4384263c0f Rewrite presubmit scripts to use new EnsureCQIncludeTrybotsAreAdded.
BUG=688765
TBR=enne@chromium.org,grt@chromium.org,robertshield@chromium.org,kapishnikov@chromium.org,zmo@chromium.org,vmiura@chromium.org,dalecurtis@chromium.org,jschuh@chromium.org,hirono@chromium.org,dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2683103002
Cr-Commit-Position: refs/heads/master@{#451034}
2017-02-16 19:06:56 +00:00
tandrii
e5587794fa PRESUBMIT: use "master." prefix in CQ_INCLUDE_TRYBOTS.
R=jam@chromium.org,danakj@chromium.org,kbr@chromium.org
BUG=617627

Review-Url: https://codereview.chromium.org/2148053002
Cr-Commit-Position: refs/heads/master@{#405365}
2016-07-14 00:37:51 +00:00
jmadill
000abd97a1 gpu: Add linux optional GPU tests to presubmit.
Now that this bot is fixed, we should trigger it on gpu changes.

BUG=583702
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1807483002

Cr-Commit-Position: refs/heads/master@{#384375}
2016-03-31 20:48:37 +00:00
kbr
fd9afe9fd1 Re-enable mac_optional_gpu_tests_rel tryserver for GPU related changes.
There's more capacity on the builders now so jobs shouldn't time out.

BUG=596250
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1829063003

Cr-Commit-Position: refs/heads/master@{#383154}
2016-03-24 21:36:11 +00:00
kbr
a42c0729fc Removed mac_optional_gpu_tests_rel from extra trybots in gpu/ and webgl/.
Leaving this trybot on the extra set for ANGLE and WebGL conformance
rolls for the time being.

BUG=596250
TBR=piman@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1818503003

Cr-Commit-Position: refs/heads/master@{#382179}
2016-03-19 04:42:09 +00:00
zmo
fb33cbfb3b Add mac_optional_gpu_tests_rel bots to gpu related CLs.
BUG=
TEST=CLs in gpu/ or third_party/WebKit/Source/module/webgl
R=kbr@chromium.org
TBR=sievers@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1720743006

Cr-Commit-Position: refs/heads/master@{#376874}
2016-02-23 00:42:31 +00:00
kbr
e85ee566e1 Run WebGL 2.0 conformance tests in more cases.
Use CQ_INCLUDE_TRYBOTS directive to run optional GPU tests, which
include the WebGL 2.0 conformance tests, on the commit queue during
ANGLE rolls. Add a script for rolling the WebGL conformance suite and do
the same then.

Add presubmit checks for the gpu/ directory and the Blink WebGL sources
which run the WebGL 2.0 conformance suite, since these are the places
most likely to break these tests.

(These tests will be run by default on the commit queue as soon as there
is machine capacity to do so.)

BUG=295792
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/1682593002

Cr-Commit-Position: refs/heads/master@{#374307}
2016-02-09 04:40:02 +00:00
sergiyb
8778ff8184 Removed references to win_gpu, which has been removed
BUG=426897
R=kbr@chromium.org,phajdan.jr@chromium.org,zmo@chromium.org,darin@chromium.org,brettw@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/794303004

Cr-Commit-Position: refs/heads/master@{#316870}
2015-02-18 18:57:08 +00:00
sergiyb
10ab0cd528 Removed references to linux_gpu, which has been removed
BUG=426897
R=kbr@chromium.org,phajdan.jr@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/800013002

Cr-Commit-Position: refs/heads/master@{#313978}
2015-01-30 20:34:16 +00:00
sergiyb
2adbe15c19 Removed references to mac_gpu, which has been removed
BUG=426897
R=kbr@chromium.org,phajdan.jr@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/805483002

Cr-Commit-Position: refs/heads/master@{#308995}
2014-12-18 12:21:44 +00:00
phajdan.jr@chromium.org
ed5040941e Update PRESUBMIT for tryserver.chromium.gpu
BUG=334892
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/200493007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257589 0039d316-1c4b-4281-b951-d872f2087c98
2014-03-18 03:16:29 +00:00
kbr@chromium.org
7821073db6 Remove defunct mac_gpu_retina configuration from presubmit scripts.
mac_gpu_retina_triggered_tests is now triggered by mac_gpu instead.

BUG=351499
TBR=bsalomon@google.com,jamesr@chromium.org,piman@chromium.org

Review URL: https://codereview.chromium.org/195573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256490 0039d316-1c4b-4281-b951-d872f2087c98
2014-03-12 09:43:15 +00:00
phajdan.jr@chromium.org
1c649fa48d Convert most Chromium presubmit files to use new multiple-tryserver-compatible protocol
BUG=334892
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/194903007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256318 0039d316-1c4b-4281-b951-d872f2087c98
2014-03-11 21:45:27 +00:00
danakj@chromium.org
94be7f7013 Add GPU bots to the default set of try jobs in ui/gl/ and gpu/.
R=kbr@chromium.org, piman@chromium.org, piman
BUG=270918

Review URL: https://codereview.chromium.org/151593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248541 0039d316-1c4b-4281-b951-d872f2087c98
2014-02-03 19:06:45 +00:00