129bb5341c
This CL scopes the ARIA Notify API to accept only a string `announcement` and a ax::mojom::AriaNotificationPriority `priority` (values of which can be "high" or "normal", with "normal" being the default value). This API shape will serve as V1 of the feature, as agreed upon by the ARIA working group: https://github.com/w3c/aria/issues/2426 Future versions of the API may include properties of `interrupt` and `notification_id` (soon to be renamed `type`). More information about these properties, and the feature in general, can be found in the explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/Accessibility/AriaNotify/explainer.md This CL gates the use of `interrupt` and `notification_id` behind the "AriaNotifyV2" feature flag. As part of the process of serializing the ARIA notification attributes, `notification_id` will be passed to the AXNodeData as an empty string and `interrupt` will be passed as kNone unless the AriaNotifyV2 flag is enabled. We cannot even read the value of the `notification_id` or `interrupt` properties that may be passed by the web author as a part of V1 -- if we don't avoid reading the properties, then feature detection for those properties will be enabled. See more: https://github.com/w3c/aria/issues/2426#issuecomment-2634700360 This CL also adds new tests that use the AriaNotifyV2 feature flag. AX-Relnotes: This feature is behind a feature flag so it should not impact the experience of users who are not enabling the flag. Bug: 326277796 Change-Id: Id72dab40aea10daab3449bd32d2ab99a3746d76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6306426 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Evelynn Kaplan <evelynn.kaplan@microsoft.com> Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1431762}
v8
@ 5fb698168a
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.