It seems that this is where it is supposed to live and it was erroneously added to PrintWebViewHelper.
BUG=67091, 92045, 91880, 92000, 92218, 95905
TEST=NONE
Review URL: http://codereview.chromium.org/8201027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105688 0039d316-1c4b-4281-b951-d872f2087c98
This is necessary for Chrome Frame, which doesn't load extensions.
We're relying on the Profile being created (and thus loading extensions) before the session is restored on startup. And as a result, we don't need to watch for NOTIFICATION_EXTENSIONS_READY anymore, nor test that.
TBR=aa
BUG=99450
TEST=NetworkDelayListener unit tests pass, and chrome_frame_net_tests don't time out
Review URL: http://codereview.chromium.org/8314005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105687 0039d316-1c4b-4281-b951-d872f2087c98
[Relanding 105659. This will re-cause failures in chrome_frame_net_tests, to be fixed in the next CL.]
Add a webRequest extension API permission, used to tell when an extension uses that API and therefore wants to delay startup. Use the "tabs" warning for it.
Also clean up the UserScriptListener, which never released requests individually and so doesn't need to track them individually either, and makes the RequestQueue handle bulk releases by its delegates instead.
BUG=99450
TEST=unit_tests.exe --gtest_filter=NetworkDelayListenerTest.*
Review URL: http://codereview.chromium.org/8205001TBR=pam@chromium.org
Review URL: http://codereview.chromium.org/8296017TBR=pam@chromium.org
Review URL: http://codereview.chromium.org/8308003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105686 0039d316-1c4b-4281-b951-d872f2087c98
Use #!/usr/bin/env python to locate python, rather than #!/usr/bin/python, for updating on expectations on Cygwin/msysgit
R=cmp@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8314002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105685 0039d316-1c4b-4281-b951-d872f2087c98
Comment 2 on the bug has a theory why this might be. Please get these
tests enabled again quickly.
BUG=100467
TEST=commit queue goes berserk less often.
Review URL: http://codereview.chromium.org/8310003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105684 0039d316-1c4b-4281-b951-d872f2087c98
The other being DebugInfoGetter so that syncer can call this class to give the debug information in protobuf format.
The implementation of this class uses a queue. And it limits the number of events to 6. if more than 6 events are in the queue we delete the oldest event.
Also we send this information to the server only once per sync cycle during the first getudpdates command.
also includes the unit test.
TBR=cmp@chromium.org for the SI relaxation.
BUG=100058
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105667
Review URL: http://codereview.chromium.org/8189003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105683 0039d316-1c4b-4281-b951-d872f2087c98
The other being DebugInfoGetter so that syncer can call this class to give the debug information in protobuf format.
The implementation of this class uses a queue. And it limits the number of events to 6. if more than 6 events are in the queue we delete the oldest event.
Also we send this information to the server only once per sync cycle during the first getudpdates command.
also includes the unit test.
BUG=100058
TEST=
Review URL: http://codereview.chromium.org/8189003TBR=lipalani@chromium.org
Review URL: http://codereview.chromium.org/8313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105680 0039d316-1c4b-4281-b951-d872f2087c98
1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs.
2. Encapsulate the private, persistent data for the InMemoryURLIndex in a new class, URLIndexPrivateData.
3. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available.
4. Correctly handle the adding and removing of page title words when a URL change is detected.
5. Move most of the support types, including the new URLIndexPrivateData class, into a new file, in_memory_url_index_types.h.
6. Replace static class member functions with non-friend, non-class functions for better flexibility.
7. Move convenience types out from InMemoryURLIndex class up into history namespace.
8. Rename convenience types to generalize their intent.
9. Other small cleanups.
BUG=96731, 92718
TEST=Unit tests updated.
TBR=atwilson,brettw
Previously reviewed and LG'ed as http://codereview.chromium.org/8120004/.
Review URL: http://codereview.chromium.org/8291005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105678 0039d316-1c4b-4281-b951-d872f2087c98
When stop is called later on the same datatype we dont call StopAssociationAsync any more (which would be implemented in the datatypes' sub class) if the datatype never started succesfully. (The assertion was in this code because we were calling StopAssociationAsync on a datatype that failed to start).
BUG=100057
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105668
Review URL: http://codereview.chromium.org/8305006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105676 0039d316-1c4b-4281-b951-d872f2087c98
When stop is called later on the same datatype we dont call StopAssociationAsync any more (which would be implemented in the datatypes' sub class) if the datatype never started succesfully. (The assertion was in this code because we were calling StopAssociationAsync on a datatype that failed to start).
BUG=100057
TEST=
Review URL: http://codereview.chromium.org/8305006TBR=lipalani@chromium.org
Review URL: http://codereview.chromium.org/8312001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105674 0039d316-1c4b-4281-b951-d872f2087c98
InstallerState::RemoveOldVersionDirectories now tells its DeleteTreeWorkItem instances to ignore failures. Deleting the old version dirs is a best-effort thing. Should one fail to be deletable on account of a file or directory being in use (other than the key files: chrome.dll, npchrome_frame.dll, and chrome_frame_helper.exe), the installer will no go on its merry way rather than trying to un-do the delete (which is error-prone to say the least).
Also, during installation, don't make success of the install contingent on being able to delete old_chrome.exe. Basically for the same reasons. If we can't delete it because it's in use by someone/thing, just leave it there. It'll be cleaned up on a later install, or when new_chrome.exe is later swapped into place. This may reduce our INSTALL_FAILED errors.
BUG=100218
TEST=see bug
Review URL: http://codereview.chromium.org/8299008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105671 0039d316-1c4b-4281-b951-d872f2087c98
When stop is called later on the same datatype we dont call StopAssociationAsync any more (which would be implemented in the datatypes' sub class) if the datatype never started succesfully. (The assertion was in this code because we were calling StopAssociationAsync on a datatype that failed to start).
BUG=100057
TEST=
Review URL: http://codereview.chromium.org/8305006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105668 0039d316-1c4b-4281-b951-d872f2087c98
The other being DebugInfoGetter so that syncer can call this class to give the debug information in protobuf format.
The implementation of this class uses a queue. And it limits the number of events to 6. if more than 6 events are in the queue we delete the oldest event.
Also we send this information to the server only once per sync cycle during the first getudpdates command.
also includes the unit test.
BUG=100058
TEST=
Review URL: http://codereview.chromium.org/8189003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105667 0039d316-1c4b-4281-b951-d872f2087c98
preview when we shouldn't. Here's the sequence that would trigger it:
1. focus the omnibox (which triggers loading the InstantLoader).
2. Type in a string that'll autocomplete to a url.
3. Arrow over a search suggestion to a non-search entry.
4. Press enter.
When you arrow over a non-search we'll hide (what was
DestroyPreviewContentsAndLeaveActive) the preview. But if between
steps 3 and 4 we get a response back from the page with suggestions
we'll set displayable_ to true and think everything is up to
date. This leads to IsCurrent returning true when it isn't.
To fix this I've nuked is_active(), which was a bit confusing anyway
and added is_out_date_ (still confusing, but at least it's private).
BUG=100368
TEST=covered by test, see bug for test scenario.
R=sreeram@chromium.org,ben@chromium.orgTBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8298005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105664 0039d316-1c4b-4281-b951-d872f2087c98
Handles two cases: Last window close (-> shuts download browser), and
last incognito window in an incognito profile (-> cancels downloads
on that profile).
Note that this doesn't cover the macintosh, which goes through different
code (http://crbug.com/88419) and the warning for incognito close is not
ideal (http://crbug.com/88421). This CL includes some modularization
to make resolving those issues easier.
BUG=61257
Review URL: http://codereview.chromium.org/7466033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105662 0039d316-1c4b-4281-b951-d872f2087c98
[Failures in chrome_frame tests]
Add a webRequest extension API permission, used to tell when an extension uses that API and therefore wants to delay startup. Use the "tabs" warning for it.
Also clean up the UserScriptListener, which never released requests individually and so doesn't need to track them individually either, and makes the RequestQueue handle bulk releases by its delegates instead.
BUG=99450
TEST=unit_tests.exe --gtest_filter=NetworkDelayListenerTest.*
Review URL: http://codereview.chromium.org/8205001TBR=pam@chromium.org
Review URL: http://codereview.chromium.org/8296017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105661 0039d316-1c4b-4281-b951-d872f2087c98
Add a webRequest extension API permission, used to tell when an extension uses that API and therefore wants to delay startup. Use the "tabs" warning for it.
Also clean up the UserScriptListener, which never released requests individually and so doesn't need to track them individually either, and makes the RequestQueue handle bulk releases by its delegates instead.
BUG=99450
TEST=unit_tests.exe --gtest_filter=NetworkDelayListenerTest.*
Review URL: http://codereview.chromium.org/8205001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105659 0039d316-1c4b-4281-b951-d872f2087c98
When the unittest module loads TestCases, it loads all attributes that begin
with 'test', even the ones that are not functions. Fix it.
Also, private member vars should be prefixed by _.
TBR=rohitbm@chromium.orgR=rohitbm@chromium.org
BUG=
TEST=desktopui_PyAutoFunctionalTests runs on chromeos
Review URL: http://codereview.chromium.org/8302022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105650 0039d316-1c4b-4281-b951-d872f2087c98
When a site enters fullscreen a bubble should appear, both to give the user the option to exit fullscreen and to inform them that the site has entered fullscreen. This patch implements that behaviour on Windows and Mac.
XIB changes: (FullScreenExitBubble.xib)
* Added explanatory text field.
* Added "allow" and "deny" buttons.
* Changed from View into Window.
BUG=73923
TEST=
Review URL: http://codereview.chromium.org/7740044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105649 0039d316-1c4b-4281-b951-d872f2087c98
BUG=99403
TEST=sync_integration_tests, manually ensure on first time sync open tabs is
an option in customize for an account with sync_tabs true.
Review URL: http://codereview.chromium.org/8295017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105636 0039d316-1c4b-4281-b951-d872f2087c98
This caused attempts to encrypt everything on first time sync to fail due to
stepping to done triggering the window to close which gets handled as
if the user cancelled setup (clearing encryption_pending_).
BUG=90063
TEST=manual
Review URL: http://codereview.chromium.org/8303004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105635 0039d316-1c4b-4281-b951-d872f2087c98
BUG=chromium-os:18103
TEST=See issue. Test network icons in status area, network menu, and internet options page, 3g in particular.
Review URL: http://codereview.chromium.org/8207009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105629 0039d316-1c4b-4281-b951-d872f2087c98
