- Try to make the tasks more general purpose.
* Add mechanism to switch output directories. Most
tasks will work with this value.
* Add tasks to run tests for the current file or directory
instead of pre-determined targets.
- Try to simplify it.
* Remove some parameters which are defaults
* Move pattern matches to top-level, to avoid duplicates.
Change-Id: Ifff15bc264be510c0859e4adcce7b996349ac343
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402189
Reviewed-by: Chase Phillips <cmp@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805872}
CorbAllowlistAlsoAppliesToOorCors (aka CORS-for-content-scripts) has
been shipping to the stable channel with Chrome85 since Aug 25th (~2
weeks ago). There have been just a handful of allowlisting requests so
far - therefore, it seems okay to declare that this change has
successfully shipped to the stable channel.
This CL transitions enabling CorbAllowlistAlsoAppliesToOorCors away from
1) fieldtrial_testing_config.json and 2) field trial config (this
includes preserving/copying the allowlisted extensions from
site_isolation/data/CorsAndCorbAllowlist.gcl to
//extensions/browser/url_loader_factory_manager.cc).
After this CL we still retain an ability to allowlist extensions:
1. Via field trial config (affecting Chrome versions prior to this CL
- Chrome 85, Chrome 86 and a little bit of Chrome 87)
2. Via the hardcoded allowlist in
//extensions/browser/url_loader_factory_manager.cc (although this
ability will go away soon - after https://crrev.com/c/2388709).
This CL unblocks the following follow-up CLs:
1. Adding |max_version| to the field trial config
(google3 - cl/330527651)
2. Starting deprecation of the allowlist
(chromium3 - https://crrev.com/c/2388709)
Bug: 920638
Change-Id: I635eb0777dc83a7ad448f57b9de388ae071e0c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359393
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805490}
- Mention more platforms at the top
- Be better about escaping underscores
- Remove some old gyp references
- Remove some no-longer-needed explicit clang opt-ins
Change-Id: I0e604a12ef67f3ae4d40cb06eac713305bdaf726
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401806
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805441}
Remove usage of DISALLOW_COPY_AND_ASSIGN from mojo documentation.
styleguide/c++/c++-dos-and-donts.md:
'DISALLOW_COPY_AND_ASSIGN` is deprecated. For
a non-copyable/movable type, delete the copy operations (the move
operations will be implicitly deleted); otherwise, declare either
copy operations, move operations, or both (a non-declared pair
will be implicitly deleted). Always declare or delete both
construction and assignment, not just one (which can introduce
subtle bugs).
Change-Id: Iad752e093643a0f964056c1d4b6714cea724728f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398069
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#805164}
This honors blink feature status ("test", "experimental", "stable")
in third_party/blink/renderer/platform/runtime_enabled_features.json5,
overriding of the default status of the corresponding chromium features,
unless the status of the chromium feature is overridden by finch trial
or command line switches.
This resolves the following problems of blink features with
status:"test", status"experimental", status:"stable" when the
corresponding chromium feature is disabled:
1. unexpected disabling of the blink feature for web tests
2. unexpected enabling of a blink feature for unit tests (in which case
the blink feature should not have a status).
This CL only affects how blink features with status are enabled with
--enable-experimental-web-platform-features
(or chrome://flags/#enable-experimental-web-platform-features)
--enable-blink-test-features when the corresponding chromium feature is
disabled by default.
This doesn't affect
1. finch experiments (which still controls the blink features through
the chromium features);
2. other command line flags that affect blink features (either directly
or indirectly through chromium features);
3. the priority relationship among 1 and 2 and the changed factors
mentioned above.
The features that will be affected by this CL have been prepared in
either of the following methods (tracked by crbug.com/1121839, based
on feedbacks in https://docs.google.com/spreadsheets/d/1DAtdbGy7XZCC_1_IXHXZKx568pw0eDlVETCtJBexqZc/edit#gid=0):
a) For features that should be enabled for web tests but were not
because of the chromium feature disabled by default, temporarily
explicitly enable it in content/child/runtime_features.cc.
An example is crrev.com/c/2380213.
These changes are removed in this CL.
b) For features that are not ready to be enabled for web tests, or are
not meaningful to be enabled for web tests (e.g. the feature is
implemented at both chromium side and blink side), the blink status
is removed to let the chromium feature fully control the blink
feature. An example is crrev.com/c/2376067.
Bug: 1048656, 1121839
Change-Id: I8b2f15e30767dce9212097f79c8c07a373af892d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375886
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803712}
Renames CONTEXT_MESSAGE_BOX_BODY_TEXT => CONTEXT_DIALOG_BODY_TEXT.
Replaces ChromeTextContext::CONTEXT_DIALOG_BODY_TEXT_LARGE uses
CONTEXT_DIALOG_BODY_TEXT. For consistency with the rename above,
CONTEXT_BODY_TEXT_SMALL is renamed CONTEXT_DIALOG_BODY_TEXT_SMALL.
What this functionally means is that CONTEXT_MESSAGE_BODY_TEXT takes on
the old style of CONTEXT_DIALOG_BODY_TEXT_LARGE, so one style of dialog
text is dropped and the new style can be used from views code. As a
result dialog body text looks more uniform.
Bug: 1122602
Change-Id: Ide5650b02f06a1925b441302e46815cfa73a3d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381299
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802827}
This change updates the responsibilities for the performance regression
sheriffs given the new automated process for triage and bisection. This
removes the need to proactively poll the alerts page in the Chromperf
Dashboard, and instead moves the sheriffing rotation to a reactive model
handling Monorail issues.
R=tdresser@chromium.org
Change-Id: Icb6e58052bd1c7480b57c341438a23b560120000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378408
Auto-Submit: Dean Berris <dberris@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802265}
Updates the GPU pixel wrangling documentation to point out
//content/test/gpu/trim_culprit_cls.py as a potentially useful tool and
updates the script's documentation to include example usages.
Bug: 1120104
Change-Id: I2026e994408097bfee8b94984dc89e8110afba0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373391
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801232}
No change to logic, only docs. This updates java_cpp_strings docs:
* The first paragraph incorrectly stated this uses comments to
determine the Java class name. This corrects that statement.
* Merges the two GN steps into one, explains it's a best practice to
add this to an android_library (or create a new one if there is
none), and recommends private visibility for :java_switches_srcjar.
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I4ae45da15f7db02a9d4c101de1a23c40f154b464
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369652
Commit-Queue: Bo <boliu@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800838}
When building Chromium for Chromium OS for Linux (linux-chromeos) there
is a choice of cros_boards, the local system and the Chromium sysroot.
At the moment linux-chromeos builds with the Chromium sysroot won't
run browser_tests on modern Debian systems due to an old version of
libffi. Since developer testing builds don't need to be protable anyway,
the Chromium sysroot is unnecessary. Document how to use the local
system as a solution to this.
Bug: chromium:1119849
Change-Id: Id5f7a41051367ae1f98cf48b1258680f6e11c9e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367736
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#800392}
This adds an optional --isolated=outdir=PATH flag to the
test executable API; this gives the test runners a stable path
to the output directory from a swarming task, so that we can key
other files off of it without needing to pass them all explicitly
via the command line.
This also adds the arg to the isolated_script wrapper, so that we
those types of tests can handle the flag (by ignoring it for now).
We may need to work through the other cases (like gtest tests)
individually, which will be done in subsequent CLs.
Bug: 816629
Change-Id: Ibff6a47544bf94af5d7693a8446dfb669351cc07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358604
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799378}
There is already some debug output available for origin trials,
which can be enabled with:
% chrome --vmodule=origin_trial_context=1 --enable-logging=stderr
This CL adds a bit more human-readable debug output, plus it adds
the appropriate flags to the documentation, so it is easier to find.
TL/DR now:
% chrome --vmodule=trial_token=2,origin_trial_context=1 --enable-logging=stderr
Change-Id: I27d08055f460287e02531886593c696e700bbe3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347385
Reviewed-by: Jason Chase <chasej@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799308}
Thanks to an earlier CL (https://crrev.com/c/2274591), this CL can
modify CorsURLLoaderFactory::IsValidRequest to enforce the presence of
|request_initiator_site_lock| (see the mojo::ReportBadMessage call in
the InitiatorLockCompatibility::kNoLock case). This is a big security
win - it means that the |request_initiator| can no longer be spoofed on
the Android platform (the CL modifies
//docs/security/compromised-renderers.md accordingly).
Bug: 1114906
Change-Id: I9e52ea33d8e929e31c1b4bfaf8fc85e5d2e185f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347195
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799116}
