I missed the fact that you need to explicitly press the "Start Review"
button with one of my recent CL's. I figure that there are other new
Chromium contributors who may have a similar experience -- so, updating
the checklist to explicitly call this out.
Change-Id: I96a9b97df38bd876b28bf5dc5c493baaf0f561fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636685
Commit-Queue: Howard Wolosky <Howard.Wolosky@microsoft.com>
Reviewed-by: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845249}
Under step #5 for manual testing. The developer doesn't have to test
these edge cases every time, but this bullet is a useful reminder to
think about what unexpected situations could break your code.
Bug: 1142952
Change-Id: Ie5cf5878bc555582e7ea0f8bdf425872b01e834f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506066
Reviewed-by: Zork <zork@chromium.org>
Commit-Queue: Zork <zork@chromium.org>
Auto-Submit: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822279}
This CL modifies commit_checklist.md to add a reminder to run gclient
sync -D after calling git rebase-update. Doing this removes third-
party build errors when trying to re-build after a rebase. This CL
also adds a tip about reverting CLs.
Bug: None
Change-Id: Id6a8072620a1162fbcdbe76b7f365b938287a785
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450698
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Auto-Submit: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814822}
This CL adds four miscellaneous tips to commit_checklist.md. Firstly,
use CL hashtags to group related CLs together. Secondly, don't use
chrome/OWNERS as a blanket stamp to land your CL if your CL makes
significant changes to subsystems. Thirdly, this CL adds a link to
instructions for building various targets. Fourthly, this CL adds a
tip about auto-submit.
Bug: None
Change-Id: Iaa3c51b8e2b4a49947061762f3a080a858f41fdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369619
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809018}
When working with downstream branches chained to upstream branches, it
helps to use `git rebase -i @{u}` twice to pull upstream changes into
the downstream branch. Expect a lot of merge conflicts when you do
this, as git is often not smart enough to figure out which change
happened more recently, and should take precedence.
Bug: None
Change-Id: Ic742439981d6d63e8d6bd1e10776fa920c88eb7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341387
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796561}
This CL responds to Mark Goldstein's comments on commit_checklist.md.
Mark Goldstein was my instructor for the Technical Writing One course,
and as a follow-up exercise, he asked us to include him as a reviewer
on a documentation-related change. This doc will also form the basis
of my upcoming talk "Life of a CL" at Chrome University, so I want to
make sure it's in tip-top form!
Bug: None
Change-Id: I0aeefcbb149929969f15d375f55ea2d2d44684f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045051
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743465}
Add step in commit_checklist.md for squashing commits into a single
commit on the local branch before running `git rebase-update` to avoid
commit-by-commit merge conflicts.
Bug: None
Change-Id: Icccf48d6fe739a3f20f8dd3f7d101ecdad46e3a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784162
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693427}
