Copies the existing final status histogram (currently split by
scheduled vs unscheduled requests) with a new histogram that is split by
scheduled with full delay, scheduled with reduced delay and unscheduled
requests. Similarly copies the NumRetriesBeforeSuccess histogram
(except without the unscheduled breakout as it is conditioned on
success).
These new histograms will provide additional detail on failure
frequencies, given that these frequencies are likely to differ greatly
for the different 'delay types'.
While these histograms are intended as replacements, the old histograms
are kept around for now to provide continuity of data and preserve
alerting. Eventually, we should remove the old metrics.
Bug: 325449807
Change-Id: Ibccfc0eddf985798ca0c2da2dfe7eb80a5c5d48d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221898
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1415794}
DatabaseOptions is getting too large for the "explicit out of line
constructor for complex types" presubmit. Adding a constructor to it
prevents it from being an aggregate type, which is how most of the
callers currently use it.
This Cl makes DatabaseOptions members private and adds builder-type
setters for each member. It also updates all callers, and adds an out of
line constructor.
A future improvement could be to add a passkey to the setters for
discouraged options.
Bug: None
Change-Id: I63562f43c8b290247878d194039487b240e958c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6216099
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Owners-Override: Gabriel Charette <gab@chromium.org>
Commit-Queue: Anthony Vallée-Dubois <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1414974}
The nonce parameter is used to identify requests in the Network Service
that should be blocked. These requests originate from a fenced frame,
and are blocked when JavaScript in the fenced frame has successfully
resolved a call to window.fence.disableUntrustedNetwork().
In most cases, the nonce provided for a transient IsolationInfo should
correspond to the relevant nonce for the current frame. This can be
fetched via the StorageKey, or the RenderFrameHostImpl (via
GetIsolationInfoForSubresources() or similar). If there is no frame
nonce available, then std::nullopt can be passed explicitly instead.
Previously, there was an additional CreateTransientWithNonce() function that served the same purpose. That has been merged into
CreateTransient(nonce) in this CL. This CL has no semantic changes, and is essentially a refactor. Existing bare calls to CreateTransient() now are passed std::nullopt, preserving existing behavior. As a follow-up, we'll identify transient IsolationInfos that could be using a frame's nonce instead of std::nullopt, and use that nonce instead.
To add the nonce parameter to existing CreateTransient() calls, I ran:
tools/git/mffr.py -d 'IsolationInfo::CreateTransient\(\)' 'IsolationInfo::CreateTransient(std::nullopt)'
To convert calls to CreateTransientWithNonce() to the new
CreateTransient(nonce) form, I ran:
tools/git/mffr.py -d 'IsolationInfo::CreateTransientWithNonce' 'IsolationInfo::CreateTransient'
I also ran a "git cl format" to fix line wrapping issues caused by
the new argument.
Bug: 377330892
Change-Id: I83b99b8ef9f19926b0d694066656bc315e1c4778
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102255
Reviewed-by: Xiaochen Zhou <xiaochenzh@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Andrew Verge <averge@chromium.org>
Reviewed-by: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1406164}
This CL removes the default value of the `tag` argument on the 2
`sql::Database` constructors, and updates all callers that didn't
explicitly pass a tag to do so.
As a convenience, this CL also defines a common tag for unit tests.
This will allow the implementation and monitoring of per-database
performance metrics (time to open, statement execution time, VMSteps,
etc) without the possibility of having some of the databases
uninstrumented. This is useful for diagnosing issues such as crbug.com/369635654 in the wild, and required for some performance investigations that we have in the pipeline.
The last step of this work item (asserting that the tag is correctly defined in histograms.xml variants) is implemented in https://chromium-review.googlesource.com/c/chromium/src/+/6055279.
Bug: 40949392
Change-Id: I6dec0fb86a5e7b98cd42ac3a9db18e23eaf9e9bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6039025
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Anthony Vallée-Dubois <anthonyvd@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1395446}
Now that the filtering ID features have all been removed (see
crrev.com/c/6011871, crrev.com/c/6019343 and crrev.com/c/6032178), this
is no longer a need to support the old format. This takes the form of
always requiring a filtering_id_max_bytes to be set (instead of it being
an optional type).
This should be mostly a no-op, but if there are any reports scheduled
and saved to disk from before the features were enabled (M128), they
will now be upgraded to the new format instead of still using the old
one.
Bug: 330744610
Change-Id: I2a28352a778afa2e60f81cdbe5da02183b7c2f94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6035826
Reviewed-by: Nan Lin <linnan@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1387019}
These were already used to reduce the delay down to 0-10 minutes in
crrev.com/c/4525396.
OBSOLETE_HISTOGRAMS=No longer needed as action was already taken using them.
Bug: 40259745
Change-Id: If40de31688cb40f5fa717f8c2c6d9b755a9d7afe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5933687
Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1369006}
Addresses ~14% of `-WUnsafe-buffer-usage` opt-out in `//content`.
This is a #cleanup.
The patch was initially partially generated by `./tool/clang/spanify`.
This patch applies conversions specifically to c-arrays in `//content`.
Although the `spanify` tool supports broader conversions, this change
intentionally focuses on c-arrays. Several manual fixes were made to
address anonymous struct issues and other edge cases encountered during
the conversion process.
Bug: 342213636, 40285824
Change-Id: I72666faa45a461ea27bb3608beeacc6c9fcd8a63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5824992
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1349804}
NOTREACHED() has turned [[noreturn]] so the former macro isn't needed
anymore.
This does not attempt to do a rewrite of any surrounding code, like:
if (!foo) {
NOTREACHED();
}
to CHECK(foo);
Those transforms take a non-trivial amount of time (and there are
thousands of instances). Cleanup can be left as an exercise for the
reader.
NO_IFTTT=No-op-rename migration.
Bug: 40580068
Change-Id: I068c5fdce9dc4c352d8bdd62bb3cd2c0a2d59659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5782602
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1342096}
This is now preferred. Also updates some Private Aggregation unittests
to match and some constexpr char arrays. Sql queries are also adapted
to use base::c_stringview instead of char*.
Change-Id: If96577d9cf67e49a60c54fa34b1762f8f2d60d0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5783696
Reviewed-by: Qingxin Wu <qingxinwu@google.com>
Reviewed-by: Nan Lin <linnan@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1341913}
This is a behavior-preserving refactor.
Note that the ComputeCborArrayOverheadLen() function does not strictly
need to be constexpr, in fact it's never called with constexpr values.
Fixed: 356298372
Change-Id: Ib376bfdf28cad6b38dc1390931fe20e0987ab014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5765899
Reviewed-by: Alex Turner <alexmt@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1339287}
Aligning on a single type enables us to avoid implicit and explicit
integer conversions. I think size_t is the natural choice because we
compare max_contributions_allowed against the size of containers.
Change-Id: Ib350e3fbf650f295dd6c6a77ee1c418a8021531d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5746930
Reviewed-by: Nan Lin <linnan@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1334935}
These were originally DCHECKs and were upgraded to CHECKs with
NotFatalUntil::M128 in crrev.com/c/5385557. We have not seen these be
triggered in the wild. Additionally, these are now fatal as M128 has
been reached; so, removing the argument should be a no-op.
Bug: 328089064
Change-Id: I287823f2501cc223c16858a282196cddfe4bb979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5725784
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1331734}
Original description:
> This CL adds more specific variants of the following histograms:
>
> * PrivacySandbox.AggregationService.ReportSender.HttpResponseOrNetErrorCode
> * PrivacySandbox.AggregationService.ReportSender.Status
>
> The new histograms break out "Status" and "HttpResponseOrNetErrorCode"
> information based on whether the request was not scheduled, or was
> originally scheduled for future delivery after a reduced delay or full
> delay.
>
> ```
> $ ./tools/metrics/histograms/print_histogram_names.py --diff origin/main
> 6 histograms added:
> PrivacySandbox.AggregationService.ReportSender.ScheduledWithFullDelay.HttpResponseOrNetErrorCode
> PrivacySandbox.AggregationService.ReportSender.ScheduledWithFullDelay.Status
> PrivacySandbox.AggregationService.ReportSender.ScheduledWithReducedDelay.HttpResponseOrNetErrorCode
> PrivacySandbox.AggregationService.ReportSender.ScheduledWithReducedDelay.Status
> PrivacySandbox.AggregationService.ReportSender.Unscheduled.HttpResponseOrNetErrorCode
> PrivacySandbox.AggregationService.ReportSender.Unscheduled.Status
> 0 histograms removed:
> ```
>
> Initially, I thought I'd replace the histograms with their more specific
> variants. However, I chose to keep the original histograms to avoid any
> monitoring disruptions. The "Status" histogram is a critical system
> health metric, so it's probably not a good idea to delete it without
> having a successor in place.
>
> Bug: 325449807
In <https://crrev.com/c/5598362>, I introduced two new death tests that
used `EXPECT_DEATH_IF_SUPPORTED`. These passed CQ, but started failing
on linux-chromeos-chrome after the CL was merged. It turns out that
under some GN args, the `CHECK` macro will discard log strings rather
than streaming them.
Patchset 1 is just a cherrypick of the original CL. I verified that it
fails on the linux-chromeos-chrome as described in issue 352185227.
This reland replaces the gtest-provided `EXPECT_DEATH_IF_SUPPORTED` with
the //base wrapper `EXPECT_CHECK_DEATH_WITH`, which accounts for whether
the `CHECK` macro will stream or discard its messages.
Bug: 325449807, 352185227
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: I1b1935c206ddb3b258b3229d888c3f614b3627e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5688555
Reviewed-by: Alex Turner <alexmt@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Nan Lin <linnan@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1326362}
This reverts commit bd8b4bff1d.
Reason for revert: This CL is causing the continuous test failures in:
https://ci.chromium.org/ui/test/chrome/ninja%3A%2F%2Fcontent%2Ftest%3Acontent_unittests%2FAggregatableReportTest.DelayTypeSerializeNulloptCrashes?q=VHASH%3A8c384ae133969dc8
Original change's description:
> Split histograms for HTTP error code and status
>
> This CL adds more specific variants of the following histograms:
>
> * PrivacySandbox.AggregationService.ReportSender.HttpResponseOrNetErrorCode
> * PrivacySandbox.AggregationService.ReportSender.Status
>
> The new histograms break out "Status" and "HttpResponseOrNetErrorCode"
> information based on whether the request was not scheduled, or was
> originally scheduled for future delivery after a reduced delay or full
> delay.
>
> ```
> $ ./tools/metrics/histograms/print_histogram_names.py --diff origin/main
> 6 histograms added:
> PrivacySandbox.AggregationService.ReportSender.ScheduledWithFullDelay.HttpResponseOrNetErrorCode
> PrivacySandbox.AggregationService.ReportSender.ScheduledWithFullDelay.Status
> PrivacySandbox.AggregationService.ReportSender.ScheduledWithReducedDelay.HttpResponseOrNetErrorCode
> PrivacySandbox.AggregationService.ReportSender.ScheduledWithReducedDelay.Status
> PrivacySandbox.AggregationService.ReportSender.Unscheduled.HttpResponseOrNetErrorCode
> PrivacySandbox.AggregationService.ReportSender.Unscheduled.Status
> 0 histograms removed:
> ```
>
> Initially, I thought I'd replace the histograms with their more specific
> variants. However, I chose to keep the original histograms to avoid any
> monitoring disruptions. The "Status" histogram is a critical system
> health metric, so it's probably not a good idea to delete it without
> having a successor in place.
>
> Bug: 325449807
> Change-Id: I0957bb00b4528b0d26b820e5e38b08eb65f904ef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5598362
> Reviewed-by: Nan Lin <linnan@chromium.org>
> Reviewed-by: Alex Turner <alexmt@chromium.org>
> Commit-Queue: Dan McArdle <dmcardle@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1325128}
Bug: 325449807, 352185227
Change-Id: I2b793c52039c6c60cb65ce8c4a49a6d1b2c5729f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689287
Owners-Override: Yoshisato Yanagisawa <yyanagisawa@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com>
Cr-Commit-Position: refs/heads/main@{#1325289}
This CL adds more specific variants of the following histograms:
* PrivacySandbox.AggregationService.ReportSender.HttpResponseOrNetErrorCode
* PrivacySandbox.AggregationService.ReportSender.Status
The new histograms break out "Status" and "HttpResponseOrNetErrorCode"
information based on whether the request was not scheduled, or was
originally scheduled for future delivery after a reduced delay or full
delay.
```
$ ./tools/metrics/histograms/print_histogram_names.py --diff origin/main
6 histograms added:
PrivacySandbox.AggregationService.ReportSender.ScheduledWithFullDelay.HttpResponseOrNetErrorCode
PrivacySandbox.AggregationService.ReportSender.ScheduledWithFullDelay.Status
PrivacySandbox.AggregationService.ReportSender.ScheduledWithReducedDelay.HttpResponseOrNetErrorCode
PrivacySandbox.AggregationService.ReportSender.ScheduledWithReducedDelay.Status
PrivacySandbox.AggregationService.ReportSender.Unscheduled.HttpResponseOrNetErrorCode
PrivacySandbox.AggregationService.ReportSender.Unscheduled.Status
0 histograms removed:
```
Initially, I thought I'd replace the histograms with their more specific
variants. However, I chose to keep the original histograms to avoid any
monitoring disruptions. The "Status" histogram is a critical system
health metric, so it's probably not a good idea to delete it without
having a successor in place.
Bug: 325449807
Change-Id: I0957bb00b4528b0d26b820e5e38b08eb65f904ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5598362
Reviewed-by: Nan Lin <linnan@chromium.org>
Reviewed-by: Alex Turner <alexmt@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1325128}
This CL validates all fields in `shared_info` except for `report_id`
which is non-deterministic. The `shared_info` is included in the
payload as a dictionary instead of a string for easier comparison.
Bug: 343870498
Change-Id: Ie2539f671d4dc68a53b052cff3322c57b930cc92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5605162
Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org>
Commit-Queue: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1312014}
This prevents a DCHECK crash in sql::Database::Poison(). It's unclear
whether Poison() should be so strict (see linked bug), but let's appease
it for the time being.
sql::Database::Poison() enforces that the only reason its internal `db_`
pointer could be null is when the database has been poisoned. However,
it turns out that attempting to open a directory as a database produces
exactly this scenario. As a workaround, we can change our database error
callback to not poison a database that is already closed.
Bug: 341947669
Change-Id: I2a214d5842cfde50242734dec1ae8ca61c264fcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5564404
Commit-Queue: Nan Lin <linnan@chromium.org>
Reviewed-by: Nan Lin <linnan@chromium.org>
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1309335}
This feature has been enabled by default since M119 and can now be
removed as we should not need the capability to disable this.
Bug: 40280536
Change-Id: If02558710c42e0e924c55cfe51c264f17c0bf312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538793
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301441}
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: Ibc66b8c440e4bcdef414e77fef4d9874d2ea9951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493800
Auto-Submit: Alison Gale <agale@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293330}
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: Iee14d10d544e9f0ec046117cc4ec8a55c427adc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469947
Reviewed-by: Darryl James <dljames@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290838}
Instead of specify explicitly for AWS and GCP, it's more extensible to
accept coordinator allowlist in the feature param. This also allows
coverage in the interop tests which can override the allowlist.
Change-Id: Ib0fb47205e0b7a9b1a5004df06e89678495c372d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5444731
Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Alex Turner <alexmt@chromium.org>
Commit-Queue: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290765}
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: Ieeb461e2d489e86fd50b87a2a0721a2be34520c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467317
Owners-Override: Alison Gale <agale@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290198}
Adds support for the new filtering_id field (added in
crrev.com/c/5420154) and the filtering_id_byte_size field. If a non-null
byte size is provided, filtering IDs are allowed to be non-null and will
be serialized to CBOR.
This support is not currently used by any API (but this will be added
for Private Aggregation in crrev.com/c/5443375). A kill switch is also
added to ignore all filtering IDs should disabling the functionality
be necessary.
Bug: 330744610
Change-Id: I1ddebdb999cad834745814c6403ee59432fcff4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5421490
Reviewed-by: Nan Lin <linnan@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1289971}
Adds the new field, but leaves it empty (nullptr) for all uses. Also
adds some CHECKs and ReportBadMessages to ensure the field is not used
until full support is added. This cl should be a no-op.
This cl has been separated out from the other cls to simplify review.
Full support is added in dependent cls (starting crrev.com/c/5421490).
Bug: 330744610
Change-Id: I4cb60a46c8498001ff280462fd07e8a31d352654
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5420154
Reviewed-by: Nan Lin <linnan@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Garrett Tanzer <gtanzer@chromium.org>
Reviewed-by: Qingxin Wu <qingxinwu@google.com>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/main@{#1286472}
