WebView no longer supports the android_webview_apk target for anything
other than automated testing. Keeping docs for building an unsupported
target is misleading, especially since android_webview_apk is not
actually a WebView.
This CL keeps the description about WebView, but removes the parts
about the test shell. It has a pointer to our team's chromium wiki page
for building and installing AOSP WebView.
This renames the section to "Build WebView" instead of "Build WebView
shell" to reflect the update.
BUG=703376
Review-Url: https://codereview.chromium.org/2770983007
Cr-Commit-Position: refs/heads/master@{#459221}
Now that 2.3 has been released, it will be the default version downloaded
by developers. //build/android/gradle/generate_gradle.py doesn't work
with 2.3 yet, and this should be reflected in our docs (we only support
2.2 currently).
BUG=700438
Review-Url: https://codereview.chromium.org/2758053002
Cr-Commit-Position: refs/heads/master@{#458060}
Added the method to callback.md because it's helpful yet I hadn't discovered it (callback_helpers.h is a more obscure file than callback.h or bind_helpers.h)
BUG=none
R=tzik@chromium.org
Review-Url: https://codereview.chromium.org/2755073002
Cr-Commit-Position: refs/heads/master@{#457939}
Reason for revert:
Breaks code editing in Android Studio, see http://crbug/700438 for more info.
Original issue's description:
> Android: Support Android Studio 2.3
>
> Also fixes excludes filters not working. For files whose directory is
> not fully included in the target, add those individually instead.
>
> BUG=700438
>
> Review-Url: https://codereview.chromium.org/2746103004
> Cr-Commit-Position: refs/heads/master@{#457093}
> Committed: f9fca7ca02TBR=wnwen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=700438
Review-Url: https://codereview.chromium.org/2758683003
Cr-Commit-Position: refs/heads/master@{#457866}
Also fixes excludes filters not working. For files whose directory is
not fully included in the target, add those individually instead.
BUG=700438
Review-Url: https://codereview.chromium.org/2746103004
Cr-Commit-Position: refs/heads/master@{#457093}
Fixes the original example, which resulted in an invalid conversion from
base::OnceCallback<void(int)> to base::Closure. Also adds a comment that
this usage is not yet supported.
BUG=none
R=tzik@chromium.org
Review-Url: https://codereview.chromium.org/2735903002
Cr-Commit-Position: refs/heads/master@{#456886}
The docs still need to be updated with more detailed instructions and
tips, but currently the docs don't even mention debugging in Android
Studio.
BUG=620034
Review-Url: https://codereview.chromium.org/2740353003
Cr-Commit-Position: refs/heads/master@{#456185}
This CL replaces the Clang 'c++-analyzer' Perl script with logic added to the Python wrapper script. This gives us the hooks we need to run analysis builds with "gomacc" (necessary for distributed builds) and gives us a convenient place to specify analyzer config flags which aren't exposed by scan-build.
Adds a warning suppression rule which prevents the analyzer from raising false positives from stdlib code (code w/namespace "std").
Other changes:
* Modify Goma portions of the GCC toolchain GNI to build paths to
the Clang static analyzer.
* Create an exception for ASM tool invocations, which don't play
well with the analysis command line flags.
* Removed 'scan-build' DEP.
BUG=687245
R=thakis@chromium.org,wez@chromium.org
Review-Url: https://codereview.chromium.org/2667853004
Cr-Commit-Position: refs/heads/master@{#456136}
This solves 2 problems:
1. Regenerating MANIFEST.json is failing on ToT (bug 697207)
- Now that MANIFEST.json is in .gitignore, regeneration works
2. Regenerating adds MANIFEST.json to MANIFEST.json (bug 683485)
- MANIFEST.json no longer shows up in MANIFEST.json
BUG=697207,666957,683485
Change-Id: I09987b66027e1f94055888c8ead58e7e40896d62
Reviewed-on: https://chromium-review.googlesource.com/447959
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#454454}
The Android Studio Style configuration does not match the checkstyle
configuration, which causes import order to be wrong. The configuration
is specified here:
//tools/android/checkstyle/chromium-style-5.0.xml
under ImportOrder.
This CL copies the style configuration from the Android repository,
but changes it so that it matches what we have in checkstyle.
It also updates the Android Studio documentation to point to the
new file, and adds the new content and the documentation to the
watchlist for Android Studio in addition to updating the error message
from checkstyle to now refer to the new style file.
BUG=None
Review-Url: https://codereview.chromium.org/2710573004
Cr-Commit-Position: refs/heads/master@{#453542}
Trying to prevent folks from creating large CLs in Options only to
discover we intend to deprecate it shortly. This codifies a few
assumptions we've been making about where new code should go.
BUG=none
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2719093002
Cr-Commit-Position: refs/heads/master@{#453304}
Remove the 'stable' virtual suite for origin trials layout tests. This
was redundant, as it had the identical expectations as the 'disabled'
virtual suite.
Rename/change the 'disabled' virtual suite to be based strictly on
runtime flags.
BUG=685788
Review-Url: https://codereview.chromium.org/2705643002
Cr-Commit-Position: refs/heads/master@{#452552}
Document how to build Chromium for devices, how to configure the
Code Signing Identity to use and which Mobile Provisioning Profile
are required to build Chromium and the tests for device.
BUG=694604
Review-Url: https://codereview.chromium.org/2712513003
Cr-Commit-Position: refs/heads/master@{#452459}
Many pages of testthewebforward.org now redirect, so replace links with
something appropriate from the new documentation.
Since the new documentation consistently says "web-platform-tests"
instead of "Web Platform Tests" and this is what folks like jgraham tend
to write as well, align our own usage with that.
BUG=657117
Review-Url: https://codereview.chromium.org/2696323003
Cr-Commit-Position: refs/heads/master@{#451045}
Move existing overview to accessibility/ subdirectory and make
accessibility.md a table of contents.
Migrate ChromeVox documentation to markdown.
Add new documentation for PATTS and BRLTTY.
Update accessibility LayoutTests documentation.
BUG=none
TBR=dtseng@chromium.org,nektar@chromium.org
NOTRY=true
Review-Url: https://codereview.chromium.org/2701603002
Cr-Commit-Position: refs/heads/master@{#450865}
Previous command-line specified --release which only worked if you
build under out/Release. New instructions make it clear how to
specify a custom one - uses my_build which GN docs use as an
example too.
BUG=none
TBR=tedchoc@chromium.org
Review-Url: https://codereview.chromium.org/2692273004
Cr-Commit-Position: refs/heads/master@{#450464}
This CL also adds a section about what kinds of changes
will be upstreamed, and the contributing guidelines for
web-platform-tests.
Review-Url: https://codereview.chromium.org/2681293004
Cr-Commit-Position: refs/heads/master@{#449798}
This CL
* Uses entry colors instead of window colors for the NTP
* Fixes a leak involving ScopedGObject
* Simplifies how background and border colors are calculated
* Adds the ".label" class only on versions of Gtk before 3.20
* Fixes text selection colors on one theme
* Updates the doc to reflect the new way colors are calculated
BUG=132847
Review-Url: https://codereview.chromium.org/2683953005
Cr-Commit-Position: refs/heads/master@{#449709}
