0
Commit Graph

90759 Commits

Author SHA1 Message Date
2c9f0def90 This adds support for encrypted ONC import to Chrome.
We now can import standalone ONC files that are encrypted by the
Spigots management app.

TBR=joaodasilva@chromium.org
BUG=chromium-os:19397
TEST=Ran new unit tests, imported encrypted ONC on device.



Review URL: http://codereview.chromium.org/8949056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117321 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 23:17:14 +00:00
98a4a4fedc Make ProfileImplIOData::Handle::GetResourceContext() imply LazyInitialize().
This is the next step to moving the AppCache and other storage related contexts into IOData.

BUG=85121
TEST=existing.

Review URL: http://codereview.chromium.org/8707002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117320 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 23:11:56 +00:00
968a51d530 fix panel window string resource ID
The panel window code was using IDS_NEW_TAB_APP_SETTINGS even though it had nothing to do with the new tab. The NEW_TAB_APP_SETTINGS string is no longer used for its original purpose, so I have deleted it, and replaced it with a new string specifically for the panel window wrench button use case.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/9147052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117319 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 23:10:45 +00:00
3a69ed589e More fine grained understanding of Omnibox navigation counts.
Review URL: http://codereview.chromium.org/9153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117318 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 23:10:32 +00:00
1b9718f6af Allow construction and assignment of one scoped_ptr from another if the types are convertible.
This allows for depth subtyping during a move operation on a scoped_ptr. With the additional constructor and operator=, we maintain move semantics but allow a scoped_ptr<A> to be constructed from a scoped_ptr<B> if B can be converted to A.

=DEFICIENCY=
This conversion sequence will _not_ implicitly work when calling an API. Specifically, if you have
void Func(scoped_ptr<Parent> p);

  scoped_ptr<Child> c;
  Func(c.Pass()); // COMPILE ERROR

This is a limitation of C++03 move emulation.  The workaround is Func(scoped_ptr<Parent>(c.Pass());

BUG=109026
TEST=new unittests

Review URL: http://codereview.chromium.org/8968032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117317 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 23:10:05 +00:00
8371c8ddec Fix cros
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117316 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 23:00:45 +00:00
b47fc32c30 Fixed lint errors
Review URL: http://codereview.chromium.org/9111026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117315 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 22:57:10 +00:00
6c058971b7 Don't pump the message loop in DeleteWhileInProgress at all.
This avoids a race condition where the request completes before the message
loop finishes its pending tasks.  The posted task starts the next experiment,
and so the assertion that only 1 experiment should be started fails.

R=eroman@chromium.org
BUG=88221
TEST=ConnectionTesterTest.DeleteWhileInProgress under drmemory


Review URL: http://codereview.chromium.org/9187017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117314 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 22:56:52 +00:00
5281db1d8b Set up the field trials before IOThread creation. We can't wait until after all the threads are created, because tasks on the IO thread reach out to IOThread which sets things up and depends on field trial values already being set. I've broken up the MetricsService initialization into two parts, one before the FILE thread starts and one after.
BUG=109863,109864
Review URL: http://codereview.chromium.org/9187011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117313 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 22:51:54 +00:00
b086ce0fdb Fix compile on linux_views.
BUG=109665
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/9192001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117312 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 22:51:03 +00:00
a71898fa70 Continuing to debug via the builders since there's no XP trybot.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117310 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 22:43:37 +00:00
522cc10d71 Reimplement ReceivedSyncMsgQueue::DispatchMessages
Implementation of IPC::SyncChannel::ReceivedSyncMsgQueue::DispatchMessages that
does not hold any messages in a local stack-frame's delayed_queue, which was
causing me to see an inbound sync message from a plugin not dispatched while
the renderer was waiting for replies from the plugin. This was causing the
plugin and renderer to deadlock waiting for each other.

BUG=108491
TEST=Run Pepperized O3D and observe for tab hangs
TEST=Run ipc_tests unittests


Review URL: http://codereview.chromium.org/9022038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117309 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 22:39:54 +00:00
76b2482e4b Coverity fix: Big parameter passed by value
CID=102492
TEST=none


Review URL: http://codereview.chromium.org/9007025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117308 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 22:27:38 +00:00
58d42fcf56 Move chrome/browser/ui/webui/print_preview* to chrome/browser/ui/webui/print_preview/
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9114062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117307 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 22:23:55 +00:00
d7d0b1aafa Attempt 2 at: Adds a trivial views based table implementation (only supports single
selection, even for grouptableview) and wires it up for hung renderer
and ssl client certificate.

Only change is adding OVERRIDEs.

BUG=109665
TEST=none
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/9187027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117305 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 22:20:39 +00:00
c5d58b7883 Add HttpHeaders to experimental.downloads.json
Review URL: http://codereview.chromium.org/9155014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117303 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 22:13:26 +00:00
6f2b506b0d [Coverity] Fix uninitialized member
CID=102890

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/9110022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117302 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 22:09:26 +00:00
7dddebc3fc Ensure one radio button is always checked in extension context menus.
This patch changes the behavior on all systems to match the behavior on Linux
ie. there is always exactly one item selected in a run of radio items.

This patch includes a unit test (ExtensionMenuManagerTest.SanitizeRadioButtons).

BUG=49808
TEST=On any OS but Linux, load an extension that has a context menu without
items selected by defuat. One item shuold be selected, but none are.

Review URL: http://codereview.chromium.org/8935016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117301 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 22:01:03 +00:00
e3beecbfd1 generalize suppression
TBR=anantha@chromium.org
BUG=69934
TEST=waterfall.sh

Review URL: http://codereview.chromium.org/9139030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117300 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:57:29 +00:00
920a2dd9a5 [uber page] Migrate remaining Personal options into Browser options.
- Move UI and backing code for account (cros), themes, import data.
- Move some code for the sync section that was missed in a previous migration.
- Minor reorganizations to match mocks.

BUG=107468,107484
Review URL: http://codereview.chromium.org/9181013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117299 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:47:04 +00:00
f32dd234f8 Continuing to debug with the XP builders.
(There aren't any XP/Vista trybots any more.)

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117298 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:41:12 +00:00
81375e87af Allow plugins to add rotate commands to Chrome context menus.
BUG=63249
TEST=manual

Review URL: http://codereview.chromium.org/9045007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117297 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:40:36 +00:00
298aabcd09 Remove FAILS for Aura ChromeMainTest builds
BUG=104650
TEST=Run ui_tests and ensure ChromeMainTest.* passes.


Review URL: http://codereview.chromium.org/9044013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117296 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:40:08 +00:00
f84374c390 Fix GLES2 Conformance test support
TEST=ran GLES2 Conformance tests
BUG=none

R=apatrick@chromium.org


Review URL: http://codereview.chromium.org/9166034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117295 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:36:24 +00:00
e64d2ac012 debug::Alias GetErrorCode in download_database.cc
BUG=96627

Review URL: http://codereview.chromium.org/9187008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117294 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:36:14 +00:00
6087662be3 Functions to return locations of various Chrome bundles.
TEST=None, code is currently not called.
BUG=None


Review URL: http://codereview.chromium.org/9147031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117293 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:35:51 +00:00
2511cef12c Try to fix the memory leak reports in g_restrictions.
This updates the Restrictions usage to be more consistent with other LazyInstances:
  - do not copy and assign
  - use static keyword
  - use LAZY_INSTANCE_INITIALIZER

BUG=106571
TEST=existing

Review URL: http://codereview.chromium.org/9027007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117292 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:32:09 +00:00
63f79e6602 Remove almost all remaining TOUCH_UIs.
TEST=ran tests
BUG=105046


Review URL: http://codereview.chromium.org/9078005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117291 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:31:54 +00:00
09351e3233 Win AcceleratedSurface always presents on the thread with it has affinity.
The D3D calls on the device all take a lock anyway so doing it as previously unnecessarily serialized the threads in the pool.

Review URL: http://codereview.chromium.org/9167036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117290 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:31:45 +00:00
e75eafc6ba Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117289 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:30:14 +00:00
5f8b0ac377 Move autocomplete_list.js from options and options2 to shared/js
BUG=NONE
TEST=Autocomplete suggestions on chrome://settings and chrome://chrome still work

Review URL: http://codereview.chromium.org/9168026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117288 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:29:58 +00:00
4ae1282297 Update libvpx revision in DEPS
This brings in these changes:

http://codereview.chromium.org/8501011 r109236 Suppress libvpx warning
http://codereview.chromium.org/8666017 r113567 Build libvpx on non-Mac POSIX platforms also, by reusing the linux config.
http://codereview.chromium.org/9185015 r117274 Compile libvpx code as PIC for all Linux targets

BUG= http://code.google.com/p/chromium/issues/detail?id=109318
TEST= sizes test should show chrome-textrel=0

R=jkoleszar@google.com

Review URL: http://codereview.chromium.org/9187016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117287 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:29:34 +00:00
da16a7aaf2 Enable logging from the client to the cloud.
BUG=106208

Review URL: http://codereview.chromium.org/9139023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117286 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:29:07 +00:00
7113171133 Detect sync server communication errors
This is part 2 of 3 in a series of patches to remove the unnecessary
SYNC_CYCLE_CONTINUATION sync cycle that follows every commit.

This patch adds infrastructure to report errors involving communication
with the sync server back to the SyncSession and SyncScheduler.

It modifies SyncerProtoUtil::PostClientToServerMessage to have it return
an error code describing why it failed.  This function's callers (all of
which are SyncerCommands) use the infrastructure added in the first
patch of this series to return the error value to SyncShare().  From
there, the return values are placed into the session's StatusController
object.  The method SyncSession::Succeeded() method provides an easy way
to determine if the anything went wrong with the current sync session,
and its response is based on the stored return values.

This change has no effect on the client's behaviour.  Although it gives
the client access to lots more information, the client does not use it
for any decision making.

BUG=94670
TEST=


Review URL: http://codereview.chromium.org/9158004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117285 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:27:58 +00:00
5667e12715 Enabled ui_tests:
-PPAPITest.URLLoader_BasicFilePOST
-PPAPITest.URLLoader_BasicFileRangePOST
now that PPB_FileIO is proxied.

BUG=none
TEST=Ran: ./ui_tests --gtest_filter="PPAPITest.URLLoader_BasicFile*" (linux)


Review URL: http://codereview.chromium.org/9187012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117284 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:27:45 +00:00
d2b1e07a6f Update thumbnail/list view buttons.
BUG=chromium-os:20161
TEST=Ctrl+m or ctrl+o or ctrl+s to open file manager/dialog, verify the view
buttons is the same as in http://folder/kenmoore/mocks/chromeos/Misc_2012/FileBrowser/VisualMaster_01-03-2012/


Review URL: http://codereview.chromium.org/9114040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117283 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:27:36 +00:00
ea58f2cb02 Mark FindInPageTest.CrashEscHandlers flaky.
BUG=109906
TEST=interactive_ui_tests

Review URL: http://codereview.chromium.org/9187018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117282 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 21:17:30 +00:00
f51eea3a42 Add an error message to the Javascript console when the NaCl plugin is blocked,
explaining why.
BUG=100466
TEST=manual

Review URL: http://codereview.chromium.org/9114057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117278 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 20:22:16 +00:00
d976c3555a Move RenderViewHostDelegateViewHelper to content.
Rename to be something less of a tongue-twister.

BUG=93804, 95573
TEST=no visible change

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117220

Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=117222

Review URL: http://codereview.chromium.org/9114047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117277 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 20:21:27 +00:00
6d6f83b1d9 Disabling use of custom build of nacl toolchains for chromeos as
the canned nacl toolchain should now function in the chromeos chroot.

BUG=None
TEST=trybots
R=mcgrathr@chromium.org
Review URL: http://codereview.chromium.org/9168036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117275 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 20:17:04 +00:00
b73889c90c Change cloud print dialog style in Aura builds.
This style more closely resembles other print dialogs and adds a close button.

BUG=109283,109084
TEST=Verify bugs.  Make sure dialogs can be closed.  Choosing "Sign-in" from the print preview UI in Chrome OS is NOT yet fixed.

Review URL: http://codereview.chromium.org/9147040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117272 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 20:13:23 +00:00
c142d8649a Increase size of cloud print dialog.
When cloud print displays the sign in page the window is too small.  Change the default size.


BUG=
TEST=Sign out.  Bring up the cloud print dialog (print preview -> select cloud print printer).  The window should be large enough for the sign in page to look ok.


Review URL: http://codereview.chromium.org/9139021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117271 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 20:11:03 +00:00
c94d254b2c suppress leak in sandbox::LoadSandboxTemplate()
BUG=109901
TBR=brettw@chromium.org
TEST=waterfall.sh

Review URL: http://codereview.chromium.org/9190015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117270 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 20:09:50 +00:00
518f4d9fdd Allow resizing a panel using chrome.windows.update() extension API.
BUG=108222
TEST=new extension api test added


Review URL: http://codereview.chromium.org/9181005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117269 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 20:07:50 +00:00
567be9397b Add CHECKs to find root cause of Windows-only crash.
Checks are temporary and would be in canary only.
For gory details please see original bug 108685.

BUG=109757

Review URL: http://codereview.chromium.org/9147039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117268 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 20:06:13 +00:00
9b9132764e GTK: More GSEALing.
BUG=79722
TEST=none


Review URL: http://codereview.chromium.org/9147044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117267 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 20:03:27 +00:00
e8b0ae43f7 Progressively refacto FirstRun class to first_run namespace(part 4).
BUG=108137
TEST=NONE


Review URL: http://codereview.chromium.org/9153008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117266 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 20:01:47 +00:00
321929bf60 Add debugging to trace down a problem on WinXP/Vista.
(We don't have trybots any longer for those platforms.)

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117265 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 20:01:20 +00:00
a079b1431c Ignore the following http server properties in prefs file
if they are corrupted.

- Spdy Settings, Alternate protocol

R=wtc
BUG=109789
TEST=unit tests

Review URL: http://codereview.chromium.org/9158025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117264 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 19:57:47 +00:00
36e5c06ea5 Synchronize access to TestAutomationResourceMessageFilter's requests_ map. This fixes a race condition in Chrome Frame's net tests that could cause URLRequestJobs to be created and destroyed on different threads. This in turn leaks PowerObservers from SystemMonitor's observer list, resulting in an observer list full of dangling pointers. In debug mode this may eventually dcheck if heap addresses are reused.
BUG=109733
TEST=chrome_frame_net_tests.exe does not DCHECK.
Review URL: http://codereview.chromium.org/9158012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117263 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-11 19:57:29 +00:00