We now can import standalone ONC files that are encrypted by the
Spigots management app.
TBR=joaodasilva@chromium.org
BUG=chromium-os:19397
TEST=Ran new unit tests, imported encrypted ONC on device.
Review URL: http://codereview.chromium.org/8949056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117321 0039d316-1c4b-4281-b951-d872f2087c98
This is the next step to moving the AppCache and other storage related contexts into IOData.
BUG=85121
TEST=existing.
Review URL: http://codereview.chromium.org/8707002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117320 0039d316-1c4b-4281-b951-d872f2087c98
The panel window code was using IDS_NEW_TAB_APP_SETTINGS even though it had nothing to do with the new tab. The NEW_TAB_APP_SETTINGS string is no longer used for its original purpose, so I have deleted it, and replaced it with a new string specifically for the panel window wrench button use case.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9147052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117319 0039d316-1c4b-4281-b951-d872f2087c98
This allows for depth subtyping during a move operation on a scoped_ptr. With the additional constructor and operator=, we maintain move semantics but allow a scoped_ptr<A> to be constructed from a scoped_ptr<B> if B can be converted to A.
=DEFICIENCY=
This conversion sequence will _not_ implicitly work when calling an API. Specifically, if you have
void Func(scoped_ptr<Parent> p);
scoped_ptr<Child> c;
Func(c.Pass()); // COMPILE ERROR
This is a limitation of C++03 move emulation. The workaround is Func(scoped_ptr<Parent>(c.Pass());
BUG=109026
TEST=new unittests
Review URL: http://codereview.chromium.org/8968032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117317 0039d316-1c4b-4281-b951-d872f2087c98
This avoids a race condition where the request completes before the message
loop finishes its pending tasks. The posted task starts the next experiment,
and so the assertion that only 1 experiment should be started fails.
R=eroman@chromium.org
BUG=88221
TEST=ConnectionTesterTest.DeleteWhileInProgress under drmemory
Review URL: http://codereview.chromium.org/9187017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117314 0039d316-1c4b-4281-b951-d872f2087c98
Implementation of IPC::SyncChannel::ReceivedSyncMsgQueue::DispatchMessages that
does not hold any messages in a local stack-frame's delayed_queue, which was
causing me to see an inbound sync message from a plugin not dispatched while
the renderer was waiting for replies from the plugin. This was causing the
plugin and renderer to deadlock waiting for each other.
BUG=108491
TEST=Run Pepperized O3D and observe for tab hangs
TEST=Run ipc_tests unittests
Review URL: http://codereview.chromium.org/9022038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117309 0039d316-1c4b-4281-b951-d872f2087c98
selection, even for grouptableview) and wires it up for hung renderer
and ssl client certificate.
Only change is adding OVERRIDEs.
BUG=109665
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/9187027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117305 0039d316-1c4b-4281-b951-d872f2087c98
This patch changes the behavior on all systems to match the behavior on Linux
ie. there is always exactly one item selected in a run of radio items.
This patch includes a unit test (ExtensionMenuManagerTest.SanitizeRadioButtons).
BUG=49808
TEST=On any OS but Linux, load an extension that has a context menu without
items selected by defuat. One item shuold be selected, but none are.
Review URL: http://codereview.chromium.org/8935016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117301 0039d316-1c4b-4281-b951-d872f2087c98
- Move UI and backing code for account (cros), themes, import data.
- Move some code for the sync section that was missed in a previous migration.
- Minor reorganizations to match mocks.
BUG=107468,107484
Review URL: http://codereview.chromium.org/9181013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117299 0039d316-1c4b-4281-b951-d872f2087c98
TEST=None, code is currently not called.
BUG=None
Review URL: http://codereview.chromium.org/9147031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117293 0039d316-1c4b-4281-b951-d872f2087c98
This updates the Restrictions usage to be more consistent with other LazyInstances:
- do not copy and assign
- use static keyword
- use LAZY_INSTANCE_INITIALIZER
BUG=106571
TEST=existing
Review URL: http://codereview.chromium.org/9027007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117292 0039d316-1c4b-4281-b951-d872f2087c98
The D3D calls on the device all take a lock anyway so doing it as previously unnecessarily serialized the threads in the pool.
Review URL: http://codereview.chromium.org/9167036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117290 0039d316-1c4b-4281-b951-d872f2087c98
BUG=NONE
TEST=Autocomplete suggestions on chrome://settings and chrome://chrome still work
Review URL: http://codereview.chromium.org/9168026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117288 0039d316-1c4b-4281-b951-d872f2087c98
This is part 2 of 3 in a series of patches to remove the unnecessary
SYNC_CYCLE_CONTINUATION sync cycle that follows every commit.
This patch adds infrastructure to report errors involving communication
with the sync server back to the SyncSession and SyncScheduler.
It modifies SyncerProtoUtil::PostClientToServerMessage to have it return
an error code describing why it failed. This function's callers (all of
which are SyncerCommands) use the infrastructure added in the first
patch of this series to return the error value to SyncShare(). From
there, the return values are placed into the session's StatusController
object. The method SyncSession::Succeeded() method provides an easy way
to determine if the anything went wrong with the current sync session,
and its response is based on the stored return values.
This change has no effect on the client's behaviour. Although it gives
the client access to lots more information, the client does not use it
for any decision making.
BUG=94670
TEST=
Review URL: http://codereview.chromium.org/9158004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117285 0039d316-1c4b-4281-b951-d872f2087c98
the canned nacl toolchain should now function in the chromeos chroot.
BUG=None
TEST=trybots
R=mcgrathr@chromium.org
Review URL: http://codereview.chromium.org/9168036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117275 0039d316-1c4b-4281-b951-d872f2087c98
This style more closely resembles other print dialogs and adds a close button.
BUG=109283,109084
TEST=Verify bugs. Make sure dialogs can be closed. Choosing "Sign-in" from the print preview UI in Chrome OS is NOT yet fixed.
Review URL: http://codereview.chromium.org/9147040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117272 0039d316-1c4b-4281-b951-d872f2087c98
When cloud print displays the sign in page the window is too small. Change the default size.
BUG=
TEST=Sign out. Bring up the cloud print dialog (print preview -> select cloud print printer). The window should be large enough for the sign in page to look ok.
Review URL: http://codereview.chromium.org/9139021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117271 0039d316-1c4b-4281-b951-d872f2087c98
Checks are temporary and would be in canary only.
For gory details please see original bug 108685.
BUG=109757
Review URL: http://codereview.chromium.org/9147039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117268 0039d316-1c4b-4281-b951-d872f2087c98
(We don't have trybots any longer for those platforms.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117265 0039d316-1c4b-4281-b951-d872f2087c98