This strips out a lot of dated content, focuses more
on practical usage, and significantly shortens the doc.
Less yawning for everyone!
BUG=None
TBR=benwells@chromium.org
Review URL: https://codereview.chromium.org/1641053003
Cr-Commit-Position: refs/heads/master@{#372063}
Reason for revert:
The change here assumes PendingScripts are separately allocated objects, an M50 change. This makes for more difficult backporting. Unnecessarily so.
Hence reverting and will reland a variation ( https://codereview.chromium.org/1642863002/ ) that works for older branches.
Original issue's description:
> Let notifyScriptLoadError() handle already detached ScriptLoaders.
>
> If a ScriptRunner has been disposed of already, allow ScriptLoaders
> to notify of their failure without asserting.
>
> R=haraken
> BUG=570012
>
> Committed: https://crrev.com/e7bf58190483dffac8e78506884170720165b198
> Cr-Commit-Position: refs/heads/master@{#371772}
TBR=haraken@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=570012
Review URL: https://codereview.chromium.org/1640263004
Cr-Commit-Position: refs/heads/master@{#372058}
Add WebFont.FontDisplayValue histogram that measures which fallback mode
is specified in font-display @font-face descriptor.
BUG=564447
Review URL: https://codereview.chromium.org/1647823003
Cr-Commit-Position: refs/heads/master@{#372055}
This change adds trace events to ThreadedDataProvider. Even though the
feature is still disabled by default, having trace events helps us
investigate the behavior locally.
BUG=581992, 277124
R=kinuko@chromium.org
Review URL: https://codereview.chromium.org/1640283004
Cr-Commit-Position: refs/heads/master@{#372054}
The image encoder runs on a background worker thread, which is not attached to Oilpan.
Thus CanvasAsyncBlobCreator::m_callback touched by the image encoder must use CrossThreadPersistent.
BUG=581877
Review URL: https://codereview.chromium.org/1641743005
Cr-Commit-Position: refs/heads/master@{#372053}
On iOS, we know whether the page has displayed insecure content; this CL
propagates that information to SecurityStateModel::VisibleSecurityState.
As far as I can tell, the resulting value isn't used by anything on the iOS
port, so this CL will not result in any visible change at the current time.
Review URL: https://codereview.chromium.org/1578273002
Cr-Commit-Position: refs/heads/master@{#372051}
The assert that is firing is very concerning and is still being
investigated.
BUG=577121
Review URL: https://codereview.chromium.org/1649443002
Cr-Commit-Position: refs/heads/master@{#372049}
This patch fixs the issue that Chrome URL bar's overlay in SurfaceFlinger
becomes fullscreen after pull to refresh. It will reduce memory bandwidth.
BUG=581626
Review URL: https://codereview.chromium.org/1638303002
Cr-Commit-Position: refs/heads/master@{#372048}
The CVDisplayLink is tied to a ScopedTypeRef data member of DisplayLinkMac.
However, there may be other references. Since there's no guarantee that
~DisplayLinkMac() will invoke the last CVDisplayLinkRelease(..) and clear
the callback automatically, clear it explicitly in ~DisplayLinkMac.
BUG=564780
Review URL: https://codereview.chromium.org/1637353002
Cr-Commit-Position: refs/heads/master@{#372046}
There are two element style recalc counters, one in Document, and one
in StyleResolver. The one in StyleResolver includes pseudo elements in
that count. We are unifying thesie counts keeping pseudo elements
included which means that the element recalc count will be higher for
tracing and the inspector, but unchanged for
internals.updateStyleAndReturnAffectedElementCount().
Also the StyleResolverStats is moved from StyleResolver to StyleEngine.
This means the stats will survive a clearResolver().
This change is motivated around item 6 and 9 in the design document for
crbug.com/401359.
R=dstockwell@chromium.org
BUG=401359
Review URL: https://codereview.chromium.org/1644543002
Cr-Commit-Position: refs/heads/master@{#372045}
Originally only sysex permission requests are exposed to the
content layer, but with this series of patches, all Web MIDI requests
will be exposed to the content layer so that each chromium embedder
can decide how to decide several permissions.
First of all, expose all requests outside Blink.
Changes for the permission service will follow as a separate patch.
BUG=535181
Review URL: https://codereview.chromium.org/1602703005
Cr-Commit-Position: refs/heads/master@{#372044}
As per the CPP style guide, variables declared constexpr or const, and whose
value is fixed for the duration of the program, are named with a leading "k"
followed by mixed case. Since objects don't have a constant value for the
duration of the program, refactor "kTestString" to "test_string".
Review URL: https://codereview.chromium.org/1649573002
Cr-Commit-Position: refs/heads/master@{#372042}
Notification type SIMPLE is for the web notification actually and it triggers some hacks which causes the problem (see the issue).
This patch changes the type to BASE_FORMAT without hacks.
BUG=b/26831435
Review URL: https://codereview.chromium.org/1640333003
Cr-Commit-Position: refs/heads/master@{#372039}
Currently dialog boxes do not take main status from the parent window.
Change this so that any child window does not become a main window.
Also, use the same trick that Cocoa bubbles use to avoid the traffic
lights dimming, but only do this for child windows that don't have their
own traffic lights.
BUG=543689
Review URL: https://codereview.chromium.org/1614663002
Cr-Commit-Position: refs/heads/master@{#372036}
We store a flag for finding ::before or ::after in
InvalidationSetFeatures, yet they are not added as features to
invalidation sets. That means we need to handle *::before as a universal
selector and cause subtree invalidations.
R=ericwilligers@chromium.org
BUG=581675
Review URL: https://codereview.chromium.org/1639133003
Cr-Commit-Position: refs/heads/master@{#372035}
cwallez@ pointed out the file was unmaintainable. Generate it from a
script instead. Effort was expended to minimize the initial changes. The
only changes are:
1. webgl_conformance_tests and webgl2_conformance_tests are swapped.
2. The D3D9 and GL versions of gles2_conform_test on the Windows testers
come first.
3. content_unittests was missed on several testers, and is now present.
This script will be generalized later to create the forthcoming
chromium.gpu.json.
BUG=542370
TBR=dpranke@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1647833004
Cr-Commit-Position: refs/heads/master@{#372033}
Before this patch, the serviceworker-internals shows a render process host ID in
"Renderer process ID" entry. This is not really helpful for blink/chromium
developers to debug errors related to renderer process activity.
After this patch, the internal page shows a real render process ID in the entry.
BUG=544760
Review URL: https://codereview.chromium.org/1645453002
Cr-Commit-Position: refs/heads/master@{#372030}
Oilpan is enabled on ToT, and is reading from TestExpectations and
has no Expectations file of its own (for now).
Mark the test as a flake and place it in TestExpectations "Oilpan"
area of that file.
TBR=haraken@chromium.org,ksakamoto@chromium.org
BUG=299010
NOPRESUBMIT=true
NOTRY=true
Review URL: https://codereview.chromium.org/1649653002
Cr-Commit-Position: refs/heads/master@{#372029}
Link header preloads were not working when sent over subresources.
This CL fixes that.
BUG=568025
Review URL: https://codereview.chromium.org/1627203002
Cr-Commit-Position: refs/heads/master@{#372024}
Culled inline hittesting was recently fixed [1] which exposed a
bug in LayoutInline::hitTestCulledInline where hit testing checked
for region intersection but returned a value based on region
containment. This bug was partially fixed in [2] for list-based
tests but a bug still existed for point-based tests.
This patch updates LayoutInline::hitTestCulledInline to check for
hit tests using region intersection, and return a value based on
region intersection (not containment). This was done by fixing a FIXME
to implement HitTestRequest::addNodeToListBasedTestResult for regions.
In addition, this patch changes the return value of
HitTestRequest::addNodeToListBasedTestResult to be an enum which
better explains its behavior.
[1] https://src.chromium.org/viewvc/blink?view=rev&revision=193729
[2] https://crrev.com/b489f7917175e2449c8f6d5874ab3ba0b7f31e88
BUG=579412
Review URL: https://codereview.chromium.org/1630793002
Cr-Commit-Position: refs/heads/master@{#372023}
- Tighten up he second argument of moveElementOutOfAncestor();
ContainerNode -> Element
- Add inDocument() check in makeInsertedContentRoundTrippableWithHTMLTreeBuild().
crrev.com/371774 fixed one such case. However we still might have such cases.
Add inDocument() check just in case in order to avoid future crashes.
BUG=537815
Review URL: https://codereview.chromium.org/1649513003
Cr-Commit-Position: refs/heads/master@{#372018}
Previously, the notes would be emitted in the iteration order over Fields,
which is an std::map<clang::FieldDecl*, FieldPoint>, which is ordered
by pointer value of FieldDecls. This would cause tests to flakily fail
on the Windows buildbots.
I'm not sure what caused these errors to start appearing right now,
but this should fix it.
BUG=581782
Review URL: https://codereview.chromium.org/1645613003
Cr-Commit-Position: refs/heads/master@{#372016}
Don't try to make VisibleSelection for elements of which content is not
selectable.
This CL has no user-visible behavior changes because
selectionFromContentsOfNode() created a null VisibleSelection before this CL.
BUG=477839
TEST=automated
Review URL: https://codereview.chromium.org/1647833002
Cr-Commit-Position: refs/heads/master@{#372015}
Re-enable the TestExpectations which was commented out for some
reason (no explanatory comment).
TBR=wkorman@chromium.org
BUG=581963,463358
NOPRESUBMIT=true
NOTRY=true
Review URL: https://codereview.chromium.org/1643863002
Cr-Commit-Position: refs/heads/master@{#372014}
