0
Commit Graph

8 Commits

Author SHA1 Message Date
Adam Rice
dfc22b6813 Undeprecate PPAPI WebSocket
Remove the deprecation console message and documentation comments for
PPAPI WebSocket. This is mostly a straightforward revert of
https://chromium-review.googlesource.com/c/chromium/src/+/1161712/
except that the enums have been left behind.

See
https://groups.google.com/a/chromium.org/d/msg/blink-dev/lWNvY56OAYs/9IoQx_ncDQAJ
for the background and justification for undoing the deprecation.

BUG=870586

Change-Id: I436e016b98e5e6224fca420ed769420f016bf6ac
Reviewed-on: https://chromium-review.googlesource.com/c/1402306
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622756}
2019-01-15 06:00:39 +00:00
Adam Rice
77d2955c74 Add a deprecation message for PPAPI WebSocket
Display a console message (in the context of the page) when a WebSocket
is created via the Pepper pp::WebSocket API.

Also add deprecation warnings to the documentation.

Tested by manual verification that the console message is shown when
the PPAPI WebSocket browser_tests are run.

Intent to deprecate thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/3NYHaxhRs14/XOdUJBvHAwAJ

BUG=870586

Change-Id: Ib4631d11cd94cecad6c42e6b3fb1fb81ffc2b7fb
Reviewed-on: https://chromium-review.googlesource.com/1161712
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581191}
2018-08-07 10:36:42 +00:00
avi
e029c4134f Switch to standard integer types in ppapi/.
BUG=138542
TBR=bbudge@chromium.org
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1548813002

Cr-Commit-Position: refs/heads/master@{#366718}
2015-12-23 06:46:20 +00:00
brettw@chromium.org
47a961c13f Add support for threadsafe completion callback factory.
This also makes the default be threadsafe. The old factory wasn't threadsafe even to the extent claimed in the header which was causing hangs in plugins

BUG=136284

Review URL: https://chromiumcodereview.appspot.com/10696157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146611 0039d316-1c4b-4281-b951-d872f2087c98
2012-07-13 19:18:52 +00:00
toyoshim@chromium.org
9c8b2fd3e1 WebSocket Pepper API: the second Close() should not return error code.
The WebSocket API defines that call to Close() on CLOSED state must do nothing
and cause no error. Currently Pepper API returns PP_ERROR_INPROGRESS. This
error code is confusing. We should return PP_OK here.

BUG=124866
TEST=browser_tests --gtest_filter='*WebSocket*'


Review URL: http://codereview.chromium.org/10169036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133894 0039d316-1c4b-4281-b951-d872f2087c98
2012-04-25 11:39:07 +00:00
jond@google.com
e0aa9cf5d4 Cleaned up documentation (standard documentation rewrite).
Review URL: http://codereview.chromium.org/9813011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129236 0039d316-1c4b-4281-b951-d872f2087c98
2012-03-27 19:11:49 +00:00
brettw@chromium.org
09af0f7661 Convert resources to take an instance key instead of an Instance*.
Review URL: https://chromiumcodereview.appspot.com/9381010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123795 0039d316-1c4b-4281-b951-d872f2087c98
2012-02-27 20:23:19 +00:00
toyoshim@chromium.org
5350822e0c WebSocket Pepper API: make the API out of dev
BUG=87310
TEST=ui_test


Review URL: http://codereview.chromium.org/9192009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119425 0039d316-1c4b-4281-b951-d872f2087c98
2012-01-27 09:42:41 +00:00