This only affects users of domains that the device is registered to for policy.
All other users are unaffected (EnableNSSSystemKeySlotForResourceContext is only called for USER_AFFILIATION_MANAGED)
For the affected users, this enables and uses the slot for
- client authentication for TSL (see ClientCertStoreChromeOS)
- client authentication for 802.1x networks
- listing/removing certificates on the settings page (see CertificateManager)
In a follow up, also the enterprise.platformKeys API will be updated.
Depends on:
https://codereview.chromium.org/426983002/https://codereview.chromium.org/428933002/
BUG=210525
R=mattm@chromium.org, rsleevi@chromium.org, willchan@chromium.org, xiyuan@chromium.org
Review URL: https://codereview.chromium.org/424523002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287175 0039d316-1c4b-4281-b951-d872f2087c98
Facilitates gapless playback across mp3 and aac. Relying on splice
frames and crossfading doesn't work in cases where the prior segment
signal diverges to null-padding values too quickly relative to the
newly appended segment.
BUG=395899
TEST=new unittests. llama-demo works.
Review URL: https://codereview.chromium.org/414603002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287174 0039d316-1c4b-4281-b951-d872f2087c98
Add case for PING frame in QuicFrame <<.
Merge internal change: 71908470
https://codereview.chromium.org/421963006/
Add methods to the QuicConnectionDebug visitor for tracking various
events which cause a QuicConnection to discard a packet.
Merge internal change: 71871881
https://codereview.chromium.org/421913015/
Change ReliableQuicStream::OnStreamFrame to return void since the method
already closes the connection when there are errors and callers are not
checking the return value
Make QuicStreamSequencer::OnStreamFrame return void instead of bool
since it is already closing the connect or resetting the stream when
there is an error.
Make two QUIC methods return void instead of bool.
Merge internal change: 71870242
https://codereview.chromium.org/420393004/
Create a visitor which can allow using both a trace... visitor and the
existing stats visitor.
Changed QuicConnection's QuicConnectionDebugVisitor to a scoped_ptr.
Merge internal change: 71863508
https://codereview.chromium.org/429453003/
Use 1350 byte QUIC packets by default.
Merge internal change: 71837432
https://codereview.chromium.org/427673005/
Improve debug logging of QUIC crypto handshake.
Merge internal change: 71833151
https://codereview.chromium.org/428803002/
Fix a bug in QuicUnackedPacketMap where an in flight packet could be
removed before being removed from bytes_in_flight.
Merge internal change: 71783653
https://codereview.chromium.org/422123005/
Inline the members of QUIC's ReceivedPacketInfo into QuicAckFrame now
that version 15 is gone.
Merge internal change: 71763611
https://codereview.chromium.org/424003002/
Remove FixRate congestion frame type.
Merge internal change: 71746617
https://codereview.chromium.org/424903002/
Remove QUIC_VERSION_15 now that Chrome Stable supports QUIC_VERSION_16.
Merge internal change: 71718286
https://codereview.chromium.org/413403008/R=rch@chromium.orgTBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/420313005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287168 0039d316-1c4b-4281-b951-d872f2087c98
Crash caused by RenderThreadImpl::OnMemoryPressure being called before
blink is initialized. Fix by skipping the crashing code if blink has not
been initialized.
BUG=398768
Review URL: https://codereview.chromium.org/437623003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287167 0039d316-1c4b-4281-b951-d872f2087c98
This is to help investigating a clusterfuzz crash, but should stay permanently to document the expectations.
BUG=399215
Review URL: https://codereview.chromium.org/432863003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287163 0039d316-1c4b-4281-b951-d872f2087c98
We use sendBeacon when enabled, otherwise fallback to "a ping".
BUG=398590
TEST=Manual
Review URL: https://codereview.chromium.org/426093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287161 0039d316-1c4b-4281-b951-d872f2087c98
Moving the extension api dependency from TtsPlatformImplChromeOs
to TtsExtensionEngine through TtsEngineDelegate.
This is part of an effort to move TTS to content.
BUG=347045
Review URL: https://codereview.chromium.org/434083003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287160 0039d316-1c4b-4281-b951-d872f2087c98
Part of extensions module componentization.
* Add a NotificationService for EventRouterTest
* Move the test data for ValueStoreFrontendTest
* The rest can move unchanged
BUG=397164
TEST=unit_tests, extensions_unittests
Review URL: https://codereview.chromium.org/435703002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287159 0039d316-1c4b-4281-b951-d872f2087c98
The desktop user manager is moving to using "person" instead of "user"
for all the things.
BUG=287883
Review URL: https://codereview.chromium.org/422063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287158 0039d316-1c4b-4281-b951-d872f2087c98
base::StringPrintf() fails quietly for strings larger than 32M,
so we could send and empty message to the DevTools front-end,
Let's split trace event notifications into chunks based
on the chunk size rather than the event count as we used to do.
BUG=
Review URL: https://codereview.chromium.org/434113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287157 0039d316-1c4b-4281-b951-d872f2087c98
The Notification provider API will reroute the notifications that are supposed to be sent to the Chrome Notification Center, so an app can get the notifications and have its own implementation of notification center.
BUG=397197
Review URL: https://codereview.chromium.org/356673003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287155 0039d316-1c4b-4281-b951-d872f2087c98
UserManagerBase contains common methods extracted from UserManagerImpl.
UserManagerImpl was renamed to ChromeUserManager and inherits UserManagerBase.
Misc refactoring:
* Move HasBrowserStarted() to SessionManager
* Add generic getter SessionManager::Get() which makes it possible for concrete clients don't depend on instance ownership like g_browser_process->platform_part()->SessionManager().
* Moved CRLSet code out of UserManager::UserLoggedIn(), to UserSessionManager.
BUG=387614
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286187
Review URL: https://codereview.chromium.org/417623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287153 0039d316-1c4b-4281-b951-d872f2087c98
The tests should only be disabled on Android to match the rule in
chrome_common.gypi.
BUG=none
Review URL: https://codereview.chromium.org/433133002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287144 0039d316-1c4b-4281-b951-d872f2087c98
- Show Gaia signin page instead of account picker.
- Pre-fill owner email in Gaia signin page.
- Show only the enrollment message in Gaia screen right panel.
- Show only a cancel button (in addition to Shutdown) at the bottom.
BUG=chromium:353050
TEST=manually test the signin page.
Review URL: https://codereview.chromium.org/426153003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287143 0039d316-1c4b-4281-b951-d872f2087c98
Removing the following unused RTCP messages:
* PLI
* NACK
* RPSI
* REMB
* BYE
* SDES
Deleted about 1200 lines of code. Tested with cast_unittests
and simulation shows no difference. Casting to a proper
receiver works as well.
BUG=393042
Review URL: https://codereview.chromium.org/427733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287142 0039d316-1c4b-4281-b951-d872f2087c98
This picks up the clang_warning_flags changes I landed earlier today.
For libvpx and icu, nothing else is in their rolls.
For hunspell and flac, one other change is also in the range.
hunspell: https://codereview.chromium.org/306793002/
flac: https://codereview.chromium.org/254083004/
Both look like they don't have an effect in practice, so I'm including them in
this roll. (NSS is currently preparing a real roll – crbug.com/396377 – so I'm
not rolling that at this point.)
BUG=none
TBR=hans
Review URL: https://codereview.chromium.org/440513002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287139 0039d316-1c4b-4281-b951-d872f2087c98
I missed a few targets that I though were deps'd in, but which (thankfully)
just live in the regular tree.
BUG=none
R=hans@chromium.org
TBR=cpu
Review URL: https://codereview.chromium.org/429793006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287137 0039d316-1c4b-4281-b951-d872f2087c98
This reverts commit aca48d3efd.
The original CL didn't cause issue 397656. It's caused by previous CLs and is
fixed by r286787. This CL simply reland the original CL.
TBR=gbillock@chromium.org
BUG=349211, 397656
TEST=Existing tests pass.
Review URL: https://codereview.chromium.org/435023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287136 0039d316-1c4b-4281-b951-d872f2087c98
Make the feedbackPrivate.getUserEmail not crash if
chromeos::UserManager has been initialized but no user is
logged in.
BUG=399749
Review URL: https://codereview.chromium.org/438963004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287135 0039d316-1c4b-4281-b951-d872f2087c98
This will allow development of the new design in parallel with the current implementation. The plan is to put new styles in local-ntp.css, which will be selected according to the class of the containing div.
This CL also adds a command-line flag, which will be tied to the Field trial from the server.
BUG=399388
TEST=using force-fieldtrials, confirmed that it works.
Review URL: https://codereview.chromium.org/435723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287131 0039d316-1c4b-4281-b951-d872f2087c98
Without this fix, if display info has changed while the settings page is running
the display info dialog will show stale data.
BUG=399690
R=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/436013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287130 0039d316-1c4b-4281-b951-d872f2087c98
This is to avoid a NOTREACHED in the RWHVBase implementation of that
virtual function. Actually fixing it will come soon.
BUG=368298,398282
Review URL: https://codereview.chromium.org/431183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287129 0039d316-1c4b-4281-b951-d872f2087c98
Tiles in chrome-search://local-ntp/local-ntp.html used to be arranged in
2 rows, and get reshuffled when screen resize causes number of columns
to change. However, detaching and reattaching elements with <iframe>s
cause the <iframe>s to reload, resulting in flickering.
This CL places all tiles in a single <div>, so no reshuffling is needed.
Instead, if number of columns change we resize the container width (and
also hide tiles beyond row 2), and let HTML layout place handle the
proper wrapping.
On blacklisting, we cannot compare identities between old tiles and new,
so a reload is necessary, which leads to some flickering.
Also tested for <body dir="RTL">
Additional cleanups:
- To show all tiles only after everything is loaded: using a Barrier
counter instead of looping on every load, which was O(n^2).
- Broke apart onMostVisitedChange() and added more comments.
- Removed unused CSS for fakebox and tiles resizing (JS does resizing now).
- Using CSS visibility instead of hidden to show #mv-tiles, so it take
up space and prevent content beneath tiles from jumping up briefly.
- Refactoring the logic to hide tiles during load and show all at once when
everything loads (or timeout occurs). Using new class Barrier to do this.
BUG=399388
Review URL: https://codereview.chromium.org/412073002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287120 0039d316-1c4b-4281-b951-d872f2087c98
Refactors the sync build target definition to fit the more common
pattern. The old target was defined differently in component and
non-component mode. This is brittle compared to the more standard
pattern of setting the target type to '<(component)'.
Introduces a shim target with type 'none'. Any target that depends on
this shim will link inherit its dependency on the two sync libraries.
A note on the history of this, for those who are interested:
This pattern was recommended during the original componentization of
sync almost two years ago. The pattern was, and still is, used by
content.gyp to ensure that dependency restrictions are being respected.
The difference with sync is that it doesn't actually make use of
fine-grained dependencies. It's not unusual to see a target depend on
conent_renderer, content_browser, or some other static library
sub-component of content. With sync, on the other hand, we have the
rule that other targets may depend only on the top level sync target.
Since no one aside from sync depends on sync_internal_api, sync_core, or
sync_api static library targets, and we have no intention of exposing
these sub-components outside of sync, there's no point in maintaining
them as separate targets.
BUG=397574
Review URL: https://codereview.chromium.org/425803013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287119 0039d316-1c4b-4281-b951-d872f2087c98
Currently if a user clicks thorough an invalid certificate, the decision is
remembered for the rest of the session, but after session restart, the decision
is forgotten. This implements a flag that remembers the decision for a specified
length of time across session restarts. Users can specific in the flag how long
decisions should be remembered, or they can specify that it should still be
reset on restart.
BUG=262615
NOTRY=true
Review URL: https://codereview.chromium.org/369703002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287118 0039d316-1c4b-4281-b951-d872f2087c98
Changes:
1) Run clang-format through source and header files.
2) Rename data member variables to use unix_hacker_ style.
3) Rename methods to use CamelCase style.
4) Rename file name to spell_check_client.
BUG=331299
Review URL: https://codereview.chromium.org/424183004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287117 0039d316-1c4b-4281-b951-d872f2087c98
When the user disables or enables crash reporting in the settings menu
this CL adds a restart message very similar to the hardware acceleration
setting also in the setting menu.
It also clears the Breakpad pipe environment variable when the user is disabling crash reporting, so that the restarted Chrome, which inherits the current environment variable, won't be able to connect to the crash handler service and report crashes.
BUG=380700
Review URL: https://codereview.chromium.org/424833008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287110 0039d316-1c4b-4281-b951-d872f2087c98
The polymer_load measurement is one we intend to use for measuring other
Polymer apps loading (e.g., paper-calculator, Topeka).
R=tonyg@chromium.org
Review URL: https://codereview.chromium.org/435043003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287109 0039d316-1c4b-4281-b951-d872f2087c98
