Some purely mechanical changes left over from r283694, now that
aura::test::EventGenerator has moved to ui::test in src/ui/events.
Moves aura/test/event_generator.* to event_generator_delegate_aura.*
Removes `using ui::test::EventGenerator;` declaration and redirects
includes that don't extend the delegate to include the ui/test
event_generator.h directly
BUG=378134
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285209
Review URL: https://codereview.chromium.org/406413004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285857 0039d316-1c4b-4281-b951-d872f2087c98
> Cleanups for aura/test/event_generator.h (resolve TODOs)
>
> Some purely mechanical changes left over from r283694, now that
> aura::test::EventGenerator has moved to ui::test in src/ui/events.
>
> Moves aura/test/event_generator.* to event_generator_delegate_aura.*
> Removes `using ui::test::EventGenerator;` declaration and redirects
> includes that don't extend the delegate to include the ui/test
> event_generator.h directly
>
> BUG=378134
>
> Review URL: https://codereview.chromium.org/406413004TBR=tapted@chromium.org
Review URL: https://codereview.chromium.org/413983006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285222 0039d316-1c4b-4281-b951-d872f2087c98
Some purely mechanical changes left over from r283694, now that
aura::test::EventGenerator has moved to ui::test in src/ui/events.
Moves aura/test/event_generator.* to event_generator_delegate_aura.*
Removes `using ui::test::EventGenerator;` declaration and redirects
includes that don't extend the delegate to include the ui/test
event_generator.h directly
BUG=378134
Review URL: https://codereview.chromium.org/406413004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285209 0039d316-1c4b-4281-b951-d872f2087c98
Some unittests get broken when --enable-text-input-focus-manager is enabled. Fixes those tests.
BUG=290701
TEST=Run unittests.
Review URL: https://codereview.chromium.org/334573004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277444 0039d316-1c4b-4281-b951-d872f2087c98
First part of a 2-sided patch to fix scroll-into-view with VK overscroll.
BUG=370592
Review URL: https://codereview.chromium.org/276483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270092 0039d316-1c4b-4281-b951-d872f2087c98
BUG=242933
Original commit broke ash_unittests for restoration of work area after login. With overscrolling, the size of the work area is no longer changes as the keyboard is shown or hidden.
Review URL: https://codereview.chromium.org/266513003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267267 0039d316-1c4b-4281-b951-d872f2087c98
in native code and in VK's javascript code through window.resizeTo
It sometimes creates conflict and cause strange animation issues.
In this CL, the window height logic in native side is removed.
The default window height is set to 0 and we expect javascript
will set the window to correct height.
If window is resized from a non zero height to another non
zeor height, we current dont do any animation.
BUG=363622
Review URL: https://codereview.chromium.org/240443006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265712 0039d316-1c4b-4281-b951-d872f2087c98
Other notable changes:
* Removed WindowTreeHostFactory as this is no longer necessary.
* Moved RootWindowTransformer to ash/host
* Removed Set/GetInsets which are no longer necessary (a code in SetInsets is now a part of
SetRootWindowTransformer)
* Added TransformerHelper that implements common behavior to transform root window for AshWindowTreeHost
* Added DEPS files
* Updated metro_viewer code to make sure it creates ash::AshRemoteWindowHostTree
A few more simplifications to come:
* Simplify RootWindowTransformer
* Eliminate EnvObserver in AshWindowTreeHostX11
I'll also work on DEPS reorg to make it more explicit under ash/
BUG=355771
TEST=No functional change. ui/aura/window_tree_host_x11_unittests has been moved to ash/host/ash_window_tree_host_x11_unittests
Review URL: https://codereview.chromium.org/201573015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263192 0039d316-1c4b-4281-b951-d872f2087c98
BUG=330566,340647
TEST=WindowSelectorTest.FullscreenWindow,RootWindowControllerTest.GetWindowForFullscreenMode,RootWindowControllerTest.MultipleDisplaysGetWindowForFullscreenMode,PanelWindowResizerTest.AttachToSecondFullscreenDisplay
TEST=Open a panel and navigate a browser to an html5 fullscreen page, and fullscreen it. Alt+tab to the panel, should be able to see the panel.
Review URL: https://codereview.chromium.org/149493008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253794 0039d316-1c4b-4281-b951-d872f2087c98
When user login, a new virtual keyboard is created. If the old virtual keyboard
was showing before user login, we need to notfiy keyboard bounds observers that
old virtual keyboard window occupy no space on screen. Otherwise, Ash still thinks
the work area should exclude virtual keyboard area even the keyboard is not showing.
This CL fixed the bug.
BUG=342524
Review URL: https://codereview.chromium.org/159473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250892 0039d316-1c4b-4281-b951-d872f2087c98
This patch reuses OnTextInputStateChanged, which was previously Android specific, but which includes not only type information, but whether the virtual keyboard should be displayed. This is the first step in consolidating the IPC messages between RenderWidget and RenderWidgetHostView for IME messages. Ideally, we can phase out OnTextInputTypeChanged in favor of the approach used by Android across all platforms.
BUG=289659, 294191, 331690
Review URL: https://codereview.chromium.org/29943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245932 0039d316-1c4b-4281-b951-d872f2087c98
- makes sure that minimum amount of window is visible when dropped.
- When moving a window to another due to display disconnect, try to keep relative position in the work are, rather than absolute position to the root window.
BUG=321702
TEST=covered by test
RootWindowController::MoveWindows_Basic
DragWindowResizerTest::WindowDragWithMultiDisplays
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240542R=mukai@chromium.org, varkha@chromium.org
Review URL: https://codereview.chromium.org/93873013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241114 0039d316-1c4b-4281-b951-d872f2087c98
- makes sure that minimum amount of window is visible when dropped.
- When moving a window to another due to display disconnect, try to keep relative position in the work are, rather than absolute position to the root window.
BUG=321702
TEST=covered by test
RootWindowController::MoveWindows_Basic
DragWindowResizerTest::WindowDragWithMultiDisplays
Review URL: https://codereview.chromium.org/93873013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240542 0039d316-1c4b-4281-b951-d872f2087c98
BUG=319889
TEST=ShelfLayoutManagerTest.FullscreenWindowInFrontHidesShelf, ShelfLayoutManagerTest.FullscreenWindowOnSecondDisplay,WorkspaceLayoutManagerTest.NotifyFullscreenChanges
TEST=Navigate to a site using HTML5 fullscreen API, alt tab away to another window and back. Window remains fullscreen but shelf shows while another window is in front.
Review URL: https://codereview.chromium.org/100903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239859 0039d316-1c4b-4281-b951-d872f2087c98
This relands https://codereview.chromium.org/47873003. It was reverted
because of VirtualKeyboardWindowControllerTest.VirtualKeyboardWindowTest
test crash on win8_aura.
R=oshima@chromium.org
TBR=jamescook, sadrul
BUG=310331
TEST=
1. add keyboard-usability-experiment flag
2. hook up an external screen
3. boot device
expected: a full screen keyboard on one of the screen
Review URL: https://codereview.chromium.org/62833010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235795 0039d316-1c4b-4281-b951-d872f2087c98
BUG=310331
TEST=
1. add keyboard-usability-experiment flag
2. hook up an external screen
3. boot device
expected: a full screen keyboard on one of the screen
Review URL: https://codereview.chromium.org/47873003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235502 0039d316-1c4b-4281-b951-d872f2087c98
> Eliminate Shell::RootWindowList in favor of aura::Window::Windows.
>
> This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows.
>
> R=oshima@chromium.org
> http://crbug.com/308843
>
> Review URL: https://codereview.chromium.org/64933002TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/59153004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233813 0039d316-1c4b-4281-b951-d872f2087c98
This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows.
R=oshima@chromium.orghttp://crbug.com/308843
Review URL: https://codereview.chromium.org/64933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233787 0039d316-1c4b-4281-b951-d872f2087c98
Also adds a typedef from RootWindow to WindowEventDispatcher, the eventual name of this type.
Adds a GetDispatcher() method that crawls up to the root Window and returns the WindowEventDispatcher.
R=sky@chromium.orghttp://crbug.com/308843
Review URL: https://codereview.chromium.org/37733003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231077 0039d316-1c4b-4281-b951-d872f2087c98
This flag is for testing virtual keyboard usability. It is intentionally excluded
from about:flag page because this flag is only intended to be used for our tests.
If the flag is set, virtual keyboard should always show unless user specifically
click hide keyboard key.
BUG=310327
Review URL: https://codereview.chromium.org/34783006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230928 0039d316-1c4b-4281-b951-d872f2087c98
Remove SetDefaultParentForRootWindow from Window, and replace with new utility function ParentWindowForContext in window_tree_client.h
This is part of my current campaign to slim down the aura Window types. I will eventually move WindowTreeClient to a new ui/wm component that I plan to create.
R=erg@chromium.orghttp://crbug.com/308844
Review URL: https://codereview.chromium.org/36473003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230501 0039d316-1c4b-4281-b951-d872f2087c98
In order to display virtual keyboard(VK) only on primary root window,
this CL did
1. Shell takes ownership of keyboard controller(KC) instead of
RootWindowController
2. keyboard container window is owned by KC instead of its parent
There should only be one KC and one keyboard container at any time after
this change. keyboard container can be dynamically enabled/disabled on a
RootWindowController at runtime. If you want to do that,
you should DisableKeyboard on the previous RootWindowController first and
then EnableKeyboard on the new RootWindowController.
BUG=297858
TEST=
1. enable virtual keyboard from about::/flags on a Chromebook
2. plug in an external monitor
verify only one virtual keyboard shows
Review URL: https://codereview.chromium.org/25111002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227088 0039d316-1c4b-4281-b951-d872f2087c98
RootWindowController::CloseChildWindows() was explicitly deleting
windows. It should only do that for windows that are owned by the
parent, otherwise the window should be removed.
BUG=297028
TEST=covered by test now.
R=oshima@chromium.orgTBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/25736004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226524 0039d316-1c4b-4281-b951-d872f2087c98
> Fixes use after free caused by delete in RootWindowController
>
> RootWindowController::CloseChildWindows() was explicitly deleting
> windows. It should only do that for windows that are owned by the
> parent, otherwise the window should be removed.
>
> BUG=297028
> TEST=covered by test now.
> R=oshima@chromium.org
>
> Review URL: https://codereview.chromium.org/25374002TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/25659002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226377 0039d316-1c4b-4281-b951-d872f2087c98
RootWindowController::CloseChildWindows() was explicitly deleting
windows. It should only do that for windows that are owned by the
parent, otherwise the window should be removed.
BUG=297028
TEST=covered by test now.
R=oshima@chromium.org
Review URL: https://codereview.chromium.org/25374002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226347 0039d316-1c4b-4281-b951-d872f2087c98
Move window control methods from window_util.h to WindowState
Removed property_util which is no longer necessary.
BUG=272460
Review URL: https://chromiumcodereview.appspot.com/24108003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224288 0039d316-1c4b-4281-b951-d872f2087c98
It returned the fullscreen window (if any) in the active workspace,
and a workspace could contain only one fullscreen window at most.
However, now there's only one desktop workspace which can contain
multiple fullscreen windows.
To follow the past state, it would be better to return the active
fullscreen window first.
TEST=covered by ash_unittests
R=oshima@chromium.org, sky@chromium.org
BUG=None
Review URL: https://chromiumcodereview.appspot.com/23534049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221602 0039d316-1c4b-4281-b951-d872f2087c98
When user session is blocked (login screen, lock etc.), virtual keyboard container
window should still be able to process events to function properly.
BUG=263599
TEST=
1. Enable virtual keyboard
2. go to login screen
verify if you can use virtual keyboard to type you password and login
Review URL: https://chromiumcodereview.appspot.com/22465007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217159 0039d316-1c4b-4281-b951-d872f2087c98
mouse can move between displays.
Added NoSessionAshTestBase for tests that should run before
a user logs in.
BUG=266987
TEST=covered by test
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/21519002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216184 0039d316-1c4b-4281-b951-d872f2087c98
Added IsUserSessionBlocked method indicating whether user session blocked by
some overlying UI (it can be lock/login/user adding UI).
Replaced IsScreenLocked() [|| IsActiveUserSessionStarted()] with
IsUserSessionBlocked() in several places in order to keep focus and user input
in locked container.
BUG=none
TEST=ash_unittests
R=sky
Review URL: https://chromiumcodereview.appspot.com/19945004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213524 0039d316-1c4b-4281-b951-d872f2087c98
This CL still keeps some of multi-workspace code, but they are
a bit tough to test.
BUG=259568
R=jamescook@chromium.org
TEST=ash_unittests covers
Review URL: https://chromiumcodereview.appspot.com/19460014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213259 0039d316-1c4b-4281-b951-d872f2087c98
