See the bug for a more detailed discussion of the problem when we don't make
this accessible through ADL.
BUG=391117
Review URL: https://codereview.chromium.org/367063006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281864 0039d316-1c4b-4281-b951-d872f2087c98
It's been unused since r255987 (which removed the --enable-dcheck flag,
among other things).
Also remove the --silent-dump-on-dcheck flag (because now there's not
even code that pretends to use it).
R=brettw@chromium.org,sky@chromium.org
BUG=352378
Review URL: https://codereview.chromium.org/331143007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277736 0039d316-1c4b-4281-b951-d872f2087c98
Allows to use any errors, and particularly useful for logging HRESULT on Windows.
Included error code on windows into error message.
Removed unused LOG_GETLASTERROR_MODULE logging macros.
Review URL: https://codereview.chromium.org/244583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265460 0039d316-1c4b-4281-b951-d872f2087c98
DCHECK_IS_ON has been a constant since r255987, and can be used in both
if() and #if. It no more needs to be in function form.
Converted 'if (DCHECK_IS_ON)' to '#if DCHECK_IS_ON' if proper.
BUG=350462
TEST=build
TBR=darin
Review URL: https://codereview.chromium.org/195973002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257156 0039d316-1c4b-4281-b951-d872f2087c98
- Remove DCHECK in non-official-release build by default
- Gyp variable dcheck_always_on=1 (existing) forces to enable DCHECK
in release build
- Remove flag --enable-dcheck
Other effects/notes:
- Now allow "buildtype=Official dcheck_always_on=1" (which will
enable DCHECK in official build) combination.
- Gyp variable logging_like_official_build no longer has an effect
- Leave DCHECK_IS_ON() unchanged. May deal with it in a later change
if needed.
This won't affect bots which use dcheck_always_on=1.
BUG=350462
TEST=LoggingTest.Dcheck
R=thakis@chromium.org
TBR=darin,sehr (command line changes in components/nacl and mojo)
Review URL: https://codereview.chromium.org/189603007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255987 0039d316-1c4b-4281-b951-d872f2087c98
It looks like logging.h _always_ defines LOGGING_IS_OFFICIAL_BUILD, it's
just defined to 0 or 1. So check for the value of LOGGING_IS_OFFICIAL_BUILD
instead of its definedness.
BUG=315884
TBR=akalin@chromium.org
Review URL: https://codereview.chromium.org/66213008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234115 0039d316-1c4b-4281-b951-d872f2087c98
The issue is that the split linker has issues with data exports vs function exports
currently only function exports are supported.
NOTRY=true
TBR=brettw,jam
TEST=none
BUG=237249
Review URL: https://chromiumcodereview.appspot.com/15403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201194 0039d316-1c4b-4281-b951-d872f2087c98
Compiling base_unittests with gcc 4.7 on linux gives these errors:
../../base/logging_unittest.cc: In member function 'virtual void logging::{anonymous}::LoggingTest_BasicLogging_Test::TestBody()':
../../base/logging_unittest.cc:68:172: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null]
../../base/logging_unittest.cc: In member function 'virtual void logging::{anonymous}::LoggingTest_LogIsOn_Test::TestBody()':
../../base/logging_unittest.cc:123:174: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null]
../../base/logging_unittest.cc:132:174: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null]
../../base/logging_unittest.cc:141:174: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null]
Switching from EXPECT_EQ(false, something) to EXPECT_TRUE(false == something)
fixes the problem.
Review URL: https://chromiumcodereview.appspot.com/14019004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193872 0039d316-1c4b-4281-b951-d872f2087c98
This cuts down on the number of strings in the executable, as well as
executable code to print them.
On Linux, this saves 208kb on a stripped official build
(chrome executable file went from 64569072 bytes -> 64782064 bytes)
On OS X, this saves 209kb on an official build (Google Chrome Framework went from 51483872 bytes -> 51274984 bytes)
On Windows, this saves 139kb on an official build (chrome.dll went from 28619264 bytes -> 28477440 bytes)
Fix test failure in logging_unittest.cc in official builds.
Add new executable check_example for easy testing of changes to the
CHECK macros.
BUG=101561
TEST=
Review URL: http://codereview.chromium.org/8734021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112649 0039d316-1c4b-4281-b951-d872f2087c98
having the pass a flag. This will be used on the try bots.
BUG=96753
Review URL: http://codereview.chromium.org/7719007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102017 0039d316-1c4b-4281-b951-d872f2087c98
