0
Commit Graph

5666 Commits

Author SHA1 Message Date
9832bca736 Revert "WebUI: Enable @typescript-eslint/require-await check in build_webui()."
This reverts commit 32867d045f.

Reason for revert: Breaks the build.

FAILED: gen/ui/webui/resources/cr_components/cr_shortcut_input/eslint.config.mjs 
python3 ../../ui/webui/resources/tools/eslint_ts.py --in_folder gen/ui/webui/resources/cr_components/cr_shortcut_input/preprocessed --out_folder gen/ui/webui/resources/cr_components/cr_shortcut_input --config_base ../../../../../../../../ui/webui/resources/tools/eslint_ts.config_base.mjs --tsconfig tsconfig_build_ts.json --in_files cr_shortcut_input.ts cr_shortcut_input.html.ts cr_shortcut_util.ts
Traceback (most recent call last):
  File "/usr/local/google/home/sesse/chromium/src/out/Default/../../ui/webui/resources/tools/eslint_ts.py", line 78, in <module>
    main(sys.argv[1:])
  File "/usr/local/google/home/sesse/chromium/src/out/Default/../../ui/webui/resources/tools/eslint_ts.py", line 67, in main
    node.RunNode([
  File "/usr/local/google/home/sesse/chromium/src/third_party/node/node.py", line 38, in RunNode
    raise RuntimeError('Command \'%s\' failed\n%s' % (' '.join(cmd), err))
RuntimeError: Command '/usr/local/google/home/sesse/chromium/src/third_party/node/linux/node-linux-x64/bin/node /usr/local/google/home/sesse/chromium/src/third_party/node/node_modules/eslint/bin/eslint --color --quiet --config gen/ui/webui/resources/cr_components/cr_shortcut_input/eslint.config.mjs gen/ui/webui/resources/cr_components/cr_shortcut_input/preprocessed/cr_shortcut_input.ts gen/ui/webui/resources/cr_components/cr_shortcut_input/preprocessed/cr_shortcut_input.html.ts gen/ui/webui/resources/cr_components/cr_shortcut_input/preprocessed/cr_shortcut_util.ts' failed

Oops! Something went wrong! :(

ESLint: 9.10.0

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:371:5)
    at validateString (node:internal/validators:119:11)
    at Object.join (node:path:1172:7)
    at file:///usr/local/google/home/sesse/chromium/src/out/Default/gen/ui/webui/resources/cr_components/cr_shortcut_input/eslint.config.mjs?mtime=1739278158700:10:26
    at ModuleJob.run (node:internal/modules/esm/module_job:185:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:281:24)
    at async importModuleDynamicallyWrapper (node:internal/vm/module:437:15)
    at async loadFlatConfigFile (/usr/local/google/home/sesse/chromium/src/third_party/node/node_modules/eslint/lib/eslint/eslint.js:390:21)
    at async calculateConfigArray (/usr/local/google/home/sesse/chromium/src/third_party/node/node_modules/eslint/lib/eslint/eslint.js:473:28)

Original change's description:
> WebUI: Enable @typescript-eslint/require-await check in build_webui().
>
>  - Enabling `enable_type_aware_eslint_checks` by default in build_webui().
>  - Fixing a few remaining violations that were not already fixed in
>    precursor CLs.
>  - Fix the dependnecies of the ":lint" target for the case of
>    `use_javascript_coverage=true`
>  - Add a new "ESLint checks" section in styleguide/web/web.md explaining
>    the two different types of ESLint checks.
>  - Update Chromium styleguide additions to include what will be
>    enfroced by @typescript-eslint/require-await as part of this CL,
>    and @typescript-eslint/no-unnecessary-type-assertion in upcoming
>    CLs.
>
> Bug: 394634491
> Change-Id: I59a07d4e76339449c3e5ff79608b57154a3e32cb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6250398
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1418375}

Bug: 394634491
Change-Id: Iccfa9b2c94f608e193f95a7fe454abbec3c3f3b4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6253018
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Steinar H Gunderson <sesse@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Owners-Override: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418592}
2025-02-11 05:49:25 -08:00
e975473c56 Roll Website from 61d3bcecee60 to 087e0ee5b711 (1 revision)
https://chromium.googlesource.com/website.git/+log/61d3bcecee60..087e0ee5b711

2025-02-10 vapier@chromium.org licensing-for-chromiumos-developers: refresh a bit

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I693efe641665839916ae149313406ed37cb2f00c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6250412
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1418423}
2025-02-10 17:42:19 -08:00
32867d045f WebUI: Enable @typescript-eslint/require-await check in build_webui().
- Enabling `enable_type_aware_eslint_checks` by default in build_webui().
 - Fixing a few remaining violations that were not already fixed in
   precursor CLs.
 - Fix the dependnecies of the ":lint" target for the case of
   `use_javascript_coverage=true`
 - Add a new "ESLint checks" section in styleguide/web/web.md explaining
   the two different types of ESLint checks.
 - Update Chromium styleguide additions to include what will be
   enfroced by @typescript-eslint/require-await as part of this CL,
   and @typescript-eslint/no-unnecessary-type-assertion in upcoming
   CLs.

Bug: 394634491
Change-Id: I59a07d4e76339449c3e5ff79608b57154a3e32cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6250398
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418375}
2025-02-10 16:44:58 -08:00
b14ca5315c update_client: Persist IID through first active.
Previously, the IID would always be cleared on
the first update check, which is usually the
update-check-to-install. To avoid continuously
retransmitting a unique identifier for inactive
clients, the install ID is not sent for
non-active updatechecks, nor for non-install
pings.

Also, update the install ID on an overinstall.
This helps terminate the install funnel
telemetry for installers used in an overinstall
context.

Bug: 343239826
Change-Id: Ifb216019179fc307e2ac13e2a7abc4005f62dccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6249219
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418371}
2025-02-10 16:42:42 -08:00
916a6d3b8a WebUI: Support ESLint type aware checks in build_webui().
Type-aware ESLint checks (see [1], [2]) can do more sophisticated checks
compared to non type-aware checks which run during presubmit.

- Implement a new `eslint_ts()` GN rule along with corresponding
  tests.
- Hook it up to `build_webui()`.
- Guard it with a new `enable_type_aware_eslint_checks` flag that
  defaults to `false`.

The new flag will be enabled on a target-by-target basis or as a whole
once existing violations are fixed. Initially applying only
@typescript-eslint/require-await when the flag is enabled. More checks
will be added eventually.

[1] https://typescript-eslint.io/rules/?=typeInformation
[2] https://typescript-eslint.io/getting-started/typed-linting/

Bug: 394634491
Change-Id: Id2255656786fc144f95801f399bc34520c910cca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5252273
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1417633}
2025-02-07 16:08:55 -08:00
718d38e3d1 Roll Website from 36958621a31e to 61d3bcecee60 (1 revision)
https://chromium.googlesource.com/website.git/+log/36958621a31e..61d3bcecee60

2025-02-06 trishalfonso@google.com Fix hyperlinks in the Developer Mode Guide.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I650798ed09fda4c8db4470c1a56e5ecb9eff62e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6240116
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1416782}
2025-02-06 07:24:56 -08:00
d695cb1c74 Docs: Fix updater download cache doc lines.
Change-Id: I67a47aeb1c37ad97490db99d85338052b06b212d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6234634
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416401}
2025-02-05 12:52:07 -08:00
139f9b8134 updater: send pings with eventresult 0 on install failures
`eventresult` needs to be `0` for pings that report failure.

Bug: 374957472,40944565
Change-Id: I49c848aa7bfbe03ebd06ce8f9d3a352a3f9839d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6235389
Auto-Submit: S Ganesh <ganesh@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: S Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416327}
2025-02-05 11:07:39 -08:00
7393aa4676 Add v8 sandbox_testing job info to clusterfuzz guidelines
Change-Id: I9209f7581be41caef1ef781558bd6d368b81ae10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226722
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Amy Ressler <amyressler@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416296}
2025-02-05 10:39:41 -08:00
69d04dc7b0 updater: Add reporting support for metainstaller errors
Fixed: 40944565
Change-Id: I2fdb6b77ae6d345963d64fc5c47ef0557cc7bf2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6231072
Commit-Queue: S Ganesh <ganesh@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Auto-Submit: S Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416229}
2025-02-05 09:10:22 -08:00
6a48482e2f [Docs] Add details on code review votes to contributing.md
contributing.md didn't have details about the votes required or copying
votes between patch sets in Gerrit. This CL adds a description of these
practices.

Bug: None
Change-Id: I2e23b336f4cc85d57a31760697c5899794da5515
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226768
Auto-Submit: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416201}
2025-02-05 08:41:14 -08:00
4913cb88be Update reclient instructions and links
Bug: N/A
Test: N/A, documentation update
Change-Id: Ib8ca6a5d814270d4b7d6959370ad7a9ab8b7d252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6227850
Reviewed-by: Neil Coronado <nemco@google.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Jenna Himawan <jhimawan@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416151}
2025-02-05 07:42:43 -08:00
7d1b2b0b0c Enable explicit module build by use_libcxx_modules arg
This CL enables explicit clang modules for libc++ and clang's builtin
headers.

There are still many compile errors even if we build `base`, but we'll
fix them one by one.

I also leave implicit modules build with use_implicit_libcxx_modules.

Bug: 40440396
Change-Id: Ie23087ff69e2ab9892625400f2cd182955cc098b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6188686
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416006}
2025-02-04 22:53:22 -08:00
09c138a26c Add allowed cases for restricted licenses in docs.
Adding in information about GPL/LGPL licences that are allowed for non-shipped dependencies and chromium. This info comes from Dash (CC'd).

Change-Id: Icf00b57d8f204b751f6ace69a0bdcd33bada989c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6229210
Reviewed-by: Jiewei Qian <qjw@chromium.org>
Commit-Queue: Jordan Brown <rop@google.com>
Reviewed-by: Rachael Newitt <renewitt@google.com>
Cr-Commit-Position: refs/heads/main@{#1415972}
2025-02-04 19:42:27 -08:00
4cef8940ec Roll Website from 8ead451a863a to 36958621a31e (1 revision)
https://chromium.googlesource.com/website.git/+log/8ead451a863a..36958621a31e

2025-02-04 rbpotter@chromium.org WebUI: Update website documentation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I1fe89129dc19790dd7ee4fa1690fca203edefc69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6231432
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1415888}
2025-02-04 15:53:38 -08:00
c98914a0b2 Update docs for updating clang format
* The file extensions for the compressed tarballs are .tar.xz, not .tgz
* Update the clang-format diff script so that xargs spawns one
  clang-format process per file in parallel instead of spawning one
  clang-format process that formats all files. This considerably speeds
  things up.

Note that the fetch and upload script is still broken for the following
reasons that I haven't fixed yet because this is difficult to debug
(upload_to_google_storage.py can only be run once per object for
example.)
* upload_to_google_storage_first_class.py prints a line that goes
  "Uploading {filename} as gs://{path}" before printing out JSON. This
  makes jq unhappy.
* upload_to_google_storage_first_class.py prints the wrong object_name
  in the JSON; the object name printed is the same as the sha256sum.
  There does exist an object with that name and it contains the right
  data, but it doesn't have the executable bit set. We want another
  object that does.

Change-Id: I6cd5faa0432b71098664e4e79bc7c22140d48545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6226772
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Alan Zhao <ayzhao@google.com>
Cr-Commit-Position: refs/heads/main@{#1415760}
2025-02-04 12:26:16 -08:00
e51ceb57bb Roll Website from 600fc3a0b121 to 8ead451a863a (1 revision)
https://chromium.googlesource.com/website.git/+log/600fc3a0b121..8ead451a863a

2025-02-04 minhopark@chromium.org Add FCCL Chromebook to list

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: If58e11164f902fab807e0f6e950ad52ea55b2564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6229340
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1415476}
2025-02-04 03:06:07 -08:00
4a54ad01b7 Add Chromium side of chrome-unsafe-rust-reviews@google.com gwsw setup.
Bug: 393410747
Change-Id: I7bbbc5ec81116004f05cf6979b6b96e4d4afd0b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6219726
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1415239}
2025-02-03 15:25:45 -08:00
de660ddd0f Roll Website from b0cdcf6bb9f2 to 600fc3a0b121 (1 revision)
https://chromium.googlesource.com/website.git/+log/b0cdcf6bb9f2..600fc3a0b121

2025-02-03 slobodan@chromium.org Remove reference to NOTREACHED_NORETURN()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I36c8944d032fd6ae3fbbe8951e02e2507fba2479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6227902
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1415198}
2025-02-03 14:22:14 -08:00
d2e79a4f40 Updating protocol 4: lists, nextfp and version
This change removes explicit list nodes and moves nextfp and
version from the pipeline nodes to the updatecheck node.

Bug: 393153877
Change-Id: I22646be95328d9bc58dba401a4ee00a62cd0ef76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6214973
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1415031}
2025-02-03 10:21:55 -08:00
0e99dfd5a0 docs: Fix broken links, typo, and remove outdated "gotcha"
"gotcha" removed here: https://crrev.com/c/5345750

Bug: N/A
Change-Id: If24d47430347a56699f9f5c58f04f12d8a523454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221248
Commit-Queue: Camden Bickel <cambickel@google.com>
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/main@{#1414365}
2025-01-31 13:08:08 -08:00
3519fdc637 android: Update histograms.xml for cold start metrics
We are switching to v4 metrics for startup. Adjust the description of
the metric in histograms.xml to match the fact that it is the primary
one. Rewrite the descriptions of the previous versions to focus only on
the differences. This will allow readers to avoid doing the diff
themselves.

Bug: 384084655
Change-Id: Ief23b69bb15586737186a450c58bb0eceee2f2a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6197642
Reviewed-by: Sean Maher <spvw@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1414348}
2025-01-31 12:43:43 -08:00
ac5fdf4dc1 Add security FAQ entry about external lists
Lists like PSL and HSTS preload are incorporated into Chrome, but
the status of additions/removals in Chrome are not security bugs.

Change-Id: I7bdcabf711606c9896f97ccddf7a96686a4bf5e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6216082
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Chris Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1413519}
2025-01-30 08:18:00 -08:00
e02f5b17fc [docs] base::Feature documentation for devtools-frontend.
Bug: 354102605
Change-Id: Ifad75f8a5ea560831e34d443c447e64d06dfac82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6218299
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1413335}
2025-01-29 23:27:01 -08:00
b2bfb48549 updater: document the lang tag parameter
Bug: 385004395
Change-Id: I2af4c752137c4ed2acd91e6b420f515a8f805e77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6214712
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Auto-Submit: S Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1413118}
2025-01-29 13:03:59 -08:00
63fc71ea34 Roll Website from a816ad10d96d to b0cdcf6bb9f2 (1 revision)
https://chromium.googlesource.com/website.git/+log/a816ad10d96d..b0cdcf6bb9f2

2025-01-29 dpranke@google.com Remove ewag@ from //OWNERS.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: Ic4e011fa409984b5dea60ede1215d86cc5762cdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6215341
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1413117}
2025-01-29 13:02:45 -08:00
68237fb98a Roll Website from 92a8f6de1d9e to a816ad10d96d (4 revisions)
https://chromium.googlesource.com/website.git/+log/92a8f6de1d9e..a816ad10d96d

2025-01-28 vapier@chromium.org vpython: update to python 3.11
2025-01-28 dpranke@google.com Clarify requirements for getting a @chromium.org address.
2025-01-28 vapier@chromium.org OWNERS: add myself
2025-01-28 dpapad@chromium.org Update links to WebUI docs to point to new location.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Test: Test: `./scripts/fetch_lobs.py` still works
Change-Id: Ief34a3caeae75635cf50adcf150724660aa2a83f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6210814
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1412740}
2025-01-28 23:55:03 -08:00
7d00f87db0 Roll Website from 7318af14ccf4 to 92a8f6de1d9e (2 revisions)
https://chromium.googlesource.com/website.git/+log/7318af14ccf4..92a8f6de1d9e

2025-01-28 waffles@chromium.org Update Getting Involved Page
2025-01-28 dpranke@google.com Auto-trigger the presubmit builder on new patchsets.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:392668431
Tbr: dpranke@google.com
Change-Id: I4df39c835793a5621995474147a2e7f31105a7fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6207313
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1412433}
2025-01-28 11:05:26 -08:00
02c8906fa7 Be more explicit and clear about OWNERS needing to be committers.
You could sort of guess at what the actual requirement was before,
but this makes it a bit clearer.

Bug: 376077658
Change-Id: I9fb0646bb4183f79916b44c7cb19ab9f403aa7e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6203519
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/main@{#1412396}
2025-01-28 10:20:57 -08:00
aafe23a98f Roll Website from 2d36f0243a62 to 7318af14ccf4 (1 revision)
https://chromium.googlesource.com/website.git/+log/2d36f0243a62..7318af14ccf4

2025-01-28 dpranke@google.com Reland "Reland "infra: enable presubmit in CQ""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:392668431
Tbr: dpranke@google.com
Change-Id: Ie650c73b9de3dea07e4cb210d69d7d77994d8174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6205316
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1412046}
2025-01-27 18:44:55 -08:00
b142846c89 Update documentation about unsafe libc calls.
This information can now be added since a recent compiler roll
has brought this behavior into scope.

Change-Id: I5a4dcf4ed5b906c4708c4b033b79e49594868960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6199587
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1411873}
2025-01-27 13:44:43 -08:00
3782d2079e Update shepherd docs to specify low severity bugs dont need OS/FoundIn
Change-Id: I6c815e9ef6202b625501b87a5a294e7a24d93559
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6194118
Reviewed-by: Amy Ressler <amyressler@chromium.org>
Reviewed-by: Liza Burakova <liza@chromium.org>
Commit-Queue: Grace Park <pgrace@google.com>
Cr-Commit-Position: refs/heads/main@{#1411806}
2025-01-27 12:13:45 -08:00
12261ed235 docs: Add a note about thin testers to the infra glossary
Clarifies the term "thin tester" which is kind of a sub category of
"child tester".

Bug: None
Change-Id: Ia83c8d90c6c1ea3d96fe8ea6b8969c0abd2c18dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6203042
Reviewed-by: Struan Shrimpton <sshrimp@google.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1411787}
2025-01-27 11:34:46 -08:00
00d6a6aacb Set up benchmarks in Win 11 Laptop Low End platform.
Change-Id: Idabc9d79004fd186215156da554fda86ae33d062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6174843
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Eduardo Yap <eduardoyap@google.com>
Reviewed-by: Jeff Yoon <jeffyoon@google.com>
Cr-Commit-Position: refs/heads/main@{#1411770}
2025-01-27 11:15:21 -08:00
75fc665835 Update the policy doc
Several improvements made:

1. Separate life of a policy doc from general doc, focus policy
   launch, modification and deprecation process.
2. Move some content to policy.yaml and policy_design doc.
3. Link all those doc from add_new_policy.md and make sure all policy
   doc are linked back to add_new_policy.md
4. Update some out of date information and some minor text changes.

Change-Id: I0fc86640bb42abb67e9dd3aa14385000c911ad64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6127973
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Anqing Zhao <anqing@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1411680}
2025-01-27 09:23:57 -08:00
5fd6c08c95 Fix more broken links to recently moved WebUI docs.
Bug: None
Change-Id: I20eff74f12cfec54139776d3680ecde041e1e4f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6197757
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Teresa Mao <temao@chromium.org>
Commit-Queue: Teresa Mao <temao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1411223}
2025-01-24 16:29:43 -08:00
84348fcac9 update_client: remove dead system requirements code.
This was only used by offline manifests, which no longer rely on this
module.

Bug: 353249967
Change-Id: If82b5ff95fd24fefb066fae9c384dbabc77889d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6196810
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1411114}
2025-01-24 12:20:11 -08:00
e8246932ee [docs] Document how to depend on another author's CL
I learned how to do this today from Chromium Slack, from a message someone sent over five years ago. They followed up with "I don't actually remember where I learned that, but it does seem like something that should be in some well-known document but probably isn't"[1]. I figured it would be good to put the instructions in a well-known document; I tried looking in docs before searching Slack and wasn't able to find these steps. (Though it's fully possible this is already documented somewhere obvious and the problem is just me.)

[1] https://chromium.slack.com/archives/CGGPN5GDT/p1576091851245200

Change-Id: I05c650ed221ddc06363c6d75307d59d4360833d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6195789
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Svend Larsen <svend@chromium.org>
Commit-Queue: Svend Larsen <svend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1410968}
2025-01-24 08:47:06 -08:00
543280cdac WebUI: Add docs about the --load-webui-from-disk mechanism.
Also, add a "Debugging tests" section in docs/webui/testing_webui.md.

Bug: 384636724
Change-Id: I6f8ec591b336c5011605d197a7013b40ba84628e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6194072
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1410751}
2025-01-24 00:03:25 -08:00
bde5dd043d Update Shepherding Guidelines with temp Fullscreen triage guidelines
Change-Id: I3ff137cb20508558d77650ecc4c5f0a70708326c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6196290
Auto-Submit: Amy Ressler <amyressler@chromium.org>
Commit-Queue: Amy Ressler <amyressler@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1410634}
2025-01-23 16:31:23 -08:00
6797092925 Roll Website from c342ee151857 to 2d36f0243a62 (1 revision)
https://chromium.googlesource.com/website.git/+log/c342ee151857..2d36f0243a62

2025-01-23 goanuj@google.com updated Mac OS quick start for browser policy testing.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: Ib1d3e205533a90d119295418a95d126578261f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6195769
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1410614}
2025-01-23 15:51:01 -08:00
b3126718e4 Remove Feature Freeze from Chromium release docs
Chromium Browser no longer relies on Feature Freeze

Bug: 377928604

Change-Id: Ie6e951c9353d5e0ee435f7a9fe6035bbf78b67f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192283
Reviewed-by: Erhu Akpobaro <eakpobaro@google.com>
Commit-Queue: Harry Souders <harrysouders@google.com>
Cr-Commit-Position: refs/heads/main@{#1410433}
2025-01-23 10:00:27 -08:00
e360db9dbe Update code_reviews.md OWNERS section for LAST_RESORT_SUGGESTION.
Add documentation for this OWNERS file syntax, which otherwise isn't documented publicly yet.  The #{LAST_RESORT_SUGGESTION} annotation is documented internally at Google, and a request to include it in the public Gerrit documents is pending action.

Change-Id: If2bc18f30af4f831476924dbdfc953aaba2caa28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192582
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1410396}
2025-01-23 09:12:07 -08:00
0993479170 Move more WebUI docs under docs/webui/ folder, fix broken links.
Bug: None
Change-Id: I5d5589951e383176893e0947fd72201b7a665d6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192917
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1410389}
2025-01-23 08:59:50 -08:00
32c8dd9d55 Move all WebUI docs under docs/webui/ folder.
As part of the move, deleting the obsolete docs/webui_in_components.md.

Bug: None
Change-Id: I63c70377482468cd9e541a06c45a243b00b0959e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6186711
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1409815}
2025-01-22 11:05:16 -08:00
e23adc3e28 Docs: Asan: Update location of log files on ChromeOS
This changed in crrev.com/3590143 by commit 0631a4fdab92 ("llvm: asan to
log to /tmp/asan") to chromiumos-overlay in ChromeOS,

Bug: 223869781
Change-Id: Ic4cb6a18792bb3d4c2064bb90ba93e1d2598f26b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6171386
Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Auto-Submit: Matt Turner <msturner@google.com>
Cr-Commit-Position: refs/heads/main@{#1409740}
2025-01-22 09:31:03 -08:00
1907ad79a7 Update Merge Request doc to reflect current merge process
Bug: 388532518

Change-Id: Ifbecc62cef314992cabf87c5f572611575190e9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6169562
Reviewed-by: Daniel Yip <danielyip@google.com>
Commit-Queue: Harry Souders <harrysouders@google.com>
Cr-Commit-Position: refs/heads/main@{#1409726}
2025-01-22 09:16:03 -08:00
181859794d Roll Website from 9357a4e8d3b2 to c342ee151857 (3 revisions)
https://chromium.googlesource.com/website.git/+log/9357a4e8d3b2..c342ee151857

2025-01-21 jdonnelly@chromium.org Remove side search design document.
2025-01-21 vapier@chromium.org PRESUBMIT: rework link scanning to span multiple lines
2025-01-21 vapier@chromium.org Revert "Reland "infra: enable presubmit in CQ""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:357910230
Tbr: dpranke@google.com
Change-Id: Ib9381a7ac26abf78d9b962cd4452dad3388aa6cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6188937
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1409465}
2025-01-21 21:19:00 -08:00
e848f2efd2 Relax "Mechanical updates" requirement for global approvals
Often reviews take longer than needed just due to getting "rubber stamps" for mechanical changes and some CLs need many such reviewers across multiple directories. Our global approvers process already addresses this concern for the specific case of updating calls to code in common directories. This change relaxes the requirement to empower such OWNERS to use their judgement in deciding when additional OWNERS need to be consulted and when they don't. It also generally encourages the use of this mechanism to avoid unnecessary waste of reviewer time.

Change-Id: Ic0764d2519bb90201490a8f498f205a2f02ea4f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6185753
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1409114}
2025-01-21 09:56:00 -08:00
8823a452e2 Roll Website from d449eb6e9d47 to 9357a4e8d3b2 (1 revision)
https://chromium.googlesource.com/website.git/+log/d449eb6e9d47..9357a4e8d3b2

2025-01-21 vapier@chromium.org Reland "infra: enable presubmit in CQ"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dpranke@google.com
Change-Id: I3230edb34fb88c259b8b67e418cabafd76545a7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6186692
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1409049}
2025-01-21 08:29:58 -08:00