Manual specify which rotations to include in the header so the internal
perf rotation can be included. Update the rotation to be a struct as
well so it's easy to discover the source of the console names
Bug: 40873502
Change-Id: Iaf38b0001cfbe26235617ce6123ed105f41ded4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6309924
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Cr-Commit-Position: refs/heads/main@{#1427186}
This feature would guard the feature development of auto-approving
session connection requests for enterprise shared CRD sessions.
To state it explicitly auto approval of the connection request dialog
would only take place if:
* the device is in a managed environment.
* there was a local user activity in the last 5 minutes.
The connection dialog would also show a 30 seconds countdown in the
request dialog before auto-approving the connection request.
Bug: b:397902801
Change-Id: I824109ca4701bd881913bc88e2780e0b33e9da98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6309388
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Jeroen Dhollander <jeroendh@google.com>
Commit-Queue: Ashutosh Singhal <macinashutosh@google.com>
Cr-Commit-Position: refs/heads/main@{#1427185}
This CL introduces a TrimEntries method to AutofillAiModelCacheImpl.
TrimEntries does two things:
- It removes entries (starting with the oldest) if the cache exceeds
the target maximum size.
- It removes entries once they exceed the maximum target age.
The TrimEntries method is triggered whenever the DB is loaded (i.e.,
on start) and when a cache entry is updated/added.
Bug: 389631477
Change-Id: If9e1fee273e6596121ba45514a9114fe97b2be04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6317566
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#1427183}
An <li> marker can generate the following layout tree:
LayoutListItem (children-inline) LI
LayoutInsideListMarker ::marker
LayoutTextFragment (anonymous) "m"
LayoutText #text "a"
If the <li> has a :first-line style, the marker pseudo element will be
under a parent <li> with a pseudo style, but the parent's pseudo style
should not apply to the marker. https://crrev.com/1138023 added code to
handle this situation, but it is after a check for stopping, which is
hitting and crashing. This patch makes the condition for "stop
decoration propagation" tighter so that the first-line case falls
into the last resort code.
This is done behind a flag, CssDecoratingBoxFirstLine, for safety.
Fixed: 392927981
Change-Id: Ifccb122ac6aad84e3723f3346cede8971b564586
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6310509
Commit-Queue: Philip Rogers <pdr@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427180}
Add new deep scanning metadata with implementations over subset of methods needed from DownloadItem and FilesystemAccessWriteItem. For now, to limit impact, only adding methods used in DownloadRequestMaker, DeepScanningRequest, and DownloadProtectionService that are relevant to have FSA support for deep scans.
Will have follow-up CL for having deep_scan_request use the new metadata interface instead of download item.
Bug: 399845136
Change-Id: Iaaf8c6de98b30cffedb01c12792e84b88dd120ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6306910
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Haihan Chen <haihan@google.com>
Reviewed-by: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427173}
With the previous implementation, on an iOS 18 device users cannot go
to the top of the NTP to select identity disc / logo if they scrolled
too far down into the feed. It seems that iOS 18 has different parsing
mechanisms for switch control and voice-over, so adding listener for
switch control to avoid that. (VO and switch control could NOT be turned
on simultaneously.)
Fixed: 399123658
Change-Id: I716d6acbb776a1e26352677931bc02d4f88cf404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6316931
Reviewed-by: Scott Yoder <scottyoder@google.com>
Commit-Queue: Scott Yoder <scottyoder@google.com>
Reviewed-by: Louis Romero <lpromero@google.com>
Commit-Queue: Ginny Huang <ginnyhuang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427171}
So far we had some checks around tokens but they were focusing on
reference from inline tokens to external variants that are not defined
in the same file.
This new version adds a check that validates that every single {Token}
used in name of the histogram is covered either inline with <token> or
out of line with <variants> (both within the same file).
A small piggyback - I noticed that python is now (correctly) complaining
about invalid escape sequences in PRESUBMIT_test.py, I just fixed that
by properly escaping the regex literals.
Tested: Added unit test coverage covering 3 correct ways to register
those tokens as well as an example of failing check when they are not
registered at all. Also did run it over existing files and it found no
errors.
Bug: 237966433
Change-Id: I882bba96f2dd114b7e72c402562b4138ba13b0a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6308818
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Andrzej Fiedukowicz <afie@google.com>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/main@{#1427167}
During an account/profile switch, in AuthenticationFlowPerformer,
ProfileSignout::kChangeAccountInAccountMenu should be used instead of
ProfileSignout::kUserClickedSignoutSettings.
In a later patch, `ProfileSignout::kChangeAccountInAccountMenu` should
be renamed to be more generic, in case account switch can be used in
other places.
Bug: 375604649
Change-Id: I95302721de453da6e61b6405082b591d41dc370e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6317389
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427164}
To maintain consistency with the other PageActionControllers we pass in
the TabInterface as a reference instead of a pointer into
IntentPickerViewPageActionController's constructor.
Also removes the early return for checking if the feature is active from
the IntentPickerViewPageActionController::UpdatePageActionVisibility and
into the constructor.
Bug: 376283840
Change-Id: I2adb6ce06148dc48a3ee03e6f294eb5177f540a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6309119
Reviewed-by: Kaan Alsan <alsan@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Commit-Queue: Daniel Soromou <koretadaniel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427160}
Before this CL, unit tests for AutoEnrollmentController were testing
legacy state determination only. However, legacy state determination was
fully replaced by Unified State Determination in M131.
This CL therefore
* drops EnrollmentFwmpHelper tests (only relevant for legacy)
* migrates AutoEnrollmentController tests to use USD
Cq-Include-Trybots:
luci.chrome.try:linux-chromeos-chrome;luci.chromium.try:linux-chromeos-rel
Bug: 383047722
Test: Refactored unit tests
Change-Id: Ib22a4f89ef8af02762c22984e4fe1c391e1d894e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6309607
Commit-Queue: Roland Bock <rbock@google.com>
Reviewed-by: Artem Sumaneev <asumaneev@google.com>
Cr-Commit-Position: refs/heads/main@{#1427159}
Add new AIPageContentPageInteractionInfo and
AIPageContentFrameInteractionInfo fields and populate them with
information about selection, focused element, and mouse position.
Bug: 395912374, 396195115, 395906765
Change-Id: Ib0c647583b7ce460a3518f42524ea57de4f344d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6297810
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427158}
This CL adds functions for formatting and parsing of dates (= year,
month, day tuples). Followup CLs use these functions for entities.
Bug: 396325496
Change-Id: Id4eaa58943d66ac0d39a0746d0f608879a5f8b0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6312740
Reviewed-by: Jan Keitel <jkeitel@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#1427143}
Instead of creating boundary interface for each value type of the
PrefetchExceptions, we can just use an enum and pass any necessary
information in the onFailure and let AndroidX create this exception based
on the data passed.
This should be the clean and optimized way of handling it.
Bug: 355430425
Change-Id: I186c3a443ecb24955442116ad49bb84a81b7f581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6309156
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Commit-Queue: Sayed Elabady <elabadysayed@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427142}
During shared tab group join flow, collaboration controller opens
the tab group locally in the tab model. However, there is a race
condition due to which sometimes the OnTabGroupAdded observer
event from TabGroupSyncService arrives later (probably due to
PostTask) which tries to create the group again in the tab model
which leads to an assert. This CL ensures that the later event is
ignored quietly instead of crashing.
Bug: 399995422
Change-Id: I5da3c47350f49902132b875bc092d8e793e2c6f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6315385
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427140}
Add a new PrivateNetworkRequestPolicy that corresponds to blocking local
network access (LNA) requests if there is no permission from the user
for the LNA request.
The permission hasn't been implemented yet, so using the policy (which
is flag guarded) blocks the local network access request.
Note: there is mention of a separate permission related to the Private
Network Access (PNA) spec. This is a completely separate permission,
that will be removed when PNA is removed from the code base.
Unfortunately, we can't remove it for a few milestones, and so in the
meanwhile we are stuck with 2 different permissions in the code base
relating to PNA/LNA.
Change-Id: Iaac8b2ca983c1ee52d26fa178602853dc88327a4
Bug: 395895368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6292479
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Hubert Chao <hchao@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Chris Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1427139}
