0
Commit Graph

136694 Commits

Author SHA1 Message Date
6cdaff796b Create abstract common base class for impl scrollbars.
BUG=None

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11573015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173466 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 15:12:36 +00:00
28f8bcc928 [Android WebView] Fix FindBugs warnings in AwSettingsTest
R=benm@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11590015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173465 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 15:12:20 +00:00
66821ca545 [Mac] Website settings: Fix DCHECK that was checking the wrong condition.
The intention of the DCHECK was to ensure that the permissions view is always
laid out before the cookies view. The correct place to do this check is when
laying out the cookies view.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11567040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173464 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 15:12:09 +00:00
645b788fcf Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173463 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 15:03:28 +00:00
9e2eb3bb39 Roll Skia DEPS to r6830
control: https://codereview.chromium.org/11600003/
Review URL: https://codereview.chromium.org/11587005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173462 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 15:02:55 +00:00
72e8d4eb6e Fix black background when locking with fullscreen window:
Store background container visibility before lock animation, animate it's visibility on lock/unlock.
Change launcher to animate opacity-only (no size transformations).
Update tests so that handle new cases, and become more readable.
Also contains two lock animation fixes:
1) Shutdown animation now have correct cancel timing (it was tarting actual shutdown too early)
2) Flickering on starting and cancelling lock was removed, and tests were updated.

BUG=162646, 162645


Review URL: https://chromiumcodereview.appspot.com/11453012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173461 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 15:02:33 +00:00
0f2927b0b9 Adding more ONC validation tests.
- A typical configuration from real world.
- A configuration generated from CPanel.

BUG=162804
TBR=stevenjb@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11488008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173460 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 15:02:20 +00:00
7e740a05df Improve CertVerifyProcOpenSSL robustness against malicious data
This patch allows OpenSSL certificate verification to fail gracefully when
preliminary initialization step fails, rather than crashing the browser.

BUG=165858


Review URL: https://chromiumcodereview.appspot.com/11572060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173459 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 15:02:03 +00:00
343da03478 Fix a glitch in disentanglement of CertVerifyProc(OpenSSL/Android)
This refers to https://chromiumcodereview.appspot.com/11549033/, which separated OpenSSL/Android certificate verification routines.

As joth@chromium.org pointed out, the above erroneously omits hard-setting |issued_by_trusted_root| field of the result on Android. This patch fixes this omission.    

BUG=147786

Review URL: https://chromiumcodereview.appspot.com/11570019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173458 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 15:01:52 +00:00
36e2f7dd1b Telemtry: hooks "chrome.gpuBenchmarking.smoothScrollBy" with java on android.
In order to provide more realistic benchmarks, instead of shortcutting in native via mousewheels,
let Telemetry cross all the boundaries and synthesize MotionEvents all the way up in java.

BUG=
TEST=./tools/perf/run_multipage_benchmarks --browser=system smoothness_benchmark tools/perf/page_sets/key_mobile_sites.json


Review URL: https://chromiumcodereview.appspot.com/11415227

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173457 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 13:33:31 +00:00
3ad701402f Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173456 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 12:45:23 +00:00
2ccbb67d0b Webkit roll 137861:137885
http://trac.webkit.org/log/?rev=137885&stop_rev=137862&verbose=on

TBR=

BUG=


Review URL: https://chromiumcodereview.appspot.com/11586009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173455 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 12:45:02 +00:00
44f5ff8d9c Fix the color of the session length countdown timer
This CL fixes the color of the session length countdown timer. The timer
should only be red when the remaining time reaches 5 minutes.

BUG=chromium-os:26957
TEST=Manual
TBR=stevenjb@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11586010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173454 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 12:37:43 +00:00
7b2cf54d96 It hits the DCHECK when changing the permission for some types like media.
Also, media does not support "allow" in website setting, when the site permission for media is "allow", the global default should be selected as default, instead of block.

BUG=166396
TEST= go to apprtc.appspot.com, and verify the website setting.

Review URL: https://codereview.chromium.org/11571010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173453 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 12:34:17 +00:00
d91adf2eff Setting audio volume is no longer ignored on low latency audio path for Mac.
Note that Mac is (was) the only platform that did not use the volume level for the low-latency output path. This discrepancy is now removed.

This change should not affect the audio/video tag or any other audio client as far as I can tell.

TBR=dalecurtis
BUG=166394
TEST=Run this https://code.google.com/p/webrtc-samples/source/browse/trunk/demos/html/local-audio-rendering.html on Mac and verify that volume settings works.

Also executed: media_unittests

Review URL: https://codereview.chromium.org/11591013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173452 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 12:20:35 +00:00
42c45cbf07 [filemanager] Fix encoding issue in file watcher.
BUG=162379
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/11601005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173451 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 12:09:56 +00:00
dae927db1a Cleanup: Remote metadata parameter from ApplyLocalChange
As it's no longer necessary to pass in the file size to the drive uploader.

BUG=none
TEST=LocalFileSyncServiceTest.*

Review URL: https://codereview.chromium.org/11602004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173450 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 12:08:39 +00:00
a53804ba54 Remove partial magnifier from settings page.
Partial magnifier won't be on R25, so its settings should be hidden from chrome://settings.

BUG=165331
TEST=verify the setting is removed and magnifier is controllable via chrome:settings, system menu and oobe. browser_tests passes.

TBR=dbeam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11550010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173449 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 12:07:42 +00:00
d632a9a0f9 Optimise MaskWebSocketFramePayload().
Add benchmarks for MaskWebSocketFramePayload(). Add a test to ensure
that it gives the correct result regardless of how the input is aligned or
chunked.

Optimise MaskWebSocketFramePayload() to apply the mask one word at a time
instead of one byte at a time. This reduces the time to mask 64k from 0.073ms
to 0.008ms on 32bit, and 0.079ms to 0.005ms on 64bit.

Input shorter than two words in length is still masked one byte at a time,
so there is no significant change in performance for small payloads.

TEST=net_unittests --gtest_filter='WebSocketFrameTestMaskBenchmark.*' --websocket-mask-iterations=10000

BUG=


Review URL: https://chromiumcodereview.appspot.com/11572010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173448 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 12:00:58 +00:00
da0d3a29fd Cleanup WebDatabaseMigrationTest schemas after protector service removal.
BUG=165008
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/11591014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173447 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 11:57:09 +00:00
b995a1e1e6 [filemanager] Decode escaped url in action choice dialog open code.
BUG=163436
TEST=See bug.

Review URL: https://chromiumcodereview.appspot.com/11590013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173446 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 11:56:23 +00:00
3c6a095087 browser: Move two other functions from browser_finder.h into chrome namespace.
BUG=133088
TBR=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11587006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173445 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 11:56:09 +00:00
ddfd713b21 Rejecting networks/certificates independently on ONC import and policy loading.
Adapted NetworkLibrary and onc::CertificateImporter.

BUG=162801
TEST=Import an ONC with one invalid and one valid network/certificate.
Ensure that the valid one is correctly imported.
TBR=eroman@chromium.org (net_internals, string change)

Review URL: https://chromiumcodereview.appspot.com/11578005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173444 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 11:55:57 +00:00
c4485aad69 Add a command to lose the context
BUG=166020


Review URL: https://chromiumcodereview.appspot.com/11568029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173441 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 10:19:09 +00:00
40b2d96a69 [content shell] if the document is plain text, dump it as text
BUG=111316
TEST=less tests that fail with [ Missing ]
R=marja@chromium.org

Review URL: https://codereview.chromium.org/11586008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173440 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 10:06:33 +00:00
f3fdedc565 Do not update FileSystemUsageCache if the delta is zero
BUG=166158

Review URL: https://chromiumcodereview.appspot.com/11597005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173439 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 10:05:31 +00:00
1bedfcfa4f Updating trunk VERSION from 1363.0 to 1364.0
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173438 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 10:01:09 +00:00
f84b727ba8 [content shell] if a layout test runs notifyDone() before it has finished loading, wait for the page to finish loading
BUG=111316
R=marja@chromium.org

Review URL: https://codereview.chromium.org/11594006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173436 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 09:50:06 +00:00
09ec9f9bad [content shell] implement additional URL handling methods of the WebTestDelegate
Those callbacks are not yet used, but are required for the TestRunner

BUG=111316
R=marja@chromium.org

Review URL: https://codereview.chromium.org/11572041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173435 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 09:46:36 +00:00
0bfe67466d More debugging output for PlatformAppBrowserTest.WindowsApiBounds GTK failures
There were some more failures even after I checked in crrev.com/171709, so this CL
might give some more visibility into what's going wrong.

BUG=164735


Review URL: https://chromiumcodereview.appspot.com/11442038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173434 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 09:26:16 +00:00
eb85b8b1c5 Update USB extension API with suggestions from review.
BUG=122984

Review URL: https://chromiumcodereview.appspot.com/11577017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173433 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 09:25:05 +00:00
721c4476b5 Sandbox the worker process on Mac
When we transitioned to content it looks like we lost the Mac sandbox for workers, this CL re-enables it.

Also, update the comment in sandbox_init_mac.h

BUG=163208
TEST=Chrome should continue to work correctly.

Review URL: https://chromiumcodereview.appspot.com/11590006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173432 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 09:04:27 +00:00
ea43b15337 Adding a new folder/url to the BMB via right-click insert it at the location clicked
BUG=82610


Review URL: https://chromiumcodereview.appspot.com/11567003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173431 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 09:03:33 +00:00
32145a9eab gpu: Add async pixel transfers.
This adds a generic async pixel transfer interface, a
stub/fallback implementation and mocks/tests.

NOTRY=true
BUG=161337

Review URL: https://chromiumcodereview.appspot.com/11428140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173430 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 09:01:59 +00:00
3abf5ba768 Sync: Remove flag to explicitly enable history delete directive sync.
History delete directives should be on whenever full history sync is on.
Added a flag to explicitly disable delete directives, as with other sync
data types.

Also move flag for disabling tab sync to be alongside all the other sync flags.

BUG=165122

Review URL: https://codereview.chromium.org/11576009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173429 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 09:01:02 +00:00
2715b8b52f History: Modify about:flags description for experimental full history sync feature.
BUG=165122

Review URL: https://codereview.chromium.org/11572042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173428 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 08:50:27 +00:00
1f7fd789d1 Converted ResumeUploadOperation to use JSON in response instead of XML.
This was the last operation using xml in response. It is now converted to json, what simplifies the code significantly.

BUG=163303

Review URL: https://codereview.chromium.org/11577002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173427 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 08:02:24 +00:00
4626cd24a4 Improve immersive mode light bar painting
The light bar looks better with sharp software-renderer rectangles than with
the softened art assets we're using. For now, just draw rectangles until we
can replace (or remove) the art assets.

Also stretch the light bar a little left and right to make it visually match
the top line of the tab.

BUG=none
TEST=visual


Review URL: https://chromiumcodereview.appspot.com/11567057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173426 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 07:53:37 +00:00
ba40bb76d7 Avoid disk accesses on the wrong thread in URLRequestFileJob
while opening and positioning in the file.

Relanding of https://chromiumcodereview.appspot.com/10695110/. First attempt to
commit was reverted because FileStream blocked deletion of temporary files in
tests on Windows. After https://chromiumcodereview.appspot.com/11440008/ FileStream
always opens files with PLATFORM_FILE_SHARE_DELETE allowing tests to successfully
delete temporary files. Thus this CL should be safe to commit now (without changes
compared to initial commit).

BUG=59849, 114783
TEST=net_unittests

Review URL: https://chromiumcodereview.appspot.com/11490024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173425 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 07:11:04 +00:00
2b6d741301 A11y: polish texts in the settings and oobe
'High contrast mode' => 'High contrast'

BUG=none
TEXT=manual

TBR=derat@chromium.org
# TBRing for string changes.

Review URL: https://chromiumcodereview.appspot.com/11571019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173424 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 06:58:48 +00:00
ef1dd5067b Show app list items which open in chrome with a tab overlay.
This change affects chrome os and windows implementations of the app list. Chrome, web store, and v1 apps like google search are displayed with a tab overlay.

BUG=159859

Review URL: https://chromiumcodereview.appspot.com/11442044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173423 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 06:41:33 +00:00
cac391a746 "Open All Bookmarks in Incognito Window" opens only valid URLs except it can't be opened in incognito window.
BUG=106607

Review URL: https://chromiumcodereview.appspot.com/11572031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173422 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 06:29:55 +00:00
c3c9652c4f Revert 173417 - Broke on win_aura
Yet another approach. Not pretty, but simple and works.

BUG=156772


Review URL: https://chromiumcodereview.appspot.com/11451002

TBR=mtomasz@chromium.org
Review URL: https://codereview.chromium.org/11594004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173421 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 05:37:42 +00:00
4b96530816 Revert 173418 - Broke on win_aura
Compile fix for r173417.

BUG=156772

Review URL: https://codereview.chromium.org/11588008

TBR=mtomasz@chromium.org
Review URL: https://codereview.chromium.org/11600004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173420 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 05:36:23 +00:00
9cb431893a exclude more test from browser_test with Dr.Memory
TBR=bruening@chromium.org

Review URL: https://codereview.chromium.org/11592006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173419 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 05:23:19 +00:00
03b61732ef Compile fix for r173417.
BUG=156772

Review URL: https://codereview.chromium.org/11588008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173418 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 05:04:35 +00:00
6b58b28609 Yet another approach. Not pretty, but simple and works.
BUG=156772


Review URL: https://chromiumcodereview.appspot.com/11451002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173417 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 04:30:56 +00:00
f30e3dac09 Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173416 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 04:21:27 +00:00
7a696abac1 Add size checks to extension icons and favicons to prevent out of memory conditions
BUG=165423

Review URL: https://chromiumcodereview.appspot.com/11576030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173415 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 04:20:41 +00:00
22d7a6c13d Webkit roll 137761:137861
http://trac.webkit.org/log/?rev=137861&stop_rev=137762&verbose=on

TBR=

BUG=


Review URL: https://chromiumcodereview.appspot.com/11591007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173414 0039d316-1c4b-4281-b951-d872f2087c98
2012-12-17 04:20:29 +00:00