The intention of the DCHECK was to ensure that the permissions view is always
laid out before the cookies view. The correct place to do this check is when
laying out the cookies view.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11567040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173464 0039d316-1c4b-4281-b951-d872f2087c98
Store background container visibility before lock animation, animate it's visibility on lock/unlock.
Change launcher to animate opacity-only (no size transformations).
Update tests so that handle new cases, and become more readable.
Also contains two lock animation fixes:
1) Shutdown animation now have correct cancel timing (it was tarting actual shutdown too early)
2) Flickering on starting and cancelling lock was removed, and tests were updated.
BUG=162646, 162645
Review URL: https://chromiumcodereview.appspot.com/11453012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173461 0039d316-1c4b-4281-b951-d872f2087c98
This patch allows OpenSSL certificate verification to fail gracefully when
preliminary initialization step fails, rather than crashing the browser.
BUG=165858
Review URL: https://chromiumcodereview.appspot.com/11572060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173459 0039d316-1c4b-4281-b951-d872f2087c98
This refers to https://chromiumcodereview.appspot.com/11549033/, which separated OpenSSL/Android certificate verification routines.
As joth@chromium.org pointed out, the above erroneously omits hard-setting |issued_by_trusted_root| field of the result on Android. This patch fixes this omission.
BUG=147786
Review URL: https://chromiumcodereview.appspot.com/11570019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173458 0039d316-1c4b-4281-b951-d872f2087c98
In order to provide more realistic benchmarks, instead of shortcutting in native via mousewheels,
let Telemetry cross all the boundaries and synthesize MotionEvents all the way up in java.
BUG=
TEST=./tools/perf/run_multipage_benchmarks --browser=system smoothness_benchmark tools/perf/page_sets/key_mobile_sites.json
Review URL: https://chromiumcodereview.appspot.com/11415227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173457 0039d316-1c4b-4281-b951-d872f2087c98
This CL fixes the color of the session length countdown timer. The timer
should only be red when the remaining time reaches 5 minutes.
BUG=chromium-os:26957
TEST=Manual
TBR=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11586010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173454 0039d316-1c4b-4281-b951-d872f2087c98
Also, media does not support "allow" in website setting, when the site permission for media is "allow", the global default should be selected as default, instead of block.
BUG=166396
TEST= go to apprtc.appspot.com, and verify the website setting.
Review URL: https://codereview.chromium.org/11571010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173453 0039d316-1c4b-4281-b951-d872f2087c98
Note that Mac is (was) the only platform that did not use the volume level for the low-latency output path. This discrepancy is now removed.
This change should not affect the audio/video tag or any other audio client as far as I can tell.
TBR=dalecurtis
BUG=166394
TEST=Run this https://code.google.com/p/webrtc-samples/source/browse/trunk/demos/html/local-audio-rendering.html on Mac and verify that volume settings works.
Also executed: media_unittests
Review URL: https://codereview.chromium.org/11591013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173452 0039d316-1c4b-4281-b951-d872f2087c98
As it's no longer necessary to pass in the file size to the drive uploader.
BUG=none
TEST=LocalFileSyncServiceTest.*
Review URL: https://codereview.chromium.org/11602004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173450 0039d316-1c4b-4281-b951-d872f2087c98
Partial magnifier won't be on R25, so its settings should be hidden from chrome://settings.
BUG=165331
TEST=verify the setting is removed and magnifier is controllable via chrome:settings, system menu and oobe. browser_tests passes.
TBR=dbeam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11550010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173449 0039d316-1c4b-4281-b951-d872f2087c98
Add benchmarks for MaskWebSocketFramePayload(). Add a test to ensure
that it gives the correct result regardless of how the input is aligned or
chunked.
Optimise MaskWebSocketFramePayload() to apply the mask one word at a time
instead of one byte at a time. This reduces the time to mask 64k from 0.073ms
to 0.008ms on 32bit, and 0.079ms to 0.005ms on 64bit.
Input shorter than two words in length is still masked one byte at a time,
so there is no significant change in performance for small payloads.
TEST=net_unittests --gtest_filter='WebSocketFrameTestMaskBenchmark.*' --websocket-mask-iterations=10000
BUG=
Review URL: https://chromiumcodereview.appspot.com/11572010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173448 0039d316-1c4b-4281-b951-d872f2087c98
Adapted NetworkLibrary and onc::CertificateImporter.
BUG=162801
TEST=Import an ONC with one invalid and one valid network/certificate.
Ensure that the valid one is correctly imported.
TBR=eroman@chromium.org (net_internals, string change)
Review URL: https://chromiumcodereview.appspot.com/11578005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173444 0039d316-1c4b-4281-b951-d872f2087c98
Those callbacks are not yet used, but are required for the TestRunner
BUG=111316
R=marja@chromium.org
Review URL: https://codereview.chromium.org/11572041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173435 0039d316-1c4b-4281-b951-d872f2087c98
There were some more failures even after I checked in crrev.com/171709, so this CL
might give some more visibility into what's going wrong.
BUG=164735
Review URL: https://chromiumcodereview.appspot.com/11442038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173434 0039d316-1c4b-4281-b951-d872f2087c98
When we transitioned to content it looks like we lost the Mac sandbox for workers, this CL re-enables it.
Also, update the comment in sandbox_init_mac.h
BUG=163208
TEST=Chrome should continue to work correctly.
Review URL: https://chromiumcodereview.appspot.com/11590006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173432 0039d316-1c4b-4281-b951-d872f2087c98
This adds a generic async pixel transfer interface, a
stub/fallback implementation and mocks/tests.
NOTRY=true
BUG=161337
Review URL: https://chromiumcodereview.appspot.com/11428140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173430 0039d316-1c4b-4281-b951-d872f2087c98
History delete directives should be on whenever full history sync is on.
Added a flag to explicitly disable delete directives, as with other sync
data types.
Also move flag for disabling tab sync to be alongside all the other sync flags.
BUG=165122
Review URL: https://codereview.chromium.org/11576009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173429 0039d316-1c4b-4281-b951-d872f2087c98
This was the last operation using xml in response. It is now converted to json, what simplifies the code significantly.
BUG=163303
Review URL: https://codereview.chromium.org/11577002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173427 0039d316-1c4b-4281-b951-d872f2087c98
The light bar looks better with sharp software-renderer rectangles than with
the softened art assets we're using. For now, just draw rectangles until we
can replace (or remove) the art assets.
Also stretch the light bar a little left and right to make it visually match
the top line of the tab.
BUG=none
TEST=visual
Review URL: https://chromiumcodereview.appspot.com/11567057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173426 0039d316-1c4b-4281-b951-d872f2087c98
while opening and positioning in the file.
Relanding of https://chromiumcodereview.appspot.com/10695110/. First attempt to
commit was reverted because FileStream blocked deletion of temporary files in
tests on Windows. After https://chromiumcodereview.appspot.com/11440008/ FileStream
always opens files with PLATFORM_FILE_SHARE_DELETE allowing tests to successfully
delete temporary files. Thus this CL should be safe to commit now (without changes
compared to initial commit).
BUG=59849, 114783
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/11490024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173425 0039d316-1c4b-4281-b951-d872f2087c98
This change affects chrome os and windows implementations of the app list. Chrome, web store, and v1 apps like google search are displayed with a tab overlay.
BUG=159859
Review URL: https://chromiumcodereview.appspot.com/11442044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173423 0039d316-1c4b-4281-b951-d872f2087c98