This change:
1. Moves all overfow-menu-carousel-related matchers into one location:
chrome_matchers.
2. Updates carousel matchers' names to use new "...Destination..."
naming convention.
3. Removes unnecessary, duplicate construction of matchers throughout
codebase, instead using the newly-refactored, localized set of matchers
in chrome_matchers.
Bug: 1339367
Change-Id: I87c2a0a6063e88e2697772c32e962772bd16881e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3722366
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Benjamin Williams <bwwilliams@google.com>
Cr-Commit-Position: refs/heads/main@{#1018208}
Xcode 13.1 or higher is required to build Chrome on iOS (required
for the catalyst environment). Bump the version in the documentation
and the version check in the code.
JDK is no longer used for the build, remove it from the list of
required software.
Bug: none
Change-Id: If4ddf544b70e2c032ac3e4af95b40a02865e3b9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3487908
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Commit-Queue: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/main@{#974670}
I suspect we actually never want this type of quote. However,
correcting them everywhere seems a lot of useless work. In the case of
code snippet however, it seems important to have it right.
Bug: 1294776
Change-Id: I71d63c902a959a3bede5aeb48bc2500a232097f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3443425
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Auto-Submit: Arthur Milchior <arthurmilchior@google.com>
Commit-Queue: Arthur Milchior <arthurmilchior@google.com>
Cr-Commit-Position: refs/heads/main@{#971228}
Test modules needs to have a stub version of the interface class
available to satisfy the linker. This stub is declared with the
macro GREY_STUB_CLASS_IN_APP_MAIN_QUEUE.
Xcode code completion is broken if the macro is not followed by
a semi-colon, but clang complains about trailing semi-colon in a
place where it is not required.
To bypass this issue, for each foo_interface.h file, create a
foo_interface_stub.mm file containing just the macro call. It
also avoid putting the stub declaration in a random source file.
Fix some naming inconsistency in file/target names.
Bug: 1015113
Change-Id: I6596575e8b7f8c0fac42fc8aace1568cecd69dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222908
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#931916}
Building Chromium on iOS now requires access to iOS 15.0 SDK, so
update the documentation and the assert that enforces a correct
version of Xcode is used.
Bug: none
Change-Id: I5d77bf8682a19d7f3b01e7a2319646c57a7ebf3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193013
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#926262}
Xcode supports having a custom .lldbinit file per target. Chrome
requires using .lldbinit to configure the path mapping to debug.
This is due to debugging symbols using relative paths to support
reproducible build.
This CL change setup-gn.py to generate a .lldbinit file alongside
the project with the proper instruction to setup the mapping. It
will help with engineer working with multiple checkout (or that
do not read the documentation).
Bug: 1153050
Change-Id: I4bd764bd0d7938c2ea871529d010e0645e77d68b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2656262
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#848359}
Goma RBE only supports paths that are relative to the source dir
while build not using Goma or using old Goma backend supports both
so always use symbolic link to system Xcode on iOS when using Goma.
This fix the compilation for people using Goma as Goma RBE is now
the default backend and without this change, the build would fall
back to local compilation, drastically slowing the build.
Stop using the ios_enable_relative_sdk_path and ios_use_goma_rbe
gn variables as they are now always expected to be `true`. Keep
the variable ios_use_goma_rbe to avoid breaking the bots that do
override the value but ignore it (bot set it to true anyway).
Bug: 1015730, 1154201
Change-Id: I728ebd960e73d5c4a021817a8acdde5e51f30181
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561844
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832765}
This reverts commit a06a6eb759.
Reason for revert: Seems to break non-goma builds on macos.
Original change's description:
> [ios] Always use symbolic links to system Xcode in build_root_dir
>
> Goma RBE only supports paths that are relative to the source dir
> while build not using Goma or using old Goma backend supports both
> so always use symbolic link to system Xcode on iOS.
>
> This fix the compilation for people using Goma as Goma RBE is now
> the default backend and without this change, the build would fall
> back to local compilation, drastically slowing the build.
>
> Stop using the ios_enable_relative_sdk_path and ios_use_goma_rbe
> gn variables as they are now always expected to be `true`. Keep
> the variable ios_use_goma_rbe to avoid breaking the bots that do
> override the value but ignore it (bot set it to true anyway).
>
> Bug: none
> Change-Id: I2a3c098304594fb20491ab92100e9a4101a048db
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555117
> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#830616}
TBR=thakis@chromium.org,sdefresne@chromium.org
Change-Id: I5aed7d701a1d2d04d389cb4d746bc975e80b0f0f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561019
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831019}
Goma RBE only supports paths that are relative to the source dir
while build not using Goma or using old Goma backend supports both
so always use symbolic link to system Xcode on iOS.
This fix the compilation for people using Goma as Goma RBE is now
the default backend and without this change, the build would fall
back to local compilation, drastically slowing the build.
Stop using the ios_enable_relative_sdk_path and ios_use_goma_rbe
gn variables as they are now always expected to be `true`. Keep
the variable ios_use_goma_rbe to avoid breaking the bots that do
override the value but ignore it (bot set it to true anyway).
Bug: none
Change-Id: I2a3c098304594fb20491ab92100e9a4101a048db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555117
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830616}
The new Widget requires Xcode 12.0 or higher to build, so assert
that the version of Xcode used for the build is recent enough.
Update the documentation to recommend the same version of Xcode
as enforced by the code, and add tips on steps recommended to
perform when updating Xcode.
Bug: none
Change-Id: I8b8fbf3d53ef2ab98c2407e28e46ce4321cd72f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527175
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#827785}
Running setup-gn.py as part of `gclient runhooks` makes working
with the generated Xcode project on iOS much easier. Add some
documentation on how to achieve this.
Bug: none
Change-Id: Id8022ab403a1a1ab1a40f8b01d08e1e49c2554f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287592
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786686}
There is now only a single project generated from gn, so update the
documentation to remove reference to the workspace (and remove old
warnings against opening the project directly).
Bug: none
Change-Id: I8d19c078159154c740e9c7fae5b72b62b1997ce3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267097
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782952}
Now that code coverage script works on iOS platform no different from
other platforms, it doesn't make sense to keep the iOS specific code
coverage docs anymore.
Bug: 800876
Change-Id: If9344e7283dae05255cc5518609dced2f4367593
Reviewed-on: https://chromium-review.googlesource.com/950469
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541158}
Add another section to explain that -d and -s arguments to iossim
are optional and may require installing additional components in
Xcode.
Bug: none
Change-Id: Iafb4e61d78be799f56862357e5e02c1d4f785dab
Reviewed-on: https://chromium-review.googlesource.com/897484
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533618}
