733e70c328
Send the correct "final update" value, with a test case to trigger the failing scenario. While trying to reduce the number of messages sent while performing find-in-page in crrev.com/1021347, the "final update" bit got set incorrectly and got sent twice in some cases. This causes the browser to "hang up" after receiving the first "final update" message and ignore the second one. Developer builds also trigger a DCHECK() failure when this happens. Fix this by giving the plugin more control over the "final update" bit in the blink::WebPluginContainer::ReportFindInPageSelection() interface, and make the simple change in WebPluginContainerImpl() to pass the value along. Then add all the plumbing necessary to the PDF plugin code to communicate with WebPluginContainer, and let PDFiumEngine::SelectFindResult() send the appropriate values. Bug: 1352097 Change-Id: I91c1433792f0f931258fb893954180f8af1c5f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828901 Reviewed-by: K. Moon <kmoon@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1037259}
Chromium
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead,
follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.