Renamed chromium_code.flags to shared_with_cronet.flags, this makes it
clearer that the configs in this file are shared and any configs that do
not need to be shared should go in chromium_apk.flags.
Bug: 338060678
Change-Id: I108e40079859f5d6a553a5c4a811878ca0cb1f45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502569
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Etienne Dechamps <edechamps@google.com>
Reviewed-by: Etienne Dechamps <edechamps@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294888}
This removes remoting_apk and remoting_test_apk from the list of all gn
targets (tested with `ninja -C out/Dir -t targets | grep remoting_apk`).
Actually removing the targets is left to future CLs since downstream
repos need to remove references to those targets first in order to avoid
breakages.
This should however unblock bots that build all targets from breaking on
androidx rolls as currently they build all targets (which before this CL
includes remoting_apk and remoting_test_apk).
Bug: 1501128, 1519713
Change-Id: I15750a38b63706b5a90072a146bc1ff3b4167c57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258621
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Owners-Override: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1255302}
Now that there are many autorollers and we no longer use the lint in
cmdline-tools, these sections of lint.md are obsolete and most devs will
not need to update baseline files. Since upstream and downstream have
their own lint binaries, baseline file changes can usually be landed
independently.
Bug: None
Change-Id: Ib673d43a87622e602dd1d28fe690309fa81b13f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4008781
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1068189}
These annotation java files have been moved to build as they relate more
to our build than base. Their package name should reflect their current
location.
The old code and proguard flags have been kept to avoid breaking
downstream. They will be removed after downstream rename is landed.
Cq-Include-Trybots: luci.chrome.try:android-internal-rel
Bug: 1038372
Change-Id: I58a00a67816214ff81a62899409c5d5dbd3e3965
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3851209
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Owners-Override: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1045966}
The .build_config files generated by write_build_config.py are actually
valid json files. Renaming them makes it clear that they are json files
and should show up in code search.
Bug: 1215551
Change-Id: I686a2084a808248508ddf624542795e4341be1a0
Fixed: 1215551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3017823
Commit-Queue: Peter Wen <wnwen@chromium.org>
Owners-Override: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#900497}
When trying to generate code coverage for downstream targets, there may
be duplicate classes, ie classes from the downstream jars and classes
from the upstream jars. This allows the upstream bars to be filtered
out.
Bug: 1204715
Change-Id: I1813d46b30de194b913d6a88e6f566389525334a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2863916
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879562}
No change to logic. This replaces "whitelist" with the term "allowlist"
for every file in build/android/ except the play_services/ subfolder
(it looks like play_services/ accepts a JSON file with "whitelist" as
property names).
Test: N/A
Change-Id: I6a06786085bc34c109e0b138101a8fbf802ceff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2743423
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#861090}
As recommended in the lint README, lint-suppressions.xml should only be
used for temporary and permanent ignores, not for old code that should
be fixed at some point:
https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.md
Thus, bulk-moving ignores for old code into lint-baseline.xml.
The one exception is for UnusedResources, since having these checks in
lint-baseline.xml causes a lot of bloat in terms of lines since each
language's xml file is listed on a separate line for every resource.
Bug: 1069186, 1077861, 1116130, 1085410, 1039415
Fixed: 1069186, 1085410
Change-Id: Iac10f4dc087e12b43595aae154dc7ffb821f2325
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552853
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829920}
This adds a section to explain how to out-of-line methods which return
or accept new types. This isn't generally necessary for implementation
code, but this is important for external-facing classes (such as
WebView's glue layer).
Fixed: 1112420
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: Ia5f835663780c50e1d1601e969a5a6d550e9fbf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493430
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820381}
AGSA queries an apps icon by name and thus fails on collapsed names. The
fix is to not collapse mipmaps (application icons).
This also fixes an old layering bug where chrome only resources were
listed under android_webview by allowing multiple config files for use
by Monochrome and Trichrome. Additionally the directive no_obfuscate has
been deprecated with no_collapse as its replacement.
TBR=boliu@chromium.org # noop change to webview config file.
Bug: b/161564466
Change-Id: Idb735cd07e9e95ab572297c8dc4848451d8d52bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343755
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796449}
go/clank-webview points at a new site now, and some of the
subdirectories have changed. This updates chromium links to
go/clank-webview for the new paths.
Test: verify each link points to the correct page.
Change-Id: Ieed6dd527dca87e51c98b6182c68c843cb82486d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307534
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790488}
We migrated into an inheritance based R.java files that means that each
R.java file has access to all resources without manually specifying each
resource individually. This means the extra_r_text_files option is no
longer needed/used since we no longer need to know exactly what is in
each R.java file separately.
Change-Id: I71ebabda0d998a53a0ae54b8a3fd6cd84311105d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302933
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789316}
Changes it into an analysis step rather that runs at the same time as
errorprone.
Removes ability to output .jar files from bytecode_processor. It now
outputs a stamp file.
TBR=agrieve # Renamed build variable.
Bug: 1080670
Change-Id: If98eb4e3673ccdfa47c151370b3f98aa23488a15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210873
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771033}
This reverts commit 01c325ec60.
Reason for revert: Repro'ed locally and ensured fixed.
To elaborate:
* The breakage occurred only in incremental builds, and only when
building before / after this change.
* E.g. Clean builds were correct, but the break was due to
the transition of before this CL to after.
* The fix I've done here is just to rename the output of the
pre-dexsplitter r8 output so that the stale artifact does
not break things.
I think there might be a bug in dexsplitter that contributed
to this breakage as well, but not going to dig into it since
I've got another change underway to remove the use of
dexsplitter.
Original change's description:
> Revert "Use .r8dex.jar and .mergeddex.jar rather than .dex.zip"
>
> This reverts commit 89a7ef178a.
>
> Reason for revert: This is breaking WebView bundles on the official builders, see crbug.com/1069724. It looks like bundletool looks specifically for .dex extensions[1], and this change breaks that assumption.
>
> 1. 3586f8630e/src/main/java/com/android/tools/build/bundletool/validation/DexFilesValidator.java (L48)
>
> Original change's description:
> > Use .r8dex.jar and .mergeddex.jar rather than .dex.zip
> >
> > This just renames the extensions in order to make build speed summaries
> > distinguish the two.
> >
> > Bug: 1067273
> > Change-Id: I0a1e14cfed3557d29cd6beb0987436cacfaf6b65
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140908
> > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > Commit-Queue: Peter Wen <wnwen@chromium.org>
> > Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> > Reviewed-by: Peter Wen <wnwen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#757855}
>
> TBR=wnwen@chromium.org,agrieve@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1067273, 1069724
> Change-Id: Ied71fc35aef250bdbf21ee4ec34f5bb2d0eb3423
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145860
> Reviewed-by: Clark DuVall <cduvall@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#758275}
Bug: 1067273, 1069724
Change-Id: I8c505ba68d1c5880a3b39eaec53455e804d48e29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149286
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759240}
