BUG=222403
Test=Manually test BrowserPlugin/<webview> on chrome and content_shell
Review URL: https://chromiumcodereview.appspot.com/12518033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190057 0039d316-1c4b-4281-b951-d872f2087c98
This has a few special cases, to be able to deal with all sorts of combinations of Me2Me/It2Me/old-plugin/old-webapp/old-host.
The idea is: A webapp that supports asking for PINs asynchronously will explicitly notify the plugin of that. Older webapps (or It2Me) will send the passphrase directly on connect.
The negotiating authenticator, instead of immediately trying to send the first SPAKE message, first sends a message with the supported methods to the host, and only when the host replies with the specific method it tries to create the authenticator. If there is a PinFetcher interface, it tries to use a PinClientAuthenticator (a thin layer on top of V2Authenticator that takes care of asynchronously asking for PIN), otherwise it uses V2Authenticator directly with the pre-provided pass phrase.
This also adds support for authenticators that can't be created in a particular state (e.g. ones for which the first message must go in one particular direction). The NegotiatingAuthenticator takes care of sending blank messages/ignoring those messages as appropriate.
BUG=115899
Review URL: https://chromiumcodereview.appspot.com/12518027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190056 0039d316-1c4b-4281-b951-d872f2087c98
This allows more configuration of the aapt call from within gyp. This is primarily to support differences that are required to use process_resources.py for java_apk.gypi.
BUG=158821
Review URL: https://chromiumcodereview.appspot.com/12516019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190055 0039d316-1c4b-4281-b951-d872f2087c98
on the static IP configuration page in network settings.
Also, adjust the size of the dialog so that custom DNS fields don't
cause scrolling.
BUG=chromium:172634
Review URL: https://chromiumcodereview.appspot.com/12502012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190053 0039d316-1c4b-4281-b951-d872f2087c98
In InstantExtended, cross origin iframes are used to display objects which can
only be referenced by the Instant page using an ID (restricted ID). These IDs
need to be unique and and cached for a while so that the SearchBox API can
fetch the object info based on the ID. The reason to use a cache of N items as
against just the last set of results is that there may be race conditions
between the internal state of the SearchBox and the data being displayed.
This CL introduces a template class InstantRestrictedIDCache that can be used
to generate the restricted IDs for objects, cache them and fetch objects based
on the IDs.
BUG=181870
Review URL: https://chromiumcodereview.appspot.com/12498002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190052 0039d316-1c4b-4281-b951-d872f2087c98
BUG=173251
TEST=Open any page that downloads an attachment such as gmail email with an attachment or
a page with an image. Download the image or an attachment - that will open a download bar at the bottom of the window. Verify that the downward arrow in the bar is centered vertically.
Review URL: https://chromiumcodereview.appspot.com/12490014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190050 0039d316-1c4b-4281-b951-d872f2087c98
Feedback Experiment to test response rate (usage of report an issue) when alternate text (Send Feedback) and or an alternate location (on windows/linux/mac the main Wrench Menu, on ChromeOS in the more tools option) is used. In the case of alternate text experiments the label for the report an issue button on the chrome://help page is also changed.
BUG=169339
TEST=Manual
Default behavior should not change, to confirm desired behavior run chrome with --force-fieldtrials=SendFeedbackLinkLocation/$GROUP_NAME/
Where GROUP_NAME is one of {alt-text,alt-location,alt-text-and-location} (note trailing '/' is required!)
Review URL: https://chromiumcodereview.appspot.com/12490012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190049 0039d316-1c4b-4281-b951-d872f2087c98
This changes the wrench menu's MenuButtonBackground to use NativeTheme colors under aura, and introduces kColorId_HotMenuItemBackgroundColor.
BUG=130810
Review URL: https://chromiumcodereview.appspot.com/12483006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190048 0039d316-1c4b-4281-b951-d872f2087c98
This method is no longer used. It was originally intended to prevent
drag and drop operations on popup windows and panels on CrOS from
triggering navigation operations in a new tab. Unfortunately, this is
not the correct way to fix the problem anyway; if this method were
actually used, it would prevent *all* drag and drop from working in the
popup/panel window. The correct fix is to plumb through the relevant
drag and drop policy to WebKit so the renderer knows not to initiate a
navigation.
BUG=none
TBR=jam
Review URL: https://codereview.chromium.org/12938013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190045 0039d316-1c4b-4281-b951-d872f2087c98
The <adview> tag is available only in packaged apps v2 -- when specifying the "adview" permission. It enables packaged apps to embed ads in a separate process (similar to <webview>), thus enforcing some separation between ad networks and app code for both security and privacy.
BUG=180618
Review URL: https://chromiumcodereview.appspot.com/12463015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190043 0039d316-1c4b-4281-b951-d872f2087c98
Chrome must show notification bar when screen capture API is used to capture
the screen. This CL reuses the notification bar that's currently used by
remoting host (see src/remoting/host/disconnect_window*). The new files are
mostly copy of the existing code in remoting (except different names).
The plan is to keep it temporarily and replace it with something better before
the API is enabled for everybody.
BUG=190156
Review URL: https://chromiumcodereview.appspot.com/12453019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190041 0039d316-1c4b-4281-b951-d872f2087c98
Previous version was reverted because it broke check_license.py.
Relanding now that the license issues are resolved. See
crbug.com/222615.
Used for the Simple Chrome Workflow (go/simple-chrome). pyelftools is a
dependency of chromite.
BUG=None
TEST=trybots
Review URL: https://chromiumcodereview.appspot.com/12426021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190038 0039d316-1c4b-4281-b951-d872f2087c98
I'll work on better fix for m28 as described in the bug.
BUG=222483
TEST=autohide launcher works on any side (lefr,right,top,bottom) when display is rotated.
Review URL: https://chromiumcodereview.appspot.com/12423007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190037 0039d316-1c4b-4281-b951-d872f2087c98
Screen Capture polls under Linux/X11, to avoid issues with poor XDAMAGE
support in some X hardware drivers for things like 3D rendering.
This CL enables XDAMAGE support under ChromeOS, since on that platform we
can make sure that the drivers support it properly.
BUG=177977
Review URL: https://chromiumcodereview.appspot.com/12408035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190032 0039d316-1c4b-4281-b951-d872f2087c98
We always build with skia now. This change removes dead code, and unnecessary
USE_SKIA guards.
BUG=110881
Review URL: https://chromiumcodereview.appspot.com/12406010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190031 0039d316-1c4b-4281-b951-d872f2087c98
Set new Aura dialogs' corewm::ShadowType to SHADOW_TYPE_NONE.
Removes the extra frame around new style dialogs on CrOS.
( does the same on the experimental Windows ash_shell )
See http://crbug.com/166075#c37 for before/after screenshots.
This doesn't remove the black dialog border on Win.
( non-transparency is required to host native controls )
BUG=166075
TEST=CrOS --enable-new-dialog-style looks nicer.
R=sky@chromium.org,ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12391056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190030 0039d316-1c4b-4281-b951-d872f2087c98
When capture device list is empty, we show a "None available" title to clearly tell the users there is no device, instead of having empty menu.
This will also fix the problem when the height of the empty menu is not the same as the other menu with item.
BUG=178383
Review URL: https://codereview.chromium.org/12457016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190028 0039d316-1c4b-4281-b951-d872f2087c98
gtest only writes test output to stdout, but on iOS 6 devices, stdout is not
available to be retrieved from the device. This CL redirects stdout to a file
while the tests are running, then dumps the contents of that file to NSLog
(which is available to be retrieved from the device).
BUG=None
Review URL: https://chromiumcodereview.appspot.com/12328083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190025 0039d316-1c4b-4281-b951-d872f2087c98
This adds a new Authenticator, that uses a third-party token service to authenticate clients and hosts and negotiate a shared secret.
The client authenticates with the third-party service, and obtains a token and a shared secret. The token is sent directly to the host, the shared secret is used to initiate a SPAKE authentication.
The host receives the token, and asks the third-party server to exchange it for the shared secret (authenticating itself by signing the request with the host private key). Once it gets the shared secret, client and host are able to finish the SPAKE negotiation.
BUG=115899
Review URL: https://chromiumcodereview.appspot.com/12326090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190024 0039d316-1c4b-4281-b951-d872f2087c98
Introducing a task manager. A task is an event chain that does certain work that we want to be atomic. Execution of multiple tasks is serialized.
Also, adding checks for anomalous situations, such as a forever-running task keeps the event page from unloading or a task still running when the event page unloads.
BUG=164227
Review URL: https://chromiumcodereview.appspot.com/12316075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190023 0039d316-1c4b-4281-b951-d872f2087c98
> Reland libjingle.gyp refactoring change.
>
> Original description (from https://codereview.chromium.org/12457027/):
> Refactor libjingle and libpeerconnection targets.
> I'm moving most of the source files back to the libjingle target since the
> current splitting doesn't work for all targets that currently rely on libjingle.
> The webrtc core libs are still only in the libpeerconnection target, and
> require the enable_webrtc gyp variable to be be set.
>
> I'm also adding a gyp variable to the libjingle target to support dependency
> injection as is supported for libpeerconnection.
>
> TBR=ronghuawu@chromium.org
>
> Review URL: https://codereview.chromium.org/12967005TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/13009007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190021 0039d316-1c4b-4281-b951-d872f2087c98
BUG=223172
This just adds a gyp variable that enables or disables the use of the OpenMAX DL FFT routines.
Review URL: https://chromiumcodereview.appspot.com/12260023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190019 0039d316-1c4b-4281-b951-d872f2087c98
Replacing FindTabbedBrowser by FindOrCreateTabbedBrowser and Navigate to open the tab.
Using Restore() to actually make the browser window visible. Otherwise it will remain minimized.
BUG=172203
Review URL: https://chromiumcodereview.appspot.com/12089026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190018 0039d316-1c4b-4281-b951-d872f2087c98
Tapping on the touchscreen during a fling scroll causes a
GestureFlingCancel to be sent to stop the fling. It also sends a pair of
GestureTapDown/GestureTap events that should be suppressed if the fling
is successfully stopped (otherwise we will have undesirable side
effects; e.g. activating a link or push button in tap location). This
was working for touchpad. It is now added for touchscreen, too.
BUG=162242
Review URL: https://chromiumcodereview.appspot.com/12087140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190017 0039d316-1c4b-4281-b951-d872f2087c98
Original description (from https://codereview.chromium.org/12457027/):
Refactor libjingle and libpeerconnection targets.
I'm moving most of the source files back to the libjingle target since the
current splitting doesn't work for all targets that currently rely on libjingle.
The webrtc core libs are still only in the libpeerconnection target, and
require the enable_webrtc gyp variable to be be set.
I'm also adding a gyp variable to the libjingle target to support dependency
injection as is supported for libpeerconnection.
TBR=ronghuawu@chromium.org
Review URL: https://codereview.chromium.org/12967005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190016 0039d316-1c4b-4281-b951-d872f2087c98
For some reason the test interferes with others and the race on the stack variable gets ignored.
BUG=223016
TBR=thestig,darin
Review URL: https://codereview.chromium.org/13040003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190002 0039d316-1c4b-4281-b951-d872f2087c98
> Revert 189990 - re-re-land of "Refactor libjingle and libpeerconn..."
> The previous attempt failed because libjingle hadn't been rolled yet. Still waiting on trybots a day later.
>
> > > > > Refactor libjingle and libpeerconnection targets.
> > > > > I'm moving most of the source files back to the libjingle target since the current splitting doesn't work for all targets that currently rely on libjingle. The webrtc core libs are still only in the libpeerconnection target, and require the enable_webrtc gyp variable to be be set.
> > > > >
> > > > > I'm also adding a gyp variable to the libjingle target to support dependency injection as is supported for libpeerconnection.
> > > > >
> > > > > TBR=darin
> > > > >
> > > > > Review URL: https://codereview.chromium.org/12457027
> > > >
> > > > TBR=tommi@chromium.org
> > > > Review URL: https://codereview.chromium.org/12662028
>
> TBR=tommi@chromium.org
> Review URL: https://codereview.chromium.org/12891005TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/12512017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189996 0039d316-1c4b-4281-b951-d872f2087c98
The previous attempt failed because libjingle hadn't been rolled yet. Still waiting on trybots a day later.
> > > > Refactor libjingle and libpeerconnection targets.
> > > > I'm moving most of the source files back to the libjingle target since the current splitting doesn't work for all targets that currently rely on libjingle. The webrtc core libs are still only in the libpeerconnection target, and require the enable_webrtc gyp variable to be be set.
> > > >
> > > > I'm also adding a gyp variable to the libjingle target to support dependency injection as is supported for libpeerconnection.
> > > >
> > > > TBR=darin
> > > >
> > > > Review URL: https://codereview.chromium.org/12457027
> > >
> > > TBR=tommi@chromium.org
> > > Review URL: https://codereview.chromium.org/12662028TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/12891005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189995 0039d316-1c4b-4281-b951-d872f2087c98