Use webrtc::MouseCursorMonitor for cursor shapes instead of
webrtc::VideoFrameCapturer, in preparation for deprecating cursor shape
functionality in the latter.
Fix memory corruption in VideoSchedulerTests_StartAndStop, where a lingering
capture task could trigger a expectation action declared on the stack during
tear down. My changes to the test somehow made the race condition more likely.
BUG=324033
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247689
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248045
Review URL: https://codereview.chromium.org/92473002
Cr-Commit-Position: refs/heads/master@{#288226}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288226 0039d316-1c4b-4281-b951-d872f2087c98
It broke Drive sync completely.
> Parse Drive API responses all at once in the blocking pool.
>
> Previous implementation did the parsing of string to base::Value
> on blocking pool, and that of base::Value to specific data types
> either on UI thread or on yet another post to blocking pool.
>
> The previous implementation is slightly inefficient and moreover
> involves a subtle bug 284244.
>
> BUG=284244
>
> Review URL: https://codereview.chromium.org/442193002TBR=kinaba@chromium.org
BUG=401843
Review URL: https://codereview.chromium.org/449323002
Cr-Commit-Position: refs/heads/master@{#288216}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288216 0039d316-1c4b-4281-b951-d872f2087c98
Jankometer is the last instance of a MessagePumpObserver. Since it has been
removed, MessagePumpObserver can also be removed.
BUG=none
R=darin@chromium.org
Review URL: https://codereview.chromium.org/421173003
Cr-Commit-Position: refs/heads/master@{#288203}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288203 0039d316-1c4b-4281-b951-d872f2087c98
Test Runner changes to allow integration tests as well as the ability
to point the device's google_base_url (or any android shell flag) to
a specified value in stored in a .flags file.
BUG=None
Review URL: https://codereview.chromium.org/444243002
Cr-Commit-Position: refs/heads/master@{#288202}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288202 0039d316-1c4b-4281-b951-d872f2087c98
This CL adds an event to the <extensionoptions> tag that fires
if the guest view is attempted to be created with an invalid
extension id.
BUG=386838
Review URL: https://codereview.chromium.org/429763002
Cr-Commit-Position: refs/heads/master@{#288201}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288201 0039d316-1c4b-4281-b951-d872f2087c98
As is discussed in the bug, it is important to occupy certain
area for logo mark in the home card, otherwise the area for
the search results is restricted.
Actual experimental app-list uses start_page webview for this,
which embeds the logo from our resource data. I think it's better
to create a dummy view with flat background instead of loading
the resource image to emphasize this is still work-in-progress.
BUG=400153
R=oshima@chromium.org
TEST=none
Review URL: https://codereview.chromium.org/441123002
Cr-Commit-Position: refs/heads/master@{#288199}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288199 0039d316-1c4b-4281-b951-d872f2087c98
Layer::CalculateContentsScale and its overrides never use
device_scale_factor, page_scale_factor, maximum_animation_contents_scale,
or animating_transform_to_screen. This CL removes these arguments.
BUG=None
Review URL: https://codereview.chromium.org/453533002
Cr-Commit-Position: refs/heads/master@{#288197}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288197 0039d316-1c4b-4281-b951-d872f2087c98
Also, ensure that it stays in sync with the renderer's copy.
BUG=99379,369661
TEST=no CHECKs hit in the wild, all tests stay green
Review URL: https://codereview.chromium.org/423393008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288196 0039d316-1c4b-4281-b951-d872f2087c98
This is where things go wrong and cause crbug.com/385795
BUG=385795
TEST=None
Review URL: https://codereview.chromium.org/448123003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288195 0039d316-1c4b-4281-b951-d872f2087c98
included the transform for fixing the video orientation.
BUG=47554
Review URL: https://codereview.chromium.org/388643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288194 0039d316-1c4b-4281-b951-d872f2087c98
df449c0 Change '>=' back to '>' in extension.h due to bad fix
2ee9c3a gclient DEPS file for auto checking out deps
9047b8b Clean up meaningless branch on commented-out code.
ef72d48 Fix the problem that memory is accessed after released due to invalid type-cast
1b9c5c4 Fix use-after-free in CPDF_Color::~CPDF_Color
06a8c87 Fix unninitialized 'tmp' in CJBig2_Image::composeTo_opt2
7b99cd3 Remove unused |m_pEvi| field.
f47ab54 Fix a segmentation fault in CPDF_DataAvail::CheckPage due to invalid usage of i++
BUG=392719,387979,387811,387774,375773,400662
TBR=tsepez@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/449093003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288186 0039d316-1c4b-4281-b951-d872f2087c98
(PageTestTestCase should also be the place to merge the unit test helper
defined in TestPageTestResults.)
BUG=383635
Review URL: https://codereview.chromium.org/449943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288182 0039d316-1c4b-4281-b951-d872f2087c98
This is a follow up CL of r287687, which missed the corner case that an error
happened before Stop().
This CL also updated the PipelineTest so that we explicitly check that all weak
pointers must have been invalidated before the stop callback returns. With this
check PipelineTeardownTest.Error_* tests will cover this corner case.
BUG=399417
TEST=Updated unit test.
Review URL: https://codereview.chromium.org/444333007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288181 0039d316-1c4b-4281-b951-d872f2087c98
There is a problem with keycode generation for non-trivial characters
(i.e. those that have modifiers) because the event array generated is
not simply a KeyDown/KeyUp combination; each modifier also gets a pair
of events.
Instead, scan through the events and send the first KeyDown that isn't
a modifier key. Also, don't send key events if nothing is changing
(as happens with the final "commit").
SendSythenticKeyEvent needed to be extended to accept modifier flags.
BUG=118639
Review URL: https://codereview.chromium.org/426063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288179 0039d316-1c4b-4281-b951-d872f2087c98
This CL instruments the interstitial pages to generate the experience sampling API onDecision event.
BUG=384635
Review URL: https://codereview.chromium.org/399773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288177 0039d316-1c4b-4281-b951-d872f2087c98
The stub class should only be built for Android, not Chrome OS.
BUG=401791
TEST=verify that screen capture notification UI is shown on ChromeOS.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/450023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288174 0039d316-1c4b-4281-b951-d872f2087c98
This pulls in the following Native Client changes:
r13581: (dschuff) Further deduplicate and simplify PNaCl SCons testing
r13582: (dschuff) Remove unneeded items from list of trusty cross toolchain packages.
r13583: (dschuff) Add toolchain_build/git_cache to list of SVN ignores
r13584: (sbc) Fix for ARM cross build with clang.
r13586: (dschuff) Update x86-64 linux prep script for Trusty
r13589: (noelallen) NaCl has it's own copy of the build files, including several GNI files which use "declare_args" to provide build options.
r13592: (sheyang) Add PROJECT field to codereview.settings for nacl
BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk_build
Review URL: https://codereview.chromium.org/449063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288166 0039d316-1c4b-4281-b951-d872f2087c98
These DEPS have not been updated for ~2 years, so there is a good chance
something will blow up. Due to interdependancy between the repos,
rolling gtest required gmock also be rolled.
BUG=none
Review URL: https://codereview.chromium.org/425333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288164 0039d316-1c4b-4281-b951-d872f2087c98
Adapted from rsleevi's original patch. The initial version of the tool rewrites
all implicit conversions of scoped_refptr<T> to T*, even unsafe ones where a
temporary scoped_refptr<T> is assigned to a T*. A small tweak/hack has also
been added to run_tool.py to allow it to handle replacements that contain
embedded newlines.
BUG=110610
R=mdempsky@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/446203003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288163 0039d316-1c4b-4281-b951-d872f2087c98
I also updated ProvisionalSaveFailure in histograms.xml, which was an oversight from a previous cl.
BUG=386402
Review URL: https://codereview.chromium.org/421563003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288162 0039d316-1c4b-4281-b951-d872f2087c98
Now this condition never happens after r287686 and BUG=344393
r287686 got rid of lost_resource from this condition.
BUG=344393 made a client never destructed before releasing all mailboxes.
BUG=344393
Review URL: https://codereview.chromium.org/451723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288157 0039d316-1c4b-4281-b951-d872f2087c98
url_request_http_job.cc contains a TODO comment for WebSocket
throttling. Since this was landed in
https://codereview.chromium.org/240873003 the comment is no longer
needed. Remove it.
BUG=343107
TEST=net_unittests
Review URL: https://codereview.chromium.org/445373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288155 0039d316-1c4b-4281-b951-d872f2087c98
