0
Commit Graph

4 Commits

Author SHA1 Message Date
Dirk Pranke
f05a1b7d4b Reland "Add webui_resources_tools_python_unittests."
This reverts commit bafb2bdc07.

Reason for revert: Relanding with fix to not run the tests on linux-win-cross-rel, win-arm64-rel, or win11-arm64-rel-tests

Original change's description:
> Revert "Add webui_resources_tools_python_unittests."
>
> This reverts commit 782dbb8052.
>
> Reason for revert: newly added tests are failing: crbug.com/398286661
>
> Original change's description:
> > Add webui_resources_tools_python_unittests.
> >
> > This adds a new test step/binary called
> > webui_resources_tools_python_unittests that runs the python unit tests
> > in //ui/webui/resources/tools.
> >
> > No-Try: true
> > Bug: 378504039
> > Change-Id: I8f7d1c34cf8a66a30f24d4295565a1596f7d4338
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6277637
> > Reviewed-by: Ben Pastene <bpastene@chromium.org>
> > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1423226}
>
> Bug: 378504039, 398286661
> Change-Id: Ida93c848800ec243cbe3dc38a3075691be8937e0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6292926
> Auto-Submit: Muyao Xu <muyaoxu@google.com>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Owners-Override: Muyao Xu <muyaoxu@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Muyao Xu <muyaoxu@google.com>
> Cr-Commit-Position: refs/heads/main@{#1423416}

Bug: 378504039, 398286661
Change-Id: Ifbd5739304ccd5477000e88b7d6906b2b7a3970d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6301559
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1425353}
2025-02-26 12:53:23 -08:00
Muyao Xu
bafb2bdc07 Revert "Add webui_resources_tools_python_unittests."
This reverts commit 782dbb8052.

Reason for revert: newly added tests are failing: crbug.com/398286661

Original change's description:
> Add webui_resources_tools_python_unittests.
>
> This adds a new test step/binary called
> webui_resources_tools_python_unittests that runs the python unit tests
> in //ui/webui/resources/tools.
>
> No-Try: true
> Bug: 378504039
> Change-Id: I8f7d1c34cf8a66a30f24d4295565a1596f7d4338
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6277637
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/main@{#1423226}

Bug: 378504039, 398286661
Change-Id: Ida93c848800ec243cbe3dc38a3075691be8937e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6292926
Auto-Submit: Muyao Xu <muyaoxu@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Muyao Xu <muyaoxu@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Muyao Xu <muyaoxu@google.com>
Cr-Commit-Position: refs/heads/main@{#1423416}
2025-02-21 14:15:11 -08:00
Dirk Pranke
782dbb8052 Add webui_resources_tools_python_unittests.
This adds a new test step/binary called
webui_resources_tools_python_unittests that runs the python unit tests
in //ui/webui/resources/tools.

No-Try: true
Bug: 378504039
Change-Id: I8f7d1c34cf8a66a30f24d4295565a1596f7d4338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6277637
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/main@{#1423226}
2025-02-21 09:46:08 -08:00
Thomas Lukaszewicz
98b997acb7 [code cache] Add tools/code_cache_generator
This CL adds a new executable utility used to generate V8 bytecode
from JS scripts.

It is intended for use in bytecode for chromium bundled WebUI
scripts for use during runtime loads.

The implementation across tools/ and third_party/blink/ follows a
similar pattern to the v8_context_snapshot utility.

Currently the tool only supports generating V8 bytecode for module
scripts (the vast majority of WebUI scripts), and does so one file
at a time. The tool can be updated to support batch compilation in
follow up CLs.

Intended use:
$code_cache_generator --module-path=<..> --code-cache-path=<..>

Bug: 378504096
Change-Id: I72731ba6582f9350fb0ae69b9f693a700f80bff9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6096433
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/main@{#1415213}
2025-02-03 14:43:27 -08:00