truncated example:
m=video 9 UDP/TLS/RTP/SAVPF 96 97 (121 more lines) direction=sendrecv mid=0
Not done for the session part where the direction is not commonly shown
BUG=None
Change-Id: Ibb6843a7a0d2d6a5ed27e4c1beb55762bee194af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6274163
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1421159}
There might exists more than 1 data point in `stepSize` interval in
`dataPoints_`. Old code was taking the last value to plot. However, this
might cause some of the critical values to disappear. Therefore, instead
of the last value we now take the average of the values in the interval.
Main reason for this change is for detection corruptions. See the child
change.
Tested manually by running
https://emilvardar98.github.io/simulcast-playground.html and checking
the graphs.
Bug: None
Change-Id: I7f1906b3c6d229bacdcb6a2e6465f18a25f72d64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6249678
Reviewed-by: Erik Språng <sprang@chromium.org>
Commit-Queue: Emil Vardar (xWF) <vardar@google.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1419795}
According to spec and implementation, this timestamp (unlike all the
other timestamps in getStats), is expressed in "NTP clock time", which
means an epoch of 1900 instead of 1970 as the Date constructor in
chrome://webrtc-internals/ expects in the DateCalculator.
The fix is to add an offset for this, and only this, timestamp.
Verified fix manually using the steps outlined in
https://crbug.com/392424843#comment5
Bug: 392424843
Change-Id: I31eefb190170951a036d68e97df55ae324bece30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6239656
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418037}
This is in preparation of removing a JS minification step happening
within Grit on Android builds, as Grit should not be responsible for
performing minification.
Bug: 340278433
Change-Id: I5f6a1df8b24a34be3b806c137419546b7c628d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6147566
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1402576}
Cloned audio tracks in WebRTC share the same track interface as
the original track, which serves as the source of the stream.
When the track interface is disabled through a single audio track,
it affects all tracks that share the same interface.
The solution is to remove this dependency on the shared track interface
when disabling or stopping an individual track.
Bug: 40849402
Change-Id: Ib4c54337cd10797449e856b420396038a45d30da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6052891
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Sunggook Chue <sunggch@microsoft.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1394493}
No code change compared with the original CL, since
crbug.com/377684694 macOS 11/12 test failure has already
been fixed by crrev.com/c/6002792
This is a reland of commit 8b41580749
Original change's description:
> Video: Make `MediaRecorder.isTypeSupported()` can reflect platform HEVC support
>
> With `media::IsEncoderSupportedVideoType()`, we now
> can know if HEVC platform encoding is available or
> not synchronously.
>
> This CL wires `MediaRecorderHandler` with this method,
> guarantee user the accurate result. Also add related
> GPU content browser test for this.
>
> Bug: 40276507
> Change-Id: I422ee97982ac4620a88f80dbce156348d4aebaa6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5986751
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Reviewed-by: Markus Handell <handellm@google.com>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Commit-Queue: Sida Zhu <zhusida@bytedance.com>
> Cr-Commit-Position: refs/heads/main@{#1378664}
Bug: 40276507
Change-Id: Iac6932931d8212243d6d64cf9a1361d633067526
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6002393
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Markus Handell <handellm@google.com>
Commit-Queue: Sida Zhu <zhusida@bytedance.com>
Cr-Commit-Position: refs/heads/main@{#1380350}
With `media::IsEncoderSupportedVideoType()`, we now
can know if HEVC platform encoding is available or
not synchronously.
This CL wires `MediaRecorderHandler` with this method,
guarantee user the accurate result. Also add related
GPU content browser test for this.
Bug: 40276507
Change-Id: I422ee97982ac4620a88f80dbce156348d4aebaa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5986751
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Markus Handell <handellm@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Sida Zhu <zhusida@bytedance.com>
Cr-Commit-Position: refs/heads/main@{#1378664}
NOTREACHED() and NOTREACHED_IN_MIGRATION() are both CHECK-fatal now.
The former is [[noreturn]] so this CL also performs dead-code removal
after the NOTREACHED().
This CL does not attempt to do additional rewrites of any surrounding
code, like:
if (!foo) {
NOTREACHED();
}
to CHECK(foo);
Those transforms take a non-trivial amount of time (and there are
thousands of instances). Cleanup can be left as an exercise for the
reader.
This does clean up kCrashOnDanglingBrowserContext as both paths of the
kill switch are currently fatal. This has been rolled out for a long
time.
Bug: 40580068, 40062641
Change-Id: Ib88e710d003e2e48df3fc502ca54d2341d157a0e
Cq-Include-Trybots: luci.chromium.try:linux-dcheck-off-rel
Low-Coverage-Reason: OTHER Should-be-unreachable code
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5974816
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1376522}
The code touched here wasn't consistent in its use of const, but
generally used it in a shallow-const fashion where even vending write
access to a block of memory could be done via a const method.
This causes problems when trying to enforce stricter lifetime checks on
writable spans, because either the code gets confused about whether the
accesses are read-only (it tries to look for the constness of the
returned pointers and can't figure out what to do if things don't
match everywhere) or it thinks something unsafe or non-sane is happening
(write access to rvalues makes no sense, for example, but read access
might in the context of a short-lived call).
Instead consistently model deep constness, which is compliant with
Chrome's style rules on const and fixes all these issues. Mostly, this
means changing const members/ref args to non-const ones.
Bug: 372381413
Change-Id: I2735c52fbf0f32b813055cbb46f7c15b09eb025f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5939406
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Fred Shih <ffred@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1373012}
Previously VideoSourceProviderImpl::GetSourceInfos would return an empty
list of cameras if the response callback was destroyed without being
called, as if that was the correct result. This still returns an empty
list, so there's no change in behaviour for code which doesn't check the
result.
We still don't actually propagate it all the way up to eg the
enumerateDevices call in JS, but at least we will log in Chrome that it
failed, retry and increment histograms with the true result.
Bug: 348159730
Change-Id: Id7be563a5854507b3f15c404d80cac26747a57eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5666787
Reviewed-by: Palak Agarwal <agpalak@chromium.org>
Reviewed-by: Polina Bondarenko <pbond@chromium.org>
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Tony Herre <toprice@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1333450}
Tests that override SetupCommandLine() already get the CommandLine as a
method argument. There is no need to call
base::CommandLine::ForCurrentProcess(). Consistently use the argument
instead.
Change-Id: I4643babbce672ceb304a14318cc0c3d73761e407
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5691228
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1325737}
This change:
1. Marks ui::SelectFile::Listener's params argument as deprecated
2. Adds new virtuals to ui::SelectFile::Listener that do not take
a params argument
3. Replaces every subclass override which doesn't use the params
argument with overrides that don't take a params argument at all
This will allow refactoring the remaining subclasses that do use params
individually, ultimately allowing for:
4. Removing all remaining overrides of the variants that take parameters
5. Removing all call sites of those variants
6. Removing the variants themselves and the params argument from
ui::SelectFile
Bug: 340178601
Change-Id: Id876295714bd0c853506cc258b33e7d1886f1b94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5659974
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly FJ <ellyjones@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322222}
webrtc-stats follow a pattern where a property ending with "Id"
is a pointer to another object in the results. This way the stats
graph can be traversed. This CL adds support for webrtc-internals
to make these members clickable as (internal) hyperlinks
BUG=chromium:345091933
Change-Id: I45dd6eb66e3789cde0c2907e68659655472ae107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5599954
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/main@{#1312763}
Suppress unsafe buffer usage on a file-by-file basis. Out of
approximately 5850 .cc and .h files only roughly 160 files fail
compilation with the unsafe buffers warning.
Suppress only, by inserting boilerplate into affected files. Do not
re-write any code to work around the issues. Properly fixing each file
will be done in follow-up CLs.
//content/ is not removed from unsafe_bufers_paths.txt file and will be
also done as a follow-up, so it makes potential reverts simpler.
Bug: 342213636
Change-Id: I4a936e63dea95a78951f7bfae6d5487708ae3c0b
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5608913
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1312393}
With multiplanar shared image for hardware decode launched, we can
change the array<gpu::ExportedSharedImage> in SharedImageBufferHandleSet
to take a single gpu::ExportedSharedImage. This change updates mojom
and relevant callsites that use it.
Bug: 332564976
Change-Id: I8cdf9626be1aa5a9a829d32f9712702e0c053a4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5593229
Commit-Queue: Saifuddin Hitawala <hitawala@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Brendon Tiszka <tiszka@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1310590}
This s/NOTREACHED()/NOTREACHED_IN_MIGRATION() for most of remaining
src/. Then I went through all changes and made sure that we didn't do
this for comments or "NOTREACHED(): " log strings.
Rolling in the corresponding change for remaining third_party/crashpad
is separately up for review.
Bug: 40580068
Low-Coverage-Reason: TRIVIAL_CHANGE Unreachable code is not reachable.
Change-Id: I707e582b710bf65474db2e3477fa06f5b8d8ea06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545807
Owners-Override: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1302866}
This was generated by replacing " NOTREACHED()" with
" NOTREACHED_IN_MIGRATION()" and running git cl format.
This prepares for making NOTREACHED() [[noreturn]] alongside
NotReachedIsFatal migration of existing inventory.
Bug: 40580068
Change-Id: I3b48b89911ac5e9ffcb211622992f917f8f9e8d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539619
Auto-Submit: Peter Boström <pbos@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301096}
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: Ibc66b8c440e4bcdef414e77fef4d9874d2ea9951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493800
Auto-Submit: Alison Gale <agale@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293330}
As part of the ClientSharedImage refactoring, this CL replaces the
usage of MailboxBufferHandleSet in WebRTC video capture service browser
test with SharedImageBufferHandleSet.
Bug: 1494911
Change-Id: Ie51609db7c7001b5be26d5e703ca912010e3b05c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463433
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291443}
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: Ib028de8bb63c99e5a81d90e24e422cf88061ad05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469583
Owners-Override: Alison Gale <agale@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290952}
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: Iee14d10d544e9f0ec046117cc4ec8a55c427adc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469947
Reviewed-by: Darryl James <dljames@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290838}
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: Ifd155bbeff882ea939f74cf8b8f847f42847940b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5468156
Reviewed-by: Darryl James <dljames@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290297}
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: Ieeb461e2d489e86fd50b87a2a0721a2be34520c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467317
Owners-Override: Alison Gale <agale@chromium.org>
Commit-Queue: Darryl James <dljames@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290198}
