Makes the minimal adjustments to the latter necessary to have it behave
exactly as the former when used with software compositing.
Bug: 403372453
Change-Id: Ida8e3ed630a30ae8300a708de94e55324e8c407d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6401014
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439280}
This CL:
* Removes the `cargo vet` presubmit for `//third_party/rust`.
After this CL, changes to `//third_party/rust` can land with an LGTM
from one of `//third_party/rust/OWNERS` and won't anymore require
recording a `cargo vet` audit.
* Documents an initial set of security review guidelines and puts them
into `//third_party/rust/OWNERS-security-review.md`. Some minor
follow-up doc changes affect `//tools/crates/gnrt`.
Bug: 405980483
Change-Id: I0fedfc012651cee7057ddad3d74a9481a1299945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6388195
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437597}
Updates the Ozone Overview documentation to explicitly specify the
differences between the IS_OZONE and IS_OZONE_WAYLAND buildflags.
IS_OZONE should run on Linux, ChromeOS, and Fuchsia.
IS_OZONE_WAYLAND should only run on Linux systems using the Wayland
window manager. Does not include ChromeOS or Fuchsia.
Change-Id: I1a2d875d3190344042ec960a56a48d3887b843fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6389135
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437110}
This CL is the 2nd step in the chain to remove any dependency on
ExternallyManagedAppInstallTask. This is done on production by updating
the struct that stored an instance of the task to only store an instance
of the ExternalInstallOption and the corresponding callback. When an
installation needs to happen, the WebAppCommandScheduler is used to
invoke an ExternalAppResolutionCommand directly with the callback, thus
completely bypassing the requirement of an intermediary task like state.
This CL also updates existing documentation that mentions the
ExternallyManagedAppInstallTask to instead refer to the command that is
called.
A future CL will remove all traces of the task code altogether.
Change-Id: Iaf88ae4c9c709a0a1ee72c63163f0f4bdd3dd313
Bug: 328431086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6357998
Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437102}
At surface level it's just BlankCTATabInitialStatePublicTransitRule
automatically creating the ChromeTabbedActivityTestRule, but it
shifts the ChromeTabbedActivityTestRule to be non-static (and adapts
to this). It also supports ending the test in a different station
(like the RegularTabSwitcherStation in HistoryPaneTest).
Bug: 404294940,399877997,399876851
Change-Id: I23f9f14938760802f25bf984d8587a231adecd4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6378329
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Owners-Override: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437020}
FreshCtaTransitTestRule is for tests that restart the CTA between test
cases, whether they are batched or not.
ReusedCtaTransitTestRule is for tests that reuse the CTA in all test
cases, so it only makes sense in batched tests (though it's equivalent
to Fresh- in non-batched tests when they all start on the same entry
point).
Bug: 399877997,404294940
Change-Id: I08fb67a0654d3a95f9ddf34bd0f136b57863ed49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6355610
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436300}
The floor bug (https://crbug.com/374162585) which blocked the previous roll has been addressed, so we're trying to update the SDK again.
Code changes are essentially the same as the previous update attempt
(https://crrev.com/c/5898835). Some minor changes to gate new SDK features behind a #define while we transition, and some regenerated image baselines to support the new 3D emojis. Note that updating mc.exe and midl.exe outputs produced no changes.
Pleasantly, the linking change to d3dcompiler_47.dll has been undone, so we no longer need to patch in an older version. This means the update is about as straightforward as it gets.
-----------------------------------------------------------------
Instructions to reproduce:
These instructions are best done on a fresh VM. Make sure to uninstall any existing installations of Visual Studio and any existing SDK installations before starting.
1. Install git for windows from their website, with the default settings (https://git-scm.com/downloads/win)
2. Install depot_tools following the instructions on their webpage (https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/depot_tools_tutorial.html#_setting_up)
3. Run:
$ git config --global depot-tools.allowGlobalGitConfig true
4. Download Visual Studio Professional (Free Trial) from the official site (https://visualstudio.microsoft.com/downloads/)
5. Run the VS installer with the following arguments:
```
$ VisualStudioSetup.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 --includeRecommended --passive
```
6. Open the VS installer (from the start menu), click “Modify”, and uninstall any existing SDK versions (search for “windows sdk”).
7. Open “Add or Remove Programs” and make sure there are no SDK versions installed; remove them if so (search for “windows software development kit”).
8. Download SDK Version 10.0.26100.3323 from the official site (https://developer.microsoft.com/en-us/windows/downloads/windows-sdk/)
9. Run the SDK installer with default settings, except disable “insights”.
10. Run the packaging script from depot_tools, e.g
$ python3 depot_tools\win_toolchain\package_from_installed.py 2022 -w 10.0.26100.0
Link to packaging script version used for packaging: https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:win_toolchain/package_from_installed.py;drc=371aa997c04791d21e222ed43a1a0d55b450dd53
This resulted in the final package with hash 076960eda6.
Bug: 362650376
Change-Id: Ib6cb299ab20cfca1e72f34728e6ea165ab057d05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6252774
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Zequan Wu <zequanwu@google.com>
Commit-Queue: Devon Loehr <dloehr@google.com>
Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1435503}
In the instructions of how the browser (c++) and Renderer (JS)
communicate, there is a step to register the mojo PageHandlerFactory to
your own controller. That step explained to do that in
chrome/browser/chrome/browser_interface_binders.cc, however all of the
registrations now exist in
chrome/browser/chrome_browser_interface_binders_webui.cc
This CL updates the doc with the correct path to register the Mojo
PageHandlerFactory to your own controller.
Change-Id: Ibdbb3041961a555fac044c6090f965850ade2b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6371454
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Commit-Queue: Jacob Stanley <jacobstanley@google.com>
Auto-Submit: Jacob Stanley <jacobstanley@google.com>
Cr-Commit-Position: refs/heads/main@{#1434902}
This CL introduces a new "Manual testing" section for accessibility. The
goal is to create a live document that is continuously updated with a
list of all features to test for the most used ATs to guide all Chromium
contributors to perform thorough manual testing when making a potentially
breaking change.
For now, we start with testing guidelines about Narrator. This section
will eventually be updated to include all popular ATs. I recommend that
we update it whenever we fix a bug that our automated tests missed (in
addition to writing a new test that will prevent the regression in
the future).
Change-Id: I69311fd986e7b5e37b1d30a139a6ed8a477f8c91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6362795
Reviewed-by: Jacques Newman <janewman@microsoft.com>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1433802}
The only workaround entry is for a bug that's likely related to video
overlays rather than direct composition as a whole. The other linked
bug doesn't even seem related to direct composition.
However, we still need to disable direct composition for things like
RenderDoc so (re)introduce the --disable-direct-composition command
line flag.
Bug: 41241478
Change-Id: Ibf4ce1aa5a6266a7459993c95f9d38697733aca8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6324950
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: David Yeung <dayeung@chromium.org>
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432806}
Mutter and its dependencies in third_party are currently checked out by
default on linux, which require an additional 300 MB disk space.
Since developers don't need to run these tests locally most of the time,
add the option to checkout the mutter sources by explicitly setting
`checkout_mutter` .gclient custom var.
Bug: 401977530
Change-Id: I83a976c7a15da69e7c3a6e86fe0dca8966cd339c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6338729
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Orko Garai <orko@igalia.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1431078}
The version of python3 shipped with macOS tends to be old (as of
macOS Sequoia 15.3.1 this is version 3.9.6 dating from June 2021).
Update the build instructions to recommend using the version of
python3 that is managed by depot_tools.
This should ensure that the build uses a version of python3 that
is recent enough (and close to the version used by the bots). It
should prevent unexpected failures when recent features are used
in build scripts.
See https://dawn-review.googlesource.com/c/dawn/+/230174 for an
example of build failure that could be caused by an old python3.
Bug: none
Change-Id: Icb806609ee5be7146cddc83d01a1c57ec2b3b762
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6343778
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1431059}
