0
Commit Graph

3264 Commits

Author SHA1 Message Date
5a9d45fc8b Remove palmer@chromium.org from docs/security/OWNERS
This is an automatically generated changelist based on group memberships and affiliations, with some transition delay.

To approve this change, CR+1/2 this change and submit. To reject this change, CR -1 this change, and the bot will abandon the change.

To report an issue, file a bug in the Infra>Security component.

Change-Id: Ie8c2ba481ff3314680cc5143b7aadd7e4aad5501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3501502
Auto-Submit: Owners Cleanup <swarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#977145}
2022-03-03 17:18:34 +00:00
2a55a45d52 Add LUCI, mb, and test configs for android-12-x64-rel
This is a production version of the FYI builder android-12-x64-fyi-rel
with the following differences:
1. The trybot is migrated to orchestrator (pool already allocated).
2. chrome_public_test_apk is marked as ci_only and experimental.

The FYI builder's mb & test configs are removed, and LUCI config is kept
so that the build links in the related bugs are accessible.

Bug: 1225851
Change-Id: I59be4a8f32caebe9449373296d1257b42139079a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3496937
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/main@{#977015}
2022-03-03 08:18:33 +00:00
de20723766 Add Android testing pointers to security sheriff docs
It can be tricky for security sheriffs to reproduce bugs that are
specific to Android, especially for those of us who don't do Android
Chrome development as part of our daily work. This adds some pointers to
our sheriffing docs.

Change-Id: I0e74ee94814dca821c650e19f7aaf468a4ee2260
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3501096
Reviewed-by: Adrian Taylor <adetaylor@chromium.org>
Commit-Queue: Chris Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/main@{#976882}
2022-03-02 23:58:21 +00:00
c469ba7bb2 Add some details for Windows depot_tools setup instructions
Change-Id: I277ef036cd011e206a1cdf83a8bd62c09bdbe661
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3497490
Auto-Submit: Eric Waldman <waldman@google.com>
Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Eric Waldman <waldman@google.com>
Cr-Commit-Position: refs/heads/main@{#976787}
2022-03-02 20:33:00 +00:00
ab3923fdc8 Added missing quotation marks in ios testing documentation
Change-Id: I220b461c1d734a51f3f906380e4f0cef773b86a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3498529
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Ernesto Izquierdo Clua <eic@google.com>
Cr-Commit-Position: refs/heads/main@{#976376}
2022-03-01 20:42:15 +00:00
d36eb354b8 docs: update python version in ios build instruction
This is for
https://groups.google.com/a/chromium.org/g/chromium-dev/c/80EdFe2w5Yo

Change-Id: If86bcb830145e143be4b6eb886ab260088f1d9ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3495884
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#976029}
2022-03-01 01:39:48 +00:00
e20fa1b473 [Fuchsia] Deprecate fuchsia_telemetry_gpu_integration_test
The gpu integration test suite on Fuchsia has finished its migration,
so delete the old target and all references to it.

Change-Id: I5750e7f87649b4cbb9344a40d689e062fbccaf88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3495654
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Chong Gu <chonggu@google.com>
Auto-Submit: Chong Gu <chonggu@google.com>
Cr-Commit-Position: refs/heads/main@{#975994}
2022-02-28 23:12:08 +00:00
b2e6580b84 WebUI: Remove leftovers of long removed a11y axs_testing.js tests.
Bug: 807458
Change-Id: Iee6a15dde67eff2591276198cda2e0762b402bef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3489985
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#975703}
2022-02-28 09:57:27 +00:00
243aad360c Update documentation for Android's incremental_install GN flag.
Change-Id: Ib39d9ddd9997c1726e268d829b4a4df967be58ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3489960
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#975382}
2022-02-26 03:33:14 +00:00
de59018693 [CodeHealth] Introduce new WebUI::MessageCallback
WebUI::DeprecatedMessageCallback2 is taking base::Value::ConstListView,
with changed plans around base::Value refactoring it should be
const base::Value::List& instead.

This CL adds new MessageCallback and corresponding
RegisterMessageCallback() unblocking actual refactoring of callers.

This CL also includes an examples of how the refactoring will look like.

Bug: 1300095
Change-Id: Ibaf0b075b4fd60f99f393535cebce154965f4bce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3483819
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mohamad Ahmadi <mahmadi@chromium.org>
Commit-Queue: Mohamad Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#975287}
2022-02-25 21:56:23 +00:00
5576433b52 Add pointer to Eng Review office hours
Change-Id: I9fea69d02430a3045b0a1840fc3b728b7935461f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3489912
Auto-Submit: Alex Mineer <amineer@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/main@{#975170}
2022-02-25 18:05:19 +00:00
cd32834614 Update the //third_party/ addition guideline
When people just move existing directories in Chromium to //third_party/,
they don't need to get approval from Eng Review and security.
The update was discussed and approved by [1].

[1] https://groups.google.com/a/google.com/g/chrome-eng-review/c/jngLG--urWw/m/ANAA1-_lAAAJ

Bug: None
Change-Id: I827bd8ae1ab32bd1c871be4ef2d06e0a5a1cf64a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3489109
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/main@{#975042}
2022-02-25 08:25:44 +00:00
4e00f8889c Updates to Security Guidelines--addendum updates
Change-Id: I509d7115f35146c3947d9288eb8a82318a05f670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3389954
Reviewed-by: Adrian Taylor <adetaylor@google.com>
Commit-Queue: Adrian Taylor <adetaylor@google.com>
Cr-Commit-Position: refs/heads/main@{#974723}
2022-02-24 18:03:41 +00:00
9137dcc7ea [ios] Update build instructions
Xcode 13.1 or higher is required to build Chrome on iOS (required
for the catalyst environment). Bump the version in the documentation
and the version check in the code.

JDK is no longer used for the build, remove it from the list of
required software.

Bug: none
Change-Id: If4ddf544b70e2c032ac3e4af95b40a02865e3b9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3487908
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Commit-Queue: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/main@{#974670}
2022-02-24 16:14:15 +00:00
2fee48c9bf Remove gl_renderer_screenshot_sync_tests
These tests are for an obsolete code path. Removing them.

Bug: 1289372
Change-Id: I3f73f082428fc50acc28a877b60ba6116de82d34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3483803
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#974333}
2022-02-23 21:36:22 +00:00
99676dc183 Removed obsolete testing expectations
We previously removed some un-monitored SkiaRenderer FYI bots:
  https://chromium-review.googlesource.com/c/chromium/src/+/3429867

However it appears that I missed some expectations, and as we enabled
some of these features by default we left some other obsolete
expectations.

This CL removes them.

Bug: 1170378
Change-Id: I119846bcdceaa317c26c0142770f54d06335a8a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3484382
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/main@{#974331}
2022-02-23 21:35:17 +00:00
f712a7fd51 Docs: mention chrome-security@google.com in adding_to_third_party.md
The email is already mentioned in docs/security/sheriff.md but
it's good to have it mentioned in the docs about adding
a third party dependency.

Change-Id: I04e9d4751ca849cd96718081f9fe7d233905dbb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3483802
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#974238}
2022-02-23 17:55:36 +00:00
c2464187d5 Linux: Document symbol file availability.
Change-Id: I3128a25648f97e7c9e53ebf1198d6b01416f82d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3484956
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/main@{#974159}
2022-02-23 14:27:51 +00:00
51292b5e41 Updates lacros.md slightly.
- Now OS_CHROMEOS macros are being replaced by BUILDFLAG(IS_CHROMEOS).
- Text decoration update.
- Removed unneeded trailing white spaces.

BUG=None
TEST=None

Change-Id: Iafda8a4b4b57aace6fa89fd064fe5925a11b9d42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3478998
Auto-Submit: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Commit-Queue: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#973619}
2022-02-22 03:55:10 +00:00
48567560a8 quick_unlock: Add TestApi to override quick_unlock checks
Currently, to prevent need of setting up user prefs in every test that
want to interact with quick_unlock, there's an EnabledForTesting API
that sets a global test flag to override all checks. But there are more
than one purposes an auth method can be used for, and also more than one
quick_unlock auth methods. Making the APIs and underlying mechanisms
more complicate can give tests more fine-grained control of what they
expect to be enabled in the test, and might help us capture some bugs in
code that accessed wrong set of purposes for auth methods. Put these
test apis into a TestApi class.

Bug: b:214871750
Test: CQ
Test: all modified unit tests, browser tests
Change-Id: I7d67fd8de77c35ab4bc36feec93b4c03bc48eacf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412557
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Jon Mann <jonmann@chromium.org>
Commit-Queue: Howard Yang <hcyang@google.com>
Cr-Commit-Position: refs/heads/main@{#973440}
2022-02-21 06:49:38 +00:00
601cc308b9 Add AVD configs for API level 19 (Kitkat) and 22 (Lollipop)
These configs can be used to run tests.

Bug: 1293115
Change-Id: I856eda38a09b68fb6cdd01a569a1691750bb3597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3449074
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/main@{#973057}
2022-02-18 19:15:14 +00:00
402d59c6a0 Adjust some sync team's OWNERS files
docs/sync/ -> The directory is empty, delete.
chrome/android/.../ -> Point to the canonical one in c/sync/.
chrome/test/data/sync/ -> Add OWNERS file.

Bug: None
Change-Id: I3b58ecb174703f2df0cccc57ff9c9f398cc90f5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3466055
Auto-Submit: Victor Vianna <victorvianna@google.com>
Reviewed-by: Jan Krčál <jkrcal@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/main@{#971728}
2022-02-16 10:36:22 +00:00
ff6d86c0f4 Add link to concurrency-in-chromium slide deck.
Change-Id: I022e0d2b43209769c62703cb073002696944aed4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3459523
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
Cr-Commit-Position: refs/heads/main@{#971250}
2022-02-15 16:26:11 +00:00
192120bede Add the correct type of quote in code snippet
I suspect we actually never want this type of quote. However,
correcting them everywhere seems a lot of useless work. In the case of
code snippet however, it seems important to have it right.

Bug: 1294776
Change-Id: I71d63c902a959a3bede5aeb48bc2500a232097f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3443425
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Auto-Submit: Arthur Milchior <arthurmilchior@google.com>
Commit-Queue: Arthur Milchior <arthurmilchior@google.com>
Cr-Commit-Position: refs/heads/main@{#971228}
2022-02-15 15:32:07 +00:00
d4809d5502 modify and replace the unavailable link in windows_build_instructions.md
"http://tortoisesvn.tigris.org/faq.html#cantmove2" is referenced in
"windows_build_instructions.md" but has not been available
(ERR_CONNECTION_TIMED_OUT).
This is probably due to the fact that "tortoisesvn.tigris.org" has been
changed to "tortoisesvn.net".
Replaced the link with
"https://tortoisesvn.net/faq.html#cantmove2" as the new link.

Change-Id: I700e17ab8ef181496a5f8cb5b9dce84b16d549a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3462028
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#971026}
2022-02-15 03:48:19 +00:00
eaa3e39577 merge_request.md: Clarify how to find release branch on Chromium Dash
Bug: None
Change-Id: Ia5e57e9414e2160ed8c2e60564f63516620ef70e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3287144
Auto-Submit: Michael Cui <mlcui@google.com>
Reviewed-by: Alex Mineer <amineer@chromium.org>
Reviewed-by: Srinivas Sista <srinivassista@chromium.org>
Commit-Queue: Srinivas Sista <srinivassista@chromium.org>
Cr-Commit-Position: refs/heads/main@{#970881}
2022-02-14 22:52:06 +00:00
58230aec40 Update merge request documentation.
The "More" button in Gerrit is now labeled with three (vertical, but ah
well) dots. Also sheriffbot has one more merge request question these
days.

Change-Id: If6298f071976e7fddba1edaedba8d400e24ddae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3278713
Reviewed-by: Alex Mineer <amineer@chromium.org>
Commit-Queue: Alex Mineer <amineer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#970872}
2022-02-14 22:35:23 +00:00
f6e2362e88 Update color best pratices to change from a View to a rooted entity.
Added best practices examples for MacOS and WebUI.

Bug: <None>
Change-Id: I2b1caad103273d2e17380a0427431f561f825d56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3457382
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/main@{#970705}
2022-02-14 18:13:03 +00:00
048ea3976d Android: Make missing dep suggestions more copy / pasteable
Bug: None
Change-Id: I01b59489312ea1c367f50f3c229ea9396bd8b2fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3457782
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#970697}
2022-02-14 17:58:54 +00:00
55bb5e7063 DPWA: update doc about when to add integration tests
Change-Id: I340f02d852325a7cf3705c0f64f39822f0bdd50a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3457685
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Phillis Tang <phillis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#970159}
2022-02-11 21:59:58 +00:00
8c54b0b7e3 Remove legacy SwiftShader GL from documentation
Legacy SwiftShader GL is deprecated, so remove it from existing
documentation, so that only SwANGLE related documentation remains.

Bug: chromium:1060139
Change-Id: I1a59d7b4a57f80cbe627df0a77430450296df607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3452836
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@google.com>
Cr-Commit-Position: refs/heads/main@{#969936}
2022-02-11 14:35:59 +00:00
6d443618ce [tcmalloc] remove remaining references to tcmalloc.
This is a follow-up to
https://chromium-review.googlesource.com/c/chromium/src/+/3402604.

Bug: 1257213, 973552, 98589
Change-Id: Ibee15fcf8b444e4d0c5db65a49d5f34fd8b78e05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3402350
Reviewed-by: Benoit Lize <lizeb@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com>
Cr-Commit-Position: refs/heads/main@{#969727}
2022-02-11 00:22:18 +00:00
e7cc34c2bd [docs] Update ccache on Mac instructions
Change-Id: I619ef54353c23cfeadc91df3bbc28fdf0d825006
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3426041
Auto-Submit: David Sanders <dsanders11@ucsbalum.com>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#969711}
2022-02-11 00:13:23 +00:00
9ce2a48816 update owners documentation to match the current plugin
BUG=1243480

Change-Id: I5a3fec78f6cabcef558523d84b0f2d3d31b83b44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3124171
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>
Cr-Commit-Position: refs/heads/main@{#969554}
2022-02-10 18:39:49 +00:00
1b9be147a1 avd.py: Ergonomic improvements to the script
* -v now shows emulator logs for "start" command
* "start" now runs "install" if obviously necessary (config.ini not present)
* "list" command added, which makes it clear what --avd-config options
  exist.

Bug: 1276006
Change-Id: Idc37641d9a665f7460e2eabe5348aea1e262d247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3438186
Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#969283}
2022-02-10 04:07:00 +00:00
e1d37e70e9 Rename DummyUiActivity to BlankUiTestActivity
This CL renames the DummyUiActivity class to BlankUiTestActivity.

Per Google's documentation and style guidelines, the words "dummy" and
"dumb down" should be avoided. For this reason we are replacing the
DummyUiActivity with the more appropriately named BlankUiTestActivity.
We also make the following renames:

DummyUiActivityTestRule -> BlankUiTestActivityTestRule
DummySettingsForTest -> PlaceholderSettingsForTest

This CL also makes updates to comments and method names where needed
to match these changes.

Bug: 1295312
Change-Id: Ib712a292e0dcee32a97e9d7c487af2fb920f5084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3445111
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/main@{#969056}
2022-02-09 19:43:54 +00:00
b2b326c858 Update accessibility TODO for how chrome os accessibility works
R=josiahk@google.com

Change-Id: I9e0aa4eb6109a3fde77bcdfe111630d5ad410b7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3449674
Reviewed-by: Josiah Krutz <josiahk@google.com>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#968933}
2022-02-09 15:41:31 +00:00
1a367a05d5 Update docs/win_cross.md to hint at using --noarm
If the Windows SDK was installed without the option to add the ARM64
components, package_from_installed.py will fail unless the --noarm
parameter is used. This CL adds a note in docs/win_cross.md pointing
to this.

Change-Id: I00e46366101857d2cb5e68b40220202e5e66a362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448950
Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/main@{#968869}
2022-02-09 12:59:22 +00:00
6e2c9deeeb Remove Nexus 5 and Win 7 from perf shard maps.
Bug: chromium:1287578
Change-Id: I29df74e7ea494c6bfe2d46f7a85dc0004e59b296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3444900
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Eduardo Yap <eduardoyap@google.com>
Cr-Commit-Position: refs/heads/main@{#968440}
2022-02-08 18:36:29 +00:00
052bfa051d Updater: Clarify user counting docs.
There was a logical inversion in the section ("greater
 than or equal to" instead of "less than"), and it was
overly wordy.

Change-Id: Idbfd7ec1781318ebdc4b0f29ca29235a90cbb7c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448429
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#968361}
2022-02-08 16:31:08 +00:00
e382717cae mac: suggest caffeinate instead of system settings to prevent sleep
Change-Id: Ie0ca5fb4c136650d121eaa04738874c6c1ae4752
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448211
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#968336}
2022-02-08 15:48:56 +00:00
9f4a2368bb mac: remove git config --global core.precomposeUnicode true
Since git 92b0c8bed0d3f, git has handled this gracefully without the
need for any user configuration. This shipped in git 1.8.5, 2013-12-02.
The new behavior is for git to detect the filesystem’s Unicode
composition characteristic when it’s initializing a repository, and to
set core.precomposeUnicode appropriately in the repository’s local
.git/config, unless core.precomposeUnicode is already set in the
system /etc/gitconfig or user global ~/.gitconfig.

Change-Id: I1945ac553d9f9afdeeed8293275ebabdc398bd82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3448129
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#968315}
2022-02-08 14:56:34 +00:00
18173ad6c8 Remove mgalonsky from //docs/privacy/OWNERS
Based on her request.

Bug: none
Change-Id: I35e761e7e8c1868328ab870eb0b609ffa8e89c2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3447501
Auto-Submit: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#968276}
2022-02-08 12:05:14 +00:00
4b30c81582 "Get the Code" documentation links to online code and simplifies building host platform requirements.
Many visitors need only browse the source code online; make that easy to find.

Clarify what host platforms are needed to build in context instead of reading different sections.

Change-Id: Ia2f7c11a946094bfad041ec0317b20fd5f937b99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3430636
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Auto-Submit: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/main@{#968129}
2022-02-08 02:02:17 +00:00
cae2b5abe4 Copyediting for document.domain deprecation
Bug: 1259920
Change-Id: I7a69d0d111c55479141f2fdeae5b76252ce50bc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3440362
Auto-Submit: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#967829}
2022-02-07 16:49:49 +00:00
2c609dc10c Add info about the document.domain deprecation.
Bug: 1259920
Change-Id: I1a65f7ef2b8c887efb16e921e1fd0afcf0fda04c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3420410
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#967338}
2022-02-04 18:14:25 +00:00
865fb8ff0d Clarify running unit tests documentation
Clarify that the test target must be built before attempting to run the
unit tests themsleves. The previous instruction only followed the chrome
build instructions. It was not immediately obvious that build chrome
would not also generate the unit_tests binary.

Change-Id: I2894d40926d6546a929ccfcdff4b08bc8f87f9f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3428904
Reviewed-by: Roman Arora <romanarora@google.com>
Commit-Queue: Fred Shih <ffred@google.com>
Cr-Commit-Position: refs/heads/main@{#966576}
2022-02-03 03:54:19 +00:00
6bd9c16c4f Add GPU CrOS bisect documentation
Adds GPU documentation about how to bisect failures locally on the
ChromeOS amd64-generic configuration.

Bug: 1293420
Change-Id: I9da49d4ac100ebf31e910c2216daaadb0d211b91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433604
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#966413}
2022-02-02 21:44:37 +00:00
d0baa8e51d Update new_builder.md
Update section on adding CQ builders (orchestrator and non-orch)

Change-Id: I22c0b7789ba8b33e5e1675a477d58c5741689f88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3426395
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Cr-Commit-Position: refs/heads/main@{#966323}
2022-02-02 19:33:19 +00:00
9e3ef453c6 Android: Docs for android_static_analysis GN arg
Add docs for the new GN arg android_static_analysis and remove docs for
disabling lint and errorprone separately since android_static_analysis
now controls both of them.

Bug: 1202732
Change-Id: I6a4bb4b23024403cecf83784d84b78a60190489d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427634
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#966234}
2022-02-02 16:48:57 +00:00