This class used to create QUIC streams, but now creates and pools QUIC
sessions instead. This rename brings it in line with SpdySessionPool and
its `RequestSession` method.
This CL has no functional impact. It is a mechanistic rename, performed
with `sed`. It avoids renaming existing metrics, preferring continuity
of data over accuracy of the name.
```
sed -i 's/quic_stream_factory/quic_session_pool/g;s/QUIC_STREAM_FACTORY/QUIC_SESSION_POOL/g;s/QuicStreamFactory/QuicSessionPool/g' $(git grep -il 'quic.\?stream.\?factory')
sed -i 's/quic_stream_request/quic_session_request/g;s/QUIC_STREAM_REQUEST/QUIC_SESSION_REQUEST/g;s/QuicStreamRequest/QuicSessionRequest/g' $(git grep -il 'quic.\?stream.\?request')
for f in net/quic/*quic_stream_factory*; do n=$(echo $f | sed -e s/stream/session/g); git mv $f $n; done
sed -i 's/Net\.QuicSessionPool/Net.QuicStreamFactory/g' $(git grep -il 'Net.QuicSession' net/ tools/)
git cl format
```
Change-Id: I20ceb3d8a0a97cd9c8888bb7414b983b9fe5fa51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190439
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Dustin Mitchell <djmitche@chromium.org>
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Paul Semel <paulsemel@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1248827}
This patch moves:
"base/allocator/partition_allocator/..."
into:
"base/allocator/partition_allocator/src/partition_alloc/...".
This tried to keep it as minimal as possible. Interesting follow-ups
will happen outside of the rename.
Context:
--------
To protect against UAF, we want to make the PartitionAlloc library
embeddable by some third_parties: pdfium, angle, dawn, swiftshader, ...
PartitionAlloc do not declare yet where is its "include_dir". It means
third parties must put the library files under
"base/allocator/partition_allocator", even if they do not use "base" and
would have liked to put it inside their "third_party" directory.
We would like to make PartitionAllocator behave like a regular library.
It should be importable using:
#include <partition_alloc/...>
That's why we are using: "src/partition_alloc"
This implements step 1 of:
1. Move from files under `src/partition_alloc/`
2. Declare PartitionAlloc GN include_dirs.
3. Update the dependants to use #include <partition_alloc/...>
Bug: chromium:1467773
Cq-Include-Trybots: luci.chromium.try:linux-chromeos-siso-rel
Cq-Include-Trybots: luci.chromium.try:linux-lacros-siso-rel
Cq-Include-Trybots: luci.chromium.try:linux-siso-rel
Cq-Include-Trybots: luci.chromium.try:linux-wayland-siso-rel
Cq-Include-Trybots: luci.chromium.try:linux-wayland-siso-rel
Cq-Include-Trybots: luci.chromium.try:linux_chromium_asan_siso_rel_ng
Cq-Include-Trybots: luci.chromium.try:win-siso-rel
Change-Id: I1b25cdc9f8077a7041221f51441c72b04b800dcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4812338
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Owners-Override: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204530}
As the last CL of the task runner handle refactor, this CL removes
Single and Thread task runner handles from the codebase entirely. The
new API for this functionality can be found under
(SingleThread|Sequenced)TaskRunner::CurrentDefaultHandle,
::GetCurrentDefault(), ::HasCurrentDefault(), and
::CurrentHandleOverride(ForTesting).
Bug: 1026641
Change-Id: Iac1e15ad215e1806b5c787939de0abdacd1da713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4150928
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Owners-Override: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1091839}
This CL contains:
- removal of references to task runner handles in comments
- removal of nearly all calls, includes, and instantiations of
thread and sequenced task runner handles
Each of these were replaced with references to the new api:
TaskRunner::CurrentDefaultHandle and associated methods.
After this change, all that should be left to do for this method
refactor is the deletion of the old API.
A few of the changes were done with a script, but they were manually
audited.
Bug: 1026641
Ax-Relnotes: n/a
Change-Id: I0858dccac95b485d982aa5152c6b461c4ce05aa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4117257
Commit-Queue: Gabriel Charette <gab@chromium.org>
Owners-Override: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Sean Maher <spvw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1088971}
We removed the pseudo stack mode. Update instructions about
arm64 and x86-64 profiling. Also specify not to use component build
for profiling.
BUG= 1199271
Change-Id: I8b1cce693d38c12f92dc9526fca1893bb276fd9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2980940
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#895428}
In particular:
- Explain how interpret and use data in pinpoint bisects for debugging.
- Add more pointers to docs explaining the details on memory
metrics and how to deal with regressions more generally.
Bug: 1029041
Change-Id: I9a8c4a1fd46a76dbf597944bb4128d972e093a16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949478
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721957}
Remove reference to no longer existing `run_benchmark try` command, and
describe pinpoint try jobs instead.
Bug: 884146
Change-Id: I95370496463b1adfe046c3bf48d3923e18831bf9
Reviewed-on: https://chromium-review.googlesource.com/c/1349322
Reviewed-by: Dave Tu <dtu@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617433}
The format is no longer supported by Telmetry, and the default
(--output-format html) already produces both results.html and traces.
Bug: 770685
Change-Id: Iafe2a91a928d74fd3ad248957b010793464d5d98
Reviewed-on: https://chromium-review.googlesource.com/692943
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505636}
I noticed this when trying to answer the questions in crbug.com/737264.
Review-Url: https://codereview.chromium.org/2955413002
Cr-Commit-Position: refs/heads/master@{#484655}
This CL:
- incorporates the feedback (see linked bug) that
memory_benchmarks.md doesn't mention where to find the trace files on
perf dashboard.
- adds
"memory:chrome:all_processes:reported_by_chrome:net:effective_size_avg"
string in a comment in url_request_context.h, so it's greppable in
code and makes it easier to find where the metric comes from.
BUG=734619
Review-Url: https://codereview.chromium.org/2952203002
Cr-Commit-Position: refs/heads/master@{#481871}
Native heap profiling can now be run on official builds by setting a
chrome://flag.
BUG=
Review-Url: https://codereview.chromium.org/2949353004
Cr-Commit-Position: refs/heads/master@{#481747}
The benchmark is now superceeded by memory.long_running_dual_browser_test
(in contrib).
Also update the docs on memory benchmarks.
Bug: 713338
Change-Id: I41b4a5b520878805dfcb0cfd30e3eaa2830dc2d8
Reviewed-on: https://chromium-review.googlesource.com/518014
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475864}
Bugs filed by bisect for memory.top_10_mobile regressions point to this
documentation. Update it so developers trying to diagnose those also
find useful information.
BUG=catapult:#3128
Review-Url: https://codereview.chromium.org/2630403002
Cr-Commit-Position: refs/heads/master@{#444070}
Add documentation for memory benchmarks, system health in particular, on what
they are, where are they tracked, how to run them, how to understand results.
BUG=catapult:#3035
Review-Url: https://codereview.chromium.org/2595613002
Cr-Commit-Position: refs/heads/master@{#442278}
This will enable more parts of Chromium to use PA, and will make it easier for things outside of Chromium (e.g. PDFium) to use PA.
This change is intended to be merely a move, and should not have significant performance impact.
This moves only the core of PA; higher API layers that Blink uses to call into PA remain in Blink.
BUG=632441
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2518253002
Cr-Commit-Position: refs/heads/master@{#438471}
Since almost all Google domains support HTTPS, and it is a good practice to
use HTTPS wherever possible, thus in this patch, I changed most HTTP links
to https whose domains are known to support HTTPS well.
Modifications are generated by running these commands in src/docs directory:
sed -i 's/http:\/\/www.chromium.org/https:\/\/www.chromium.org/g' *.md
sed -i 's/http:\/\/developer.android.com/https:\/\/developer.android.com/g' *.md
sed -i 's/http:\/\/dev.chromium.org/https:\/\/dev.chromium.org/g' *.md
sed -i 's/http:\/\/build.chromium.org/https:\/\/build.chromium.org/g' *.md
sed -i 's/http:\/\/src.chromium.org/https:\/\/src.chromium.org/g' *.md
sed -i 's/http:\/\/crbug.com/https:\/\/crbug.com/g' *.md
sed -i 's/http:\/\/groups.google.com/https:\/\/groups.google.com/g' *.md
sed -i 's/http:\/\/cs.chromium.org/https:\/\/cs.chromium.org/g' *.md
sed -i 's/http:\/\/codereview.chromium.org/https:\/\/codereview.chromium.org/g' *.md
BUG=
Review-Url: https://codereview.chromium.org/2545363002
Cr-Commit-Position: refs/heads/master@{#436501}
This includes spelling mistakes like:
accomodate->accommodate
ommited->omitted
unuseable->unusable
dependant->dependent
enviroment->environment
preceed->precede
occurrance->occurrence
occurrances->occurrences
intergrated->integrated
altough->although
appriopriate->appropriate
corresponing->corresponding
dependecies->dependencies
leniant->lenient
overriden->overridden
persisten->persistent
specifyinhg->specifying
As well as capitalization changes like:
javascript->JavaScript
Webkit->WebKit
linux->Linux
A couple other minor things:
the the -> the
trybot -> try bot
etc.
Review-Url: https://codereview.chromium.org/2551513002
Cr-Commit-Position: refs/heads/master@{#436046}
I replaced the old documents with links that redirect to
the new locations so we don't break external links.
Also fixes a couple of broken links I found.
BUG=chromium:663353
Review-Url: https://codereview.chromium.org/2494063002
Cr-Commit-Position: refs/heads/master@{#431920}
