Also made change to top-level PRESUBMIT.py to prevent testing default bots when
change is only in native_client_sdk.
BUG=none
R=noelallen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10919303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157653 0039d316-1c4b-4281-b951-d872f2087c98
Along with cc/, this is the other directory for compositor code that recently
moved from WebKit to Chromium. In the short term, to make it easier for folks
moving patches in flight from WebKit to Chromium (and so that they can use the
commit queue), just ignore these files. These suppressions will be removed as
soon as the style in both of these directories have been updated.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10918252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156900 0039d316-1c4b-4281-b951-d872f2087c98
- Switch android tester from android to android_dbg,
the latter which kicks off a triggered tester
BUG=147462
Review URL: https://chromiumcodereview.appspot.com/10928137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156587 0039d316-1c4b-4281-b951-d872f2087c98
The logic in PRESUBMIT.py to only try a single OS bot when the changes
are for a single OS doesn't work for the android_webview directory
because the regex doesn't match at the top level. Tweak the regexes to
allow mac/win/android to be the start of the full path. Now, webview
code is recognised as being android-specific.
R=maruel@chromium.org
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/10918102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155217 0039d316-1c4b-4281-b951-d872f2087c98
And fix existing callers of FindBrowserForProfile.
BUG=None
TEST=Make sure that the page cyclers still work (they're one of the users of the API), as well as the download page gets opened properly on the Mac when the user chooses to wait (the other user of the API).
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152788
Review URL: https://chromiumcodereview.appspot.com/10855183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153207 0039d316-1c4b-4281-b951-d872f2087c98
And fix existing callers of FindBrowserForProfile.
BUG=None
TEST=Make sure that the page cyclers still work (they're one of the users of the API), as well as the download page gets opened properly on the Mac when the user chooses to wait (the other user of the API).
Review URL: https://chromiumcodereview.appspot.com/10855183TBR=mad@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10870014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152790 0039d316-1c4b-4281-b951-d872f2087c98
And fix existing callers of FindBrowserForProfile.
BUG=None
TEST=Make sure that the page cyclers still work (they're one of the users of the API), as well as the download page gets opened properly on the Mac when the user chooses to wait (the other user of the API).
Review URL: https://chromiumcodereview.appspot.com/10855183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152788 0039d316-1c4b-4281-b951-d872f2087c98
DEPS rules are added.
Includes that violate permant rules are still errors, and on upload
there is still a prompt, so the author of the change will definitely
know about the problem.
BUG=138280
Review URL: https://chromiumcodereview.appspot.com/10855266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152581 0039d316-1c4b-4281-b951-d872f2087c98
1. The default trybot rules don't include win_aura in enough cases
2. The CQ did not build win_aura
BUG=141701
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/10831242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150950 0039d316-1c4b-4281-b951-d872f2087c98
we are working to eliminate, and errors on new #includes of disallowed
dependencies.
BUG=138280
Review URL: https://chromiumcodereview.appspot.com/10806049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149167 0039d316-1c4b-4281-b951-d872f2087c98
This seems to have outlived its usefulness.
NOTRY=true
BUG=none
TEST=lol
Review URL: https://chromiumcodereview.appspot.com/10826040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148666 0039d316-1c4b-4281-b951-d872f2087c98
Since With this change we will start compiling unit_tests_apk on the main
waterfall, we are making android a default try bot.
To be submitted after we have increased our capacity to handle the extra
load.
BUG=117407
TEST=
Review URL: https://chromiumcodereview.appspot.com/10808022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147453 0039d316-1c4b-4281-b951-d872f2087c98
- android doesn't currently build anything in chrome/
so we're changing try job logic to send builds to android
unless the CL was exclusively in chrome/
Previously we would have built on roughly 20% of cls with 'git try'
After this change we will build on roughly 60% of cls (based on last 10k
commits)
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10694029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144841 0039d316-1c4b-4281-b951-d872f2087c98
- clean up logic for determining preferred trybots
- allow windows only CLs to try only on win_rel
- less restrictive filter for mac only CLs
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10667007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144372 0039d316-1c4b-4281-b951-d872f2087c98
BUG=130980
TEST=browser_tests:FilePathWatcher* are green
Review URL: https://chromiumcodereview.appspot.com/10519003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140285 0039d316-1c4b-4281-b951-d872f2087c98
So when a user does git try -t base_unittests, base_unittests is not run on
linux_clang.
Remove an invalid line added in r125922.
R=thakis@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/10263007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135696 0039d316-1c4b-4281-b951-d872f2087c98
The GPU code generates relatively complicated code.
We generate that code and check in the generated files
to make it easy to use codereview to see what was generated
makes sense.
Unfortunately, keeping the generator always generating
lint error free code is hard. We mark lines that have issues
with // NOLINT but that feature has apparently been removed
from our lint so instead we'd just like to have presubmit
ignore *_autogen.h files.
R=maruel@chromium.org
BUG=none
TEST=checked that it did indeed exclude *_autogen.h files
Review URL: http://codereview.chromium.org/9692059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126542 0039d316-1c4b-4281-b951-d872f2087c98
will add linux_clang automatically.
TEST=Less tree breakage because of not trying changes on clang first.
BUG=None
NOTRY=true
Review URL: http://codereview.chromium.org/9395027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122041 0039d316-1c4b-4281-b951-d872f2087c98
Also add warning in android_all.gyp that extra targets in 'all' can
have a significant impact on the try load so coordinate appropriately.
BUG=None
TEST=
Review URL: http://codereview.chromium.org/9360028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121560 0039d316-1c4b-4281-b951-d872f2087c98
native_client_sdk uses a different copyright header so it must not be processed by this check.
NOTRY=true
BUG=109004
Review URL: http://codereview.chromium.org/9071009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116143 0039d316-1c4b-4281-b951-d872f2087c98
Sky assures me this will point the devs who hit problems to relevant problems
quickly and more often.
BUG=chromium:107599
TEST=None
TBR=God
NOTRY=true
Review URL: http://codereview.chromium.org/8968019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114830 0039d316-1c4b-4281-b951-d872f2087c98
