Do not modify the DOM of the most visited page if nothing has changed, which
is often the case as the top sites are polled periodically just to make sure
they are up to date.
Also, moves the event listener to a node with a text attribute that allows it
to be selected in accessibility mode.
Makes some markup nodes as skippable in accessibility mode by marking them as
having empty alt text.
BUG=155450
Review URL: https://chromiumcodereview.appspot.com/11155022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162246 0039d316-1c4b-4281-b951-d872f2087c98
(a simplified replacement for TextButton[Base], etc.)
Add the LabelButton class, based on TextButton.
(simplify, cleanup, re-use views controls, etc.)
Add a supporting LabelButtonBorder class.
Add unit tests and a views example in ButtonExample.
Add ImageView interactive flag for hit-testing.
Make Label::text() return a const string16 ref.
TODO(followup): Replace TextButton[Base] use, etc.
TODO(followup): Fix CanvasSkia multi-line label painting.
BUG=155363
TEST=views examples use of the new LabelButton, etc.
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11068012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162245 0039d316-1c4b-4281-b951-d872f2087c98
http://code.google.com/p/chromium/issues/detail?id=134093https://chromiumcodereview.appspot.com/10993067/
This is a better fix than 10993067. This CL undoes that change and moves the fix to the AcceleratorController. This is a more general fix which employs a table of actions that are allowed when in a modal dialog. All other actions are suppressed.
BUG=153077
TEST=System Tray -> Ehternet -> Join Other; while the modal dialog is up, try various ash shortcuts. Observe that the ones are working (like volume up) make sense, but things like new window or moving around windows are inactive.
Review URL: https://chromiumcodereview.appspot.com/10977088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162240 0039d316-1c4b-4281-b951-d872f2087c98
This reverts the revert 2ed4f50146.
My change https://chromiumcodereview.appspot.com/11098008/ got reverted
due to crash on startup of chromium_testshell.
The difference from the previous CL is that TabBaseAndroidImpl constructor
now calls InitTabHelpers() and that InitTabHelpers() is now a protected instead
of private.
Review URL: https://chromiumcodereview.appspot.com/11137004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162237 0039d316-1c4b-4281-b951-d872f2087c98
DISABLE_CAPS_LOCK is invoked with Shift keyup and should not
be consumed. Otherwise the Shift keyup event is not sent to
the renderer for tabbed web pages.
BUG=155434
TEST=Manually check Shift keyup event is generated.
Review URL: https://chromiumcodereview.appspot.com/11113004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162236 0039d316-1c4b-4281-b951-d872f2087c98
Per discussion with perkj@, after media stream is generated, all error messages would be sent to client, instead of media stream.
Review URL: https://codereview.chromium.org/11146008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162235 0039d316-1c4b-4281-b951-d872f2087c98
The new common_resources.grd will be used for non-loalizeable resources,
such as images.
Review URL: https://chromiumcodereview.appspot.com/11087059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162226 0039d316-1c4b-4281-b951-d872f2087c98
BUG=none
TEST=manual test by verifying new draggable region syntax works
Review URL: https://chromiumcodereview.appspot.com/11028125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162224 0039d316-1c4b-4281-b951-d872f2087c98
WinHttpGetProxyForUrl() can fail in some network configurations. For example it often fails when running in a home network when it cannot download the PAC script. In other words it is normal for this function to fail and the calling cade should just be able to handle it (which is does already).
BUG=156135
Review URL: https://codereview.chromium.org/11183007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162220 0039d316-1c4b-4281-b951-d872f2087c98
does not show up because the display id gets mangled due to mismatching type.
BUG=155523
Review URL: https://chromiumcodereview.appspot.com/11189005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162219 0039d316-1c4b-4281-b951-d872f2087c98
We've seen some crashes in DebugDaemonClientImpl::OnRequestStopSystemTracing.
If debugd crashes or completes I/O back to Chrome too early we could NULL out
a scoped_ptr<> before the code expects it. Null check the pointer.
BUG=155774
TEST=crash reports
Review URL: https://chromiumcodereview.appspot.com/11155017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162217 0039d316-1c4b-4281-b951-d872f2087c98
GLES2Interface is a pure virutal interface. It's likely
that more functions of GLES2Implementation will need have
be declared in GLES2Interface but this is a first step
BUG=155914
Review URL: https://chromiumcodereview.appspot.com/11138021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162216 0039d316-1c4b-4281-b951-d872f2087c98
Revert 162142 - Full Screen Magnifier: Add MagnificationManager
MagnificationManager controls the full screen magnifier from chrome-browser side (not ash side. Note that MagnificationController is on ash side).
MagnificationManager does:
- Watch logged-in. Change the behavior between the login screen and user desktop.
- Watch change of the pref. When the pref changes, the setting of the magnifier will interlock with it.
In addition, this patch make the magnifier settings per-user instead of per-device.
BUG=151891
TEST=manual, browser_test passes.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162080
Review URL: https://chromiumcodereview.appspot.com/11065008TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/11194011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162211 0039d316-1c4b-4281-b951-d872f2087c98
Add AwResource.java, a class that defines a set of resource IDs and
functionality to resolve those IDs to concrete resources.
Initially, we add three resources - two raw resources to represent
error pags and a string resource for default text encoding.
The embedder should set up the IDs before starting to use Chromium.
Review URL: https://codereview.chromium.org/11145026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162205 0039d316-1c4b-4281-b951-d872f2087c98
Updated TaskManagerPanelResourceProvider to no longer expect Panel to have web contents after web contents are disconnected.
BUG=155133
TEST=updated
Review URL: https://chromiumcodereview.appspot.com/11092066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162200 0039d316-1c4b-4281-b951-d872f2087c98
(1) Adds an additional template pattern with "webhp"
(2) ExtractSearchTermsFromURL now requires HTTPS
BUG=135106
TEST=Standard unit tests under TemplateURL.*
Review URL: https://chromiumcodereview.appspot.com/11094046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162199 0039d316-1c4b-4281-b951-d872f2087c98
Rather than requiring early registration for all method id, we can initialize
them lazily as required.
This solves the problem of building against SDK X but running against X - 1.
Also adds a microbenchmark to ensure there are no considerable regressions.
Results are a bit variable, but it hovers over:
[ERROR:jni_android_unittest.cc(125)] JNI LazyMethodIDCall (us) 1983
[ERROR:jni_android_unittest.cc(127)] JNI MethodIDCall (us) 1862
BUG=152987
TEST=JNIAndroidMicrobenchmark.MethodId
TBR=akalin
Review URL: https://chromiumcodereview.appspot.com/11038015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162186 0039d316-1c4b-4281-b951-d872f2087c98
This fixes the scroll-wheel axes being swapped when connecting to Mac hosts.
BUG=155960
Review URL: https://chromiumcodereview.appspot.com/11140047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162185 0039d316-1c4b-4281-b951-d872f2087c98
BUG=137118
TEST=See unit tests, not called in any code yet
Review URL: https://chromiumcodereview.appspot.com/11185002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162184 0039d316-1c4b-4281-b951-d872f2087c98
The current code causes a crash if |parent| belongs to 2nd display. We may want to ensure that |parent| shouldn't have kUsesScreenCoordinatesKey, but this CL rather fixes the caller's code as a quick fix.
BUG=155656
TEST=on goobuntu, run chrome with --aura-host-window-size='800+0-1000x800,800+900-800x600', move a window to 2nd display, click the maximize button, and make sure that the click doesn't cause any crashes.
Review URL: https://chromiumcodereview.appspot.com/11150031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162183 0039d316-1c4b-4281-b951-d872f2087c98
The VerifyUpdatesCommand was used to ensure the validity of each update
that had been delivered from the server and to prepare for the
ProcessUpdatesCommand. The ProcessUpdatesCommand would then take all
updates that had been successfully verified and move them into the
SERVER_ fields of the sync directory.
It turns out that the logic can be greatly simplified by performing both
tasks within the same command. This patch does not take full advantage
of the merge. This patch is intended simply to merge the two files,
with the goal of performing more significant refactorings later.
BUG=154654
Review URL: https://chromiumcodereview.appspot.com/11091009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162176 0039d316-1c4b-4281-b951-d872f2087c98
Ran test 30 times locally, 100% pass rate.
BUG=152033
Review URL: https://chromiumcodereview.appspot.com/11184002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162175 0039d316-1c4b-4281-b951-d872f2087c98
When no network, xmlhttprequest will throw an exception 101. This CL catches the exception and shows an error message in wallpaper picker.
BUG=153895
Review URL: https://chromiumcodereview.appspot.com/11066090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162174 0039d316-1c4b-4281-b951-d872f2087c98
* pnacl_test_example was a smoke test that broke in revision r161425.
* browser_startup_time was a performance test that needs to be redone to work on the Chrome bots.
* stress_many_nexes was a manual test.
BUG= http://code.google.com/p/chromium/issues/detail?id=154400
Review URL: https://chromiumcodereview.appspot.com/11145002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162173 0039d316-1c4b-4281-b951-d872f2087c98
