chromium/src
0
Fork 0
Code Activity
1,002,608 Commits 3 Branches 23,233 Tags
ab4286029cb7c6be94231be24c6ff7f6328b65d0
Commit Graph

3 Commits

Author SHA1 Message Date
Matt Kotsenas
c8c054c497 Add back python executable in test_env_unittest.py 
http://crrev.com/c/2229335 added Python3 support for the `test_env_unittest.py`
files, but appears to have broken the test on Windows in the process.

Fixing by adding back `sys.executable` in the command to run, as Windows
doesn't support running scripts via shebang.

Bug: 942720
Change-Id: I40757a78ad707f36481e2906251ee8451aa89318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238269
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776726}
 2020-06-09 22:15:41 +00:00
Chris McDonald
c3e0f26bef Make test_env compatible with python 2 & 3 
Use the vendored copy of the `six` library to make this code work across
Python versions.

Bug: 942720
Change-Id: I4bdb1032ed8e89e733b929eb13ada54efeb3b019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229335
Commit-Queue: Chris McDonald <cjmcdonald@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774934}
 2020-06-04 02:15:14 +00:00
Caleb Rouleau
6844df15de [testing] Fix signal handling on Windows. 
See https://bugs.chromium.org/p/chromium/issues/detail?id=733612#c6
for details.

Also add tests both for windows and non-windows.

Bug: 733612
Change-Id: Id656635a5fc79ea8f805658873599b526e764406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796572
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695429}
 2019-09-11 01:11:59 +00:00