Add a unit test for PdfViewWebPlugin::FormTextFieldFocusChange() to make
sure it updates the text input type in both the plugin and the frame
widget.
Bug: 1199558
Change-Id: Ic2d98ee18d0eb2097d815962f3b30839f3fb4568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2881308
Commit-Queue: Hui Yingst <nigi@chromium.org>
Reviewed-by: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881317}
This reverts commit 83ca63522c.
Reason for revert: Broke internal waterfall, crbug.com/1207692
Original change's description:
> [ios] Delays WebTest's BrowserState creation until SetUp().
>
> Delaying BrowserState creation until SetUp() will allow subclasses to
> supply their own custom BrowserStates for use in tests. Previously, the
> WebTest constructor was responsible for setting up a TaskEnvironment, so
> it was not possible for a subclass to create a BrowserState before
> WebTest's constructor ran.
>
> Bug: None
> Change-Id: I95d1d8b508d58cc14c11ff81bf7aee10e61d4a4f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2878697
> Commit-Queue: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#881191}
Bug: None
Change-Id: I08783cb9cd0f9c3634234ae0a012cc3e1e423b85
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2885650
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Javier Flores <javierrobles@chromium.org>
Auto-Submit: Javier Flores <javierrobles@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#881315}
These tests depended on the legacy localStorage data format (SQLite
databases for each origin), which blocks removal of the legacy migration
code. This rewrites the tests to populate localStorage with test data
without depending on the legacy format.
Also re-enables one of the tests, which was previously flaky, but is now
rewritten.
Bug: 1206834, 1028676
Change-Id: I7634854bbeaf2be99b2beb76652a2483b78dedb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2880742
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881314}
This reports ANR events. The main purpose of use it is the context of
ANR reduce project to utilize UMA functionality to track improvements
and conduct Finch experiments.
Android part: ag/14415327
BUG=b:187112142
TEST=Locally, modified framework timeouts to easy cause ANRs and confirm
they appear in chrome://histograms
Change-Id: Ide6ae234923b4bd1bbed942a3a4065d71a0e8792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2869972
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Alan Ding <alanding@chromium.org>
Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Reviewed-by: Greg Levin <glevin@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881313}
ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
a single source.
- base::ScopedMultiSourceObservation for observers that do or may
observe more than a single source.
This CL was uploaded by git cl split.
R=dominickn@chromium.org
Bug: 1145565
Change-Id: I705bb782e343977e738fc2db1df599763be330b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2883687
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881312}
Header files that do not use TRACE macros or base::trace_event code do
not need this include. In some cases, the base::trace_event classes can
be forward declared, so the include is also not necessary. Remove the
trace_event.h includes and fix the build by adding missing includes.
Bug: 242216
Change-Id: Iead36b8d2b22aed8eb7bfdcd7c33c4d9971ac440
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2881471
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881309}
Currently if a user has multiple displays and clicks/taps the new desk
button, there is a DeskNameView that is created on each display for the
new desk. Additionally, all of these DeskNameViews request focus,
leading to unexpected behavior. What should happen is that the newly
created DeskNameView on the same DesksBarView as the button that was
clicked/tapped should be focused.
This CL fixes this bug by adding a field to the DesksBarView, which is
set when a new desk button is clicked. Only the DesksBarView with this
new field will have its newly created name view focused.
Test: added
Bug: 1206013
Change-Id: I63b7cb3594a5c6a63ec015e4b0d00ac1dcd740a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2877734
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881308}
SecureDnsManager only needs to be instantiated if the kDnsProxyEnableDOH
feature is enabled, otherwise it's just wasted cycles.
BUG=b:182240110
TEST=units pass
Change-Id: Ia7289a36dabac550ec4cb5cf53d5d57b73104fe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2881504
Commit-Queue: Garrick Evans <garrick@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881304}
When shutting down with a text field in focus, the IME will query the
ChromeKeyboardClient to check if the virtual keyboard is enabled or not.
Unfortunately, the virtual keyboard is already destroyed by then, so
the ChromeKeyboardClient will dereference a nullptr, causing a crash.
Fix this by adding a null check.
Bug: 1206849
Change-Id: Id35738d5630db73aacf117d9cabfc5272998c926
Fixed: 1206849
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2879785
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881302}
This is meant to prevent the case where tab changes independently from
ActivityTabTabObserver related signals. When it does onSSLStateUpdate
can be called with a tab that is not set of LocationBarModel tripping
the assert.
This affects StartSurfaceTests
Bug: 1205642, 1108496
Change-Id: Ib4571033e139120ef8f266b417523672acbe69bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2872438
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Matt Jones <mdjones@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881298}
Some of the logging in SandboxBPF::DisableIBSpec() is causing
debug-build test failures because the sandbox test code expects
no output for many tests.
This CL removes an unnecessary LOG(INFO) and changes one to a VLOG(1).
Bug: 1171027, 1206746
Change-Id: I8e255805e7aa53033205a28231ee366e03069edf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2880845
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881297}
This is a reland with a fix to declare the WebAppProviderFactory
to depend on HostContentSettingsMap so that the WebAppProvider system
is shutdown before HostContentSettingsMap.
Original CL description:
> Unregister file handlers when file handling permission is changed to BLOCK
> by the user, and re-register file handlers when the permission settings is
> changed to ASK/ALLOW. Make WebAppInstallFinalizer observe file handling
> permission changes and update app db state as well as OS state. Make
> both install and update task checks file handling permission during
> |WebAppInstallFinalizer::SetWebAppManifestFieldsAndWriteData|.
>
> Bug: 1194163
> Change-Id: Ia24030018243571b6ed020de205cf346742c0169
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2868925
> Commit-Queue: Phillis Tang <phillis@chromium.org>
> Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#880576}
Change-Id: I30cdc19e6d3327004e45df3b9372bc2708829e08
Bug: 1194163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2885422
Commit-Queue: Phillis Tang <phillis@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881294}
Currently performance.eventCounts() is broken especially for pointerdown, touchstart.
There are two main reasons:
1. A touchstart can be dropped because of HitTest() for touch event. In this case, following pointerdown will not be created. On the
other hand, in touch event model only touch starts can set the target and after that the touch event always goes to that
target. So when touchstart is dropped， the following touchend will not be dispatched.
2. In pointer_event_manager, when there's no pointerevent listener, a pointerevent will not be dispatched.
This CL is trying to count all pointerevent and touchevents for EventTiming invoked by user interactions.
Bug: 1123967
Change-Id: I415dca8cebfc0b8d50b80010eb6673a14ec6f534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2758031
Commit-Queue: Hongbo Song <hbsong@google.com>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881289}
Makes a couple of Python 3 compatibility changes to everything under
//content/test/gpu/:
1. Adds the print_function import to every Python file, which enforces
Python 3's use of print as a function instead of a statement.
2. Fixes found instances of the above.
3. Changes "xrange" to "range".
These changes are compatible with both Python 2 and 3, so there should
be no functional changes.
Bug: 1198237
Change-Id: I44e9fcdc87ef98ad8742cd9ac813c607f6814185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2885679
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881288}
AppDrag is still needed while Mohnstrudel is rolling out. Extend and
make all the histograms expire date consistent. Also extend and make
BackGesture related histograms expire date consistent.
Bug: 1200390, 1200389, 1200360
Change-Id: I0220f02a264c16cd41942a5f464f9febde2f3557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2881347
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881277}
File Handling and Font Access previously were only usable behind a flag,
and therefore their permissions were only viewable in site settings when
the flag was enabled.
Font access has now begun origin trials[1], and file handling is planned
to begin origin trials soon[2]. Remove checks that only expose these
permissions in site settings when relevant flags are active, and instead
always show these permissions.
[1]: https://crrev.com/c/2359470
[2]: https://crbug.com/1157254
Bug: 535764, 1204323
Change-Id: I026fe5b689da49c1a8ca2573cd4f32d4d9deabd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2880900
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#881273}
This CL adds the worker for fetching discounts in the background. This
worker is designed to do background work after calling
FetchDiscountWorker#Start and continue until Chrome is finished. It will
post a delayed task to perform the background work after it finished a
task.
Change-Id: If06dec617d6b51d0d4d009c2f3ccc018f8530b7d
Bug: 1196024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2827399
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Yusuf Ozuysal
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881271}
ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
a single source.
- base::ScopedMultiSourceObservation for observers that do or may
observe more than a single source.
This CL was uploaded by git cl split.
R=csharrison@chromium.org
Bug: 1145565
Change-Id: Ica49fd1d2aee766cc216de1cc0c48b75607fa227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2883882
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881269}
Headers that do not contain "std::" do not need STL includes.
This CL is first mechanically generated as follows:
INCL="algorithm|array|list|map|memory|queue|set|string|unordered_map|unordered_set|utility|vector"
git ls-files net | grep '\.h$' | xargs grep -L std:: | \
xargs grep -El "#include <($INCL)>$" > to_process.txt
INCL_ESCAPED="$(echo $INCL|sed 's/|/\\|/g')"
cat to_process.txt | xargs sed -i "/^#include <\($INCL_ESCAPED\)>$/d"
cat to_process.txt | xargs sed -i '/^$/N;/^\n$/D'
Then also remove an unused <bitset> include, which is not in the list
above.
Bug: 1200833
Change-Id: I962f3a1222d727eba0c1eccfdfb6cc86124fa1a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2881261
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881268}
