These private interfaces no longer have any users, now that the PDF
Viewer stopped using PPAPI. Prior CLs deleted most of the related code,
leaving only a minimal implementation. Delete that along with stragglers
that still reference the PDF headers.
Bug: 1302684
Change-Id: I9c2b5e81d8a919f32b069c68ae053d58a02e2710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3502892
Reviewed-by: K. Moon <kmoon@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#979393}
This CL trades the target-level allowlist for "nogncheck" on a few
lines. This allows us to turn on `gn check` for the target, and prevent
backsliding in other files, even while the leaky abstraction continues
to exist.
Bug: 1158995, 1228394
Change-Id: If147d215cdd0157175bbe9e9c9eba61dc7403547
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3018325
Auto-Submit: Chris Fredrickson <cfredric@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#900650}
Headers that do not contain "std::" do not need STL includes.
This CL is first mechanically generated as follows:
INCL="algorithm|array|list|map|memory|queue|set|string|unordered_map|unordered_set|utility|vector"
git ls-files | grep '\.h$' | xargs grep -L std:: | \
xargs grep -El "#include <($INCL)>$" > to_process.txt
Remove a bunch of third party files from to_process.txt.
INCL_ESCAPED="$(echo $INCL|sed 's/|/\\|/g')"
cat to_process.txt | xargs sed -i "/^#include <\($INCL_ESCAPED\)>$/d"
cat to_process.txt | xargs sed -i '/^$/N;/^\n$/D'
Then fix the build in rlz/.
Bug: 1200833
Change-Id: I7c48cdb53ec85412b6331df626f2f5c4c0174faa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2896225
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#883318}
- Removes some 'pepper_flash_*' files that were removed from the build.
- Removes PPB_Flash_File and PPB_Proxy_Private that are now unused.
- Removes assorted things in content/ and ppapi/ that are no longer
relevant without Flash.
- Removes PepperPluginInstanceImpl::is_flash_plugin method.
Bug: chromium:1064652
Change-Id: I6905b64de90a58668e007a1282a6b6b248506358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481283
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818732}
This removes jumbo.gni, the imports of jumbo.gni, and
any remaining stray references to it in the build files and docs.
Bug: 994387
Change-Id: Ic39b7c609e1bd922e05c7e1104f1e5532c188f5a
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337392
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#796080}
Now that the jumbo build is no longer supported (and hasn't been
for quite a while), there is no need to use the jumbo target types
like jumbo_source_set, jumbo_component, and jumbo_static_library.
This CL converts all such targets back to their non-jumbo equivalents.
The change was made via a simple search and replace.
Bug: 994387
Change-Id: I19b431c148d3b43fa19a72f00b28d84ff5a14e8b
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337280
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#795492}
This change adds struct PP_PrivateAccessibilityButtonFieldInfo to
PP_PrivateAccessibilityFormFieldInfo to transfer accessibility related
PDF button data (radio button, checkbox and push button) from the plugin
process to the mimehandler process. Made the same changes to the C++
versions of these structs and added the appropriate conversion code.
Bug: 1030242
Change-Id: I33eaab3c6471e017799c54ad8d9c98c43e1baeca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217716
Commit-Queue: Mansi Awasthi <maawas@microsoft.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ankit Kumar 🌪️ <ankk@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#775964}
This change adds struct PP_PrivateAccessibilityChoiceFieldInfo to
PP_PrivateAccessibilityFormFieldInfo to transfer accessibility related
PDF choice field data from the plugin process to the mimehandler
process. Made the same changes to the C++ versions of these structs and
added the appropriate conversion code.
Bug: 1030242
Change-Id: I7aa6fd612de051d9e6b22e84e60c964d24685242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214734
Commit-Queue: Mansi Awasthi <maawas@microsoft.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ankit Kumar 🌪️ <ankk@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#774049}
This change adds struct PP_PrivateAccessibilityFormFieldInfo to
PP_PrivateAccessibilityPageObjects to transfer accessibility related PDF
form field data from the plugin process to the mimehandler process. Made
the same changes to the C++ versions of these structs and added the
appropriate conversion code.
This CL refactors existing PP_PrivateAccessibilityPageObjects to send
text field data as part of PP_PrivateAccessibilityFormFieldInfo struct.
Going forward, other form fields will also be added in
PP_PrivateAccessibilityFormFieldInfo.
This change is needed to avoid bloating of
PP_PrivateAccessibilityPageObjects structure with multiple objects.
Bug: 1030242
Change-Id: Ie55ee36645ff9df9bc57dfaa18fb4cc3f245d60b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215155
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ankit Kumar 🌪️ <ankk@microsoft.com>
Commit-Queue: Mansi Awasthi <maawas@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#772610}
This change adds struct PP_PrivateAccessibilityTextFieldInfo to
PP_PrivateAccessibilityPageObjects to transfer accessibility related PDF
text field data from the plugin process to the mimehandler process. Made
the same changes to the C++ versions of these structs and added the
appropriate conversion code.
Bug: 1030242
Change-Id: I50c9e82a9416445394b9cd1747606fc6d3706ef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032463
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Mansi Awasthi <maawas@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#738857}
`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.
Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.
This CL was uploaded by git cl split.
R=bbudge@chromium.org
Bug: 1041419
Change-Id: Ib80f67bc1f9a6a30349eb1289285585590abaffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997826
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730701}
Update Chromium PDF code to use more floats, because that is what PDFs
contain and what newer PDFium APIs return. Adjust related code that
process these floats as well.
Change-Id: I294eea6c66a71a41b340396d4d45dde48eabc5e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961566
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724683}
This change adds new *AccessibilityAnnotInfo structs to transfer
accessibility related PDF annotation data from the plugin process up to
the mimehandler process via the pepper API. This annotation information
is bundled along with links and images into the
*AccessibilityPageObjects group of structs introduced as a part of
http://crrev.com/c/1831957. It will be populated from within pdfium_page
in a subsequent change.
Bug: 1008775
Change-Id: I89eabc8f56c135eac95c2c887d33854fbccbbcb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837558
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Commit-Queue: Kalpak Tapas <katapas@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#716555}
This is a reland of cc4f1e5fe4
This change was reverted due to "Windows Deterministic" bot failing. Apparently,
these bots seems to have a problem with any changes to ppapi/. Currently, the
only way we know is to try again.
This is the exact same CL as the one that was reverted.
Original change's description:
> Pdf a11y: Populate AXNode with new text style info
>
> This change fills the font-family, font-size, font-weight, italic, bold
> and color attributes of the AXNode with exposed values from the PDFium
> APIs.
>
> I've also added a PDF accessibility tree dump test using the filter
> properties to dump those attributes in the expected file. The test file
> is "text-style.pdf".
>
> Somehow, I added in a previous change text-format-expected-blink.txt.
> This file should have never been committed. I removed it in this CL.
>
> Bug: 985604
> Change-Id: I70a4729269aea69e184e61710d7977425b431704
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755412
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Bill Budge <bbudge@chromium.org>
> Reviewed-by: Ian Prest <iapres@microsoft.com>
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711942}
TBR=raymes@chromium.org,bbudge@chromium.org,iapres@microsoft.com,tsepez@chromium.org
Bug: 985604
Change-Id: I4030926c8aff39c05e45b8cdc3a3262d94158c8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898162
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712455}
This change fills the font-family, font-size, font-weight, italic, bold
and color attributes of the AXNode with exposed values from the PDFium
APIs.
I've also added a PDF accessibility tree dump test using the filter
properties to dump those attributes in the expected file. The test file
is "text-style.pdf".
Somehow, I added in a previous change text-format-expected-blink.txt.
This file should have never been committed. I removed it in this CL.
Bug: 985604
Change-Id: I70a4729269aea69e184e61710d7977425b431704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755412
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711942}
In changes pdfium:60110, pdfium:60410 and pdfium:59670, we exposed new
APIs for text style: fill/stroke color, rendering mode and weight.
This change forwards these new available text properties(+ font-family,
which was already exposed) to the
ppapi::PrivateAccessibilityTextRunInfo struct. We use an object of
this type in PdfAccessibilityTree to create the AXNode.
The next step is to populate this information on AXNode.
Bug: 985604
Change-Id: Ia2e41c5427cfb972c071c2a3608631a4f23e6ff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752165
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#710404}
The V8 natives blob (natives_blob.bin) is unused and will shortly be
removed in V8. This CL removes all related infrastructure in chromium.
Specifically, this means that natives_blob.bin is no longer
1. generated during the build process,
2. installed on the target system,
3. loaded by chrome at runtime, and
4. passed to V8.
Tbr: oksamyt@chromium.org
Bug: v8:7624
Change-Id: I535d4308a8aa539c354a212174d47ade411bc89d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847217
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708094}
This is a preparatory change for adding accessibility support for PDF
annotations. Currently, text, links and images within a PDF page are
supported in an accessibility context. These are passed as separate
parameters in Set/GetAccessibilityPageInfo methods exposed through the
Pepper API. When annotation support comes in, the number of parameters
would increase to 6 making those function calls unwieldy and requiring
additional extensions to the templated DispatchResourceCall function.
This change groups links and images into a new *PageObjects struct which
will also be the home for the upcoming representation of PDF
annotations.
Bug: 1008775
Change-Id: Icee1b9b17290614265be8c65c5b594d3a99fe767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831957
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Commit-Queue: Kalpak Tapas <katapas@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#705481}
This reverts commit 147e1d3bae.
Reason for revert: compare_build_artifacts step is flaky on Windows deterministic builder.
File that failed diff check: ppapi_nacl_tests_pnacl_newlib_x64.nexe
(Linux looks good though.)
Original change's description:
> Remove using directives ("using namespace x") from ppapi/, take 2.
>
> Testing to see if this route avoids breaking the Linux Deterministic bot.
>
> TBR=bbudge
>
> Bug: 82078
> Change-Id: I1512141cc886dafa6683f5ff38c6a50f35be067a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818998
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#698817}
TBR=pkasting@chromium.org,bbudge@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1007979
Change-Id: I6b24cc229ac48f5838b230b74d5022a34e1c6415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824673
Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699825}
Use C++ structs for the data structures instead of C structs. This way,
the caller can just pass in C++ data as is, and not worry about the C++
to C data conversion. PPAPI will do the conversion internally.
Bug: 981448
Change-Id: Ief9c97e4e50c9f70413da80db5a9131c1fdcc123
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794247
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697125}
This change modifies the existing PDF interfaces to send data for links
and images. This extends the existing pipeline to accommodate links and
images which is part of the larger effort to make links and images
accessible in PDF. This extends the messaging pipeline between plugin
process and mimehandler process to send links and images.
This doesn't have any changes pertaining to actual data being populated
in the structures. In future CL's the data will be populated in the
structures for links and images.
Bug: 981448
Change-Id: Iee0b1ffae36df57772a739937c240aec5e01dd02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703627
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#682921}
