ad01fbd448
[Sysroot] Port sysroot-creator.sh to Python
...
R=thestig
Bug: None
Change-Id: I951ec800463624ece45b1460c631e08429c37d03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5027933
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org >
Reviewed-by: Lei Zhang <thestig@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226243}
2023-11-17 18:52:30 +00:00
7e4777ab28
Unify callbacks for AddTask and UpdateTask
...
These callbacks will be used in the UI layer to control progress bar
indicators and error messages. In addition, `AddTask` needs to return a
newly created Task with the server-created ID, to route all further
edits to `UpdateTask` instead.
Bug: b/301253574
Change-Id: I670e86652cdb0930bfa866fc2def9f77d93557eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5039016
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org >
Commit-Queue: Artsiom Mitrokhin <amitrokhin@chromium.org >
Reviewed-by: Toni Barzic <tbarzic@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226242}
2023-11-17 18:50:03 +00:00
7be860038d
Revert "cros: Add PasswordSelectionScreenTest"
...
This reverts commit 9590064497https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/37255/overview
Original change's description:
> cros: Add PasswordSelectionScreenTest
>
> Add a browser test for PasswordSelectionScreen.
> Check the user selected password choice options.
>
> Bug: b:304961785
> Change-Id: I12de0ea949e254e4578419511f20e03dbacb7068
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038690
> Reviewed-by: Denis Kuznetsov <antrim@chromium.org >
> Auto-Submit: Anastasiia N <anastasiian@chromium.org >
> Commit-Queue: Denis Kuznetsov <antrim@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1226058}
Bug: b:304961785
Change-Id: Ibac3366ede01a9b08ef5bce4bbc08940cde87d62
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5041455
Auto-Submit: Fabio Tirelo <ftirelo@chromium.org >
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org >
Owners-Override: Fabio Tirelo <ftirelo@chromium.org >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1226241}
2023-11-17 18:48:10 +00:00
857f22a3be
Roll Chrome Win32 PGO Profile
...
Roll Chrome Win32 PGO profile from chrome-win32-main-1700222233-58d43600d345ab671b4edf9abd5959facca615b3.profdata to chrome-win32-main-1700233171-bfd6d0f561a35f3c28f44cf518f87e0e2a522956.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com ,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I4c693f2624ceabae64c1da96043c8ea5d096fecd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5039925
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1226240}
2023-11-17 18:47:47 +00:00
8d32b9f8af
[lacros skew tests] Refresh skew tests for M121
...
This CL updates the ash version ['121.0.6134.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org .
R=rubber-stamper@appspot.gserviceaccount.com
Bug: None
Change-Id: I2c2c9063532f0e9281d7d215331af8c4b3e9fcbe
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5041312
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1226239}
2023-11-17 18:46:20 +00:00
9e49e63b70
Add dawn TLs to tryserver.chromium.dawn.star OWNERS
...
There are currently no OWNERS in European time zone that can fix breakages.
Change-Id: I662a51866943f4b5a2b101abc616125088c0b80b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038697
Commit-Queue: Ben Clayton <bclayton@chromium.org >
Reviewed-by: Ben Pastene <bpastene@chromium.org >
Auto-Submit: Ben Clayton <bclayton@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226238}
2023-11-17 18:45:35 +00:00
b6cab384a1
Installer: Remove .want_full_install file.
...
1 - Remove writing the file during the install. The install still
updates the tag using ksadmin.
2 - In cases where Chrome registers with an updater via keystone_glue,
assume a full update is always needed. This code is moribund and
will only be used if we flip kUseChromiumUpdater back to false,
which would be an emergency circumstance in any event due to other
issues with Keystone, and very unlikely to happen in M121.
3 - In cases where Chrome registers with an updater via
browser_updater_client, do not look for a .want_full_install file.
In practice, this happens only if Chrome is not currently
registered with the updater. If .want_full_install exists, Chrome
should be registered (since the updater must have run
.keystone_install at some point and a diff update failed), but if
this ever happens, it is acceptable to take one additional diff
update.
Fixed: 1503126
Change-Id: I33dd4f567bc6ac9090b705136d6e68d2863051cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5037535
Reviewed-by: Mark Mentovai <mark@chromium.org >
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Commit-Queue: Joshua Pawlicki <waffles@chromium.org >
Auto-Submit: Joshua Pawlicki <waffles@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226237}
2023-11-17 18:38:24 +00:00
495d32e894
[UPMLocalPwd] Rename the util used to check UPM local readiness
...
... which also implies that the password store has been split into
local and account.
Change-Id: I016141a4ab517742bcf0853c2db1b198f7132504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5040716
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org >
Commit-Queue: Ioana Pandele <ioanap@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226236}
2023-11-17 18:38:03 +00:00
4df2155d72
Revert "[Code Health] Remove getLastUsedRegularProfile from FeedFeatures method"
...
This reverts commit 379e12e8eehttps://ci.chromium.org/ui/p/chrome/builders/ci/chromium-internal-arm-builder/18690/overview
Original change's description:
> [Code Health] Remove getLastUsedRegularProfile from FeedFeatures method
>
> Remove usage of the static getLastUsedRegularProfile used in the
> `FeedFeatures.isWebFeedUIEnabled` and adjust its callers to
> propagate a profile instance without further usage of
> `getLastUsedRegularProfile`.
>
> Bug: 1410601
> Change-Id: I0e16f1d48d9a971abf3a860770c6bb829c93c1d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5012896
> Reviewed-by: Ted Choc <tedchoc@chromium.org >
> Commit-Queue: Anthi Orfanou <anthie@google.com >
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
> Cr-Commit-Position: refs/heads/main@{#1226161}
Bug: 1410601
Change-Id: I6c38ae9e806554ab0c828bfa5c86d0838ddb2360
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5041434
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Ian Wells <iwells@chromium.org >
Owners-Override: Ian Wells <iwells@chromium.org >
Auto-Submit: Ian Wells <iwells@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226235}
2023-11-17 18:36:04 +00:00
04c0392e38
focus-mode: Add progress bar fully rounded corner
...
Override the default corner radius of 3, and supply a corner radius of
half the bar height, 4, instead.
Change-Id: I74ee4114b650e1f7210fb90e3029b83dd858f2c4
Bug: b/286931547
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5039774
Auto-Submit: Andrew Pantera <andp@chromium.org >
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org >
Reviewed-by: Richard Chui <richui@chromium.org >
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226234}
2023-11-17 18:34:43 +00:00
2844dd2fc3
Roll Media App from TH-wuXVDHiIWULgej... to lljhrMxHsaH-YZVvN...
...
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202311170600_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/lljhrMxHsaH-YZVvNoj5KRBOPyruvwvT670mhGUhTM8C
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC cros-essential-apps-dev@chromium.org ,jomag@google.com ,media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/208904355,b/301793518,b/310792599
Tbr: media-app@grotations.appspotmail.com
Change-Id: Ieaf4e1e973b9118fe987e6f967dadcd9dc80d4de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5040673
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1226233}
2023-11-17 18:33:44 +00:00
1c8eda0321
[ios/uno] Stop migrating most global SelectedTypes prefs
...
Behavior changes are behind the existing
kReplaceSyncPromosWithSignInPromos flag.
Before this CL, the current value of the global prefs was taken into
account for the new per-account prefs introduced by UNO. The motivation
was that sync happens to honor the global prefs even for signed-in
non-syncing users today. "So we'd better not start syncing types
that were previously disabled".
Well, this behavior is in fact a bug [1]. Pre-UNO, signed-in
non-syncing users cannot configure most such prefs via any UI.
Meaning some data types could be disabled without any apparent reason.
We can even achieve this broken state by:
- Enabling sync.
- Disabling some types.
- Disabling sync (keeps data type prefs).
- Signing in without syncing.
In this CL the migration logic stops reading the global prefs for most
types, i.e. leaves the new account-scoped prefs in their default
states. There is one exception: passwords, which *does* currently
expose a toggle reading/writing the global pref. So that one needs
to stay. We also use the occasion to fix a tangentially related bug:
only the user-configurable pref should be read, not the one from
enterprise policies.
The main point of this CL is making it easier (in follow-ups) to
use the account-scoped prefs also on other platforms.
[1] Honoring the managed version of the pref is still important to
respect the SyncTypesListDisabled policy. That's still guaranteed by
IsTypeManagedByPolicy().
Bug: 1485015
Change-Id: I159165040d8b1f047586fbe72c58ebd0e6b99f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4894708
Reviewed-by: Marc Treib <treib@chromium.org >
Auto-Submit: Victor Vianna <victorvianna@google.com >
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Commit-Queue: Victor Vianna <victorvianna@google.com >
Cr-Commit-Position: refs/heads/main@{#1226232}
2023-11-17 18:30:13 +00:00
c1f1b738ea
Roll clank/internal/apps from 19758c0c3bcc to 1e7642cb671c (1 revision)
...
19758c0c3b..1e7642cb67https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com ,iwells@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: iwells@google.com
No-Try: true
Change-Id: I00b19e6f8ca2d6067ffb5e8c6519c0f8b4f213b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5041038
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1226231}
2023-11-17 18:29:30 +00:00
860f63008f
Roll Skia from 8e9e168418a0 to dd7a26ead897 (1 revision)
...
https://skia.googlesource.com/skia.git/+log/8e9e168418a0..dd7a26ead897
2023-11-17 scroggo@google.com Android: Pin skia's cpp_std to gnu++17
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC nicolettep@google.com ,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:311052584
Tbr: nicolettep@google.com
Change-Id: I9b7f04ae1a600d100fd147438c428e3209955616
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5041271
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1226230}
2023-11-17 18:26:18 +00:00
089f4ef26d
[DanglingPointer] Remove dangling pointer in chrome_download_manager_delegate_unittest.cc
...
Bug: 1291138
Change-Id: Ibad3ef208652a34561cbbe098d8e91e19ae3155f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5020282
Reviewed-by: Min Qin <qinmin@chromium.org >
Commit-Queue: Jagadesh Jai <jagadeshjai1999@gmail.com >
Reviewed-by: David Trainor <dtrainor@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226229}
2023-11-17 18:26:08 +00:00
286d0f0a90
Roll Perfetto from db32e2586d27 to 145279951713 (2 revisions)
...
db32e2586d..1452799517shauncarnegie@google.com Merge changes from topic "android-battery-counter-voltage" into main
2023-11-17 mayzner@google.com tp: NumericStorageBase to enable ownership of data in Storages
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com ,primiano@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: chromium:307482437,chromium:309623584
Tbr: perfetto-bugs@google.com
Change-Id: Iefd3360093638987b302c483b83048c42d2d529a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5041114
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1226228}
2023-11-17 18:24:05 +00:00
1c69717e38
Highlighting toggle
...
This CL connects the highlighter functionality with the user toggle.
I've also changed how we handle disabled menu items (rather than hiding, I disable clicks on them).
Bug: b/304310569
Change-Id: Ia9a90445f5c102e5774708193591f3b552ba591d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5037999
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Reviewed-by: Ian Wells <iwells@chromium.org >
Commit-Queue: Basia Zimirska <basiaz@google.com >
Cr-Commit-Position: refs/heads/main@{#1226227}
2023-11-17 18:19:48 +00:00
4f821e3834
Roll Perfetto Trace Processor Win from 867067368dec to 00d522fc8e81
...
867067368d..00d522fc8ehttps://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC chrometto-team@google.com ,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: Ib6f35024e9fc58e8f124426a54e010f21ddc28cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038648
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1226226}
2023-11-17 18:19:05 +00:00
3febdfd701
HistorySyncBridge: Remove no-longer-needed workaround
...
In the past, ApplyDisableSyncChanges() was not always called when it
should have been, and HistorySyncBridge contained a hacky workaround
for this situation.
These days, ApplyDisableSyncChanges() works reliably, so no more need
for the workaround.
Bug: 897628, 1347733
Change-Id: Ifc77e4fa7b0b6df89c7725bbb0e4fa51ba1ab6f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5033415
Reviewed-by: Jood Hajeer <jood@google.com >
Commit-Queue: Marc Treib <treib@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226225}
2023-11-17 18:18:39 +00:00
cc7aa2b212
Disable the feature kDelayOnFramePresent on Mac
...
This flag is used by CVDisplayLinkBeginFrameSource.
Bug: 1404797
Change-Id: Ib193d3db4091f4b94d50dbfdc53ac24cfc257454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038373
Reviewed-by: ccameron chromium <ccameron@chromium.org >
Commit-Queue: Maggie Chen <magchen@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226224}
2023-11-17 18:17:50 +00:00
7d7f447ee9
pgo: Add support for android in generate_profile
...
Add android support to generate_profile.py as well as documentation in
docs/pgo.md for getting pgo profiles from android devices.
TODO:
- Improve stability (currently adb pull fails often).
- Improve ergonomics (calculate pgo_profiles directory instead of
needing to manually provide it)
Bug: 1498612
Change-Id: Ie2b3010808b185032692f3852086919f8b585ee7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038772
Commit-Queue: Peter Wen <wnwen@chromium.org >
Reviewed-by: Nico Weber <thakis@chromium.org >
Reviewed-by: Andrew Grieve <agrieve@chromium.org >
Auto-Submit: Peter Wen <wnwen@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226223}
2023-11-17 18:14:09 +00:00
2de97d8609
Android: Fix r8 3pp compilation
...
R8 introduced a new compiler flag that we need to preserve in order to
avoid compile failures.
Bug: b/311202383
Change-Id: Ib168c32c6fb74cb6b2a9fea4d55f173520b62872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038334
Auto-Submit: Peter Wen <wnwen@chromium.org >
Reviewed-by: Andrew Grieve <agrieve@chromium.org >
Commit-Queue: Peter Wen <wnwen@chromium.org >
Commit-Queue: Andrew Grieve <agrieve@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226222}
2023-11-17 18:14:00 +00:00
9e5292f619
Update AndroidSandboxRendererProcessPolicy config to include webview.
...
Change-Id: Ifae2ee1695389abb8d89494947c684ee4263e258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038455
Reviewed-by: Elly FJ <ellyjones@chromium.org >
Commit-Queue: Liza Burakova <liza@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226221}
2023-11-17 18:12:58 +00:00
d36d493a86
Roll third_party/distributed_point_functions/
...
This CL rolls distributed_point_functions up to the latest commit:
2db593b64a99f178f682ef0db222d417c23e5bb5. View the diff here:
95a383908a..2db593b64ahttps://github.com/google/distributed_point_functions.git '
# Generate a patch based on the old upstream ref.
cd ~/REPOS/distributed_point_functions
git diff 95a383908a4b39158ec0dd7da6cfe1088403bc5b > ~/dpf.patch
cd ~/REPOS/chrome
git apply ~/dpf.patch \
-p1 \
--directory=third_party/distributed_point_functions/code/ \
--include='third_party/distributed_point_functions/code/dpf/*'
The changes to README.chromium were manual. I updated the "Version"
field to be "N/A" as directed by presubmits (see
//third_party/README.chromium.template).
Bug: 1499970, 1483857
Fuchsia-Binary-Size: Increase is unavoidable due to roll of necessary third-party library.
Low-Coverage-Reason: COVERAGE_UNDERREPORTED https://crbug.com/1501035
Change-Id: Iccb63899982a87290ed80380cc2311ea09687241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5005441
Auto-Submit: Dan McArdle <dmcardle@chromium.org >
Commit-Queue: Dan McArdle <dmcardle@chromium.org >
Reviewed-by: Alex Turner <alexmt@chromium.org >
Reviewed-by: Nan Lin <linnan@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226220}
2023-11-17 18:10:03 +00:00
ea03ead78d
Roll WebRTC from 68ea746993b9 to 4e1e5eae9e9b (15 revisions)
...
https://webrtc.googlesource.com/src.git/+log/68ea746993b9..4e1e5eae9e9b
2023-11-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3b13b74f8b..46fd3cd06c (1225957:1226066)
2023-11-17 jansson@webrtc.org Add xcode caches to dimensions.
2023-11-17 herre@google.com Support shortcircuiting encoded transforms
2023-11-17 jansson@webrtc.org Revert "Added an encode/decode test parameterizable via command line"
2023-11-17 perkj@webrtc.org Add ByteBufferReader constructor for ArrayView
2023-11-17 phancke@microsoft.com Merge Add(Audio|Video)ContentFor(Offer|Answer)
2023-11-17 perkj@webrtc.org UDP socket and TCP socket use AsyncPacketSocket::NotifyPacketReceived
2023-11-17 ssilkin@webrtc.org Added an encode/decode test parameterizable via command line
2023-11-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 231d950fb5..3b13b74f8b (1225584:1225957)
2023-11-17 hta@webrtc.org Use uint8_t as inner type for rtc::ByteBufferReader
2023-11-17 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2023-11-17T04:02:07).
2023-11-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2c0da8a128..231d950fb5 (1225462:1225584)
2023-11-16 twaik@meta.com Reverse the kbits logic according to RFC
2023-11-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 605ee1f19f..2c0da8a128 (1225302:1225462)
2023-11-16 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2023-11-16T04:05:18).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com ,webrtc-infra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1502781
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ifcc9cc28ef2964b53f8a1ae7c7fcca9db059b095
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5041014
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1226219}
2023-11-17 18:09:20 +00:00
61a0abf2f2
scanning: Update end of comment tag
...
End of comment tag is being included in generated css module. Moving
closing tag to same line as 'css_wrapper_metadata_end' to resolve
issue.
Bug: None
Test: Manually deployed and verified UI.
Test: Manually verified generated css.
Change-Id: I6afe6c0466d266da7bd8d5a49020046bffa4a76b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5040321
Reviewed-by: Michael Checo <michaelcheco@google.com >
Commit-Queue: Ashley Prasad <ashleydp@google.com >
Cr-Commit-Position: refs/heads/main@{#1226218}
2023-11-17 18:07:57 +00:00
7e84b07cc9
Roll Website from b225cf637ba1 to f51c9146bda8 (1 revision)
...
https://chromium.googlesource.com/website.git/+log/b225cf637ba1..f51c9146bda8
2023-11-17 davidbienvenu@chromium.org Add page on fixing chrome-branded tests
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dpranke@google.com
Change-Id: I58389af7251d7c8efa29fe6f3de8c209095235ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5041115
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1226217}
2023-11-17 18:05:44 +00:00
a68fe3b288
Replace std::find with base::Contains
...
Source code is much easier to write:
if (base::Contains(my_vector, my_search_value))
than:
if (std::find(my_vector.begin(), my_vector.end(), my_search_value)
!= my_vector.end())
Bug: 561800
Signed-off-by: Aquibuzzaman Md. Sayem <md.sayem@samsung.com >
Change-Id: I02f57383ecbfeb10dbc45155f3cf39b6069dbf29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5034064
Commit-Queue: Maks Orlovich <morlovich@chromium.org >
Reviewed-by: Matt Menke <mmenke@chromium.org >
Reviewed-by: Caleb Raitto <caraitto@chromium.org >
Commit-Queue: Matt Menke <mmenke@chromium.org >
Reviewed-by: Maks Orlovich <morlovich@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226216}
2023-11-17 18:04:45 +00:00
ae4f224243
Roll Perfetto Trace Processor Linux from 00d522fc8e81 to db32e2586d27
...
00d522fc8e..db32e2586dhttps://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC chrometto-team@google.com ,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I50aeaf2329e6a8a03766f07d36a2c4d477e8a35f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5040677
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1226215}
2023-11-17 18:03:52 +00:00
73b359a1fa
[X11] Simplify visual_picker_glx
...
GetFbConfigForFormat() is no longer used, so VisualPickerGlx can
be simplified. A class is no longer needed, so this CL changes it
to be a function instead.
R=sky
Bug: 739898
Change-Id: Ib5fb28106684cafa26b92149569a4495bef51442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5037718
Reviewed-by: Scott Violet <sky@chromium.org >
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org >
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1226214}
2023-11-17 18:03:33 +00:00
85e8dbc423
[Code Health][iOS] Move ios/c/b/mailto_handler to model subfolder
...
To simplify the folder hierarchy on iOS and have a clearer layer
separation, all the files in ios/c/b/mailto_handler/ will be moved to
ios/c/b/mailto_handler/model/ to showcase that they are model files.
This is part of a multi-step CL:
1. crrev.com/c/5026640
2. crrev.com/i/6665307
3. This
Bug: 1480318
Change-Id: Id2d1b32238cc5abf86f64e50df06cc22e68a4030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5033091
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Commit-Queue: Robbie Gibson <rkgibson@google.com >
Reviewed-by: Rohit Rao <rohitrao@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226213}
2023-11-17 18:02:42 +00:00
cee685cd1a
Firmware UI: Set test host using prod const
...
- Extract url_constants into a separate source_set.
- Add url_constants source set as a public dependency in
browser tests and firmware update to enable using const
in targets that depend on it.
- Replace host name const with imported const from prod
code in browser test.
- Remove TODO.
Bug: b:309953643
Test: browser_test --gtest_filter=*FirmwareUpdate*
Change-Id: I6e51bfed7af3d4dfbc20faa56bb38aa57b13b927
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5025653
Reviewed-by: Camden Bickel <cambickel@google.com >
Commit-Queue: Ashley Prasad <ashleydp@google.com >
Reviewed-by: Michael Checo <michaelcheco@google.com >
Cr-Commit-Position: refs/heads/main@{#1226212}
2023-11-17 18:02:25 +00:00
6fc5dd5dbd
[CPA] Fixed reader mode not showing on CCTs
...
When the CPA reader mode feature is enabled we disable the
previous message UI to avoid having two UIs for the same feature.
The CPA reader mode button is not available on CCTs, so the only
way to use reader mode is through the messages UI.
This CL re-enables the messages UI when opening reader mode elegible
pages on custom tabs.
Bug:1502306
Change-Id: I9cbf2133176bb7a2186e451f0826326804803b04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5031511
Reviewed-by: Tommy Nyquist <nyquist@chromium.org >
Commit-Queue: Salvador Guerrero Ramos <salg@google.com >
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1226211}
2023-11-17 18:01:31 +00:00
4d77815b11
Add field trial config for RTL improvements bug fix.
...
Bug: none
Change-Id: I0d1ebb7492448dbc4bf3203ddc5d37495b2af71f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4994451
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Reviewed-by: Gauthier Ambard <gambard@chromium.org >
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org >
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226210}
2023-11-17 17:59:06 +00:00
0558853a59
Use MenuRunner constructor with unique_ptr in AppMenu.
...
As a drive-by, fix a dangling pointer that was caused by the wrong
member definition order.
Bug: 1501294
Change-Id: I7f9e4eab33a0ec2fc76d2a56ac8a1e7fced6e0f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5034921
Reviewed-by: Caroline Rising <corising@chromium.org >
Commit-Queue: Caroline Rising <corising@chromium.org >
Auto-Submit: Jan Keitel <jkeitel@google.com >
Cr-Commit-Position: refs/heads/main@{#1226209}
2023-11-17 17:56:16 +00:00
fc24821edc
[Gardener] Disable flaky test on Linux
...
Bug: 1489241
Change-Id: Ic073e6031705e2dc4de20de4dd81e4624e6f2f09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5037428
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org >
Owners-Override: Fabio Tirelo <ftirelo@chromium.org >
Commit-Queue: Rupert Wiser <bewise@chromium.org >
Reviewed-by: Ian Wells <iwells@chromium.org >
Reviewed-by: Rupert Wiser <bewise@chromium.org >
Auto-Submit: Fabio Tirelo <ftirelo@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226208}
2023-11-17 17:55:16 +00:00
f2c92eb52e
[components] Refactor tests to use ClientSharedImage
...
This CL refactors tests to reduce the usage of mailbox and replaces
DestroySharedImage() calls with the version that takes a ClientSI
parameter.
Bug: 1494911, 1499992
Change-Id: If3c6ad2fcfa57b2b9757c280ebeab94f15ba64e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5037492
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org >
Commit-Queue: Mingjing Zhang <mjzhang@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226207}
2023-11-17 17:55:03 +00:00
3ff0ab7b8c
Firmware UI: Update end of comment tag
...
End of comment tag is being included in generated css module. Moving
closing tag to same line as 'css_wrapper_metadata_end' to resolve
issue.
Bug: None
Test: Manually verified generated css.
Test: Manually deployed and verified UI.
Change-Id: I3b0696291a3cc50bc48ce38d9c30f5e86eee4190
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5040678
Reviewed-by: Michael Checo <michaelcheco@google.com >
Commit-Queue: Ashley Prasad <ashleydp@google.com >
Cr-Commit-Position: refs/heads/main@{#1226206}
2023-11-17 17:51:53 +00:00
6125ef6f2b
Forbid DevTools front-end to access local FS on CrOS
...
Bug: b/306400265
Change-Id: I6d3977c00ec3fadcdf799d84b6a8250d60d6b4f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5037738
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org >
Commit-Queue: Andrey Kosyakov <caseq@chromium.org >
Reviewed-by: Danil Somsikov <dsv@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226205}
2023-11-17 17:49:28 +00:00
6300172ac3
Add OWNERS for sign-in bottom sheet in Feed
...
The code in chrome/browser/feed/android/java/src/org/chromium/chrome/browser/feed/signinbottomsheet/
integrates sign-in bottom sheet.
Bug: None
Change-Id: Id5ea5888e9ea3df4674f30dd5ea2a1f0e0427139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5033731
Commit-Queue: Jian Li <jianli@chromium.org >
Auto-Submit: Boris Sazonov <bsazonov@chromium.org >
Reviewed-by: Jian Li <jianli@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226204}
2023-11-17 17:49:00 +00:00
55e32689fd
Do not let chrome.debugger extensions invoke Network.getAllCookies
...
Network.getAllCookies is deprecated in favor of Storage.getCookies
and the latter is not allowed for extensions, so we shouldn't let
extensions use the former either.
Bug: 1496250https://chromium-review.googlesource.com/c/chromium/src/+/5039174
Reviewed-by: Danil Somsikov <dsv@chromium.org >
Commit-Queue: Andrey Kosyakov <caseq@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226203}
2023-11-17 17:48:22 +00:00
a17896b69c
[webauthn] Remove WebAuthenticationCrosPlatformAuthenticator flag
...
Remove WebAuthenticationCrosPlatformAuthenticator flag. It is expired.
Fixed: 1419259
Change-Id: Ib08e14b3a5a4f1e2063490f4058a52af1b5d43eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5039013
Auto-Submit: Nina Satragno <nsatragno@chromium.org >
Reviewed-by: Martin Kreichgauer <martinkr@google.com >
Commit-Queue: Martin Kreichgauer <martinkr@google.com >
Cr-Commit-Position: refs/heads/main@{#1226202}
2023-11-17 17:47:22 +00:00
115c91f3a8
Put the CVDisplayLink Presentation delay behind a flag on Mac
...
Put the CVDisplayLink Presentation delay in ImageTransportSurfaceOverlayMacEGL::Present() behind a new flag
"DelayOnFramePresent". When this flag is enabled, Presentation
feedback and completion callbacks will not be called until the next HW
VSync. The flag has no effect if kCVDisplayLinkBeginFrameSource is
disabled.
Bug: 1404797
Change-Id: Ib38e61a683be9d250494360d0f4cc6401f0f79dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5037740
Reviewed-by: ccameron chromium <ccameron@chromium.org >
Commit-Queue: Maggie Chen <magchen@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226201}
2023-11-17 17:43:46 +00:00
55d16efe81
Roll clank/internal/apps from 3349b8146992 to 19758c0c3bcc (1 revision)
...
3349b81469..19758c0c3bhttps://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com ,iwells@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1476973
Tbr: iwells@google.com
No-Try: true
Change-Id: Iafaa4e6fa33025239d30c78398fd523695714e8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5041275
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1226200}
2023-11-17 17:43:30 +00:00
2978963897
Assign Mac and iOS builders to the Bling EngProd team
...
As discussed by mail, Mac and iOS builders will be owned by the Bling
EngProd team.
Bug: 1401558
Change-Id: I109216a07e39fe3529b04419c0bba1259c55d3da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4975115
Reviewed-by: Gregory Guterman <guterman@google.com >
Commit-Queue: Gregory Guterman <guterman@google.com >
Reviewed-by: Struan Shrimpton <sshrimp@google.com >
Cr-Commit-Position: refs/heads/main@{#1226199}
2023-11-17 17:40:17 +00:00
f3f2315d31
[iOS] ports testSignOutForSupervisedUserClearAccountData
...
Adapts this test for kReplaceSyncPromosWithSignInPromos.
It now ensures account bookmarks are erased.
Bug: 1477295
Change-Id: I557dc3d677610c11ccdd9c3160375ce018f4b561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5023248
Reviewed-by: Menghan Yang <myuu@google.com >
Commit-Queue: Arthur Milchior <arthurmilchior@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226198}
2023-11-17 17:38:50 +00:00
53e94e74a6
[Gardener] Revert "Roll Chrome Lacros Amd64 Generic PGO Profile"
...
This reverts commits:
- 5ded1e11e9969a7071a9https://ci.chromium.org/ui/p/chrome/builders/ci/lacros-arm-generic-chrome-skylab/9742/overview
Bug: 1503173
Change-Id: Icf2a41e597d6d55d201fc8e9fb2f3c7f4fc78e5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5037493
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org >
Auto-Submit: Fabio Tirelo <ftirelo@chromium.org >
Reviewed-by: Ian Wells <iwells@chromium.org >
Commit-Queue: Ian Wells <iwells@chromium.org >
Owners-Override: Fabio Tirelo <ftirelo@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226197}
2023-11-17 17:38:31 +00:00
f6689b93e1
[rust] stack-probes-lto.rs passes on Mac again
...
So we can remove it from the set of excluded tests.
Bug: 1486137
Change-Id: Id365ee79e914779c3a47e352c91d3de43ea90288
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5033600
Reviewed-by: Zequan Wu <zequanwu@google.com >
Auto-Submit: Hans Wennborg <hans@chromium.org >
Commit-Queue: Hans Wennborg <hans@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226196}
2023-11-17 17:37:43 +00:00
fcc4a69ee2
[ios] Disable BackForwardCacheBrowserTest.DoesNotCacheIfDisplayMediaAccessGranted
...
This test currently fails on the plaform due to video capture issues.
Bug: 1503172
Change-Id: I63968283d6ce71682a78ee4ead1f40028a46a349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5038356
Reviewed-by: Rohit Rao <rohitrao@chromium.org >
Commit-Queue: Ian Vollick <vollick@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226195}
2023-11-17 17:36:07 +00:00
4c9a7cabaf
Add lazy load scroll margin wpt tests
...
Spec:
https://html.spec.whatwg.org/#lazy-load-root-margin
R=pdr
Bug: 1391989
Change-Id: I1d6ff6b7c08b9ad458af249c0e52b4d8d084b998
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5023396
Reviewed-by: Philip Rogers <pdr@chromium.org >
Commit-Queue: Traian Captan <tcaptan@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1226194}
2023-11-17 17:35:46 +00:00
