b75dba0f30
Simplify message parsing in PdfViewWebPluginTest
...
Adds a ParseMessage() wrapper around base::test::ParseJson() that
returns a base::Value::Dict instead of a base::Value. This makes it
easier to construct test messages in a readable way.
Bug: 1323307
Change-Id: I3c8a3be545616103e5b305f9fbd1eee8b31e6634
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698903
Reviewed-by: Lei Zhang <thestig@chromium.org >
Commit-Queue: K. Moon <kmoon@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012672}
2022-06-09 20:17:25 +00:00
372b8fd867
Feedback: Finalize string > search page > suggestedHelpContent
...
* Add screenshot and hash for suggestedHelpContent string.
* Screenshot: http://screen/AQLEefkPENFjEuz
Bug: b:185624798
Test: browser_tests --gtest_filter=OSFeedbackBrowserTest.*
Change-Id: I2c259c0e8e9ef7baeab96220efb053b18cf87dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696201
Commit-Queue: Xiangdong Kong <xiangdongkong@google.com >
Auto-Submit: Longbo Wei <longbowei@google.com >
Reviewed-by: Xiangdong Kong <xiangdongkong@google.com >
Cr-Commit-Position: refs/heads/main@{#1012671}
2022-06-09 20:15:40 +00:00
093af2d066
Add the Android SDK Level to the ARC line in version pages
...
TEST=deploy to volteer with ARC
BUG=228532808
Change-Id: I774f0963c806d9b596ac40ea3fc4082b36cab826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3686576
Reviewed-by: Denis Kuznetsov <antrim@chromium.org >
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org >
Reviewed-by: Jungshik Shin <jshin@chromium.org >
Reviewed-by: Yusuke Sato <yusukes@chromium.org >
Commit-Queue: Josh Hale <joshuahale@google.com >
Cr-Commit-Position: refs/heads/main@{#1012670}
2022-06-09 20:14:26 +00:00
f68af62946
StableVideoDecoderService: Implement Initialize().
...
This CL implements the StableVideoDecoderService::Initialize() method
which simply forwards that call to the underlying mojom::VideoDecoder.
The unit tests are expanded to cover the new code.
Bug: b:195769334
Test: ./media_unittests --gtest_filter="StableVideoDecoderServiceTest.*" in amd64-generic VM.
Change-Id: Ib488328f5041dd79e0a9ffcaab8fa8b024110962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3673497
Reviewed-by: Pilar Molina Lopez <pmolinalopez@chromium.org >
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org >
Reviewed-by: Dan Sanders <sandersd@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012669}
2022-06-09 20:13:10 +00:00
d5aa6fd6d9
Roll SwiftShader from f1a62bb45663 to d68d367047f5 (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/f1a62bb45663..d68d367047f5
2022-06-09 swiftshader.regress@gmail.com Regres: Update test lists @ f1a62bb4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-eng+autoroll@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-eng+autoroll@google.com
Change-Id: Ie08cb22d448f7b73e3aed86603bd845e372a08de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698204
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1012668}
2022-06-09 20:12:51 +00:00
06a9399867
Roll Chrome Linux PGO Profile
...
Roll Chrome Linux PGO profile from chrome-linux-main-1654775993-b65d056154fbbce4b7558bc0c41bc25ee9c6f28a.profdata to chrome-linux-main-1654797479-b238efbb6a1b094b46f3fd1a86b359018e179d3d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I32ffe19a73d2e55cecbc1b783dfe5f6ce0fdcc9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698808
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1012667}
2022-06-09 20:10:32 +00:00
b9b28308e1
Roll Fuchsia Internal Images from 8.20220609.0.1 to 8.20220609.2.1
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/fuchsia-internal-images-chromium
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:fuchsia-fyi-astro
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Disable-Retries: true
Change-Id: Iea7b82ad65ae1372e681b5ce419adf375f083e7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698625
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1012666}
2022-06-09 20:10:11 +00:00
48fe5c1ef4
[journeys] Use i18nMixin instead of $i18n for strings in clusters
...
Internationalization using $i18n is not supported for components in
cr_components. As part of the refactor of the clusters' components we
need to switch to the i18nMixin. Also added a missing boolean and string
to the history_clusters data source.
Bug: 1310280
Change-Id: I32bfcf92125a1ad51b5657fcde78a050c84b3d62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3697497
Reviewed-by: Tommy Li <tommycli@chromium.org >
Commit-Queue: Marlon Facey <mfacey@chromium.org >
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012665}
2022-06-09 20:09:02 +00:00
8ebe292e96
[Autofill] Remove unused validity-related preferences
...
The preferences have been deprecated in M100 and can now be safely
removed.
Bug: 1288863
Change-Id: I3a0aca5a926b3b7e6f6af07760d5b0dfcf518b1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3695432
Reviewed-by: Christoph Schwering <schwering@google.com >
Commit-Queue: Matthias Körber <koerber@google.com >
Auto-Submit: Matthias Körber <koerber@google.com >
Cr-Commit-Position: refs/heads/main@{#1012664}
2022-06-09 20:05:21 +00:00
1b2ca40c55
Launch the quiet permission chip to 100% stable.
...
Bug: 1334626
Change-Id: Ia6345430c01c2546792543e5a826d618d763148b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3695320
Reviewed-by: Balazs Engedy <engedy@chromium.org >
Commit-Queue: Illia Klimov <elklm@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012663}
2022-06-09 20:02:41 +00:00
db919c1d55
[UrlParamFilter] Add applicable classifications metric
...
The new metric is intended to serve as a sanity check on what is
received via component updater, especially if experiments are run. There
is no intended user-facing behavioral change with this CL.
Bug: 1327663
Change-Id: Icd69cbd8e366c5ef1f9f2767ea53475f68d858ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696999
Reviewed-by: Ben Kelly <wanderview@chromium.org >
Commit-Queue: Matt Reichhoff <mreichhoff@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012662}
2022-06-09 19:59:30 +00:00
2212e2bf1f
Revert "lacros - add observers for extension-controlled prefs"
...
This reverts commit c3f61f6cbe1218145https://chromium-review.googlesource.com/c/chromium/src/+/3641706
> Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org >
> Commit-Queue: Ian Helmke <helmke@google.com >
> Reviewed-by: Erik Chen <erikchen@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1011942}
Bug: 1218145https://chromium-review.googlesource.com/c/chromium/src/+/3698842
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org >
Commit-Queue: Ian Helmke <helmke@google.com >
Reviewed-by: Erik Chen <erikchen@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012661}
2022-06-09 19:57:31 +00:00
735051eb03
gio: update string resources
...
This CL updates strings resources for:
- educational dialog
- settings UI
- nudge
Bug: b:232948415 b:188452744
Test: manual, opened archero to capture captures for translation.
Change-Id: I4d3e339509a7642311276dd6a050be083cb0e88d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3697480
Reviewed-by: Cici Ruan <cuicuiruan@google.com >
Commit-Queue: David Jacobo <djacobo@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012660}
2022-06-09 19:56:32 +00:00
161a2bffdf
[sync] Change android sync promo description string in settings
...
This CL changes the android sync promo description string in settings
which shows up when SyncAndroidPromosWithTitle feature flag
is enabled.
Fixed: 1332456
Change-Id: Ib0b2447ebc480829ea5e0db721a9d349d6841f34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3697518
Reviewed-by: Victor Vianna <victorvianna@google.com >
Commit-Queue: Mahmoud Rashad <mmrashad@google.com >
Reviewed-by: Alice Wang <aliceywang@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012659}
2022-06-09 19:55:11 +00:00
789775b4d5
[Follow] Record histogram when Follow Recommendation IPH is shown
...
Follow Recommendation IPH is the textual bubble pops up
from bottom toolbar when the user is browsing an applicable
website. It tells the user that they can follow the site
through 3-dot menu item.
Record histogram when follow Recommendation IPH is shown.
Bug: 1334801https://chromium-review.googlesource.com/c/chromium/src/+/3696902
Reviewed-by: edchin <edchin@google.com >
Reviewed-by: Cathy Li <chili@chromium.org >
Reviewed-by: Adam Arcaro <adamta@google.com >
Commit-Queue: Tina Wang <tinazwang@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012658}
2022-06-09 19:49:22 +00:00
973eba654f
Roll Skia from 60ce7871e774 to 5aa784801054 (3 revisions)
...
https://skia.googlesource.com/skia.git/+log/60ce7871e774..5aa784801054
2022-06-09 mike@reedtribe.org Update to latest rive
2022-06-09 jmbetancourt@google.com correct typo in bulge effect file name
2022-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1190dc2b6863 to 22255d13ec18 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: djsollen@google.com
Change-Id: I32b38b39fbe6d7eacb19153f5e1d4983ff93e1ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698689
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1012657}
2022-06-09 19:49:02 +00:00
1ae31d96f6
Roll Perfetto Trace Processor Linux from 1bbaa538c100 to d82a099c7ee1
...
1bbaa538c1..d82a099c7ehttps://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I439effd0c3ed549e933d5001c5bbeb345a6dbba4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698145
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1012656}
2022-06-09 19:45:32 +00:00
69eefc835e
Roll RE2 from 3e9622e0cd94 to ba2e7c2f2504 (1 revision)
...
3e9622e0cd..ba2e7c2f25hannahshisfb@gmail.com fix 64 to 32 bit clang conversion warning
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/re2-chromium
Please CC junyer@chromium.org ,thakis@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: junyer@chromium.org ,thakis@chromium.org
Change-Id: Ie1df98ddd14d8eb4b75f4278ccd6682a7aa20d60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698803
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1012655}
2022-06-09 19:40:42 +00:00
c6ea70fc7e
Decouple signing out from clear browsing data
...
This cl no longer signs out signed-in non syncing users when clearing
browser data.
This cl also adds a footer link in the clear browsing data page to
enable users to sign out manually.
For supervised users who can't sign-out the footer link is not shown.
The new sign-out point is tracked by a new ProfileSignout(native)/
SignoutReason(java) enum histogram
Bug: 1323259
Change-Id: I5262d923985f7cbc69da466d3d94bb1782185911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3691848
Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012654}
2022-06-09 19:40:22 +00:00
49df3661a6
Add segmentation_platform support in iOS
...
Adds a factory to create segmentation service.
Few pieces like profile observation are left out and will
be added in the next CL.
BUG=1333641
Change-Id: Ic031a0e9c841f236e7a480a825507bcca6ac9598
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3690865
Reviewed-by: Sophie Chang <sophiechang@chromium.org >
Reviewed-by: Raj T <rajendrant@chromium.org >
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org >
Commit-Queue: Siddhartha S <ssid@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012653}
2022-06-09 19:38:50 +00:00
221d842127
Revert "[MessageExp] Use long duration message for some features"
...
This reverts commit c0843ebd4chttps://chromium-review.googlesource.com/c/chromium/src/+/3557977
> Reviewed-by: Chris Lu <thegreenfrog@chromium.org >
> Commit-Queue: Tina Wang <tinazwang@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#986733}
Bug: 1284475
Change-Id: Ifd94e24b2d177ccb80361ec45e22b0c85ad62cda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3697373
Reviewed-by: Chris Lu <thegreenfrog@chromium.org >
Commit-Queue: Tina Wang <tinazwang@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012652}
2022-06-09 19:33:00 +00:00
8a01cba2dc
[SCT Auditing] Enable hashdance by default
...
This enables the SCTAuditingHashdance feature by default. It also
removes a now obsolete test (NotOptedIn_ShouldNotEnqueueReport which is
superseded by the SCTHashdanceBrowserTest suite for the "SB enabled but
extended reporting not enabled" case).
Bug: 1292222
Change-Id: I1c2af9a5e0ec553ff6ec996db08c2334454604e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3674030
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org >
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org >
Commit-Queue: Chris Thompson <cthomp@chromium.org >
Auto-Submit: Chris Thompson <cthomp@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012651}
2022-06-09 19:32:22 +00:00
f50066a510
Use mock time source in ChildCallStackProfileCollectorTest
...
This allows the test to compare exact timestamps, which is safer.
R=wittman
Bug: 1327069
Change-Id: I9d5e6028dc551889ec7cb6a4cf1ccf9deb2f22dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696729
Auto-Submit: Joe Mason <joenotcharles@google.com >
Commit-Queue: Mike Wittman <wittman@chromium.org >
Reviewed-by: Mike Wittman <wittman@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012650}
2022-06-09 19:26:11 +00:00
d74e08d9bd
[Autofill] Enable AutofillParsingPatternProvider in captured-site tests.
...
Bug: 1334830
Change-Id: Ic026610aa47efd3351a49aa08dc89967c5247450
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698485
Commit-Queue: Christoph Schwering <schwering@google.com >
Reviewed-by: Matthias Körber <koerber@google.com >
Auto-Submit: Christoph Schwering <schwering@google.com >
Commit-Queue: Matthias Körber <koerber@google.com >
Cr-Commit-Position: refs/heads/main@{#1012649}
2022-06-09 19:20:12 +00:00
5386432364
Add LocalContentAnalysisEnabled feature
...
This adds a feature to control the overall LCAC implementation, and is
done in its own CL as multiple code paths are likely to depend on it.
Change-Id: Ib4450b3d675bdc6c1018fd376fa3b3b7407b3034
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698862
Reviewed-by: Roger Tawa <rogerta@chromium.org >
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012648}
2022-06-09 19:19:00 +00:00
6eef34848f
Update Crashpad to 816c5572b8c6d7aac8fb85db770496bc1f1da439
...
816c5572b8c6 Lazy load settings in CrashReportDatabase
Change-Id: I06b1e96ce632afaa9e26e2958fe75da2d83de3f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3697300
Reviewed-by: Robert Sesek <rsesek@chromium.org >
Commit-Queue: Justin Cohen <justincohen@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012647}
2022-06-09 19:17:41 +00:00
3aa189cb7a
Remove an internal usage of Event.path
...
Event.path is a non-standard and deprecated API. This patch removes
another internal usage (pointed out by [1]) to help the deprecation.
[1] https://bugs.chromium.org/p/chromium/issues/detail?id=1277431#c15
Bug: 1277431
Change-Id: Ifbea64b6b7234adfe01d766672f9eddc5dd60c29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3691389
Reviewed-by: Jon Mann <jonmann@chromium.org >
Commit-Queue: Jon Mann <jonmann@chromium.org >
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012646}
2022-06-09 19:17:30 +00:00
f6ab08881e
Add entity collection UMA metrics for Omnibox Journey chips.
...
Bug: 1322690
Change-Id: I31de54cc1072f3cc060028e16db0cba8bdc2f2b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3690385
Reviewed-by: manuk hovanesian <manukh@chromium.org >
Commit-Queue: Jun Zou <junzou@chromium.org >
Reviewed-by: Sophie Chang <sophiechang@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012645}
2022-06-09 19:11:54 +00:00
a6d49b0d74
[pdf] Migrate UpdateScroll() tests
...
Migrates tests exercising PdfViewPluginBase's UpdateScroll() method.
Also cleans up more dead code in pdf_view_plugin_base_unittest.cc.
Bug: 1323307
Change-Id: Id7e318c581282e02b4dd16dcaddabb31306df32c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696528
Commit-Queue: K. Moon <kmoon@chromium.org >
Reviewed-by: Lei Zhang <thestig@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012644}
2022-06-09 19:08:25 +00:00
bf93e7f19b
ksv: use GetBackgroundColorInMode
...
- Update code to set color using GetBackgroundColorInMode ensures
color matches UX specs. Previously GetBaseLayer returned the expected
background and frame color. Currently it uses the wallpaper to change
the background color causing color mismatch with other elements
(see screenshot).
- Update test to match expectation.
Screenshot: http://screen/BFec8RLPoa6yZ4q
Bug: None
Test: Deploy to DUT and validate background color match color mode.
Change-Id: Ib10112fd1312d547b24949c86aba1070dc6254c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3691819
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org >
Commit-Queue: Ashley Prasad <ashleydp@google.com >
Cr-Commit-Position: refs/heads/main@{#1012643}
2022-06-09 19:02:48 +00:00
cd290e7cbe
Add download_file_types.asciipb entry for DIAGCAB
...
This file is an executable component of the Windows troubleshooting
platform, so we should treat it like an executable.
Bug: 1332392
Change-Id: Iebdff06d72db74a679c93cec97fb636bb2fb66e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698763
Commit-Queue: Daniel Rubery <drubery@chromium.org >
Reviewed-by: Rohit Bhatia <bhatiarohit@google.com >
Cr-Commit-Position: refs/heads/main@{#1012642}
2022-06-09 19:02:02 +00:00
3f25abf3c7
Roll WebRTC from fd0f6b9bf576 to 4cd3a0d082d0 (2 revisions)
...
https://webrtc.googlesource.com/src.git/+log/fd0f6b9bf576..4cd3a0d082d0
2022-06-09 terelius@webrtc.org Revert "TaskQueue: unexpose delayed task convenience methods."
2022-06-09 handellm@webrtc.org TaskQueue: unexpose delayed task convenience methods.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I24fdf2289f99af9952bcdb032012f4a670a34f0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696879
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1012641}
2022-06-09 19:01:42 +00:00
b420c7b38c
Don't prime geolocation header if DSE does not have geolocation permission
...
Bug: 1328339
Change-Id: I23a3b03e8b1abca6ac74fe5a00680feff21ddb72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3673772
Commit-Queue: Andy Paicu <andypaicu@chromium.org >
Reviewed-by: Patrick Noland <pnoland@chromium.org >
Reviewed-by: Balazs Engedy <engedy@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012640}
2022-06-09 19:00:04 +00:00
3aea0cbb21
Re-enable tests disabled on LSAN.
...
The original leaks seem to have been fixed.
Bug: 960985
Fixed: 960985
Change-Id: Iae25856f578ac902dabd4f1be5cf6ba76b4ea79c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698119
Reviewed-by: Ben Kelly <wanderview@chromium.org >
Commit-Queue: Caleb Raitto <caraitto@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012639}
2022-06-09 18:56:21 +00:00
5cf481d111
Roll Chrome Win32 PGO Profile
...
Roll Chrome Win32 PGO profile from chrome-win32-main-1654775993-221856fdacdbc5d90ad8d21ad8fc9bbf6fc6518a.profdata to chrome-win32-main-1654786776-3441ffa71b4e58a939c9368eb600f129694fb604.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I08260c4482f0ca0fe5d01f3c263cec089207a8b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698225
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1012638}
2022-06-09 18:55:14 +00:00
a982ed28ad
desk_model: Add unittests to improve code coverage
...
This CL adds additional unittests for desk_model_wrapper.cc to improve
its code coverage.
BUG= b/234850590
TEST= DeskModelWrapper*
Change-Id: I6f4f6520db6958087fa17283e8b1141e70009373
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3688265
Commit-Queue: Matthew Zhu <zhumatthew@google.com >
Reviewed-by: Yanzhu Du <yzd@google.com >
Cr-Commit-Position: refs/heads/main@{#1012637}
2022-06-09 18:54:11 +00:00
2a3aa8e99d
[Cast Convergence] Re-Land "Remove is_chromecast from misc places"
...
This Cl re-lands commit 52026271dbhttps://chromium-review.googlesource.com/c/chromium/src/+/3632828
> Reviewed-by: Alexander Cooper <alcooper@chromium.org >
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org >
> Reviewed-by: Matt Menke <mmenke@chromium.org >
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org >
> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org >
> Commit-Queue: Ryan Keane <rwkeane@google.com >
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1001779}
Bug: 1219802, 1293594
Change-Id: If2bbcca9e80363c47c19e35c7a17307520fff890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3687578
Reviewed-by: Alexander Cooper <alcooper@chromium.org >
Reviewed-by: Eric Orth <ericorth@chromium.org >
Reviewed-by: Mark Foltz <mfoltz@chromium.org >
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org >
Commit-Queue: Ryan Keane <rwkeane@google.com >
Reviewed-by: Alex Gough <ajgo@chromium.org >
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org >
Reviewed-by: David Dorwin <ddorwin@chromium.org >
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012636}
2022-06-09 18:51:32 +00:00
9c7d29fe63
Adds simple WPT for aggregatable reporting.
...
Bug: 1326930
Change-Id: Ie309a0b7c2d9834e8aba35b3104c0a94bc0e874e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696259
Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org >
Commit-Queue: Nan Lin <linnan@chromium.org >
Auto-Submit: Adarsh Murthy <adarshmurthy@google.com >
Reviewed-by: Nan Lin <linnan@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012635}
2022-06-09 18:47:42 +00:00
8aef42eb31
[DesktopScreenshots] Load editor component only after feature use.
...
Bug: 1334831
Change-Id: Ib94eed5eeec9fdc613e1b3d936cb4bd5a5b0abef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3697416
Reviewed-by: Sorin Jianu <sorin@chromium.org >
Reviewed-by: Robert Kaplow <rkaplow@chromium.org >
Commit-Queue: Travis Skare <skare@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012634}
2022-06-09 18:47:31 +00:00
b54568da58
CARendererLayerTree: Move layer matching algorithm to separate function
...
This algorithm is suboptimal. Put it in a separate function so that it
can be easily replaced by an alternative.
Bug: 1313999
Change-Id: I9eb393c83d6ba9844466e233414b908c57338c2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696785
Reviewed-by: Maggie Chen <magchen@chromium.org >
Commit-Queue: Maggie Chen <magchen@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012633}
2022-06-09 18:46:21 +00:00
43f8979171
Add aggregation for Blink.UpdateTime:Accessibility
...
The original addition to ukm.xml overlooked the aggregation
necessary for the dashboard.
Bug: 1334731
Change-Id: I99a7ad51fec78c5e61ad33db49229270c44f3948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696559
Commit-Queue: Robert Kaplow <rkaplow@chromium.org >
Reviewed-by: Chris Harrelson <chrishtr@chromium.org >
Reviewed-by: Robert Kaplow <rkaplow@chromium.org >
Auto-Submit: Stephen Chenney <schenney@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012632}
2022-06-09 18:45:20 +00:00
1e835c104c
Move tab strip setup to BrowserCoordinator
...
– Moved tab strip creation to `BrowserCoordinator`
Bug: 1329097https://chromium-review.googlesource.com/c/chromium/src/+/3687685
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org >
Commit-Queue: Petro Akzhygitov <pakzhygitov@google.com >
Cr-Commit-Position: refs/heads/main@{#1012631}
2022-06-09 18:42:56 +00:00
77417cd732
arc/gio: Clear focus when pressing outside of ActionLabel
...
In kEditMode, when pressing on blank space (outside of the
ActionLabel), ActionLabel is unfocused.
Bug: b:232948415 b:188452744
Test: manual test and unittest
Change-Id: Id2d9e1ea66e8b313d29b8090045263cd605e6c03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3694755
Reviewed-by: David Jacobo <djacobo@chromium.org >
Commit-Queue: Cici Ruan <cuicuiruan@google.com >
Auto-Submit: Cici Ruan <cuicuiruan@google.com >
Cr-Commit-Position: refs/heads/main@{#1012630}
2022-06-09 18:42:17 +00:00
5fdad228f0
inspector: Add page-transition-tag to pseudo nodes.
...
Add the page-transition-tag used to uniquely identify pseudo elements
created for a DocumentTransition to the inspector protocol.
Bug: 1316155
Change-Id: Ib69dced4aa7f62b87741e2e33399b6cb314be19d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3688880
Reviewed-by: Andrey Kosyakov <caseq@chromium.org >
Commit-Queue: Khushal Sagar <khushalsagar@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012629}
2022-06-09 18:36:53 +00:00
8f6210c121
[fuchsia] Present overlay frames in Flatland
...
This CL adds the foundation for handling overlay planes in Flatland
and generating a scene graph. It also add includes tests for
FlatlandSurface class.
Bug: 1146006
Change-Id: I4e7801511c9039b0abf643b6ad4d80a5ca4a872b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3513953
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org >
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org >
Commit-Queue: Emircan Uysaler <emircan@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012628}
2022-06-09 18:36:32 +00:00
5226dfed4b
Contextual Page Actions: Handle WebContents destruction
...
This CL adds handling WebContents destruction by keeping a weak_ptr.
Bug: 1322001
Change-Id: I828eced1a9cff2a7bc31bcece502b7c93ac238ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696601
Reviewed-by: Siddhartha S <ssid@chromium.org >
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012627}
2022-06-09 18:33:46 +00:00
e234fed518
Polished the UI for event list view
...
The left, right, and bottom border for event list view overlay on the
borders for the calendar view. We moved the left border to its right by
1px, decreased the width of event list view by 2px (=moved the right
border to its left by 1px), and assigned a new bottom padding so that
the event list view is contained within the calendar view.
Light mode:
before change: https://screenshot.googleplex.com/35SwsBXWDdnLwnw.png
after change: https://screenshot.googleplex.com/AkLcYYUwpc7R8Vy.png
Dark mode:
before change: https://screenshot.googleplex.com/AW8rT3D82KUzbjE.png
after change: https://screenshot.googleplex.com/47Lqws3fpKSWitt.png
Bug: 1329345
Change-Id: Ib34a3321d6457cc5188d5d0a8557f9fe20792f93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3688832
Reviewed-by: Jiaming Cheng <jiamingc@chromium.org >
Commit-Queue: Sylvie Liu <sylvieliu@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012626}
2022-06-09 18:33:11 +00:00
870fd0f853
[Follow] Fix first follow sheet animation
...
Previously when the user clicks on "Go to Feed" button of the first
follow sheet, the sheet won't show a dismissal animation and the
corner radius will change immediately.
To fix: navigate to the new tab page when dismissal animation
completed.
Bug: 1264872
Change-Id: I268f02d9d48b33b368f759b9df62b59a8a18cf7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696919
Commit-Queue: Tina Wang <tinazwang@chromium.org >
Reviewed-by: edchin <edchin@google.com >
Cr-Commit-Position: refs/heads/main@{#1012625}
2022-06-09 18:32:40 +00:00
c2d90ee50c
Fix crash due to SigninManager not being instantiated yet
...
See details here crbug.com/1335029#c5. This brings back one
unconditional call to getSigninManager() that was removed in
crrev.com/c/3692749. Also adds one missing early return in
FirstRunSigninProcessor that should've been there but doesn't make a
difference (except for whether getSigninManager() was called).
Fixed: 1335029
Change-Id: Ib52522e12e9dfe2d9545b27687879537c24cf044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698383
Reviewed-by: Boris Sazonov <bsazonov@chromium.org >
Auto-Submit: Victor Vianna <victorvianna@google.com >
Commit-Queue: Boris Sazonov <bsazonov@chromium.org >
Commit-Queue: Victor Vianna <victorvianna@google.com >
Cr-Commit-Position: refs/heads/main@{#1012624}
2022-06-09 18:27:45 +00:00
1edf73f533
Add histograms for the ECH experiment
...
While we have general SSL/TLS error and latency metrics, ECH is a new,
evolving extension, so most servers will not support it. As most effects
of the experiment will only be visible on those servers, we want to
limit our metrics to only those connections.
Fortunately, both the control and experiment group can determine those
connections, based on whether there was an ECHConfigList in DNS. The
control group will just ignore the ECHConfigList. Thus, add error and
latency metrics based on that set.
ECH also includes a recovery mechanism for DNS/server mismatches. Add
some metrics for how frequently we hit this and what the result was.
I've named that one Net.SSL.ECHResult to align with the subcategory
recommendation in [1]. We probably should have done that for all the
other SSL/TLS histograms, but we can start naming them now.
[1] https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#Naming-Your-Histogram
Bug: 1091403
Change-Id: Idd6c9872ed74811484091518193a9cf284bceaba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3695625
Reviewed-by: Charlie Harrison <csharrison@chromium.org >
Reviewed-by: Matt Mueller <mattm@chromium.org >
Commit-Queue: Matt Mueller <mattm@chromium.org >
Auto-Submit: David Benjamin <davidben@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1012623}
2022-06-09 18:26:51 +00:00
