Ryan Hamilton
7f3bd3d40f
Remove net wrappers around base/strings/escape.h
...
A number of string escaping functions were moved from //net to
//base/strings recently. crbug.com/1100760 was filed to move callers
to the new location and remove the net:: functions. This CL does that
and removes net/base/escape.h and .cc.
https://docs.google.com/document/d/1bNDZyi3uHN1aYf1ReWpa8R9DHM50JnHcouH3d3G8Na8/edit#
Bug: 1068052
Change-Id: Ic879d91e53f1d0f4fa925d7e4887e40ef8350709
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3583363
Reviewed-by: danakj <danakj@chromium.org >
Owners-Override: danakj <danakj@chromium.org >
Commit-Queue: Ryan Hamilton <rch@chromium.org >
Cr-Commit-Position: refs/heads/main@{#995437}
2022-04-23 00:07:39 +00:00
Peter Kasting
debb95b023
Enable -Wshadow by default for the "chromium code" config.
...
Bug: 794619
Change-Id: I67efcfe0f1f7369243cf65c37306d708e05c69ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3276279
Commit-Queue: Peter Kasting <pkasting@chromium.org >
Reviewed-by: Scott Violet <sky@chromium.org >
Owners-Override: Scott Violet <sky@chromium.org >
Cr-Commit-Position: refs/heads/main@{#941841}
2021-11-15 22:14:19 +00:00
Kamila Hasanbega
3fadf6d931
Revert "Enable -Wshadow by default for the "chromium code" config."
...
This reverts commit 4bc6f71377https://chromium-review.googlesource.com/c/chromium/src/+/3202306
> Auto-Submit: Peter Kasting <pkasting@chromium.org >
> Reviewed-by: Dirk Pranke <dpranke@google.com >
> Commit-Queue: Peter Kasting <pkasting@chromium.org >
> Owners-Override: Scott Violet <sky@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#940761}
TBR=sky@chromium.org ,pkasting@chromium.org ,dpranke@google.com ,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: I507152afeadaf7c8d66822a30e9d94858aaecb91
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 794619
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3275779
Reviewed-by: Kamila Hasanbega <hkamila@chromium.org >
Reviewed-by: Dave Tapuska <dtapuska@chromium.org >
Owners-Override: Liviu Tinta <liviutinta@chromium.org >
Owners-Override: Kamila Hasanbega <hkamila@google.com >
Commit-Queue: Dave Tapuska <dtapuska@chromium.org >
Cr-Commit-Position: refs/heads/main@{#940767}
2021-11-11 15:09:03 +00:00
Peter Kasting
4bc6f71377
Enable -Wshadow by default for the "chromium code" config.
...
Bug: 794619
Change-Id: Ic125a2da8692ba63479d260d3712ed75d7a7cd9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202306
Auto-Submit: Peter Kasting <pkasting@chromium.org >
Reviewed-by: Dirk Pranke <dpranke@google.com >
Commit-Queue: Peter Kasting <pkasting@chromium.org >
Owners-Override: Scott Violet <sky@chromium.org >
Cr-Commit-Position: refs/heads/main@{#940761}
2021-11-11 14:51:34 +00:00
Peter Kasting
6552e4c03f
Enable size_t truncation warnings in most directories.
...
Bug: 167187
Change-Id: I757b2469336069ff637de60fde4abeb29bf4d041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3057921
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org >
Reviewed-by: Zhenyao Mo <zmo@chromium.org >
Reviewed-by: danakj <danakj@chromium.org >
Commit-Queue: Zhenyao Mo <zmo@chromium.org >
Auto-Submit: Peter Kasting <pkasting@chromium.org >
Owners-Override: danakj <danakj@chromium.org >
Cr-Commit-Position: refs/heads/master@{#907277}
2021-07-30 21:54:20 +00:00
Scott Violet
8c23e548b1
error_page_populator: minor optimization
...
This code should do nothing if error_html is null. This moves
the check earlier.
BUG=none
TEST=none
Change-Id: I568c5ece3c2e1aca23e91480918ce1a35a07fa55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324654
Commit-Queue: Scott Violet <sky@chromium.org >
Commit-Queue: Bo <boliu@chromium.org >
Auto-Submit: Scott Violet <sky@chromium.org >
Reviewed-by: Bo <boliu@chromium.org >
Cr-Commit-Position: refs/heads/master@{#792463}
2020-07-29 00:27:34 +00:00
Colin Blundell
49f165d652
WebView/WebLayer: Componentize and share network error pages impl
...
This CL componentizes WebView's renderer-side code for displaying
network error pages and replaces WebLayer's fork of the code with
usage of the shared code.
TBR=jochen@chromium.org
Bug: 1024326
Change-Id: I6d9c8070d01a68e0e634fb9e72889ce9d2e8bb9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995323
Commit-Queue: Colin Blundell <blundell@chromium.org >
Reviewed-by: Bo <boliu@chromium.org >
Cr-Commit-Position: refs/heads/master@{#731331}
2020-01-14 14:08:53 +00:00
Colin Blundell
38d069cb4c
[WebView] Componentize strings/resources for error pages
...
This CL takes the first step to componentizing WebView's implementation
of network error pages for sharing with WebLayer (which currently has
forked the implementation). Specifically, this CL moves the
necessary strings and resources to //components. This move leaves
aw_strings.grd and aw_resources.grd effectively empty; however, this
CL makes no attempt to eliminate them in order to keep its scope
limited.
Note that we do not whitelist the strings/resources in WebLayer. We
would ideally do so in order to not have an implicit dependence of
WebLayer on WebView's whitelists, but doing so would currently cause
these resources to be duplicated in the APK. See crbug.com/1041799 for
further details.
Bug: 1024326
Change-Id: If135634e68f5524ba3830c8f0a3f763d12beebac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991569
Commit-Queue: Colin Blundell <blundell@chromium.org >
Reviewed-by: Bo <boliu@chromium.org >
Cr-Commit-Position: refs/heads/master@{#731249}
2020-01-14 12:19:18 +00:00
