chromium/src
0
Fork 0
Code Activity
1,133,963 Commits 3 Branches 23,233 Tags
b75dba0f307d1aff28d17dad801bd366c9f6b508
Commit Graph

18 Commits

Author SHA1 Message Date
David Sanders
a9544a22e0 Fix link to Python 3 migration doc 
Change-Id: Id787cec5fb6f3175266d95a30460ab76557f9c07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3518666
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: David Sanders <dsanders11@ucsbalum.com>
Cr-Commit-Position: refs/heads/main@{#980244}
 2022-03-12 00:59:08 +00:00
Dirk Pranke
0dfd069333 Remove dpranke from OWNERS files. 
I'm going to be out for a while, so this removes me from
various owners files to avoid confusion during reviews.

Change-Id: Iecf6c65f544d5803edc1f806a164b6e5322cf2bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3434116
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/main@{#969168}
 2022-02-09 23:16:05 +00:00
David Munro
9980b2c2bd styleguide/python: Fix typo in the suggested shebang line 
Bug: None
Test: None
Change-Id: I990ba79af4b0df2eb11021840975199d1efb02cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3428612
Auto-Submit: David Munro <davidmunro@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#966200}
 2022-02-02 15:30:41 +00:00
John Palmer
be05130dfd [COIL] Change chromium code search type links to use main rather than master for styleguide 
See this doc: go/chromium-coil-change for more info
    BUG=1210385

Change-Id: I9b7ab9492650ec2d40d825c0a5b7146d3d4f3de6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2902875
Auto-Submit: John Palmer <jopalmer@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Owners-Override: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#884419}
 2021-05-19 11:48:35 +00:00
Dirk Pranke
cc232340a2 Update Python style guide, add Python3 migration doc. 
Now that the migration to Python3 is (finally) in full swing,
I've written up a short cheat-sheet on how to migrate things
and updated the Python style guide to reflect current thinking
(e.g., it is safe to write new code assuming Python 3, etc.).

Bug: 941669
Change-Id: Idcc136d115414554485102be3a64e441079ea9d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2893344
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#882719}
 2021-05-13 22:20:12 +00:00
Kent Tamura
c9bbe0a76d Reformat third_party/blink/*.py for PEP8 
- Update third_party/blink/.style.yapf
- Remove sections about 132 line length limit from blink-python.md
- Remove all .style.yapf in Blink except for the top-level one

This CL has no behavior changes.

Bug: 1051750
Change-Id: Ie0aab33b1485a14fe63ece05ca42a6c502c131e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599792
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838862}
 2020-12-22 14:39:56 +00:00
Edward Lesmes
07c97c0f0b Add DIR_METADATA files to //styleguide 
Generate DIR_METADATA files and remove metatada from OWNERS files for //styleguide.

Bug: 1113033
Change-Id: Ia223073dc571c11b1bc55eeaba7e8a9d738de16d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451392
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814302}
 2020-10-06 18:31:20 +00:00
Dirk Pranke
2202afc83d Remove 'dpranke@chromium.org' from OWNERS. 
I'm now consistently only using 'dpranke@google.com', so there
shouldn't be any need for the other address.

Change-Id: I7576a8bf318cc9455862ea8ef48960e0e6abf641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336508
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#794690}
 2020-08-04 20:00:26 +00:00
Dirk Pranke
aefb264aca Change 'dpranke@chromium.org' -> 'dpranke@google.com' in OWNERS files. 
I'm switching to using just my @google.com account everywhere.

R=pinkerton@chromium.org

Change-Id: I06ee1b3a7068107f71de4b6072f9ca0585dbd8c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207588
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770769}
 2020-05-20 21:15:27 +00:00
Dirk Pranke
2c0d2f0045 Update TEAM in OWNERS for build-related directories. 
Now that there's a build@chromium.org list, this CL
updates the various TEAM= entries in the OWNERS files
to reflect that.

R=agrieve@chromium.org, thakis@chromium.org, mark@chromium.org

Change-Id: I8c41a604dd89aa20c9b381090701eff699c1d302
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209616
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770658}
 2020-05-20 17:39:31 +00:00
John Budorick
9f93ca4808 Remove jbudorick from most non-third_party OWNERS. 
Change-Id: I60fed511086449c987e8ed79721b11f7c2dff073
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136268
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756698}
 2020-04-06 16:48:36 +00:00
Eric Stevenson
6ed879cf22 Remove estevenson from OWNERS files. 
Change-Id: I9d08a918fac32be8f1abce43f1896fe45fb42b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022617
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: (gone) Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735563}
 2020-01-27 21:33:31 +00:00
Andrew Grieve
83d4c6a990 python.md: Update .style.yapf example to for PEP-8 
TBR=agrieve  # trivial doc update.

Bug: 846432
Change-Id: I996bb72278c17c8af6840a16b38808f29727a4f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989765
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728952}
 2020-01-07 16:50:23 +00:00
Andrew Grieve
32bc5e0de6 Python Style: Remove PEP-8 exceptions for indent & naming 
As per discussion: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/RcJgJdkNIdg/discussion

Bug: 846432
Change-Id: I0d1abb42c79278d5edf03091a47fce03d5897c25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984356
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728275}
 2020-01-03 19:39:52 +00:00
Allen Robinson
753a80677e Port Blink Python style guide to Markdown. 
Original can be found at
https://www.chromium.org/blink/coding-style#TOC-Python.

Change-Id: I0763ea22c42aff06b27edc306a28ba05f0a7e2fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685328
Auto-Submit: Allen Robinson <arobins@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674308}
 2019-07-03 00:55:50 +00:00
agrieve
1a1b9066b3 python.md: Add info about YAPF bugs and editor integrations 
Bug: 846432
Change-Id: Ie618f4e8f978bec4134b1b163e46f087d3101967
Reviewed-on: https://chromium-review.googlesource.com/c/1356238
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612658}
 2018-11-30 15:47:22 +00:00
Andrew Grieve
a6dad4a95a python.md: Add info about YAPF and elaborate on pylint 
Bug: 846432
Change-Id: Iac715f99198a10409018c208588211252aa53e53
Reviewed-on: https://chromium-review.googlesource.com/c/1352819
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612178}
 2018-11-29 13:57:32 +00:00
Peter Wen
dcdb2ecc99 Add python style guide with python@chromium.org 
This splits out the python style guide from the root directory and
allows a better way to facilitate discussions surrounding python style.

This is especially useful as we are now starting to use the yapf
formatter. To reduce the delta from original doc, no mention of yapf was
added, but it will be added here in the future when it is turned on by
default.

Bug: None
Change-Id: Ib524512459cdc4e4872246457e414e0636979dc1
Reviewed-on: https://chromium-review.googlesource.com/c/1347029
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610968}
 2018-11-26 23:00:36 +00:00