The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: I89f0a4d7ddeb7c9585f3a0e5421aef8ce5a6f0f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5455854
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1287738}
Migrate all metadata files for components/ folders starting from k to n
and mixins used by metadata files under those folders.
Verify components with http://b/components/{id} or at
go/chrome-on-buganizer-prod-components.
Bug: chromium:1518875
Change-Id: Ie49d4768745b8f7c325d14eef1de4e4e525cdae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5277565
Commit-Queue: Jeff Yoon <jeffyoon@google.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1257969}
Implicit unwrapping of a scoper to its underlying pointer is dangerous
and that capability is being removed. This converts uses of implicit
conversion to be explicit in preparation for its removal, and performs
other cleanup and modernization.
This was committed as https://crrev.com/c/4979673 but reverted due to
a bug. This relands it with the bug fixed.
Bug: 1495439
Low-Coverage-Reason: LARGE_SCALE_REFACTOR Switching from implicit to explicit
Change-Id: Ida8e222c28917a574883a3502570123584c30969
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4994366
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1218807}
This reverts commit a84d64e3c8.
Reason for revert: crbug.com/1497943 crbug.com/1497963
Original change's description:
> Remove uses of implicit conversion of ScopedTypeRef in /components
>
> Implicit unwrapping of a scoper to its underlying pointer is dangerous
> and that capability is being removed. This converts uses of implicit
> conversion to be explicit in preparation for its removal, and performs
> other cleanup and modernization.
>
> Bug: 1495439
> Change-Id: I4d64f17d3442682281e61030a33cd55b5a493031
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4979673
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1217168}
Bug: 1495439
Change-Id: I572bf8a164041489bcc04220cd583d4a740162f8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4994686
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1217574}
Implicit unwrapping of a scoper to its underlying pointer is dangerous
and that capability is being removed. This converts uses of implicit
conversion to be explicit in preparation for its removal, and performs
other cleanup and modernization.
Bug: 1495439
Change-Id: I4d64f17d3442682281e61030a33cd55b5a493031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4979673
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1217168}
This is mostly how the signal works on other desktop platforms since
they work by polling the memory state rather than receiving a
notification from the OS.
Done behind a feature flag as this will have a major impact on how
memory pressure will be handled on MacOS.
Bug: 1417298
Change-Id: I23b443896990b548053e36f5df801da6fcbffc54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4250339
Reviewed-by: Francois Pierre Doray <fdoray@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1108603}
In practice, SetDispatchCallback() was only used in the
MultiSourceMemoryPressureMonitor implementation. This CL removes that
method from the base class so that it becomes specific to
MultiSourceMemoryPressureMonitor.
In addition, this CL renames SetDispatchCallback() to
SetDispatchCallbackForTesting() as it is only used in unit tests.
Bug: None
Change-Id: If17e319e9cb11a80731115bc0d0e8c368493fa28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4209171
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Francois Pierre Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1107036}
This is in preparation for adding support for unified bindings.
At that point there will be subsets of bindings available with
various suffixes, and the unprefixed target will only be used
for fidl_library targets to depend on each other.
Bug: 1351487
AX-Relnotes: n/a. Not user visibile.
Change-Id: I9997e2ebc8f78c4a11f2a5479eeff94e197ff44f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4209851
Owners-Override: Wez <wez@chromium.org>
Commit-Queue: Bryant Chandler <bryantchandler@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1102308}
Turns out there's a lot of includes, so these will have to be removed
before deleting the implementation of the task runner handles.
To allow the deletion of the task runner handle headers, add
the sequenced/thread task runner handles where they are used in
the codebase with scripts.
This was done with an automated change, with a few touchups afterwards.
The code for the mass-refactor changes are here:
python:
https://paste.googleplex.com/5534570878337024
shell:
https://paste.googleplex.com/6466750748033024
In terms of touchups:
- add sequenced/thread task runner handles to
the third_party/blink/public/DEPS, because multiple files were using
it transitively anyways.
- rewrite certain parts of the codebase which used
ThreadTaskRunnerHandles instead of CurrentDefaultHandles.
- fix a compile issue with forward-declaration in
extensions/browser/extension_file_task_runner.h.
AX-Relnotes: n/a.
Bug: 1026641
Change-Id: I737ef32aee4e77c21eaa3a2bdc403a28322cf1b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4133323
Owners-Override: Gabriel Charette <gab@chromium.org>
Commit-Queue: Sean Maher <spvw@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1090532}
This allows:
- features to be defined with a consistent set of qualifiers, and for
that set of qualifiers to be updated over time as appropriate.
- better PRESUBMIT checks to ensure that base::Features are not defined
in headers.
- simplifies things for scripts trying to extract feature definitions
out of C++ code.
The primary CL was generated using a script that automatically rewrites
base::Feature declarations and definitions to the macro form. Changes to
any files with known incompatibilities with the macros (base::Features
without static storage duration and base::Features declared as static
class members) were then fully reverted; those changes will be manually
handled in followups.
This CL was uploaded by git cl split.
R=chrisha@chromium.org
Bug: 1364289
Change-Id: I6fc44bb3b3f3093f32f5c39a1b4f239bf7b038e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916733
Reviewed-by: Francois Pierre Doray <fdoray@chromium.org>
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Francois Pierre Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1051990}
This CL is a no-op.
Only fixing instances where base::Time (and Ticks/Delta) is used in
a statement (i.e. not as a parameter to avoid adding includes in mere
overrides). Skipping pointer and reference qualified instances.
i.e. matches this regex:
'(\n *[^/\n][^/\n][^/\n]*base::(Time|Thread)(Ticks|Delta)?\b[^*&][^)]*;)'
and skipping files that have any existing fwd-decl for any of the
variants.
This is a prereq to remove unused base/task/post_task.h includes in
https://chromium-review.googlesource.com/c/chromium/src/+/3555247
Bug: 1026641
Change-Id: I87b43a8dc92bdceb67f4bd59b327b54813aa72a6
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557354
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#987283}
This CL was generated by using tools/git/move_source_file.py to change
the includes for those files:
base/bind_post_task.h
base/deferred_sequenced_task_runner.h
base/post_task_and_reply_with_result_internal.h
base/sequenced_task_runner.h
base/sequenced_task_runner_helpers.h
base/single_thread_task_runner.h
base/task_runner.h
base/task_runner_util.h
base/updateable_sequenced_task_runner.h
Then formatted using "git cl format". DEPS files were fixed with a
simple search and replace script.
Bug: 1255932
Change-Id: I0d9b5ddd9260fde5e4581e6c6e0080bdb0ed2c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209175
Reviewed-by: Gabriel Charette <gab@chromium.org>
Owners-Override: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#929867}
This is an automatically generated changelist based on group memberships and affiliations, with some transition delay.
To approve this change, CR+1/2 this change and submit. To reject this change, CR -1 this change, and the bot will abandon the change.
To report an issue, file a bug in the Infra>Security component.
Change-Id: I737a493e9cb75b41781435157e3bdd215ae00c4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3144097
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Auto-Submit: Owners Cleanup <swarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#919237}
