vikas soni
ba008f7f0c
[MappableSI] Use CPU_ONLY_READ_WRITE for CrOs media capture.
...
As a part of MappableSI, we are replacing GMB usage with MappableSI.
Creating a MappableSI for R8 format in media capture code currently
fails in service side code[1]. This is because creating a
NativePixmap as part of OzoneImageBacking creation will fail as
the underlying buffer is not texturable.
Also for media capture code irrespective of the format, we don't really
need to hold the GMB handle in the service side SharedImage backing
anyways since capture code only need the GMB handle to map. Handle is
then sent to renderer which actually creates a shared image which will
be used in the GPU process.
Hence use SHARED_IMAGE_USAGE_CPU_ONLY_READ_WRITE which instructs the
service side that a NativePixmap inside the SharedImage is not
necessary for this use case. This allows skipping the service side
checks for texturable format.
[1] https://source.chromium.org/chromium/chromium/src/+/main:ui/gfx/linux/gbm_wrapper.cc;drc=5d0194cbc9cddc2ad096da32f16d7d1eac5d4a34;l=410
Bug: 40264379, 382679374, 370760466
Change-Id: Ie1263454ca3e857efe521d1fe282f399d3db899f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072273
Reviewed-by: Colin Blundell <blundell@chromium.org >
Commit-Queue: vikas soni <vikassoni@chromium.org >
Auto-Submit: vikas soni <vikassoni@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401487}
2025-01-02 10:07:09 -08:00
Charles Hager
0866d0eb4c
Don't show Safety Hub on Auto
...
Safety check features are not currently supported on automotive devices.
Bug: 384884222
Change-Id: I156d90ff919167dff214256b78f92eaa252dd24c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6121008
Commit-Queue: Theresa Sullivan <twellington@chromium.org >
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Reviewed-by: Theresa Sullivan <twellington@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401486}
2025-01-02 10:04:23 -08:00
vikas soni
a80d6a242b
Reland "[MappableSI] Convert GpuMemoryBufferTrackerCros to use MappableSI."
...
This is a reland of commit f3df661110https://chromium-review.googlesource.com/c/chromium/src/+/5901567 and
https://chromium-review.googlesource.com/c/chromium/src/+/6072273 .
Original change's description:
> [MappableSI] Convert GpuMemoryBufferTrackerCros to use MappableSI.
>
> Convert GpuMemoryBufferTrackerCros to use MappableSI instead of
> GpuMemoryBuffer. Future CLs will rename the class, file names and unit
> tests to remove GpuMemoryBuffer naming convention and update it with
> appropriate name.
>
> Bug: 40264379
> Change-Id: I5181d303313c056560a10f5f39633de5c35f2e4a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5786614
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org >
> Commit-Queue: vikas soni <vikassoni@chromium.org >
> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org >
> Auto-Submit: vikas soni <vikassoni@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1341359}
Bug: 40264379, 361010222, 370760466
Change-Id: Ie7f320af73a128cbb429ced9c2984cddbffd8374
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6022280
Auto-Submit: vikas soni <vikassoni@chromium.org >
Reviewed-by: Colin Blundell <blundell@chromium.org >
Commit-Queue: Colin Blundell <blundell@chromium.org >
Commit-Queue: vikas soni <vikassoni@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401485}
2025-01-02 10:03:37 -08:00
Jacob Stanley
8291f8a757
[Ads API UX Enhancements] Updating notice storage service metrics
...
Bug: 377557616
Change-Id: Ibf55199c984963ee55e29c204aa06d79b4d3b9cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6121856
Reviewed-by: Christine Ying <chrstne@google.com >
Reviewed-by: Abe Boujane <boujane@google.com >
Commit-Queue: Jacob Stanley <jacobstanley@google.com >
Cr-Commit-Position: refs/heads/main@{#1401484}
2025-01-02 10:02:37 -08:00
Abigail Katcoff
072152ec38
Topics: Sending Topics with image requests
...
Send the Topics request header on image requests that specify the "browsingTopics" attribute.
Use much of the existing plumbing work from the fetch() API. Adapt many
of the tests for the fetch() API to also run for <img> attribute.
PR: https://github.com/patcg-individual-drafts/topics/pull/357
Bug: 382532794
Change-Id: Id5975006a0c842df8765c49470c5f30bca7586c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6067268
Commit-Queue: Abigail Katcoff <abigailkatcoff@chromium.org >
Reviewed-by: Chris Harrelson <chrishtr@chromium.org >
Reviewed-by: Robert Ogden <robertogden@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401483}
2025-01-02 10:02:26 -08:00
chromium-autoroll
ece015a34b
Roll DevTools Frontend from ad63287c9ad7 to 586fb9db396c (1 revision)
...
ad63287c9a..586fb9db39alinavarkki@google.com [RPP] Point the Annotation Connection Arrow to the middle of the entry instead of the top
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com ,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:373727083
Change-Id: Ia98b42731393b4bdc6c670580baed0b0057e7def
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6138656
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1401482}
2025-01-02 10:00:53 -08:00
Dheeraj Kumar
797b874f30
Remove unused file ActivityContentVideoViewEmbedder.java
...
Cleanup : Removes unused file ActivityContentVideoViewEmbedder.java
from components.
Bug: None
Change-Id: I82e141966ee85aea21313bf1301bb9e8c688a77b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6138041
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org >
Reviewed-by: Ted Choc <tedchoc@chromium.org >
Commit-Queue: Ted Choc <tedchoc@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401481}
2025-01-02 09:59:53 -08:00
Sam Maier
1462e0a138
Roll androidx from XOFE2ivPYQt3K7Rf2... to 7Ly5SKSpj-BSWl8Zf...
...
This is a manual roll of AndroidX, with expectations updates included.
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Change-Id: I746e0a228c905e145553663b1602cf7544bc349d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6138124
Commit-Queue: Andrew Grieve <agrieve@chromium.org >
Reviewed-by: Andrew Grieve <agrieve@chromium.org >
Auto-Submit: Sam Maier <smaier@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401480}
2025-01-02 09:58:57 -08:00
Vishwas Uppoor
338f469482
[Metadata] Cleanup finch flag
...
The AutofillImageFetcher is being used by all payment types to fetch
image assets. AutofillEnableCardArtServerSideStretching was an
optimization that only applied to credit card image assets.
Cleanup AutofillEnableCardArtServerSideStretching without rolling out.
Fixed: 356236072
Change-Id: If67af25a9c33e74fe4edb0b32f8b2934d56a4c35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6112600
Reviewed-by: David Trainor <dtrainor@chromium.org >
Reviewed-by: Siyu An <siyua@chromium.org >
Commit-Queue: Vishwas Uppoor <vishwasuppoor@google.com >
Cr-Commit-Position: refs/heads/main@{#1401479}
2025-01-02 09:57:54 -08:00
Hira Mahmood
f6906a8600
[iOS] Add feature flag for kUpdatedFirstRunSequence
...
This CL adds a flag for a feature with three variations that will update
the sequence of the FRE screens.
Bug: 379306137
Change-Id: Ib2be927e81c2aa2c6f32d68ac9b06d6b7bdab07f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6127189
Reviewed-by: Jérôme Lebel <jlebel@chromium.org >
Commit-Queue: Hira Mahmood <hiramahmood@google.com >
Cr-Commit-Position: refs/heads/main@{#1401478}
2025-01-02 09:55:09 -08:00
Mike Dougherty
56a1c73106
Extend IOS.SandboxMetrics.WebKitCacheSize
...
Extend this metric to match other sandbox metrics
Fixed: 380880173
Change-Id: Ibe698d9f0ec9382cdcd0753734b198ab2e18e848
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111561
Reviewed-by: Olivier Robin <olivierrobin@chromium.org >
Commit-Queue: Mike Dougherty <michaeldo@chromium.org >
Auto-Submit: Mike Dougherty <michaeldo@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401477}
2025-01-02 09:54:14 -08:00
Lily Chen
efbacb867b
Update security FAQ about Safe Browsing warnings
...
Incorporates post-submission feedback on crrev.com/c/6102607.
Change-Id: Ib00a7c7054ede093f431720d78a1a0ac245b394f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6133676
Auto-Submit: Lily Chen <chlily@chromium.org >
Reviewed-by: Seung Jae Lim <andysjlim@chromium.org >
Commit-Queue: Seung Jae Lim <andysjlim@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401476}
2025-01-02 09:52:53 -08:00
chromium-autoroll
0f054f9ce4
Roll Perfetto from 82992fff76e4 to fe572aaa2144 (1 revision)
...
82992fff76..fe572aaa21lalitm@google.com ui: rewrite how trace processor tracks are added to the UI
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com ,petrcermak@google.com ,primiano@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com ,petrcermak@google.com
Change-Id: I2cbf6acd4f10e79593d62e17fd523d6893bc023b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6138560
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1401475}
2025-01-02 09:52:33 -08:00
Chromium WPT Sync
26e358d6ce
Import wpt@0669ef6dc697a069926084ea2031213e9864a39a
...
7f001e1c7...0669ef6dcbe2f02370bhttps://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
vogelheim@chromium.org:
external/wpt/trusted-types
NOAUTOREVERT=true
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Change-Id: Id835f67d91fdfe2e29ecf1af01fe3d06c3af87d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6134784
Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Reviewed-by: Weizhong Xia <weizhong@google.com >
Commit-Queue: Weizhong Xia <weizhong@google.com >
Cr-Commit-Position: refs/heads/main@{#1401474}
2025-01-02 09:50:04 -08:00
chromium-autoroll
25c3dabe07
Roll FreeType from 38272bf85341 to 10b3b14da2a6 (4 revisions)
...
38272bf853..10b3b14da2apodtele@gmail.com * src/truetype/ttobjs.c: Abbreviate tracing.
2025-01-02 apodtele@gmail.com * src/sfnt/ttsbit.c (tt_face_load_sbix_image): Refactor `flip`.
2025-01-01 apodtele@gmail.com [truetype] Consolidate bitmap strike handling.
2024-12-31 apodtele@gmail.com [truetype] Ingnore FT_LOAD_NO_BITMAP in bitmap-only fonts.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com ,drott@google.com ,thestig@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac11.0-blink-rel;luci.chromium.try:win10.20h2-blink-rel
Tbr: bungeman@google.com ,drott@google.com ,thestig@google.com
Change-Id: If8b38ca42b92400afef555eb4861ca25dad59fc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6137436
Commit-Queue: Ben Wagner <bungeman@google.com >
Reviewed-by: Ben Wagner <bungeman@google.com >
Cr-Commit-Position: refs/heads/main@{#1401473}
2025-01-02 09:46:11 -08:00
Alison Gale
e37f3253e9
Change default color of linux glic icon
...
Have a bug tracking a fix to theme the icon but in the meantime,
white is generally going to be the right choice for corp linux
machines for testing.
Bug: 386839488
Change-Id: Ieaa08702372591edbee3a64bb999378ed08158f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6130369
Commit-Queue: Alison Gale <agale@chromium.org >
Auto-Submit: Alison Gale <agale@chromium.org >
Commit-Queue: Ian Wells <iwells@chromium.org >
Reviewed-by: Ian Wells <iwells@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401472}
2025-01-02 09:38:09 -08:00
chromium-autoroll
f7717acb11
Roll Chrome Android ARM64 PGO Profile
...
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1735829695-530571e7d07b9cfa94c3b358d16743387db27574-967cd5e77ba691a25a1bbec84be3e8057177072a.profdata to chrome-android64-main-1735833257-dc30766517abddb0cf959335d85f63ee16dbfbf1-fc1eded9c99631b9e9d38f362b39cef7ece70097.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com ,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I60297025e0efb33dae3fc3dd242bb31fb32700e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6137606
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1401471}
2025-01-02 09:36:43 -08:00
Avynn Donaghe
0ec5183576
[BabelOrca] Handle Language Identification Events
...
Babel Orca handles language identification events and
will switch the source language of the transcriptions
when a language change is detected.
TESTED: unit test coverage, tested on device.
Bug: 376671280
Change-Id: I2f7aff58fae395888c63e2cb90395f44d90a10df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6064253
Commit-Queue: Avynn Donaghe <avynn@google.com >
Reviewed-by: Ahmed Nasr <anasr@google.com >
Cr-Commit-Position: refs/heads/main@{#1401470}
2025-01-02 09:31:28 -08:00
Nicolás Peña
6ae05123ce
[FedCM] Pass the type to the ID assertion endpoint
...
Fixed: 347742955
Change-Id: Ic02f366b9df884d6f1dd6b6b988f1d8e658faa99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6132541
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org >
Commit-Queue: Nicolás Peña <npm@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401469}
2025-01-02 09:31:17 -08:00
Svend Larsen
77b6625609
[DIPS] Mark some metrics as singular and clarify summaries
...
DIPS.SuspectedTrackerFlow* and some DIPS.TrustIndicator* are singular events, but were not marked with `singular="True"` when they were added. Simply marking them as singular now is unsafe, so this CL creates V2s of these metrics.
The <summary>s for many of the DIPS.SuspectedTrackerFlow* and DIPS.TrustIndicator* events were also formatted and/or ordered confusingly; this CL hopefully makes them easier to read.
Change-Id: I463c45e3a6b7f033982e66e5d1a3bd745af71177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6115181
Commit-Queue: Svend Larsen <svend@chromium.org >
Reviewed-by: Sun Yueru <yrsun@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401468}
2025-01-02 09:30:13 -08:00
Kevin Graney
cff578d3ba
Separate feature to equalize button styling
...
Bug: 382314358
Change-Id: Idce28344c64e01ccfcc3cadb2a4642b8dfdd69da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6113667
Reviewed-by: Jacob Stanley <jacobstanley@google.com >
Reviewed-by: Abe Boujane <boujane@google.com >
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Commit-Queue: Kevin Graney <kmg@google.com >
Cr-Commit-Position: refs/heads/main@{#1401467}
2025-01-02 09:24:56 -08:00
Maks Orlovich
48de5faf6a
FLEDGE: Add send_creative_scanning_metadata to AuctionConfig
...
Since this is used to configure trusted signals fetching, it needs to
be consistent per SellerWorklet, so it's passed to that layer a
part of worklet config/worklet key, and not as NonSharedParams.
See https://github.com/WICG/turtledove/issues/792#issuecomment-2402992572 for more context.
Bug: 383513677
Change-Id: Ie2ef2b95ab8d11a5c6707fcf6170a0975f96bd21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6091988
Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org >
Commit-Queue: Maks Orlovich <morlovich@chromium.org >
Reviewed-by: Caleb Raitto <caraitto@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401466}
2025-01-02 09:20:51 -08:00
Mikel Astiz
1bf60eec02
[bookmarks] Fix lagging UUID index upon moves involving nested nodes
...
Before this patch, BookmarkModel::Move() could lead to an outdated UUID
index if both conditions below were met:
1. The move exercises with a folder containing nested nodes.
2. The move involves updating the UUID index because the move was across
'storage' boundaries (i.e. a local bookmark became an account node or
the other way round).
The issue was that the implementation didn't handle descendants of the
node being moved.
In this patch, a helper function UpdateUuidIndexUponNodeMoveRecursive()
is introduced to recursively handle all descendants, in addition to
handling the node itself being moved.
Change-Id: I0684c7a2ce328eab466cb7ca3003fd73bd52f41d
Bug: 387132026
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114588
Reviewed-by: Ankush Singh <ankushkush@google.com >
Commit-Queue: Mikel Astiz <mastiz@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401465}
2025-01-02 09:16:17 -08:00
Kevin Graney
65bc08c9e4
Revert "Disable flaky PrivacySandboxDialogViewBrowserTests"
...
This reverts commit 38643ef150https://ci.chromium.org/ui/p/chromium/builders/ci/Win10%20Tests%20x64
>
> Bug: 371487612
> Change-Id: I8997c87fab6fe0da2ebf864a775f847f2863e6c6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000657
> Owners-Override: Sean Maher <spvw@google.com >
> Reviewed-by: Sean Maher <spvw@google.com >
> Commit-Queue: Sean Maher <spvw@chromium.org >
> Commit-Queue: Sean Maher <spvw@google.com >
> Cr-Commit-Position: refs/heads/main@{#1379226}
Bug: 371487612
Change-Id: I9c456e6f0385b1121cf9421a984bc58a07d32f19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6077405
Commit-Queue: Abe Boujane <boujane@google.com >
Auto-Submit: Kevin Graney <kmg@google.com >
Reviewed-by: Abe Boujane <boujane@google.com >
Cr-Commit-Position: refs/heads/main@{#1401464}
2025-01-02 09:15:40 -08:00
Abigail Katcoff
70da710859
Protected Audience: fix HttpCachedTrustedBiddingSignalsAge metric
...
The request time on the response head corresponds with the original
request time (for the validated and cached entries), not the new
request time, so this metric wasn't being recorded as expected. Do not
record for the "updated" case because we do not appear to have the
relevant fields for it.
OBSOLETE_HISTOGRAM[Ads.InterestGroup.Auction.HttpCachedTrustedBiddingSignalsAge]=replaced by HttpCachedTrustedBiddingSignalsAge2
Bug: 383579272
Change-Id: I223c3c666f12662b13dc32fcc228f238f42778ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6116043
Reviewed-by: Maks Orlovich <morlovich@chromium.org >
Reviewed-by: Orr Bernstein <orrb@google.com >
Commit-Queue: Abigail Katcoff <abigailkatcoff@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401463}
2025-01-02 09:15:09 -08:00
Shakti Sahu
db20b7a11b
[Recent Activity] Move string generation to platform agnostic layer
...
The strings used in recent activity such as title, description,
and timestamp can be created in the cross platform layer. This
CL achieves that. As a result, we deprecate some fields and
introduce other fields in the ActivityLogItem struct.
Bug: 382626225
Change-Id: Ia13c523742d102a50c096e786511a9c7cd15aad7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6119704
Reviewed-by: Min Qin <qinmin@chromium.org >
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org >
Reviewed-by: Gauthier Ambard <gambard@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401462}
2025-01-02 09:09:15 -08:00
Colin Blundell
dbb77bed4c
[Blink] Hardcode resource type in DrawingBuffer::ExportCanvasResource()
...
In preparation for moving this method away from creating a
TransferableResource at all, this CL changes it to hardcode
DrawingBuffer as the resource type rather than taking it from the
TransferableResource. Note that the resource type (which will always be
DrawingBuffer for DrawingBuffer) currently comes from [1] via [2] due to
[3].
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc;l=648;drc=cc14db140cbb0fd068bfd271971307fee9a1721b;bpv=1;bpt=1
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc;l=479-480;drc=cc14db140cbb0fd068bfd271971307fee9a1721b;bpv=1;bpt=1
[3] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc;l=831-836;drc=cc14db140cbb0fd068bfd271971307fee9a1721b;bpv=1;bpt=1
Bug: 352263194
Change-Id: I62d415fba487501c2b0d30cbb502fd4d66a5d120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6113609
Reviewed-by: Saifuddin Hitawala <hitawala@chromium.org >
Commit-Queue: Colin Blundell <blundell@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401461}
2025-01-02 09:08:00 -08:00
Andy Phan
f81e64b4b3
[CodeHealth] Migrate user actions UI to TypeScript
...
Fixed: 385317090
Change-Id: I531f8fd8cb72e770aa0c35f6be1d997dc3ee2124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111518
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org >
Commit-Queue: Andy Phan <andyphan@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401460}
2025-01-02 09:07:02 -08:00
Andy Phan
e978441518
[CodeHealth] Update user action WebUI to use build_webui
...
Roll out build_webui() to the user action WebUI.
This is a prerequisite for migrating the folder to TypeScript.
Bug: 40150605, 385317090
Change-Id: I29dfafb2bb25738e3461e498b6a4637aa165f182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114858
Reviewed-by: David Roger <droger@chromium.org >
Commit-Queue: Andy Phan <andyphan@chromium.org >
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401459}
2025-01-02 09:06:49 -08:00
Alex Mitra
e4f2934140
Re-enable StylusGestureEndToEndTests
...
This test was originally disabled as it was failing on
android-14-x64-rel but the failures were unrelated to the test itself
and seem to have since been resolved.
Bug: 343810189
Cq-Include-Trybots: luci.chromium.try:android-14-x64-rel
Change-Id: Iba98802624c783cb35db5426179615540f4d06db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6120420
Auto-Submit: Alex Mitra <alexmitra@chromium.org >
Commit-Queue: Ziad Youssef <ziadyoussef@chromium.org >
Owners-Override: Alex Mitra <alexmitra@chromium.org >
Reviewed-by: Ziad Youssef <ziadyoussef@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401458}
2025-01-02 09:03:57 -08:00
PKI Metadata Updates Bot
294c73aac6
Automatic update from google3
...
Automatic update for 2025-01-02 UTC
Change-Id: Icb24f070690d38c102dc42ec880c679b8141ade6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6138689
Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com >
Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com >
Cr-Commit-Position: refs/heads/main@{#1401457}
2025-01-02 09:00:57 -08:00
chromium-autoroll
ea1c51f13f
Roll Perfetto Trace Processor Linux from 4b6bff18f3a6 to 82992fff76e4
...
4b6bff18f3..82992fff76https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC chrometto-team@google.com ,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I0ebb0473ceec90c2bb14f3048dcf19cfa3563e41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6137590
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1401456}
2025-01-02 09:00:12 -08:00
chromium-autoroll
2b3a7a9bcc
Roll Dawn from d7d2425e01c0 to a15bad593af0 (1 revision)
...
https://dawn.googlesource.com/dawn.git/+log/d7d2425e01c0..a15bad593af0
2025-01-02 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3a2dbe02736d to 6b6f51cabb41 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com ,dneto@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64
Bug: None
Tbr: dneto@google.com
Change-Id: I1e7532726774001c801252e220f0eadd6b09d9fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6138569
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1401455}
2025-01-02 08:57:11 -08:00
Josh Karlin
916279bfbd
Make GetDomainAndRegistry Cache thread-safe
...
The current implementation of the GetDomainandRegistry
cache is created per-thread. When investigating making it per-sequence,
I noticed just how many instances were being created (~100). It makes
much more sense to make this simple class thread-safe. In so doing the
hit rate remains stable and local perf tests show further improvements.
Bug: 383728878
Change-Id: I6a22cb3447c117949cec4003aa4167521fdc043d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6107725
Commit-Queue: Josh Karlin <jkarlin@chromium.org >
Reviewed-by: Chris Fredrickson <cfredric@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401454}
2025-01-02 08:48:36 -08:00
chromium-autoroll
ff8c786e60
Roll DevTools Frontend from 22a077e79eb4 to ad63287c9ad7 (1 revision)
...
22a077e79e..ad63287c9abmeurer@chromium.org [ui] Make `Widget#detach()` cancel the update cycle.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com ,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:301364727
Change-Id: I827ce99bcd79a37fb04d78486d2d9515fcc59d01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6136894
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1401453}
2025-01-02 08:47:34 -08:00
Yann Dago
0c51f2d9e7
[Enterprise Profile]Remove dependency on ImprovedSigninUIOnDesktop flag
...
Bug: 385364948
Change-Id: I03e97c811709a1915168b77c56ea49e9ada3e701
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6115151
Auto-Submit: Yann Dago <ydago@chromium.org >
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Reviewed-by: Ryan Sultanem <rsult@google.com >
Reviewed-by: David Roger <droger@chromium.org >
Commit-Queue: Yann Dago <ydago@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401452}
2025-01-02 08:44:30 -08:00
chromium-internal-autoroll
0d9874c5fc
Roll clank/internal/apps from b1218b50e4cd to 4d4cf09821c6 (1 revision)
...
b1218b50e4..4d4cf09821https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC atsvirchkova@google.com ,chrome-brapp-engprod@google.com ,ritikagup@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: atsvirchkova@google.com ,ritikagup@google.com
No-Try: true
Change-Id: I7b95dac55b8f01537b4ad0b9c106b1122814b463
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6138653
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1401451}
2025-01-02 08:42:30 -08:00
Alvin Lam
b340aa5ad6
[PS Survey Controller] Add support for the Ads CCT Control Surveys
...
Bug: 379930582
Change-Id: I40b6a757577ec97871fc8c79fba1d3225455debb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114873
Reviewed-by: Kevin Graney <kmg@google.com >
Reviewed-by: Abe Boujane <boujane@google.com >
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Commit-Queue: Alvin Lam <alvingo@google.com >
Reviewed-by: Jacob Stanley <jacobstanley@google.com >
Cr-Commit-Position: refs/heads/main@{#1401450}
2025-01-02 08:38:53 -08:00
chromium-autoroll
45e05e85ca
Roll Skia from 68d4407438ca to 65d7bff9d16a (1 revision)
...
https://skia.googlesource.com/skia.git/+log/68d4407438ca..65d7bff9d16a
2025-01-02 lukasza@chromium.org [rust png] Use `u32` => `f32` conversion that matches Blink.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bwils@google.com ,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:383580201
Tbr: bwils@google.com
Change-Id: Ida8186daf95225459c8bcbf7c526e4271d0e355f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6137316
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1401449}
2025-01-02 08:37:58 -08:00
Nan Lin
561dfc90bd
[Code Health] Remove stale feature StartAssistantAudioDecoderOnDemand
...
Bug: 356234998
Change-Id: I38e95b38e1acd365077752a5641bb8e45e4ecd99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108728
Reviewed-by: Yuki Awano <yawano@google.com >
Commit-Queue: Nan Lin <linnan@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401448}
2025-01-02 08:37:41 -08:00
Aykut Bulut
969a33ce68
Import elgamal files in private-join-and-compute
...
Files are copied from commit at 375be83109e10b32441483dbd0f1ac493488d197
and edited to fix include paths.
Adds new files that define functions to streamline required
functionality. Adds tests for the new functionality.
FIXED: 379335252
Bug: 379379936
Change-Id: I17ecbe982a826fef87e5b8d67af83fe01bb29118
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108229
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org >
Reviewed-by: Dustin Mitchell <djmitche@chromium.org >
Commit-Queue: Aykut Bulut <aykutb@google.com >
Cr-Commit-Position: refs/heads/main@{#1401447}
2025-01-02 08:34:16 -08:00
William Liu
15b950a127
Let border resize as the browser resizes
...
Fixed: 386049748
Change-Id: Iaadb3763cfe5acc1bb5f4c419c0231df6da6d6d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6125236
Reviewed-by: Justin DeWitt <dewittj@chromium.org >
Commit-Queue: William Liu <liuwilliam@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401446}
2025-01-02 08:30:51 -08:00
Nico Weber
165d16321d
Reland^3 "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
...
This reverts commit e00908739e5886a73c34https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/2001/overview
>
>
>
> Original change's description:
> > Reland "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
> >
> > This reverts commit b198121dechttps://chromium-review.googlesource.com/c/chromium/src/+/6115847
> >
> > Original change's description:
> > > Revert "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
> > >
> > > This reverts commit cb59cac5a0https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8727971662145799313
> > >
> > > Sample failed build: https://ci.chromium.org/b/8727971662145799313
> > >
> > > If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6111305&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8727971662145799313&type=BUG
> > >
> > > Original change's description:
> > > > Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> > > >
> > > > This reverts commit dca68566e732fd5de30ahttps://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
> > > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
> > > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
> > > > > with the error:
> > > > > chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
> > > > > 182 | CastWebContents* const parent_cast_web_contents_ = nullptr;
> > > > >
> > > > > Original change's description:
> > > > > > Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
> > > > > >
> > > > > > 8cb44859..091448e3a522d78598..8a1f8039a7https://github.com/llvm/llvm-project/pull/119414 .
> > > > > >
> > > > > > Bug: 382540640
> > > > > > Disable-Rts: True
> > > > > > Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> > > > > > Auto-Submit: Alan Zhao <ayzhao@google.com >
> > > > > > Commit-Queue: Zequan Wu <zequanwu@google.com >
> > > > > > Commit-Queue: Alan Zhao <ayzhao@google.com >
> > > > > > Reviewed-by: Zequan Wu <zequanwu@google.com >
> > > > > > Cr-Commit-Position: refs/heads/main@{#1399472}
> > > > >
> > > > > Bug: 382540640
> > > > > Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
> > > > > Owners-Override: David Baron <dbaron@chromium.org >
> > > > > Auto-Submit: David Baron <dbaron@chromium.org >
> > > > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> > > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> > > > > Cr-Commit-Position: refs/heads/main@{#1399476}
> > > >
> > > > Bug: 382540640
> > > > Change-Id: I0c6504bd82a38b6a8fddb27b080af3b639e4acc6
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111305
> > > > Commit-Queue: Alan Zhao <ayzhao@google.com >
> > > > Reviewed-by: Alan Zhao <ayzhao@google.com >
> > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> > > > Commit-Queue: Nico Weber <thakis@chromium.org >
> > > > Cr-Commit-Position: refs/heads/main@{#1399482}
> > > >
> > >
> > > Bug: 382540640
> > > Change-Id: Ic3fc3671ab942245b89aaa461cf8e5c5331d96d2
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6116109
> > > Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com >
> > > Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com >
> > > Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com >
> > > Cr-Commit-Position: refs/heads/main@{#1399490}
> >
> > Bug: 382540640
> > Change-Id: I0e783f8acad96b4bf57d715f33fef50c8af9b4a4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114634
> > Commit-Queue: Nico Weber <thakis@chromium.org >
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> > Auto-Submit: Nico Weber <thakis@chromium.org >
> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> > Cr-Commit-Position: refs/heads/main@{#1399535}
>
> Bug: 382540640
> Change-Id: I468132e0b79883372f0b3487577b942b2e212629
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108528
> Auto-Submit: Lingqi Chi <lingqi@chromium.org >
> Commit-Queue: Lingqi Chi <lingqi@chromium.org >
> Owners-Override: Lingqi Chi <lingqi@chromium.org >
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> Cr-Commit-Position: refs/heads/main@{#1399706}
Bug: 382540640,385545752
Change-Id: I748d35167b0a05a9f01976226d311f387e1d193e
Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6133672
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Nico Weber <thakis@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401445}
2025-01-02 08:27:35 -08:00
Stepan Khapugin
9236657392
[Code Health][iOS] Move ios/c/b/ui/authentication to ui_bundled
...
To simplify the folder hierarchy on iOS and have a clearer layer
separation, all the files in ios/c/b/ui/<foo>/ will be moved to
ios/c/b/<foo>/ui_bundled/ to showcase that they are model files.
Low-Coverage-Reason: LARGE_SCALE_REFACTOR only moving code
Fixed: 324232855
Change-Id: I9aae94384d660e0acc87cb5e31dcce80bf1ff400
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6110787
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org >
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org >
Reviewed-by: Mark Cogan <marq@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401444}
2025-01-02 08:23:38 -08:00
Caroline Rising
550f775088
Reland "Reland "Cap side panel width at 2/3 browser width while respecting min width""
...
This is a reland of commit e600673dbd5dac3b15c7https://chromium-review.googlesource.com/c/chromium/src/+/6082293
> > Commit-Queue: Caroline Rising <corising@chromium.org >
> > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
> > Reviewed-by: Erik Chen <erikchen@chromium.org >
> > Cr-Commit-Position: refs/heads/main@{#1394539}
>
> Bug: 326297943
> Change-Id: I0a5f25038e075a69f987e2db6cf4d179f84e2cdf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6089613
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
> Commit-Queue: Caroline Rising <corising@chromium.org >
> Reviewed-by: Erik Chen <erikchen@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1397311}
Bug: 326297943
Change-Id: I4193263d8b4205db82b1265816803312b6dd306a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6130916
Reviewed-by: David Pennington <dpenning@chromium.org >
Reviewed-by: Erik Chen <erikchen@chromium.org >
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com >
Commit-Queue: Caroline Rising <corising@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401443}
2025-01-02 08:22:32 -08:00
Ben Wagner
8040778b99
[freetype] Add autoroller to OWNERS of README.chromium
...
The Chromium CQ can no longer be run without Code-Owners being satisfied
on all changed files. The autoroller has OWNERS on DEPS and
third_party/freetype/src (gitlink) but it does not currently have OWNERS
on third_party/freetype/README.chromium which is the other file which
must be updated when rolling.
Change-Id: I2639bb6df4bbe167bb94239352b27bdad54ec688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6134173
Commit-Queue: Ben Wagner <bungeman@google.com >
Reviewed-by: Greg Daniel <egdaniel@google.com >
Cr-Commit-Position: refs/heads/main@{#1401442}
2025-01-02 08:21:23 -08:00
Arthur Milchior
958968be62
[java]Accept kMaxValue in enum
...
kMaxValue has a special meaning for histogram enum.
No suffix can be prefixed to it.
So the fact that it has no prefix should not lead to considering that the enum itself has no prefix generally.
It’ll allow, in the next CL, to simplify some code.
Unit test by @ljjlee copied from crrev.com/c/6129846
Bug: None
Change-Id: I53927df99ec17fd0eb664d62957cb22da341ad5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6120414
Auto-Submit: Arthur Milchior <arthurmilchior@chromium.org >
Reviewed-by: James Lee <ljjlee@google.com >
Reviewed-by: Sam Maier <smaier@chromium.org >
Commit-Queue: Arthur Milchior <arthurmilchior@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401441}
2025-01-02 08:21:00 -08:00
Amelie Schneider
a041f4edb0
[UNO] Fix UAF of web contents when address sign in promo is closed
...
When the window was closed with the address sign in promo open, an
address bubble controller was created from web contents in an invalid
sequence, causing a UAF. This fixes the UAF by checking the web
contents before use.
Bug: 385355879
Change-Id: I8eee4bdda05b600674567e31113cbe7e47381133
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6113608
Commit-Queue: Amelie Schneider <amelies@google.com >
Reviewed-by: David Roger <droger@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401440}
2025-01-02 08:19:37 -08:00
Maks Orlovich
a81a99ac07
FLEDGE: Add InterestGroup::Ad::creative_scanning_metadata
...
See https://github.com/WICG/turtledove/issues/792#issuecomment-2402992572 for more context.
Bug: 383513677
Change-Id: I0fb23266c12a20046976c7a1b723136499a59a44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6084483
Reviewed-by: Caleb Raitto <caraitto@chromium.org >
Commit-Queue: Maks Orlovich <morlovich@chromium.org >
Reviewed-by: Dave Tapuska <dtapuska@chromium.org >
Reviewed-by: Cammie Smith Barnes <cammie@chromium.org >
Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1401439}
2025-01-02 08:16:46 -08:00
Karol Sygiet
3498deee30
[Japan] Fix explicitly removing alternative name in settings UI
...
Before this change if there was an alternative name stored, clearing it
failed, since the value was formatted again from the subcomponents as
part of the `FinalizeAfterImport` flow.
After this change the values are no longer formatted from
subcomponents if they were user verified to be empty. In that case
the `CompleteFullTree` method will fail causing the tree to be Wiped
and reparsed.
Bug: 386905027, 359768803
Change-Id: If1ca748e799075534d813b84166e50f5bed86871
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6132997
Reviewed-by: Norge Vizcay <vizcay@google.com >
Commit-Queue: Karol Sygiet <sygiet@google.com >
Cr-Commit-Position: refs/heads/main@{#1401438}
2025-01-02 08:11:49 -08:00
