Currently, PageContentAnnotationsService queries country code
directly from VariationsService, which will return an empty string
for country code on local builds. This makes functionalities with
country limitation not work on local builds. This CL fixes this
issue by applying a default country code when country code is not
available in VariationsService.
Change-Id: Ib7f1abbdce3c3edd87e737780eba963779d78297
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5171200
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243472}
Crowdsourcing helps to classify forms online, based on signals from
different users about the same form. However on localhost it's likely
that semantically different forms will receive same signatures, so
PasswordManager should not use server predictions and upload votes
for such forms.
The follow-up CL will stop uploading votes.
Bug: 1515560
Change-Id: Ibb2bdf3537e2b54b944c86f099dc90cd370880e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5168686
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Maria Kazinova <kazinova@google.com>
Cr-Commit-Position: refs/heads/main@{#1243471}
For now, this functionality is gated behind a base::Feature that is
disabled by default.
This CL does *not* interact with SameSite semantics, and still
maintains that only SameSite=None cookies are allowed in ABA contexts.
This exception is for 3P cookie blocking only.
This exception cannot be applied to cookies accessed via JS.
Bug: 1513690
Change-Id: Id5964224403b7eb9aab69cebe69095530da5baa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5147868
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Reviewed-by: Chris Fredrickson <cfredric@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243468}
This CL introduces the interface PasswordSafetyCheckController that is
supposed to be created as a helper for SafetyCheckMediator to handle
password check state. GmsCorePasswordSafetyCheckController implements
the interface and uses Gms core functionality for the password check.
Method
PasswordsCheckPreferenceProperties.passwordsStateFromPasswordCheckResult
will be used to convert the password check result provided by the
controller into the PasswordsState known to the SafetyCheckMediator.
There will be 2 implementations of the interface:
- One for the password check done on the Gms core side.
- One for the password check in Chrome.
The old Chrome internal implementation will be introduced in the follow
up CLs. The correct version of PasswordSafetyCheckController will be
instantiated and used for the SafetyCheckMediator depending on whether
the Gms core is being used or not.
Bug: b/312930046
Change-Id: I0368169066018cf1037a2797f45206b2035602cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5168585
Commit-Queue: Anna Tsvirchkova <atsvirchkova@google.com>
Reviewed-by: Rainhard Findling <rainhard@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243464}
This feature is code-complete. Removing the experimental prefix makes it
possible to enable this feature without the risk of accidentally
enabling potentially incomplete http flags code paths in old versions of
Cronet. But we don't want to use the final name just yet because we
might have to make last-minute changes which may force another rename.
Bug: b:318805346
Change-Id: I228a5ce31ff1cc4b96bf7f3d914a7f018dd0ca57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5172599
Reviewed-by: Stefano Duo <stefanoduo@google.com>
Auto-Submit: Etienne Dechamps <edechamps@google.com>
Commit-Queue: Stefano Duo <stefanoduo@google.com>
Cr-Commit-Position: refs/heads/main@{#1243462}
Added test suite and target "webview_trichrome_64_cts_hostside_tests" for trial running host-driven WebView CTS, supported by http://crrev/c/4901987
Added mixin description to display Android API level in Milo build step for API level 31 and 33.
Follow up work:
To remove these builders once host-driven CTS test suite is added to "android-12-x64-rel" required CQ builder.
Bug: b/267730567
Cq-Include-Trybots: luci.chromium.try:android-webview-13-x64-dbg-hostside
Change-Id: I5d1bc2fb5a32b04c08fe6cda54105f30d97432e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5116858
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Mateusz Zbikowski <zbikowski@google.com>
Commit-Queue: Gabrielle Lau <gabriellelau@google.com>
Cr-Commit-Position: refs/heads/main@{#1243460}
Follow-up to revert crrev.com/c/5166237. Adds the xcore core binaries
and dummy driver instead of the entire xorg package which installs lots
of video / input drivers.
Bug: 1417069, 1513713
Change-Id: I3075508e470c1ed11628c13f2bfb1250c4fc26c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5171264
Commit-Queue: Brad Triebwasser <btriebw@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243456}
This CL dismisses the keyboard as soon as the scrollview with the search
results is scrolled.
Prior to the new Compositional Layout, this was not an issue, as there
was a bug where the Suggested Actions had a way too large height,
leading to the Suggested Actions not being able to be occluded by the
keyboard. But the Compositional Layout gives it its correct height,
leaving it hidden behind the keyboard.
An alternative fix would be to subscribe to the keyboard notifications,
and adapt the scroll view's additional safe area insets but it's more
cumbersome.
Fixed: 1515895
Change-Id: I411b5bb0deb9fa62e4e43805a2eb5d2601da891e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5172556
Reviewed-by: Aliona Dangla <alionadangla@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Auto-Submit: Louis Romero <lpromero@google.com>
Commit-Queue: Aliona Dangla <alionadangla@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243454}
There are only 10 dips to play with for battery fill level.
The old behavior always rounds down (floor rounding) so a charge
level of 29% and a charge level of 20% both only have 2 pixels of
fill height.
UX prefers we normally round below 50% battery and floor round
otherwise. This means that a charge level of 25% would have 3 pixels
of fill, so it would look more accurate at lower battery levels.
Bug: b:302345829
Change-Id: I21fa6854953ede757dc63d045e11fe69b565bc6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5171985
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243452}
Provide some glue code for pane initialization in TabManagementDelegate
this code is subject to change so should be considered "experimental".
However, landing this help illustrate the general shape of the API.
a follow up CL.
Low-Coverage-Reason: TESTS_IN_SEPARATE_CL integration tests will be in
Bug: 1505772
Change-Id: Ifc397e2b41f74c9338fe0e5d438b97ac7fee2459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5131297
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243449}
The platform bug that's being worked around is fixed in Android U;
update the conditions for calling it to match, so that we no longer
depend on this private API reflection unnecessarily.
Bug: 1373440
Change-Id: I0bb145be6053885dbcd90d2a99beb1e728d42910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5169413
Commit-Queue: Richard (Torne) Coles <torne@chromium.org>
Auto-Submit: Richard (Torne) Coles <torne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243448}
No behavioral changes, pure refactoring.
Using syncer::DeviceInfo in public sharing APIs such as SharingService
goes against the abstraction layer and leaks the underlying mechanism
to list remote devices via sync. syncer::DeviceInfo also grew over time
and a) contains low-level information that sharing users shouldn't
consume and b) has performance implications when it comes to copying
around device information.
As a first step, this patch introduces SharingTargetDeviceInfo which
is just an alias for syncer::DeviceInfo.
Change-Id: Ib29e8733ff14a4471b2222aba7cdf0f1acbd6755
Bug: b/316374607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5173408
Reviewed-by: Rushan Suleymanov <rushans@google.com>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243447}
We now make sure the CompositorRenderPass* is only valid during the
aggregation. The ptr is set at the start of the aggregation and reset
back to null at the end of the aggregation.
Thanks to kylechar@.
Bug: 1512711
Change-Id: I9b541ad5da709dd5e641f489a492446743c55371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5132533
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: William Liu <liuwilliam@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243446}
Utilize FormatMessageW to retrieve the error message, treating it
as UTF-16 encoding. Convert the obtained message to UTF-8 encoding
and return it, ensuring proper preservation of non-ASCII characters.
Bug: 1515262
Change-Id: I06b015047c14142eb8547c0f1349ee755db9a56e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5166531
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243440}
Currently, `isVisible` methods in `ChoobeScreenTester` return null
when the element does not exist. Update the methods to only return
a boolean value.
Bug: b:287862720
Change-Id: I290368ad55b2f5200238b8d8e86f60df8b2de360
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5171805
Reviewed-by: Bohdan Tyshchenko <bohdanty@google.com>
Commit-Queue: Osama Fathy <osamafathy@google.com>
Cr-Commit-Position: refs/heads/main@{#1243435}
This workaround is marked as “can be removed at any time after 2015”,
and causes NOTREACHED() when background: is set to a custom property.
(This is because we set background to expand to background-size
in the .json5, but the parser does not when this flag is set.)
This fixes one of the top CSS crashes on WebView, since evidently,
some ad out there is doing exactly that.
Bug: 277157
Fixed: 1423568
Change-Id: I20d7581ca425db5b27277f38932325647dbd6bd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5153781
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Steinar H Gunderson <sesse@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243433}
This reverts commit dd50eda9cb.
Reason for revert: Use of prefService in omaha_service.mm is wrong
because the method can be called if the ApplicationContext() or
LocalState() are not defined. See: crbug/1515797 and crbug/1515793
Original change's description:
> [ios] Move kIOSChromeUpToDateKey out of NSUserDefaults
>
> This CL moves key kIOSChromeUpToDateKey out of NSUserDefaults.
>
> The key has been moved in the PrefService. Note that there are two
> types of PrefServices, in this case the code has been moved in the
> PrefService coming from ApplicationContext which is specific to
> the device.
>
> Bug: None
> Change-Id: I33959cd72baf1e5e8a05e8d0c24eb661ac56bb44
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5126043
> Reviewed-by: Asami Doi <asamidoi@chromium.org>
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Commit-Queue: Federica Germinario <fedegermi@google.com>
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1242891}
Bug: None
Change-Id: I622553bac556c32346947eae62bb26b27007444e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5173245
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Federica Germinario <fedegermi@google.com>
Auto-Submit: Federica Germinario <fedegermi@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1243432}
In addition to logging after the network request completes, the metric
now logs whenever the service's lookup completes, including:
- if it's in backoff mode
- if it fully hits the local cache
- if it fails to fetch a valid OHTTP key
Due to the scope change, the SafeBrowsing.HPRT.OperationResult histogram
is renamed to SafeBrowsing.HPRT.OperationOutcome.
OBSOLETE_HISTOGRAM[SafeBrowsing.HPRT.OperationResult]=Replaced by SafeBrowsing.HPRT.OperationOutcome.
Bug: 1392143, 1407283
Change-Id: Ia304e2db510ff869ed69498bd70c7d8f83874c5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5169412
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: thefrog <thefrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1243431}
