c16f5e874a
Restore mistakenly deleted entry
...
Bug: None
Change-Id: Ia7f6f5f6a9848694830180eb59bce2975a86b8a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318255
Commit-Queue: Brandon Wylie <wylieb@google.com >
Reviewed-by: Bo Liu <boliu@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427389}
2025-03-03 14:24:08 -08:00
2bd5aa42c5
Update TestExpectations with bugs filed for crrev.com/c/6316625
...
R=rubber-stamper@appspot.gserviceaccount.com
Bug: 400504661
Change-Id: I1b177619fc3dd3c5bb61423e1ef905cccb06c973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6317918
Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1427388}
2025-03-03 14:23:10 -08:00
88cab9f970
Bump android_browsertests to 20 shards on Android Desktop 15 builder
...
So that the average shard runtime can reduce to ~10 mins so that we
can promote to CQ.
Bug: 391893869
Change-Id: I7edf7431a11d143936d981bcd2141da771703a5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6319040
Reviewed-by: Renuga Nanjappan <rnanjappan@chromium.org >
Commit-Queue: Haiyang Pan <hypan@google.com >
Auto-Submit: Haiyang Pan <hypan@google.com >
Cr-Commit-Position: refs/heads/main@{#1427387}
2025-03-03 14:22:58 -08:00
782ab35542
Rename css file for shared toolbar styles.
...
For the lit migration, we'll move the read-anything-toolbar specific
styles out of read_anything_toolbar.html to read_anything_toolbar.css.
However, read_anything_toolbar.css currently has shared styles, so I'm
renaming the file so it's clear that we differentiate between the
component specific styles and shared styles.
Bug: 352583619
Change-Id: I5f169409dc6a96be16f89d324c908ec359196de9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6317487
Reviewed-by: Kristi Saney <kristislee@google.com >
Commit-Queue: Eitan Goldberger <eitang@google.com >
Cr-Commit-Position: refs/heads/main@{#1427386}
2025-03-03 14:21:58 -08:00
6fd8d8f93d
Roll src-internal from d37707216544 to aaa94da49bcb (1 revision)
...
d377072165..aaa94da49bhttps://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,khushalsagar@google.com ,stluong@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: khushalsagar@google.com ,stluong@google.com
Change-Id: I6b71112cd38dabcf0d7502f02d9dcc508381dc0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6317811
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1427385}
2025-03-03 14:21:45 -08:00
ab26de7ff4
extensions: Remove ExtensionService::IsExtensionEnabled, part 6
...
IsExtensionEnabled() has moved to ExtensionRegistrar. Redirect callers
to ExtensionRegistrar.
This CL is addressing code review feedback in:
https://chromium-review.googlesource.com/c/chromium/src/+/6306049
Bug: 396722906
Change-Id: I317c96f66f89ec51bd728530ecca7d57a4f7af08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6311592
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org >
Commit-Queue: James Cook <jamescook@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427384}
2025-03-03 14:20:18 -08:00
c2725019c2
Add Zoom page action controller
...
This CL adds the Zoom page action controller. It's responsible updating
the page action depending on the zoom level.
In addition, this CL update the PageActiondContainer by adding a
parameter to allow page action icon hide when their is a space
constraint. That is needed for the WebApp toolbar.
Bug: 376284060
Change-Id: Iadb9703ee2bb9515ce25e9f5d7a178362e48703f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299294
Reviewed-by: Caroline Rising <corising@chromium.org >
Commit-Queue: Daniel Soromou <koretadaniel@chromium.org >
Reviewed-by: Christopher Grant <cjgrant@chromium.org >
Reviewed-by: Kaan Alsan <alsan@chromium.org >
Reviewed-by: Darryl James <dljames@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427383}
2025-03-03 14:18:14 -08:00
dcba9470ae
Migrate VectorIconModel and its related classes to ui::ColorVariant
...
Bug: b:394420459
Change-Id: I838ec1927823a0d77f8da9b7ef421baccb1dac57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6236788
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org >
Commit-Queue: Zoraiz Naeem <zoraiznaeem@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427382}
2025-03-03 14:16:02 -08:00
badbedab2a
Remove the assertion of use_blink from //ui/color.
...
In crrev.com/c/5051135, the assert was added because when
`//ui/native_theme/features` was unconditionally added to the deps of
//ui/color:mixers, ios build started failing on `use_blink` assert from
other BUILD files down the dependency tree.
To solve this issue, `use_blink` assertion was added `//ui/color` and
this this target was conditionally used.
However, given that `//ui/native_theme/features` simply defines
features, it is not ideal to limit `//ui/color`. This can be solved by
moving define native_theme_feature.* in a separate BUILD file.
This CL also migrated ui/native_theme header files to use
`COMPONENT_EXPORT()`
AX-Relnotes: n/a.
Change-Id: I04e8b7bb60e6204706ffd372b666de49cc5b862a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6244911
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org >
Commit-Queue: Zoraiz Naeem <zoraiznaeem@chromium.org >
Reviewed-by: Avi Drissman <avi@chromium.org >
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org >
Reviewed-by: Philip Rogers <pdr@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427381}
2025-03-03 14:15:03 -08:00
c62e2bc3d9
Move CodePointAtAndNext() definition to cc file
...
crrev.com/c/6312280 regressed build size by ~6x the recommended
threshold (1.73 GiB vs 300 MiB).
Inlining the new method doesn't seem necessary and moving it to
the cc file along with other method definitions that depend on
utf16.h brings the size back down by 1.73 GiB.
Bug: 389726691
Change-Id: Ibb5a86ad6b593d3ac8d39d7fc99517d9637cb4bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318460
Reviewed-by: Kent Tamura <tkent@chromium.org >
Commit-Queue: Erik Staab <estaab@chromium.org >
Auto-Submit: Erik Staab <estaab@chromium.org >
Commit-Queue: Kent Tamura <tkent@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427380}
2025-03-03 14:14:51 -08:00
74eccdfea6
[Autofill] Rename EntityInstance::Set[Raw]InfoWithVerificationStatus()
...
Before this CL, EntityInstance defined:
(1) SetInfo()
(2) SetInfoWithVerificationStatus()
(3) SetRawInfoWithVerificationStatus()
This CL
- removes SetInfo()
- renames SetInfoWithVerificationStatus() to SetInfo()
- renames SetRawInfoWithVerificationStatus() to SetRawInfo()
So as a result, EntityInstance has SetInfo() and SetRawInfo().
The arguments are:
- SetInfo() was only called in test code.
- The verification status is only one of multiple parameters.
The only reason for calling it out appears to be consistency with
FormGroup. But we're departing from FormGroup anyway because
SetInfo[WithVerificationStatus]() will soon get another
parameter (std::u16string_view format_string).
- SetRawInfoWithVerificationStatus() should be named like
SetRawInfo[WithVerificationStatus]().
Bug: 40100455
Change-Id: I3c8da0428ec7b4826764aececf26f0b51d14bade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318779
Reviewed-by: Jihad Hanna <jihadghanna@google.com >
Commit-Queue: Christoph Schwering <schwering@google.com >
Cr-Commit-Position: refs/heads/main@{#1427379}
2025-03-03 14:13:38 -08:00
174ba3b54a
Make tab_interface const TranslatePageActionController
...
To maintain consistency with the other PageActionControllers, this CL
update the `tab_interface` in TranslatePageActionController to be a
constant.
Change-Id: I4b2053ff1eda0d564aaaf58880ced87e99373e57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6319100
Reviewed-by: Emily Shack <emshack@chromium.org >
Commit-Queue: Daniel Soromou <koretadaniel@chromium.org >
Reviewed-by: Kaan Alsan <alsan@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427378}
2025-03-03 14:12:14 -08:00
46dd54d686
[mtb-cct] Fix a typo in feature flag option
...
Fixes a typo in the feature flag param.
Bug: 391930980
Change-Id: Ib486a4991b81d15ade59be879104b62b35729166
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318006
Reviewed-by: Sinan Sahin <sinansahin@google.com >
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427377}
2025-03-03 14:10:59 -08:00
75fdf5b636
Data sharing: fix skw-color-surface1 not passed to SDK
...
This CL fixes an issue empty favicon placeholder doesn't have a
background color in the join dialog.
Screenshot:https://screenshot.googleplex.com/4BdoyXAaCoPXTf5
Bug: 396159229
Change-Id: I07f8b5de7abda807dd041ea26bf702820fa7a349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318800
Reviewed-by: Mickey Burks <mickeyburks@chromium.org >
Commit-Queue: Yuheng Huang <yuhengh@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427376}
2025-03-03 14:10:41 -08:00
31d9c69cee
Signout managed users when they continue using chrome without an account
...
Bug: 400037343
Change-Id: I2e81cfd39fdc671058222581b3510e877828649e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6312892
Reviewed-by: David Roger <droger@chromium.org >
Auto-Submit: Yann Dago <ydago@chromium.org >
Commit-Queue: Yann Dago <ydago@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427375}
2025-03-03 14:09:32 -08:00
28e2aca6fd
Reland "metrics: Enable OOBE pre-consent metrics feature flag."
...
This reverts commit cf51a05f2349519dff4chttps://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/49282/overview
>
> Original change's description:
> > metrics: Enable OOBE pre-consent metrics feature flag.
> >
> > BUG=b:369205818
> >
> > Change-Id: I862cd5df118658f3c1ee9332bd2b0d9bbb871274
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6287405
> > Commit-Queue: Troy Wang <troywang@google.com >
> > Reviewed-by: Jong Ahn <jongahn@chromium.org >
> > Reviewed-by: Simon Ziegltrum <ziegltrum@google.com >
> > Cr-Commit-Position: refs/heads/main@{#1426587}
>
> Bug: b:369205818
> Change-Id: I32942baf746494bb846bc0bcdb7363819ae89ce3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6314720
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> Auto-Submit: Xiyuan Xia <xiyuan@chromium.org >
> Owners-Override: Xiyuan Xia <xiyuan@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1426691}
Bug: b:369205818
Change-Id: I945c9b61c69c04984347ad7c520dd871bd3b6e35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6317354
Reviewed-by: Simon Ziegltrum <ziegltrum@google.com >
Commit-Queue: Troy Wang <troywang@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1427374}
2025-03-03 14:08:11 -08:00
4d9cf6063c
Add Synthetic Field Trial TS API
...
Bug: 394958637
Change-Id: I63dba2ef13866721e93b0a55c9eef96dda990184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6303005
Reviewed-by: Erik Chen <erikchen@chromium.org >
Commit-Queue: Nick Birnie <birnie@google.com >
Cr-Commit-Position: refs/heads/main@{#1427373}
2025-03-03 14:04:15 -08:00
ea777fea6d
Roll Website from 441c86221443 to d00ede697084 (1 revision)
...
https://chromium.googlesource.com/website.git/+log/441c86221443..d00ede697084
2025-03-03 kuanhuang@chromium.org Add chrome-for-testing per-commit builds to the public bisect-builds.py doc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:390476466
Tbr: dpranke@google.com
Change-Id: I6925a9e0916ad58b96c3d9b43622c72e82f66915
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6319233
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1427372}
2025-03-03 14:01:51 -08:00
f122265e51
[Read aloud] Splice on punctuation on desktop to reduce sentence delays.
...
Bug: 395909372
Change-Id: I40031f4c39d17627e1d817c07eae24fd3b41831e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318839
Commit-Queue: Lauren Winston <lwinston@google.com >
Reviewed-by: Kristi Saney <kristislee@google.com >
Cr-Commit-Position: refs/heads/main@{#1427371}
2025-03-03 14:01:12 -08:00
215544f8ed
Clean up some of Task Manager's Task code
...
- Consolidate identical UpdateFavicon() impls into
RendererTask::DefaultUpdateFaviconImpl().
- Modernize code and fix nits.
Change-Id: Idf80d352d02bb83397146aa08644242b4eee30f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6311034
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org >
Commit-Queue: Lei Zhang <thestig@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427370}
2025-03-03 14:00:37 -08:00
93c9640f57
Roll ANGLE from d254f6dd2157 to 9df57ec52ecc (1 revision)
...
d254f6dd21..9df57ec52ecclao@google.com Vulkan: Limit max vector size of mEmptySlotBits to 4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com ,solti@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: solti@google.com
Change-Id: I172c599544aa938e3c7906b46682f3bc01406e2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6319139
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1427369}
2025-03-03 14:00:00 -08:00
08e2a13abd
Roll Skia from a11cc17d0133 to 52d06100a044 (2 revisions)
...
https://skia.googlesource.com/skia.git/+log/a11cc17d0133..52d06100a044
2025-03-03 michaelludwig@google.com [skif] Use SkM44 in skif::Mapping
2025-03-03 danieldilan@google.com Reland "Remove transform_scanline functions from SkJpegEncoderImpl"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com ,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:40041526
Tbr: michaelludwig@google.com
Change-Id: Ibe5f1ea21887a2ba0f92f5c3b029cc1e9c24907f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318598
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1427368}
2025-03-03 13:59:28 -08:00
74be871a61
[ntp][enterprise] Add a11y label for Calendar module meeting button
...
Bug: 397228646
Change-Id: If6a261dccc60a390f8030cf3adcf1c8cc2274aa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6302583
Reviewed-by: Riley Tatum <rtatum@google.com >
Commit-Queue: Jennifer Serrano <jennserrano@google.com >
Cr-Commit-Position: refs/heads/main@{#1427367}
2025-03-03 13:58:49 -08:00
5f659f34a4
Fix typo in audio_handler.cc comment
...
There is a repeated word have in this comment.
Change-Id: I7a7d6eb105a3694cfc79bbb4e9ec0335084d4af9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318465
Reviewed-by: Jack Hsieh <chengweih@chromium.org >
Auto-Submit: Michael Wilson <mjwilson@chromium.org >
Commit-Queue: Jack Hsieh <chengweih@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427366}
2025-03-03 13:58:18 -08:00
51a80379d7
Roll clank/internal/apps from 180253c44f92 to 194aa99a50d1 (1 revision)
...
180253c44f..194aa99a50https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC bjfong@google.com ,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bjfong@google.com
No-Try: true
Change-Id: I13c10b2e0e04bd5c1e064482f50e58894d8a6069
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318736
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1427365}
2025-03-03 13:57:40 -08:00
a3e653cb68
Fix bug where cc clip paths affected intersection behavior
...
This change fixes a bug where intersection observers would behave
differently depending on whether the feature is enabled or not. This
bug occurred because ClipPathClipper::LocalClipPathBoundingBox is
used both for painting and for computing intersections. This change
reverts ClipPathClipper::LocalClipPathBoundingBox back to its prior
behavior, and instead explicitly overrides usages when a cc clip path
animation is present.
Additionally, this change adds an extra flag to the clip paint
property so that it is dectectable in code whether there is a cc
clip path animation requiring an expanded rectangle. This allows
intersection observers to query the real 'precise' rectangle when
necessary, by means of a special flag.
A test is added for this case.
Bug: 394244260
Change-Id: I22024a0264366b055416eebefb91ffec8861e998
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6242433
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org >
Commit-Queue: Claire Chambers <clchambers@microsoft.com >
Reviewed-by: Philip Rogers <pdr@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427364}
2025-03-03 13:57:09 -08:00
faec7e1432
Roll Chrome Mac Arm PGO Profile
...
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1741023700-54cae20b1f74fc488f4b8264842ca4b723795891-602eb3d3d3816b61c47e7c5156cb42c620f4ff3e.profdata to chrome-mac-arm-main-1741031982-398aca89fde6a210e263cb8ee6f11474ba1fd654-e84477d78a66deacedf092860876ee6b43db2abb.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com ,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ib7d9736d47ce0bd08f8d8e66b81748c7430aab78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6319254
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1427363}
2025-03-03 13:56:31 -08:00
bd278b37de
[commerce] Align IneligibilityReason expiry with other Commerce.PDP* dates
...
Bug: 392615400
Change-Id: I5a21e3954c8b93d651a87758a5a97948ab852996
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318597
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org >
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org >
Commit-Queue: Matthew Jones <mdjones@chromium.org >
Auto-Submit: Matthew Jones <mdjones@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427362}
2025-03-03 13:56:02 -08:00
7b7b3f96d2
Add Unpin context menu to glic button
...
Screenshot: https://screenshot.googleplex.com/97JepPTAP6gdmqB
Fixed: 393438949
Change-Id: I1fd8a651976d0fced88694a451ef76f04373d042
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6312564
Auto-Submit: Charles Meng <charlesmeng@chromium.org >
Commit-Queue: Charles Meng <charlesmeng@chromium.org >
Reviewed-by: Eshwar Stalin <estalin@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427361}
2025-03-03 13:55:20 -08:00
73a75c4060
Roll Chrome Mac PGO Profile
...
Roll Chrome Mac PGO profile from chrome-mac-main-1741003178-94fb56a5dc7eb7b16827f25b2ef7b66550177dc7-42b800fc7b9cf7970eae4a11f645e54f92645250.profdata to chrome-mac-main-1741023700-3f8c7581a0439bc38c097a6bf60a692e3ca33b4e-602eb3d3d3816b61c47e7c5156cb42c620f4ff3e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC chrome-brapp-engprod@google.com ,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I65726df67da4d98caa1659dae33b2fd56fbfcf3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318594
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1427360}
2025-03-03 13:54:52 -08:00
477f0a0baf
[wpt] Warn about bugs beyond Blink>Infra>Ecosystem when rolling tools
...
Bugs like https://crbug.com/388024336 blocking the tooling roll are not
for infra to fix, but the query should still surface them so long as
they have the `WPT-{JS,Tooling}-Roll` label.
Also, put the URLs on one line each for easier copying.
Bug: None
Change-Id: I489d4f99586775ffd1f3a96b99ace0be8dc58bb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318921
Commit-Queue: Jonathan Lee <jonathanjlee@google.com >
Reviewed-by: Weizhong Xia <weizhong@google.com >
Cr-Commit-Position: refs/heads/main@{#1427359}
2025-03-03 13:54:06 -08:00
2081d0e10b
Revert "[Fast Pair] Add Feature Flag for Fast Pair Devices in Bluetooth Settings"
...
This reverts commit 9708496614https://chromium.googlesource.com/chromium/src/+/master/docs/how_to_add_your_feature_flag.md?pli=1
>
> Change-Id: I54933fc9de48d684bc15bdea3ea600ca311d921f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4657783
> Commit-Queue: Paola Lacouture <paolalac@google.com >
> Reviewed-by: Alex Kingsborough <akingsb@google.com >
> Reviewed-by: Daniel Classon <dclasson@google.com >
> Cr-Commit-Position: refs/heads/main@{#1166795}
Bug: 378568944
Change-Id: I978609a57d47216f96a061886fd60d6c2e19a833
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6309135
Reviewed-by: Alex Kingsborough <akingsb@google.com >
Commit-Queue: Daniel Classon <dclasson@google.com >
Cr-Commit-Position: refs/heads/main@{#1427358}
2025-03-03 13:53:17 -08:00
fb119c1c92
infra: Regen configs after CL race
...
https://crrev.com/c/6300051 likely raced with
https://crrev.com/c/6314009 . Just need to regen.
Bug: None
Change-Id: I6a302a520c5a34e500a96406c92286fa01015ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318761
Commit-Queue: Struan Shrimpton <sshrimp@google.com >
Auto-Submit: Ben Pastene <bpastene@chromium.org >
Reviewed-by: Struan Shrimpton <sshrimp@google.com >
Commit-Queue: Ben Pastene <bpastene@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427357}
2025-03-03 13:52:57 -08:00
0f89a6164d
Extend expiry of VirtualTestSuite align-surface-layer
...
The feature flag hasn't been removed for
AlignSurfaceLayerImplToPixelGrid, so let's keep this VTS around a while
longer.
Bug: 399697999
Change-Id: I5f87090ce8d554a03f8b2402e493fa179204aed2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6317629
Reviewed-by: Philip Rogers <pdr@chromium.org >
Commit-Queue: James Maclean <wjmaclean@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427356}
2025-03-03 13:52:05 -08:00
0c68ad910b
Roll Release Scripts from b2b37d4e813e to 8ed977418333 (1 revision)
...
b2b37d4e81..8ed9774183https://skia-autoroll.corp.goog/r/release-scripts-chromium
Please CC chrome-release-infra@google.com ,gbeaty@google.com ,guterman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: gbeaty@google.com ,guterman@google.com
Change-Id: I70c8166303ba96aa87319fac8dd92ef23b3858d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6319082
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1427355}
2025-03-03 13:51:48 -08:00
95905c7417
Reland "Reland "Reland "Ship Explicit Resource Management"""
...
This reverts commit ba194a8d209dbcca133ccf8f2817e74bdbb26933https://chromium-review.googlesource.com/c/chromium/src/+/6106859
> > > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org >
> > > > Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org >
> > > > Cr-Commit-Position: refs/heads/main@{#1398764}
> > >
> > > Change-Id: I4fa8800a8bec599fadc9673aeedd883767f81fc1
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6154715
> > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org >
> > > Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org >
> > > Reviewed-by: Shu-yu Guo <syg@chromium.org >
> > > Cr-Commit-Position: refs/heads/main@{#1403327}
> >
> > Change-Id: Iea186cb2d59519b7a99eff22605141f42b712cb1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6174695
> > Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org >
> > Reviewed-by: Shu-yu Guo <syg@chromium.org >
> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org >
> > Cr-Commit-Position: refs/heads/main@{#1406406}
>
> Change-Id: I51863a09535944ba704f1b420e5053eb70a728b0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6302579
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org >
> Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org >
> Reviewed-by: Shu-yu Guo <syg@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1426069}
Change-Id: I6c00af9c8705f67920edf59f329f3979609639d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318341
Reviewed-by: Chris Harrelson <chrishtr@chromium.org >
Reviewed-by: Shu-yu Guo <syg@chromium.org >
Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427354}
2025-03-03 13:50:51 -08:00
c9b33906e8
[search-engines] Add metric for disabling sync of autogenerated keywords
...
This CL adds the following failure metrics for
DisableSyncAutogeneratedSearchEngines feature, the count of these
metrics should always be zero:
1. Count of local search engines which are untouched+autogenerated and either prepopulated or starter pack entries (Sync.SearchEngine.LocalUntouchedAutogenerated.*).
2. Count of remote search engines which are untouched+autogenerated and either prepopulated or starter pack entries (Sync.SearchEngine.RemoteUntouchedAutogenerated.*).
3. Count of untouched+autogenerated search engines which are updated and are either prepopulated or starter pack entries (Sync.SearchEngine.UntouchedAutogeneratedChanged.*).
This CL also adds a metric (Sync.SearchEngine.RemoteSearchEngineIsUntouchedAutogenerated) to
record the ratio of remote search engines which are
untouched+autogenerated.
Change-Id: I3524207ea99846a318c1dc29cf865aa0928ad25c
Bug: 361374753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6316666
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org >
Auto-Submit: Ankush Singh <ankushkush@google.com >
Commit-Queue: Ankush Singh <ankushkush@google.com >
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com >
Cr-Commit-Position: refs/heads/main@{#1427353}
2025-03-03 13:50:40 -08:00
12dbcd6774
[memory] Add kUserLevelMemoryPressureSignal features
...
To control sending user level memory pressure signal.
The current state is somewhat inconsistent; 4-6gb is enabled but
3gb is disabled.
Meanwhile, I'm working on v8 memory saver mode, which
might replace some other v8 memory pressure handling.
This is partly reverting
https://chromium-review.googlesource.com/c/chromium/src/+/6082219
https://chromium-review.googlesource.com/c/chromium/src/+/6082217
Bug: 388844091
Change-Id: I4567b0296ada061ff20c7953194e70e85c3a6cc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318320
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
Reviewed-by: Bo Liu <boliu@chromium.org >
Reviewed-by: Dave Tapuska <dtapuska@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427352}
2025-03-03 13:49:40 -08:00
1a5237f8df
[rust roll] Explicitly squash branch when uploading
...
The script implicitly assumes that `git cl` is squashing commits at
upload time, but this can be overriden in .git config.
Change-Id: Id584a9feb524b46c5e389b47d5c4258e8fa2b874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6312262
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org >
Commit-Queue: Daniel Cheng <dcheng@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427351}
2025-03-03 13:49:26 -08:00
fc52255e49
Annual rotation of the pinned CUP public keys
...
Last year's rotation: https://crrev.com/c/5292075
Bug: 319141953
Change-Id: Ib3ff44ef995634947c35e1e717102c76edb693d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6310468
Reviewed-by: Joshua Pawlicki <waffles@chromium.org >
Reviewed-by: Emily Stark <estark@chromium.org >
Commit-Queue: Joshua Pawlicki <waffles@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427350}
2025-03-03 13:48:26 -08:00
c8a35e5be5
updater: replace ASCII with UTF8 in base::FilePath usage
...
* `AppendASCII` -> `Append` for posix-only and windows-literals-only
* `AppendASCII` -> `AppendUTF8` for all other code
* `FromASCII` -> `FromUTF8Unsafe`
* `MaybeAsASCII` -> `AsUTF8Unsafe`
Bug: 397561234
Change-Id: I4b2e52dadf5a4df819affd50afff1dc8bdc8a49e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6310521
Auto-Submit: S Ganesh <ganesh@chromium.org >
Reviewed-by: Joshua Pawlicki <waffles@chromium.org >
Commit-Queue: Joshua Pawlicki <waffles@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427349}
2025-03-03 13:48:15 -08:00
ae035773a1
Roll Perfetto Trace Processor Linux from 81f26b6c8adb to aa4d8267bafa
...
81f26b6c8a..aa4d8267bahttps://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC chrometto-team@google.com ,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: Ib35d464c3b7db42dea4d60cf5e6b5fe8f592fea6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318879
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#1427348}
2025-03-03 13:47:16 -08:00
2e03615fbe
Tentative fix for CreateUrlLoader crash
...
It seems like something is holding a scoped_refptr<UrlData> that's
outliving the UrlIndex which should be owning it. This at least allows
UrlIndex to notify all UrlData instances that it's being deleted.
Bug: 399478934
Change-Id: I2a74b45158df1e2e90deeb3f5acb40cbeb9f527f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6313398
Reviewed-by: Dale Curtis <dalecurtis@chromium.org >
Commit-Queue: Ted (Chromium) Meyer <tmathmeyer@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427347}
2025-03-03 13:47:03 -08:00
f29fa5254a
Validate and log instance identity tokens in CloudHostStarter
...
The current impl attempts to retrieve an instance identity token
and passes it along w/o validation. For troubleshooting purposes,
it would be better if the jwt received was validated and logged.
Bug: 388886766
Change-Id: Idf4835f72911005d4614f0ea423deb35d0f7a325
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318821
Reviewed-by: Gary Kacmarcik <garykac@chromium.org >
Commit-Queue: Joe Downing <joedow@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427346}
2025-03-03 13:46:03 -08:00
ccede60ffe
[Gardener] Disable flaky CustomizableSelectEnabledDumpAccessibilityTreeTest
...
Disable AccessibilityCustomSelectMixedOptions and
AccessibilityCustomSelectLabelElement on fuchsia since they are flaky.
Bug: 400473838
Change-Id: I7189f27b7569320cd2d665f6192a37ec0547dd3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6319001
Owners-Override: Steven Luong <stluong@chromium.org >
Commit-Queue: Steven Luong <stluong@chromium.org >
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org >
Auto-Submit: Steven Luong <stluong@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427345}
2025-03-03 13:45:53 -08:00
680cb05f51
Use security_level when checking for Android MediaDrm version
...
Some Android devices say that they support secure codecs but for some
reason MediaDrm won't. So this updates the version check to attempt to
create a MediaDrm object with the appropriate security level to verify
that MediaDrm actually supports secure codecs. If it fails to create the
appropriate MediaDrm object, report the key system as unavailable.
Added the flag kUseSecurityLevelWhenCheckingMediaDrmVersion so that this
can be disabled if it causes problems.
When MediaDrm doesn't support secure codecs,
chrome://media-internals#cdms will display:
Key System: com.widevine.alpha
Robustness: Hardware Secure
Name: Widevine Content Decryption Module
Version: N/A
Path: N/A
Status: Enabled
Capabilities: "No Capability: MediaDrm not available for the key
system and robustness specified"
Tested on real device and on an emulator that does not support secure
codecs.
Bug: b:368659592
Test: see above
Change-Id: I7e11efb4befba69740e9f3a88aad7fbdd7f9228f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6115532
Reviewed-by: Xiaohan Wang <xhwang@chromium.org >
Commit-Queue: John Rummell <jrummell@chromium.org >
Reviewed-by: Nasko Oskov <nasko@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427344}
2025-03-03 13:09:58 -08:00
5e3f32ad1f
Revert "Disable RBE for proguard.py to see if TraceReferences errors go away"
...
This reverts commit d05bbbcf79https://chromium-review.googlesource.com/c/chromium/src/+/6297857
> Commit-Queue: Andrew Grieve <agrieve@chromium.org >
> Reviewed-by: Junji Watanabe <jwata@google.com >
> Auto-Submit: Andrew Grieve <agrieve@chromium.org >
> Cr-Commit-Position: refs/heads/main@{#1424734}
Bug: 398058215, 399665139
Change-Id: Id71cb85f320883c0f2b861f857fc429fa555be5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6318881
Auto-Submit: Andrew Grieve <agrieve@chromium.org >
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Andrew Grieve <agrieve@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427343}
2025-03-03 13:08:40 -08:00
b12d5104c4
Update histogram expiration for memory saver and battery saver
...
Standardizing all histograms to the same expiration cycle for ease of
updating.
Change-Id: I182b937850c8f549fce6a974f939b4be7fc8323f
Bug: 400444290,400444487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6317184
Reviewed-by: Steven Luong <stluong@chromium.org >
Commit-Queue: Alison Gale <agale@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427342}
2025-03-03 13:07:57 -08:00
af3839762d
viz: Use FrameSinkId as client_namespace_id
...
This CL makes us use a renderer's FrameSinkId as the
client_namespace_id, instead of the resolveed frame's
child_resource_id_. The former is more stable across frames, since it
is associated with the lifetime of a frame sink, whereas the
child_resource_id_ is tied to the lifetime of ResolvedFrameData, which
is only stable for the same frame sink on contiguous frames.
Bug: 40258587
Change-Id: I7c0bc79e9bd38d54fa90c376a12d8560a9444138
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6093277
Reviewed-by: Colin Blundell <blundell@chromium.org >
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org >
Commit-Queue: Michael Tang <tangm@microsoft.com >
Cr-Commit-Position: refs/heads/main@{#1427341}
2025-03-03 13:07:30 -08:00
059690eb49
Scope some WebAudio enums
...
Scoped enums don't pollute the global namespace, and are not implicitly
convertible to integers, so are preferred.
There is one functional change in a DCHECK error message printing the
node name instead of the enum index, otherwise no functional change.
Change-Id: Ib5745eb2404a373f8dabb572e289782be2d7ddaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6313597
Reviewed-by: Jack Hsieh <chengweih@chromium.org >
Commit-Queue: Michael Wilson <mjwilson@chromium.org >
Cr-Commit-Position: refs/heads/main@{#1427340}
2025-03-03 13:06:47 -08:00
