0
Commit Graph

8 Commits

Author SHA1 Message Date
Lei Zhang
8815c18835 Do IWYU for base/check_op.h in //gin.
Code should include headers they use, rather than transitively, so
unrelated code changes do not cause build failures.

Change-Id: I9ae1cf472ad717385e8f0569432b644f3dab0c77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4000696
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1067006}
2022-11-03 14:40:27 +00:00
Avi Drissman
468e51b677 Update copyright headers in gin/
The methodology used to generate this CL is documented in
https://crbug.com/1098010#c34.

No-Try: true
Bug: 1098010
Change-Id: Iafb266228260abedd345bc3e8c1d483c3a4dc4d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3891087
Commit-Queue: Mark Mentovai <mark@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Owners-Override: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1046550}
2022-09-13 20:47:01 +00:00
Bill Budge
2ca35149f4 Reland "[wtf] Eliminate ArrayBufferContents page memory methods."
This is a reland of fe99f02317.

Original change's description:
> [wtf] Eliminate ArrayBufferContents page memory methods.
>
> - Removes ReserveMemory method.
> - Removes ReleaseReservedMemory, this is now just base::FreePages.
> - Removes SetProtection, this is now base::SetPermissions.
> - Removes dependency on sandbox/linux. base::AllocPages / FreePages
>   now updates address space limits.
>
> Bug: chromium:799573
> Change-Id: Iabc57c61511dfdc7b7ca2aa93c56ed21a22692f4
> Reviewed-on: https://chromium-review.googlesource.com/923173
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Bill Budge <bbudge@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537868}

TBR=kbr@chromium.org

Bug: chromium:799573
Change-Id: I62ec635b0f685cc4d33d71fb97fc21ebd3ac0da6
Reviewed-on: https://chromium-review.googlesource.com/928801
Commit-Queue: Bill Budge <bbudge@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538246}
2018-02-21 23:22:22 +00:00
Maxim Kolosovskiy
06e04ffee5 Revert "[wtf] Eliminate ArrayBufferContents page memory methods."
This reverts commit fe99f02317.

Reason for revert: failures of webaudio tests
See https://bugs.chromium.org/p/chromium/issues/detail?id=814231

Original change's description:
> [wtf] Eliminate ArrayBufferContents page memory methods.
> 
> - Removes ReserveMemory method.
> - Removes ReleaseReservedMemory, this is now just base::FreePages.
> - Removes SetProtection, this is now base::SetPermissions.
> - Removes dependency on sandbox/linux. base::AllocPages / FreePages
>   now updates address space limits.
> 
> Bug: chromium:799573
> Change-Id: Iabc57c61511dfdc7b7ca2aa93c56ed21a22692f4
> Reviewed-on: https://chromium-review.googlesource.com/923173
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Bill Budge <bbudge@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537868}

TBR=bbudge@chromium.org,jbroman@chromium.org,kbr@chromium.org,haraken@chromium.org,eholk@chromium.org

Change-Id: I69e8cd3871dfdd6ac4db922145b269eedcd30569
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:799573
Reviewed-on: https://chromium-review.googlesource.com/928341
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538054}
2018-02-21 10:01:31 +00:00
Bill Budge
fe99f02317 [wtf] Eliminate ArrayBufferContents page memory methods.
- Removes ReserveMemory method.
- Removes ReleaseReservedMemory, this is now just base::FreePages.
- Removes SetProtection, this is now base::SetPermissions.
- Removes dependency on sandbox/linux. base::AllocPages / FreePages
  now updates address space limits.

Bug: chromium:799573
Change-Id: Iabc57c61511dfdc7b7ca2aa93c56ed21a22692f4
Reviewed-on: https://chromium-review.googlesource.com/923173
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537868}
2018-02-20 20:36:30 +00:00
Eric Holk
b2fa95d4ff Reland "Implement updated array buffer allocator in gin"
This is a reland of 714060db89
Original change's description:
> Implement updated array buffer allocator in gin
> 
> Bug: chromium:720302
> Change-Id: I127daca6ee9954774b8ff23382ba38cb23da7318
> Reviewed-on: https://chromium-review.googlesource.com/543670
> Commit-Queue: Eric Holk <eholk@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481959}

Bug: chromium:720302
Change-Id: I880773c83d51c8ec0d3d55dfa8913e6b3a16ddec
Reviewed-on: https://chromium-review.googlesource.com/570978
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Eric Holk <eholk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487179}
2017-07-17 18:51:36 +00:00
Ted Choc
dea76b7b72 Revert "Implement updated array buffer allocator in gin"
This reverts commit 714060db89.

Reason for revert: This broke the cronet builds:
FAILED: lib_net_unittests__library.so lib_net_unittests__library.so.TOC ...
../../gin/array_buffer.cc:40: error: undefined reference to 'base::AllocPages(void*, unsigned long, unsigned long, base::PageAccessibilityConfiguration)'
../../gin/array_buffer.cc:55: error: undefined reference to 'base::FreePages(void*, unsigned long)'
../../gin/array_buffer.cc:67: error: undefined reference to 'base::SetSystemPagesInaccessible(void*, unsigned long)'
../../gin/array_buffer.cc:70: error: undefined reference to 'base::SetSystemPagesAccessible(void*, unsigned long)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Marshmallow%2064bit%20Builder/builds/10832

Original change's description:
> Implement updated array buffer allocator in gin
> 
> Bug: chromium:720302
> Change-Id: I127daca6ee9954774b8ff23382ba38cb23da7318
> Reviewed-on: https://chromium-review.googlesource.com/543670
> Commit-Queue: Eric Holk <eholk@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481959}

TBR=eholk@chromium.org,jochen@chromium.org

Change-Id: Id51402c6a8e87ef8af6eb3d0f8c8332f52eeefdb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:720302
Reviewed-on: https://chromium-review.googlesource.com/546676
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481970}
2017-06-23 18:46:11 +00:00
Eric Holk
714060db89 Implement updated array buffer allocator in gin
Bug: chromium:720302
Change-Id: I127daca6ee9954774b8ff23382ba38cb23da7318
Reviewed-on: https://chromium-review.googlesource.com/543670
Commit-Queue: Eric Holk <eholk@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481959}
2017-06-23 18:13:44 +00:00